git/t/chainlint/chain-break-return-exit.expect

case "$(git ls-files)" in
one ) echo pass one ;;
* ) echo bad one ; return 1 ;;
esac &&
(
	case "$(git ls-files)" in
	two ) echo pass two ;;
	* ) echo bad two ; exit 1 ;;
esac
) &&
case "$(git ls-files)" in
dir/two"$LF"one ) echo pass both ;;
* ) echo bad ; return 1 ;;
esac &&

for i in 1 2 3 4 ; do
	git checkout main -b $i || return $?
	test_commit $i $i $i tag$i || return $?
done
chainlint.pl: don't flag broken &&-chain if failure indicated explicitly There are quite a few tests which print an error messages and then explicitly signal failure with `false`, `return 1`, or `exit 1` as the final command in an `if` branch. In these cases, the tests don't bother maintaining the &&-chain between `echo` and the explicit "test failed" indicator. Since such constructs are manually signaling failure, their &&-chain breakage is legitimate and safe -- both for the command immediately preceding `false`, `return`, or `exit`, as well as for all preceding commands in the `if` branch. Therefore, stop flagging &&-chain breakage in these sorts of cases. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2022-09-01 00:29:49 +00:00			`case "$(git ls-files)" in`
			`one ) echo pass one ;;`
			`* ) echo bad one ; return 1 ;;`
			`esac &&`
			`(`
			`case "$(git ls-files)" in`
			`two ) echo pass two ;;`
			`* ) echo bad two ; exit 1 ;;`
			`esac`
			`) &&`
			`case "$(git ls-files)" in`
			`dir/two"$LF"one ) echo pass both ;;`
			`* ) echo bad ; return 1 ;;`
			`esac &&`

chainlint.pl: don't require `return\|exit\|continue` to end with `&&` In order to check for &&-chain breakage, each time TestParser encounters a new command, it checks whether the previous command ends with `&&`, and -- with a couple exceptions -- signals breakage if it does not. The first exception is that a command may validly end with `\|\|`, which is commonly employed as `command \|\| return 1` at the very end of a loop body to terminate the loop early. The second is that piping one command's output with `\|` to another command does not constitute a &&-chain break (the exit status of the pipe is the exit status of the final command in the pipe). However, it turns out that there are a few additional cases found in the wild in which it is likely safe for `&&` to be missing even when other commands follow. For instance: while {condition-1} do test {condition-2} \|\| return 1 # or `exit 1` within a subshell more-commands done while {condition-1} do test {condition-2} \|\| continue more-commands done Such cases indicate deliberate thought about failure modes by the test author, thus flagging them as breaking the &&-chain is not helpful. Therefore, take these special cases into consideration when checking for &&-chain breakage. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2022-09-01 00:29:45 +00:00			`for i in 1 2 3 4 ; do`
			`git checkout main -b $i \|\| return $?`
			`test_commit $i $i $i tag$i \|\| return $?`
			`done`