Commit graph

331 commits

Author SHA1 Message Date
ghidragon 04fa097f58 GP-3667 Cleaning up weird behavior of GraphDisplayOptions to register options when given a tool 2023-07-25 12:26:07 -04:00
dragonmacher bd0c491263 GP-3615 - Added a test harness method to make it easier to change log output from a test. The test harness will reset any changes made at the end of the test. 2023-07-19 12:47:47 -04:00
Ryan Kurtz dd0bae252c Merge remote-tracking branch
'origin/GP-3322_isabella3412_Simplify_Merge_Tests--SQUASHED'
2023-06-21 13:16:47 -04:00
isabella3412 7551714b9d GP-3322 Renamed the interfaces from their temporary names after passing tests
GP-3322 Updated with fixes after testing
GP-3322 Few files with formatting updates
GP-3322 Initial commit with removal of transaction creation at all uses of these interfaces.
2023-06-21 16:17:30 +00:00
dragonmacher a8328a39f5 Fixed bad palette references; set standard theme for screenshots 2023-06-20 14:23:45 -04:00
dragonmacher 5fc9e80d40 GP-3515 - New copy special action tests and help 2023-06-08 15:10:40 -04:00
dragonmacher 2f2a07c671 Test fixes 2023-05-11 17:10:45 -04:00
Ryan Kurtz e2188d4cfb Merge remote-tracking branch 'origin/GP-3402-dragonmacher-graph-threading' 2023-05-11 06:51:08 -04:00
Ryan Kurtz 78d9a6c6e3 Merge remote-tracking branch
'origin/GP-3349_ghidragon_adding_support_for_mutliple_default_contexts--SQUASHED'

Conflicts:
	Ghidra/Features/ByteViewer/src/test.slow/java/ghidra/app/plugin/core/byteviewer/ByteViewerPlugin2Test.java
2023-05-11 06:43:59 -04:00
dragonmacher bde74ad4d3 GP-3402 - Updated the Graph service API to better manage concurrent
threaded accesses
2023-05-09 15:43:02 -04:00
Dan c5da826540 GP-2641: Add training course materials for the Debugger 2023-05-09 09:21:49 -04:00
ghidragon 5da5af23fb GP-3349 added support for mulitple default action context providers. Previously, all default (non-focused) context was provided by the Listing. Now the default provider is registered for each ActionContext class. 2023-05-08 12:30:01 -04:00
Ryan Kurtz e7d08749d9 Merge remote-tracking branch 'origin/GP-2846-dragonmacher-theme-documentation--SQUASHED' into Ghidra_10.3 2023-05-02 13:41:51 -04:00
dragonmacher d4eae5ff3c GP-2846 - Theming Documentation 2023-05-02 13:39:19 -04:00
ghidra1 d999f1bfc5 GP-0 corrected DWARFRegisterMappingsTest 2023-05-01 15:27:58 -04:00
Ryan Kurtz 7fa3389119 GP-2974: Fixing warnings 2023-05-01 07:23:48 -04:00
dev747368 87c16f9cd0 GP-2114 golang import / analyzer 2023-05-01 02:02:53 -04:00
ghidra1 1d722447f7 GP-0 corrected test failures caused by x86 context size change 2023-04-27 00:45:13 -04:00
ghidra1 2cdaebf0c3 Merge branch 'GP-2308_1633_ghidra1_FunctionDefinitionCallingConventions'
(Closes #4537, Closes #4898, Closes #3723, Closes #3267)
2023-04-20 15:41:45 -04:00
ghidra1 a4776892bd GP-1633/GP-2308 Added ProgramArchitecture to datatype managers.
Refactored ProjectDataTypeManager to extend StandaloneDataTypeManager.
Added actions to datatype tree to allow setting archive architecture.
Added use of storage translators when switching architectures.  Allow
FunctionDefinition to accept arbitrary calling convention
names and many other misc changes.
2023-04-20 14:01:39 -04:00
dragonmacher 4f1d3c8053 GP-3094 - Theming - Converted most colors to palette colors 2023-04-14 16:49:39 -04:00
ghidragon bbadb4aed4 GP-3282 Separated out the concepts of whether or not a program was analyzed from the state of if the user should be asked to analyze on open 2023-04-04 15:39:17 -04:00
Ryan Kurtz 1574262722 GP-2877: Refactoring Loader and AutoImporter to better accommodate loading more than one thing 2023-02-14 15:33:06 -05:00
Ryan Kurtz 2891722195 Merge remote-tracking branch 'origin/GP-2912_pcode_emit_tests' 2023-02-13 14:57:09 -05:00
ghidra1 7143f64c51 Merge remote-tracking branch
'origin/GP-2986-dragonmacher-component-provider-methods--SQUASHED'
2023-02-03 17:55:23 -05:00
ghidra1 67677174c4 GP-3050-2935 Eliminate client-side canonical hostname lookups. Add subject alternative name to self-signed server certs. Improved initial server connect check to use faster timeout. 2023-02-03 14:21:49 -05:00
dragonmacher c252e3b905 GP-2986 - ComponentProvder and dialog cleanup on dispose 2023-02-02 17:51:15 -05:00
ghidragon 0bf0911e11 GP-2934 cleaning up user interface for Theming 2023-01-19 17:24:05 -05:00
Ryan Kurtz dc10c83e78 GP-3008: Fixing search limit option message and help 2023-01-12 09:01:26 -05:00
James 62f14d9f9d GP-2912 pcode emit test 2023-01-06 22:40:31 +00:00
Ryan Kurtz 55124ff249 Merge remote-tracking branch 'origin/patch' 2022-12-28 09:02:06 -05:00
Ryan Kurtz 70a155cb70 GP-0: Using TaskMonitor.DUMMY instead of deprecated
TaskMonitorAdapter.DUMMY_MONITOR
2022-12-28 08:06:16 -05:00
dragonmacher 27016ed926 test fixes 2022-12-13 16:46:52 -05:00
dragonmacher 8379285044 GP-2795 - Refactor of ButtonPanelFactory 2022-12-12 18:54:57 -05:00
ghidra1 d377b9642b GP-2897 Allow Diff with another open program within same tool. Modified
OpenVersionedFileDialog to faciltate the program selection.
2022-12-07 17:20:54 -05:00
Ryan Kurtz 112c4afe52 Merge remote-tracking branch 'origin/GP-2875_ghidragon_split_out_gui_from_generic--SQUASHED' 2022-11-30 13:09:50 -05:00
ghidragon 56fcce1456 GP-2875 Split Generic module into two modules to remove Gui related code from the generic module 2022-11-30 12:33:04 -05:00
Ryan Kurtz 0d72cce015 Merge remote-tracking branch 'origin/GP-2791_pcode_override_tests--SQUASHED' 2022-11-30 12:18:44 -05:00
James d470adfde2 GP-2971 added tests for PcodeEmit 2022-11-30 09:32:24 -05:00
ghidra1 5a422c4502 GP-2509 GP-2644 Improved Ghidra URL support. Added support for Ghidra
URL linked files and folders within project.
2022-11-22 12:47:17 -05:00
ghidragon edfb5a0877 GP-1981 Refactored Gui to use ThemeManager 2022-11-15 14:56:08 -05:00
ghidragon 45c52e3cb9 GP-1981 - Updated help to allow authors to use theme image ids; updated
help to only allow modules that live on the classpath. Dpdating themd
documentation. Fixing gradle help build
2022-11-15 14:55:56 -05:00
ghidragon c86b884daf GP-1981 added quick font adjust action, cleaned up tempColorUtils
and converted File extension icons file to use theming
2022-11-15 14:55:52 -05:00
ghidragon 9a0d7892da GP-1981 Theme help and module conversions 2022-11-15 14:53:46 -05:00
dragonmacher a99841e6d4 GP-1981 - Theming - PDB and Code Compare Modules 2022-11-15 14:53:33 -05:00
dragonmacher d90db3baa2 Moved test to allow for cross-module dependencies 2022-10-21 10:11:01 -04:00
Ryan Kurtz 6f61a07a93 Merge remote-tracking branch 'origin/GP-2687-dragonmacher-module-classpath-filtering--SQUASHED' 2022-10-20 10:19:04 -04:00
dragonmacher 4d95dc3559 Test fix 2022-10-20 09:51:21 -04:00
dragonmacher 98927d7e4e GP-2687 - Filter modules used by using the classpath 2022-10-19 13:38:58 -04:00
emteere ca5a6204c3 GP-2391 added evaluation of return address, allow thunking addresses to externals. Added new arem thunk pattern. 2022-10-11 18:25:09 -04:00
ghidra1 52d1097c5b GP-2496 edit shared project info improvements 2022-09-08 17:57:09 -04:00
ghidra1 8d4a6c213e GP-2480 Add sleigh compiler support for inst_next2 2022-08-24 17:57:04 -04:00
Dan cfdf1051a1 GP-1451: Add sync selection actions, toggles 2022-05-20 10:14:58 -04:00
dragonmacher 2a5e6f45b8 GP-1826 - Scripting - Created a Script Quick Launch dialog. 2022-03-28 17:17:46 -04:00
Ryan Kurtz 2d7c8d5055 Merge remote-tracking branch 'origin/patch'
Conflicts:
	Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/disassembler/ClearTest.java
	Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/select/qualified/QualifiedSelectionPluginTest.java
2022-03-17 18:01:59 -04:00
dragonmacher 900513ba93 Test timinig fixes 2022-03-17 16:52:34 -04:00
Ryan Kurtz 3c11555a76 Merge remote-tracking branch 'origin/patch' 2022-03-16 08:28:01 -04:00
dragonmacher 907c084b25 GP-1804 - Added an API method to the GraphDisplayProvider to get the active graph 2022-03-15 16:19:44 -04:00
ghidra1 8c209ce76e GP-1769 improved Ghidra Server SSH key use and error handling. Replaced use of ganymed-ssh2 library with Bouncy Castle library use. 2022-03-03 17:26:09 -05:00
ghidra1 8c3c9149b8 Merge remote-tracking branch 'origin/GP-1684_Dan_patchDataAction--SQUASHED' 2022-01-26 17:35:28 -05:00
Dan a5b643f392 GP-1684: Add 'Patch Data' action and fix encoders. 2022-01-25 11:21:51 -05:00
ghidra1 073c726885 Merge remote-tracking branch 'origin/patch' 2022-01-21 19:49:10 -05:00
dragonmacher 16cd1ee3a4 GP-1688 - Fixed broken MS demangler option to toggle function signature
application; added option to not apply function signature calling
conventions
2022-01-21 13:48:32 -05:00
caheckman 311a22c038 Allow SLEIGH bitrange operator applied to dynamic varnodes 2022-01-03 17:03:29 -05:00
ghidra1 0ef2367ed4 GP-1481 add support for cancelling hung Ghidra Server connect attempt 2021-12-28 12:03:16 -05:00
Ryan Kurtz 2fb860bcd7 Merge remote-tracking branch 'origin/GP-1512-dragonmacher-screenshot-fix' 2021-11-23 13:57:28 -05:00
dragonmacher e30884b229 GP-1512 - fixed failing screenshot 2021-11-18 15:03:59 -05:00
ghidravore cb3c5b92e7 GP-1511- fixing more duplicate actions in debugger tool 2021-11-18 14:43:20 -05:00
dragonmacher 9a9c1fc64a GP-1424 - remove 'refresh' action from data type manager 2021-10-22 09:11:29 -04:00
dragonmacher ec88c732d2 GP-1382 - Added Find actions to the Data Types provider to allow users
to find structures by size or by offset(s).
2021-10-21 14:17:54 -04:00
dragonmacher e80dedcbdf GP-1316 - Enums - Updates for PR to add comments to enum values 2021-09-30 14:44:52 -04:00
ghidra1 27892f659a GP-943 Resurected and revised Structure.getComponentAt method. Also
revised behavior of Structure.getComponentContaining.  Both will now
ignore zero-length components.
2021-09-26 19:11:34 -04:00
ghidra1 cfdec26da4 GP-943 Added support for zero-length arrays and
zero-length components.  NOTE: We still never return 0 for
DataType.getLength().  Added DataType.isZeroLength().
2021-09-24 16:29:29 -04:00
ghidra1 754c67b295 Merge remote-tracking branch 'origin/patch' 2021-09-23 10:26:17 -04:00
ghidra1 89f123ab65 GP-1314 added serialization filter to Ghidra Server 2021-09-23 10:05:24 -04:00
dragonmacher 51af44f843 Xref merge test fixes 2021-09-21 12:56:33 -04:00
ghidra1 9db26bc7f5 GP-1296 Eliminated use of sun.security package and refactored ApplicationKeyManagerUtils 2021-09-15 13:55:20 -04:00
ghidravore 1fd6b54f07 fixed graph test issue (and a few other improviements)> Mainly protecting against creating ridiculously large icons in tests because of a strange headless environment. 2021-08-18 12:28:12 -04:00
ghidravore fe6006c300 fixed DataReferenceGraphTaskTest failure 2021-08-10 13:45:58 -04:00
ghidravore 210cc0bca0 Created the concept of graph types and display options for those graph types. 2021-08-09 13:18:23 -04:00
dragonmacher 9297f275cf GP-658 - fixed graph actions test 2021-06-29 09:29:28 -04:00
ghidra1 21b3fbf8ea Merge remote-tracking branch 'origin/GP-984_dev747368_simplify_loadpdb_gui--SQUASHED' into Ghidra_10.0 2021-06-04 08:28:41 -04:00
dev747368 a97c3dc4af GP-984 simplify LoadPdbDialog gui 2021-06-03 15:23:05 -04:00
ghidra1 7c11bb5751 GP-0 Moved most graph tests into integration tests. Corrected failing
graph tests
2021-05-20 16:21:24 -04:00
ghidra1 7b52b80a40 GP-42 Corrected integration test dependency 2021-05-19 21:13:54 -04:00
ghidra1 22675e9f39 Merge remote-tracking branch 'origin/GP-42_dev747368_PdbSymbolServer_for_10' 2021-05-18 21:42:23 -04:00
dev747368 9b7299492e GP-42 changed remote searching to its own button 2021-05-17 18:07:20 -04:00
dev747368 425667e640 GP-42 Initial implementation of Pdb symbol store / symbol servers 2021-05-12 16:55:01 -04:00
Ryan Kurtz 3a0ae8ee39 GP-849: Gradle 7 support 2021-05-12 13:45:16 -04:00
ghidra1 da800b6e41 GP-862 Refactor of Composite interface and internals. Changes made to
packing and alignment methods (see WhatsNew.html for API changes).
2021-05-07 20:56:35 -04:00
ghizard 0fcee8998e GP-0 - Fix Demangler skip apply plate logic 2021-04-19 09:16:32 -04:00
ghidra1 fe0f67cd5e Merge remote-tracking branch 'origin/patch' 2021-03-22 15:48:07 -04:00
ghidra1 ce056f1ea9 Corrected timing-related test failure 2021-03-22 15:44:17 -04:00
ghidra1 d377d90e14 Merge remote-tracking branch 'origin/patch'
Conflicts:
	Ghidra/Features/GraphServices/certification.manifest
2021-03-17 19:38:50 -04:00
ghidra1 162f203395 Updated certification headers 2021-03-17 18:22:50 -04:00
ghidra1 ed1580f4f9 Merge remote-tracking branch
'origin/GP-94_dragonmacher_PR-2214_astrelsky_GnuDemangler' (fixes #2214)
2021-02-16 13:25:25 -05:00
dragonmacher 8f1dc3f476 GP-94 - Gnu Demangler - review fixes
Closes #2214
2021-02-12 17:33:46 -05:00
dragonmacher b956870432 GP-628 - Dialogs - test of greatly simplified parenting code 2021-02-08 17:58:53 -05:00
dragonmacher 4041c3693b GP-658 - Temporarily disable failing tests 2021-02-03 12:41:03 -05:00
ghidra1 cd17734924 Merge remote-tracking branch 'origin/GP-639_ghidra1_DTArchiveSearchPaths--SQUASHED' 2021-01-28 16:21:51 -05:00
dev747368 b38880eaef GP-639 corrected broken archive search path preference retention 2021-01-28 16:15:10 -05:00
James 8f49837efe additional changes due to github #2693 2021-01-27 18:03:21 +00:00
ghidra1 cc483f08ab Merge remote-tracking branch 'origin/patch' 2021-01-11 18:50:07 -05:00
Jason P. Leasure e4e15cdb9d don't assume that scripts are Java, fixes #2562 2021-01-11 09:33:48 -05:00
ghidra1 db1e3d1b62 Renamed Record class to DBRecord 2020-12-28 13:30:36 -05:00
ghidravore 6dc9b3387d GP-440 Refactored graph exporters to be more extensible and easy to use in scripts 2020-12-08 17:04:30 -05:00
ghidravore b23c8ca435 Merge remote-tracking branch 'origin/patch' 2020-11-30 16:52:08 -05:00
dragonmacher 2ac0bf1edf Updated test suite to avoid compiler failure due to 'integration test'
not having test compile dependency on the 'byte viewer' module
2020-11-25 20:31:33 -05:00
ghidravore 1259632113 fixed stack trace when exporting 2020-11-25 13:11:16 -05:00
ghidra1 941ba0caf9 Merge remote-tracking branch 'origin/GT-3294_ghidra1_DBFixedField_update' 2020-11-24 17:22:54 -05:00
ghidra1 133d6c251f Merge remote-tracking branch 'origin/patch' 2020-11-24 11:39:15 -05:00
ghidravore f76577e99b Merge remote-tracking branch 'origin/GP-210_dragonmacher_PR-744_S-S-P_master' 2020-11-24 10:57:00 -05:00
ghidravore bc6613141d added dialog for user to change name of group vertices as they are created 2020-11-24 10:40:28 -05:00
ghidra1 d7dbcfebf5 GP-420 relaxed memory block naming restrictions and eliminated throwing of DuplicateNameException from memory block API 2020-11-23 17:35:49 -05:00
ghidra1 fcb3151f94 GT-3294 Added support for DB FixedField with improved indexing. 2020-11-23 14:30:38 -05:00
dragonmacher ccedc6627a GP-210 - Added new 'Copy Special' items to make copying from Ghidra to
Python and C++ easier
2020-11-23 13:36:29 -05:00
ghidravore e6fe576b87 Merge remote-tracking branch
'origin/GP_371_ghidravore_vertex_collapse--SQUASHED'

Conflicts:
	Ghidra/Features/GraphServices/src/main/java/ghidra/graph/visualization/DefaultGraphDisplay.java
2020-11-20 16:52:32 -05:00
ghidravore 724ab5a950 removed dead code
Incorporates the Jungrapht 'collapse nodes' feature into ghidra graphing.
2020-11-20 16:48:12 -05:00
ghidra1 29a3732adc Merge remote-tracking branch 'origin/patch' 2020-11-16 16:16:39 -05:00
ghidravore 6648cbb8cb Merge remote-tracking branch
'origin/GT-0_ghidravore_fixing_missing_invalide_cache_method_in_FunctionTagManager'

Conflicts:
	Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/function/tags/FunctionTagsComponentProvider.java
2020-11-05 17:39:50 -05:00
dragonmacher ea851ffe7b GP-272 - Gnu Demangler - updated to handle a lambda function as a
function parameter
2020-11-05 16:22:58 -05:00
dragonmacher 0fcdb7c6c3 Function Tags - updated DB to have a tag count cache; added service
interface
2020-11-04 16:35:31 -05:00
ghidravore b88c949c6b Merge remote-tracking branch 'origin/Ghidra_9.2' 2020-11-02 14:44:34 -05:00
ghidravore e169e28b48 Merge remote-tracking branch 'origin/GP-310-dragonmacher-graph-service-mouse-handling--SQUASHED' into Ghidra_9.2 2020-11-02 14:19:02 -05:00
ghidravore d9a1c8906f GP-310 - Graphing - Updated mouse handling to be consistent with other graph widgets. 2020-11-02 14:15:01 -05:00
ghidra1 15a3b26b8e PDB - standardized use of PDB storage preference and hid
PDB Universal options intended for loader use.
2020-11-02 12:45:48 -05:00
dragonmacher edc8efdbf6 GP-256 - Graphing - fixed AST graph exceptions 2020-10-28 17:52:12 -04:00
dragonmacher 77ee698797 GP-266 - Function Tags - updated function tags to load tags in a
background thread

Closes #2366
2020-10-21 13:40:03 -04:00
ghidravore 592b8a3cfc Changed graph api to use vertex and edge object instead of ids. 2020-10-09 14:27:29 -04:00
ghidravore 532a1d4fd0 Adding capbility to add DockingActions to GraphDisplay. Also, wired in the help for existing actions. 2020-10-07 17:58:48 -04:00
ghidra1 3452940147 GP-145 Removed obsolete analyzer support code 2020-09-08 13:33:10 -04:00
dragonmacher fc247aa499 GP-65 - Error Dialog - updated the error dialog to accumulate errors
while it is open instead of repeatedly showing new dialogs
2020-09-02 14:25:05 -04:00
Jason P. Leasure 1a598f26b2 make sure the user scripts dir exists before creating a script in it 2020-07-29 10:02:27 -04:00
Jason P. Leasure 0d520dae16 style fixes for review 2020-07-28 16:56:09 -04:00
Jason P. Leasure 2015f13542 style fixes in ghidra.app. {plugin.core.script script} 2020-07-28 16:56:09 -04:00
Jason P. Leasure 9216a940dc save/restore active bundles, use generic.util.Path string encoding 2020-07-28 16:56:08 -04:00
Jason P. Leasure 2b49816c6c factor GhidraScriptInfoManager out of GhidraScriptUtil
- move bundlehost to ghidrascriptmgrplugin
2020-07-28 16:56:08 -04:00
Jason P. Leasure 49e3d6dcdc tease out GhidraScriptUtil state, clarify headless and headed cases
- GhidraScriptUtil how has (static) initialize & dispose
  - initialize is either through (headed/GUI) GhidraScriptMgrPlugin or
    directly (headless)
- BundleHost
  - now owns bundle paths (script dirs)
  - save and restore to SaveState for use by GUI
  - no static instances
  - GhidraScriptUtil BundleHost coincides with GUI's when both are used
  - generates events
  - conservative use of auto-vivification
- BundleStatusCompoentProvider / PathManager
  - better split between GUI & model
  - subscribes to GUI's BundleHost for events
  - provider registers for generated events, controls BundleHost
2020-07-28 16:56:07 -04:00
Jason P. Leasure 431d7ac752 introduce GhidraBundle, cleanup packages, rename path->status 2020-07-28 16:56:07 -04:00
Jason P. Leasure f39d55cca1 start connecting OSGi to bundlestatusmanager
- minimize access to BundleHost instance (JavaScriptProvider is still bad)
- BundlePath
  - restrict construction to osgi package
  - remove "editable" attribute and fix incorrect reference
  - remove references in GhidraScriptUtil
    - BundlePath attribute choice came down only to system or user
    - user filtering on "enabled" were redundant
- move compilation from JavaScriptProvider to BundheHost
2020-07-28 16:56:07 -04:00
Jason P. Leasure d8610b00be improve model/view split in bundle status, more nomenclature fixes 2020-07-28 16:56:07 -04:00
Jason P. Leasure ad897f263c rename variables, move bundlehost instance, clean dead fileinstaller code 2020-07-28 16:56:07 -04:00
Jason P. Leasure 2e05da019f move bundle path manager to core as a ComponentProvider for bundle status
- PathManager was most of a ComponentProvider anyway, so this isn't a
  huge change
- this makes bundle status available w/out the GhidraScript component
- it's no longer modal, e.g. script directory list updates are immediate
2020-07-28 16:56:07 -04:00
Jason P. Leasure 092d716e96 update tests
- note: timeout increased by 33% in waitForTaskEnd because the entire
  script directory needs to compiled now
- complete recursive wipe of binary artifacts added to @After action
2020-07-28 16:56:07 -04:00
ghidra1 fd0e66d812 Merge remote-tracking branch 'origin/GP-38_ghidra1_CaseInsensitiveRegisterLookup' 2020-07-24 16:16:08 -04:00
ghidra1 e39b2e9ea9 GP-38 Refactored language/context related APIs to return unmodifiable
lists instead of arrays for some register related methods
2020-07-21 19:10:19 -04:00
dragonmacher 3be8657ff3 GT-3645 - Gnu Demangler - update parser to handle the 'unnamed type' 2020-07-21 17:09:12 -04:00
ghidra1 58157a1175 Changed JUnit tests to resolve register case sensitivity issues 2020-07-17 10:57:01 -04:00
ghidravore 2647f67be0 fixed junits for SetLanguageTest 2020-06-29 13:31:17 -04:00
ghidravore 9bd4358594 Github-1996 duplicate actions appearing in ProjectDataDialog. Also,
actions that don't belong in DataTreeDialog showing up.
2020-06-19 16:21:05 -04:00