development/ghidra
development/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra synced 2024-07-07 19:49:54 +00:00
Code Issues Projects Releases Wiki Activity

GP-4477 Don't allow references from address tables to offcut strings.

Browse Source 
Revert default number of threads for constant analysis.
This commit is contained in:
emteere 2024-05-07 15:03:35 -04:00
parent 197a18a77e
commit 28807a4641
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/analysis/ConstantPropagationAnalyzer.java
View File

@ -66,7 +66,7 @@ public class ConstantPropagationAnalyzer extends AbstractAnalyzer {
protected static final String MAX_THREAD_COUNT_OPTION_NAME = "Max Threads";
protected static final String MAX_THREAD_COUNT_OPTION_DESCRIPTION =
"Maximum threads for constant propagation. Too many threads causes thrashing in DB.";
protected static final int MAX_THREAD_COUNT_OPTION_DEFAULT_VALUE = 1;
protected static final int MAX_THREAD_COUNT_OPTION_DEFAULT_VALUE = 2;
protected static final String MIN_KNOWN_REFADDRESS_OPTION_NAME = "Min absolute reference";
protected static final String MIN_KNOWN_REFADDRESS_OPTION_DESCRIPTION =

5
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/disassembler/AddressTableAnalyzer.java
View File

@ -419,11 +419,8 @@ public class AddressTableAnalyzer extends AbstractAnalyzer {
if (cu == null) {
continue;
}
boolean atStartOfCU = cu.getMinAddress().equals(targetAddr);
// always allow offcuts to strings
if (cu instanceof Data data && data.getDataType() instanceof AbstractStringDataType) {
continue;
}
if (!allowOffcutReferences && !atStartOfCU) {
// if the processor uses low bit to reference instructions
// allow offcut to an instruction by 1