development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-02 14:34:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
flutter/packages
History
Taha Tesser c386acca54
Fix MaterialStateBorderSide lerp in the Checkbox and chips (#148124) 
fixes [`Checkbox` and Chips side with `MaterialStateBorderSide` doesn't lerp in their theme](https://github.com/flutter/flutter/issues/135136)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  testWidgets('test', (WidgetTester tester) async {
    late ColorScheme colorScheme;

    Widget buildCheckbox({required Color seedColor}) {
      colorScheme = ColorScheme.fromSeed(seedColor: seedColor);
      return MaterialApp(
        theme: ThemeData(
          colorScheme: colorScheme,
          checkboxTheme: CheckboxThemeData(
            side: MaterialStateBorderSide.resolveWith(
                (Set<MaterialState> states) {
              return BorderSide(
                color: colorScheme.primary,
                width: 4.0,
              );
            }),
          ),
        ),
        home: Scaffold(
          body: Center(
            child: Checkbox(
              value: false,
              onChanged: (_) {},
            ),
          ),
        ),
      );
    }

    await tester.pumpWidget(buildCheckbox(seedColor: Colors.red));
    await tester.pumpAndSettle();

    RenderBox getCheckboxRenderer() {
      return tester.renderObject<RenderBox>(find.byType(Checkbox));
    }

    expect(getCheckboxRenderer(), paints..drrect(color: colorScheme.primary));

    await Future<void>.delayed(const Duration(seconds: 3));

    await tester.pumpWidget(buildCheckbox(seedColor: Colors.blue));
    await tester.pump();

    await Future<void>.delayed(const Duration(seconds: 3));

    expect(getCheckboxRenderer(), paints..drrect(color: colorScheme.primary));
  });
}
```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/6df34104-37ba-4a82-b5cb-7ed4f887992a" /> | <img src="https://github.com/flutter/flutter/assets/48603081/44359248-a101-46eb-a85a-77f976da5f0f"  /> |
2024-05-10 23:37:05 +00:00
..
flutter Fix MaterialStateBorderSide lerp in the Checkbox and chips (#148124) 2024-05-10 23:37:05 +00:00
flutter_driver if chains → switch expressions (#147793) 2024-05-10 00:55:48 -06:00
flutter_goldens Remove hidden dependencies on the default LocalPlatform (#147342) 2024-05-09 15:33:55 -07:00
flutter_localizations Unpin DDS and roll pub packages (#147925) 2024-05-08 10:35:28 +01:00
flutter_test if chains → switch expressions (#147793) 2024-05-10 00:55:48 -06:00
flutter_tools bump cupertino_icons to 1.08 (#146806) 2024-05-10 21:55:52 +00:00
flutter_web_plugins Unpin DDS and roll pub packages (#147925) 2024-05-08 10:35:28 +01:00
fuchsia_remote_debug_protocol Don't pin package:macros (#148087) 2024-05-09 16:28:49 -07:00
integration_test Don't pin package:macros (#148087) 2024-05-09 16:28:49 -07:00
analysis_options.yaml