mirror of
https://github.com/flutter/flutter
synced 2024-10-13 19:52:53 +00:00
68b39da346
Exit the tool after a repeated network error to download. previously we were returning null and continuing on, leading to a ProcessException when we unzipped a missing file.
280 lines
10 KiB
Dart
280 lines
10 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/memory.dart';
|
|
import 'package:file/src/interface/file.dart';
|
|
import 'package:file_testing/file_testing.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/io.dart';
|
|
import 'package:flutter_tools/src/base/logger.dart';
|
|
import 'package:flutter_tools/src/base/os.dart';
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
import 'package:flutter_tools/src/cache.dart';
|
|
import 'package:mockito/mockito.dart';
|
|
|
|
import '../src/common.dart';
|
|
|
|
final Platform testPlatform = FakePlatform(environment: <String, String>{});
|
|
|
|
void main() {
|
|
testWithoutContext('ArtifactUpdater can download a zip archive', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: MockHttpClient(),
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
|
|
await artifactUpdater.downloadZipArchive(
|
|
'test message',
|
|
Uri.parse('http:///test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
);
|
|
expect(logger.statusText, contains('test message'));
|
|
expect(fileSystem.file('out/test'), exists);
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater will re-attempt on a non-200 response', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final MockHttpClient client = MockHttpClient();
|
|
client.testRequest.testResponse.statusCode = HttpStatus.preconditionFailed;
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: client,
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
|
|
await expectLater(() async => await artifactUpdater.downloadZipArchive(
|
|
'test message',
|
|
Uri.parse('http:///test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
), throwsToolExit());
|
|
|
|
expect(client.attempts, 2);
|
|
expect(logger.statusText, contains('test message'));
|
|
expect(fileSystem.file('out/test'), isNot(exists));
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater will tool exit on an ArgumentError from http client with base url override', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final MockHttpClient client = MockHttpClient();
|
|
client.argumentError = true;
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: FakePlatform(
|
|
environment: <String, String>{
|
|
'FLUTTER_STORAGE_BASE_URL': 'foo-bar'
|
|
},
|
|
),
|
|
httpClient: client,
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
|
|
await expectLater(() async => await artifactUpdater.downloadZipArchive(
|
|
'test message',
|
|
Uri.parse('http:///foo-bar/test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
), throwsToolExit());
|
|
|
|
expect(client.attempts, 1);
|
|
expect(logger.statusText, contains('test message'));
|
|
expect(fileSystem.file('out/test'), isNot(exists));
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater will rethrow on an ArgumentError from http client without base url override', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final MockHttpClient client = MockHttpClient();
|
|
client.argumentError = true;
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: client,
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
|
|
await expectLater(() async => await artifactUpdater.downloadZipArchive(
|
|
'test message',
|
|
Uri.parse('http:///test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
), throwsA(isA<ArgumentError>()));
|
|
|
|
expect(client.attempts, 1);
|
|
expect(logger.statusText, contains('test message'));
|
|
expect(fileSystem.file('out/test'), isNot(exists));
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater will de-download a file if unzipping fails', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: MockHttpClient(),
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
operatingSystemUtils.failures = 1;
|
|
|
|
await artifactUpdater.downloadZipArchive(
|
|
'test message',
|
|
Uri.parse('http:///test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
);
|
|
expect(logger.statusText, contains('test message'));
|
|
expect(fileSystem.file('out/test'), exists);
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater will bail if unzipping fails more than twice', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: MockHttpClient(),
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
operatingSystemUtils.failures = 2;
|
|
|
|
expect(artifactUpdater.downloadZipArchive(
|
|
'test message',
|
|
Uri.parse('http:///test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
), throwsA(isA<ProcessException>()));
|
|
expect(fileSystem.file('te,[/test'), isNot(exists));
|
|
expect(fileSystem.file('out/test'), isNot(exists));
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater can download a tar archive', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: MockHttpClient(),
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
|
|
await artifactUpdater.downloadZippedTarball(
|
|
'test message',
|
|
Uri.parse('http:///test.zip'),
|
|
fileSystem.currentDirectory.childDirectory('out'),
|
|
);
|
|
expect(fileSystem.file('out/test'), exists);
|
|
});
|
|
|
|
testWithoutContext('ArtifactUpdater will delete downloaded files if they exist.', () async {
|
|
final MockOperatingSystemUtils operatingSystemUtils = MockOperatingSystemUtils();
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
final BufferLogger logger = BufferLogger.test();
|
|
final ArtifactUpdater artifactUpdater = ArtifactUpdater(
|
|
fileSystem: fileSystem,
|
|
logger: logger,
|
|
operatingSystemUtils: operatingSystemUtils,
|
|
platform: testPlatform,
|
|
httpClient: MockHttpClient(),
|
|
tempStorage: fileSystem.currentDirectory.childDirectory('temp')
|
|
..createSync(),
|
|
);
|
|
|
|
artifactUpdater.downloadedFiles.addAll(<File>[
|
|
fileSystem.file('a/b/c/d')..createSync(recursive: true),
|
|
fileSystem.file('d/e/f'),
|
|
]);
|
|
|
|
artifactUpdater.removeDownloadedFiles();
|
|
|
|
expect(fileSystem.file('a/b/c/d'), isNot(exists));
|
|
expect(logger.errorText, isEmpty);
|
|
});
|
|
}
|
|
|
|
class MockOperatingSystemUtils extends Mock implements OperatingSystemUtils {
|
|
int failures = 0;
|
|
|
|
@override
|
|
void unzip(File file, Directory targetDirectory) {
|
|
if (failures > 0) {
|
|
failures -= 1;
|
|
throw const ProcessException('zip', <String>[], 'Failed to unzip');
|
|
}
|
|
targetDirectory.childFile(file.fileSystem.path.basenameWithoutExtension(file.path))
|
|
.createSync();
|
|
}
|
|
|
|
@override
|
|
void unpack(File gzippedTarFile, Directory targetDirectory) {
|
|
if (failures > 0) {
|
|
failures -= 1;
|
|
throw const ProcessException('zip', <String>[], 'Failed to unzip');
|
|
}
|
|
targetDirectory.childFile(gzippedTarFile.fileSystem.path.basenameWithoutExtension(gzippedTarFile.path))
|
|
.createSync();
|
|
}
|
|
}
|
|
|
|
class MockHttpClient extends Mock implements HttpClient {
|
|
int attempts = 0;
|
|
bool argumentError = false;
|
|
final MockHttpClientRequest testRequest = MockHttpClientRequest();
|
|
|
|
@override
|
|
Future<HttpClientRequest> getUrl(Uri url) async {
|
|
attempts += 1;
|
|
if (argumentError) {
|
|
throw ArgumentError();
|
|
}
|
|
return testRequest;
|
|
}
|
|
}
|
|
class MockHttpClientRequest extends Mock implements HttpClientRequest {
|
|
final MockHttpClientResponse testResponse = MockHttpClientResponse();
|
|
|
|
@override
|
|
Future<HttpClientResponse> close() async {
|
|
return testResponse;
|
|
}
|
|
}
|
|
class MockHttpClientResponse extends Mock implements HttpClientResponse {
|
|
@override
|
|
int statusCode = HttpStatus.ok;
|
|
|
|
@override
|
|
Future<void> forEach(void Function(List<int> element) action) async {
|
|
return;
|
|
}
|
|
}
|