mirror of
https://github.com/flutter/flutter
synced 2024-08-24 02:21:12 +00:00
7292c94bac
Even though this does not fix the below issue lets land this anyway as not logging to stderr when clearing logs makes sense to me. related https://github.com/flutter/flutter/issues/150093 The test added is bad. It does not verify the behavior changed. To verify the behavior changed correctly I would need to modify the generic device class to have clearLogs be an async function like many of the other calls. That would mean modifying every other device type and their implementations and their tests. Then I would need to update android_device to expose its logger. That is more than I have time for to validate a 2% flake error. Feel free to disagree in the comments on this pr. |
||
|---|---|---|
| .. | ||
| flutter | ||
| flutter_driver | ||
| flutter_goldens | ||
| flutter_localizations | ||
| flutter_test | ||
| flutter_tools | ||
| flutter_web_plugins | ||
| fuchsia_remote_debug_protocol | ||
| integration_test | ||
| analysis_options.yaml | ||