development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-29 21:14:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
flutter/dev
History
auto-submit[bot] 1c9607fc9c
Reverts "Normalize TabBarTheme (#155476)" (#155698) 
Reverts: flutter/flutter#155476
Initiated by: eyebrowsoffire
Reason for reverting: The newly added tests are failing in postsubmit. See https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_libraries/19062/overview
Original PR Author: QuncCccccc

Reviewed By: {TahaTesser}

This change reverts the following previous change:
This PR is to make preparations to make `TabBarTheme` conform to Flutter's conventions for component themes:

* Added a `TabBarThemeData` class which defines overrides for the defaults for `TabBar` properties.
* Added 2 `TabBarTheme` constructor parameters: `TabBarThemeData? data` and `Widget? child`. This is now the preferred way to configure a `TabBarTheme`:
```
TabBarTheme(
  data: TabBarThemeData(labelColor: xxx, indicatorColor: xxx, ...),
  child: TabBar(...)
)
```
  These two properties are made nullable to not break existing apps which has customized `ThemeData.tabBarTheme`.

* Changed the type of component theme defaults from `TabBarTheme` to `TabBarThemeData`.

TODO:

* Fix internal failures.
* Change the type of `ThemeData.tabBarTheme` from `TabBarTheme` to `TabBarThemeData`. This may cause breaking changes, a migration guide will be created.

Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
2024-09-25 17:50:18 +00:00
..
a11y_assessments text button case rework (#154943) 2024-09-13 19:11:08 +00:00
automated_tests Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
benchmarks Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
bots Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
conductor Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
customer_testing Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
devicelab Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
docs Update API docs footer (#150347) 2024-06-17 19:39:12 +02:00
forbidden_from_release_tests Manual dependency bump (#152881) 2024-08-06 02:40:27 +00:00
integration_tests Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
manual_tests Manual roll to 48ddaf578fb0c8326d5b4b680b0f49ea72e33216 (#155070) 2024-09-12 17:58:12 +00:00
missing_dependency_tests
snippets Roll pub packages (#155640) 2024-09-25 00:03:57 +00:00
tools Reverts "Normalize TabBarTheme (#155476)" (#155698) 2024-09-25 17:50:18 +00:00
tracing_tests Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 (#155579) 2024-09-24 00:21:06 +00:00
analysis_options.yaml
README.md

README.md

This directory contains tools and resources that the Flutter team uses during the development of the framework. The tools in this directory should not be necessary for developing Flutter applications, though of course, they may be interesting if you are curious.

The tests in this directory are run in the framework_tests_misc-* shards.