mirror of
https://github.com/flutter/flutter
synced 2024-09-28 20:44:26 +00:00
834566f05d
Fixes: #115275 Fixes: #116127 Fixes: #126682 Continuing on: #139078 (Credits to @LowLevelSubmarine for his initial work!) When using `ZoomPageTransitionsBuilder`, which is the default for `ThemeData` with a `MaterialApp`, dark edges would show around the exiting page that was being zoomed out in the background. Other times, a scrim (what looked like a slightly transparent dark overlay over the page) would appear. After some experimenting it was concluded that, in the first case, this was because both pages don't fully fill the enclosing scaffold area during the transition and the color for filling the remaining space was set hard coded as `Colors.black`. The second case (scrim) happens when navigating from a page with an enclosing scaffold to a nested one, without a scaffold, unlike the first case that happens when both pages have a (different) enclosing scaffold, except this time it would be the hard coded color covering the page with a slight opacity reduction. ### Changes - Replaced the hard coded color for transition filling with the current `ThemeData.colorScheme.surface` - Added a RenderBox based test to verify the correct color is being used in the transition. ## Preview **Before, notice the dark outline flash when navigating to the first page and the scrim when navigating to the second:** https://github.com/user-attachments/assets/b4cc8658-1008-49f4-8553-abd5fcc72989 **After, using the theme relative color (in this case the default white) to replace the hard coded value:** https://github.com/user-attachments/assets/b70f42d2-6246-4964-99d1-34ff8051ab06 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation. - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
132 lines
4.8 KiB
Plaintext
132 lines
4.8 KiB
Plaintext
# Below is a list of people and organizations that have contributed
|
|
# to the Flutter project. Names should be added to the list like so:
|
|
#
|
|
# Name/Organization <email address>
|
|
#
|
|
# Anyone who has contributed to the Flutter project in any way (not
|
|
# limited to submitting PRs) is welcome to submit a PR to add their
|
|
# name to this file.
|
|
#
|
|
# Thanks to everyone for your contributions!
|
|
|
|
Google Inc.
|
|
The Chromium Authors
|
|
The Fuchsia Authors
|
|
Jim Simon <jim.j.simon@gmail.com>
|
|
Lex Berezhny <lex@damoti.com>
|
|
Wyatt Arent <hello@wyatt.ninja>
|
|
Michael Perrotte <mikemimik@gmail.com>
|
|
Günter Zöchbauer <guenter@gzoechbauer.com>
|
|
Raju Bitter <rajubitter@gmail.com>
|
|
Michael Beckler <mcbeckler@gmail.com>
|
|
Alexandre Ardhuin <alexandre.ardhuin@gmail.com>
|
|
Luke Freeman <luke@goposse.com>
|
|
Vincent Le Quéméner <eu.lequem@gmail.com>
|
|
Mike Hoolehan <mike@hoolehan.com>
|
|
German Saprykin <saprykin.h@gmail.com>
|
|
Stefano Rodriguez <hlsroddy@gmail.com>
|
|
Yusuke Konishi <yahpeycoy0403@gmail.com>
|
|
Fredrik Simón <fredrik@fsimon.net>
|
|
Ali Bitek <alibitek@protonmail.ch>
|
|
Tetsuhiro Ueda <najeira@gmail.com>
|
|
Dan Field <dfield@gmail.com>
|
|
Noah Groß <gross@ngsger.de>
|
|
Victor Choueiri <victor@ctrlanddev.com>
|
|
Christian Mürtz <teraarts@t-online.de>
|
|
Lukasz Piliszczuk <lukasz@intheloup.io>
|
|
Felix Schmidt <felix.free@gmx.de>
|
|
Artur Rymarz <artur.rymarz@gmail.com>
|
|
Chema Molins <chemamolins@gmail.com>
|
|
Stefan Mitev <mr.mitew@gmail.com>
|
|
Jasper van Riet <jaspervanriet@gmail.com>
|
|
Mattijs Fuijkschot <mattijs.fuijkschot@gmail.com>
|
|
Volodymyr Lykhonis <vladimirlichonos@gmail.com>
|
|
TruongSinh Tran-Nguyen <i@truongsinh.pro>
|
|
Sander Dalby Larsen <srdlarsen@gmail.com>
|
|
Marco Scannadinari <m@scannadinari.co.uk>
|
|
Frederik Schweiger <mail@flschweiger.net>
|
|
Martin Staadecker <machstg@gmail.com>
|
|
Igor Katsuba <katsuba.igor@gmail.com>
|
|
Diego Velásquez <diego.velasquez.lopez@gmail.com>
|
|
Simon Lightfoot <simon@devangels.london>
|
|
Sarbagya Dhaubanjar <mail@sarbagyastha.com.np>
|
|
Rody Davis Jr <rody.davis.jr@gmail.com>
|
|
Robin Jespersen <info@unitedpartners.de>
|
|
Jefferson Quesado <jeff.quesado@gmail.com>
|
|
Mark Diener <rpzrpzrpz@gmail.com>
|
|
Alek Åström <alek.astrom@gmail.com>
|
|
Efthymios Sarpmpanis <e.sarbanis@gmail.com>
|
|
Cédric Wyss <cedi.wyss@gmail.com>
|
|
Michel Feinstein <michel@feinstein.com.br>
|
|
Michael Lee <ckmichael8@gmail.com>
|
|
Katarina Sheremet <katarina@sheremet.ch>
|
|
Nicolas Schneider <nioncode+git@gmail.com>
|
|
Mikhail Zotyev <mbixjkee1392@gmail.com>
|
|
Maria Melnik <melnikmk@gmail.com>
|
|
Ayush Bherwani <ayush.bherwani1998@gmail.com>
|
|
Luke Cheng <chengludev@gmail.com>
|
|
Brian Wang <xinlei966@gmail.com>
|
|
法的空间 <zmtzawqlp@live.com>
|
|
CaiJingLong <cjl_spy@163.com>
|
|
Alex Li <alexv.525.li@gmail.com>
|
|
Ram Navan <hiramprasad@gmail.com>
|
|
meritozh <ah841814092@gmail.com>
|
|
Terrence Addison Tandijono(flotilla) <terrenceaddison32@gmail.com>
|
|
YeungKC <flutter@yeungkc.com>
|
|
Nobuhiro Tabuki <japanese.around30@gmail.com>
|
|
nt4f04uNd <nt4f04und@gmail.com>
|
|
Anurag Roy <anuragr9847@gmail.com>
|
|
Andrey Kabylin <andrey@kabylin.ru>
|
|
vimerzhao <vimerzhao@gmail.com>
|
|
Pedro Massango <pedromassango.developer@gmail.com>
|
|
Hidenori Matsubayashi <Hidenori.Matsubayashi@sony.com>
|
|
Perqin Xie <perqinxie@gmail.com>
|
|
Seongyun Kim <helloworld@cau.ac.kr>
|
|
Ludwik Trammer <ludwik@gmail.com>
|
|
J-P Nurmi <jpnurmi@gmail.com>
|
|
Marian Triebe <m.triebe@live.de>
|
|
Alexis Rouillard <contact@arouillard.fr>
|
|
Mirko Mucaria <skogsfrae@gmail.com>
|
|
Karol Czeryna <karol.czeryna@gmail.com>
|
|
Callum Moffat <callum@moffatman.com>
|
|
Koutaro Mori <koutaro.mo@gmail.com>
|
|
Sergei Smitskoi <sergflutterdev@gmail.com>
|
|
Casey Rogers <caseycrogers@berkeley.edu>
|
|
Pradumna Saraf <pradumnasaraf@gmail.com>
|
|
Kai Yu <yk3372@gmail.com>
|
|
Denis Grafov <grafov.denis@gmail.com>
|
|
TheOneWithTheBraid <the-one@with-the-braid.cf>
|
|
Alberto Miola <betoman96@gmail.com>
|
|
Twin Sun, LLC <google-contrib@twinsunsolutions.com>
|
|
Taskulu LDA <contributions@taskulu.com>
|
|
Jonathan Joelson <jon@joelson.co>
|
|
Elsabe Ros <hello@elsabe.dev>
|
|
Nguyễn Phúc Lợi <nploi1998@gmail.com>
|
|
Jingyi Chen <jingyichen@link.cuhk.edu.cn>
|
|
Junhua Lin <1075209054@qq.com>
|
|
Tomasz Gucio <tgucio@gmail.com>
|
|
Jason C.H <ctrysbita@outlook.com>
|
|
Hubert Jóźwiak <hjozwiakdx@gmail.com>
|
|
David Neuy <quantjump@gmail.com>
|
|
Eli Albert <crasowas@gmail.com>
|
|
Jan Kuß <jan@kuss.dev>
|
|
André Sousa <andrelvsousa@gmail.com>
|
|
Bartek Pacia <barpac02@gmail.com>
|
|
Mike Rydstrom <m.rydstrom@gmail.com>
|
|
Harish Anbalagan <warriorharish95668@gmail.com>
|
|
Kim Jiun <kkimj@hanyang.ac.kr>
|
|
LinXunFeng <linxunfeng@yeah.net>
|
|
Sabin Neupane <sabin.neupane26@gmail.com>
|
|
Mahdi Bagheri <1839491@gmail.com>
|
|
Mok Kah Wai <taboosun1996@gmail.com>
|
|
Lucas Saudon <lsaudon@gmail.com>
|
|
Om Phatak <everythingoutdated@gmail.com>
|
|
Amir Panahandeh <amirpanahandeh@gmail.com>
|
|
Kostiantyn Sokolovskyi <sokolovskyi.konstantin@gmail.com>
|
|
Valentin Vignal <valentin.vignal.dev@outlook.fr>
|
|
Cedric Vanden Bosch <cedvdb@youvision.dev>
|
|
Flop <kukuzuo@gmail.com>
|
|
Dimil Kalathiya <kalathiyadimil@gmail.com>
|
|
Nate Wilson <nate.w5687@gmail.com>
|
|
dy0gu <support@dy0gu.com>
|