Commit graph

358 commits

Author SHA1 Message Date
Greg Spencer 1b9cba4b42
Make sure we refer to 'stable', and not 'release' branch. (#23745) 2018-10-30 16:57:54 -07:00
Ian Hickson 4a094de290
[H] Cleanup (#23632)
* Avoid abbreviations

* Sample code for AppBar.leading

* Add a test for OverflowBox/FractionallySizedBox

* Minor wording improvements in the text.

The words "note that" here don't really contribute to the flow.
2018-10-29 19:44:00 -07:00
Jacob Richman b21fb8c27d
Run flutter tests with --track-widget-creation as part of the build. (#23415) 2018-10-23 14:10:53 -07:00
Greg Spencer 65d3ddd5d1
Dartdoc snippet extension to inject full featured code snippets in to API docs. (#23281)
This creates a custom dartdoc tool that will generate snippet blocks in our API docs that allow the user to copy easily to the clipboard, and will also embed the snippet code into a template to show it in a larger context with an app.

This PR adds the snippet tool, a template, and a couple of HTML skeleton files, one for snippets that are designed to be in an application setting, and one where it simply puts a nice container around existing snippets, making them easier to copy to the clipboard.
2018-10-23 13:50:24 -07:00
Greg Spencer fbb01eabae
Update dartdoc to use 0.24.1 (#23275) 2018-10-19 10:40:30 -07:00
Greg Spencer 2000583ed3
Revert "don't disable TODO issues in IDEs (#23274)" (#23297)
Devon asked me to revert commit c4d1b31b74.

Merging on red to fix the build.
2018-10-19 10:03:35 -07:00
Devon Carew c4d1b31b74
don't disable TODO issues in IDEs (#23274)
* don't disable TODO issues in IDEs

* minor change to start cirrus
2018-10-19 08:01:05 -07:00
Siva cf18d01e86
Disable unsafePackageSerialization as it causes issues when coverage is turned on (#23280)
* Disable unsafePackageSerialization as it causes issues when coverage is
used (see https://github.com/dart-lang/sdk/issues/34841)

* Restore Coverage.
2018-10-19 06:19:24 -07:00
Danny Tuppeny b357b55904
Use (processors-1) for test runs (test defaults to processors/2) (#22803)
* Use (processors-1) for test runs (test defaults to processors/2)

* Add missing import 🙄
2018-10-19 08:07:54 +01:00
Yegor 9524b611c0
skip coverage due to https://github.com/dart-lang/sdk/issues/34841 (#23224) 2018-10-17 17:56:07 -07:00
Alexandre Ardhuin 8b0de38ef8
fix upcoming lint avoid_returning_null_for_void (#23190) 2018-10-17 11:01:37 +02:00
Alexandre Ardhuin 936dea28da
enable lint prefer_void_to_null (#23174)
* enable lint prefer_void_to_null

* replace last Null by void
2018-10-17 08:09:29 +02:00
Janice Collins 24717a3280
Update dartdoc to v0.24.0. (#23175) 2018-10-16 14:40:03 -07:00
Jacob Richman c6a222fa28
Revert "Run flutter tests with --track-widget-creation as part of the build. (#22596)" (#23129)
This reverts commit bf92d7f286.
2018-10-15 17:13:44 -07:00
Jacob Richman bf92d7f286
Run flutter tests with --track-widget-creation as part of the build. (#22596) 2018-10-15 13:46:25 -07:00
Greg Spencer ba1323929a
Re-enable docs generation. (#22979) 2018-10-11 15:56:22 -07:00
Greg Spencer 081d2a7a86
Re-land text wrapping/color PR (#22831)
This attempts to re-land #22656.

There are two changes from the original:

I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.

I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.

As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.

*     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)

    This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).

    Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.

    Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.

    Since wrapping is now turned on, also removed many redundant '\n's in the code.
2018-10-10 18:17:56 -07:00
Janice Collins 59f1f1b6e2
Update dartdoc to 0.23.1. (#22875) 2018-10-09 13:49:00 -07:00
Yegor 8d643013b1
add AOT smoke tests to Cirrus (#22751) 2018-10-08 12:38:46 -07:00
Andrew Davies 9ceb9ab305
[flutter_driver] Adds fuchsia compat for connect() (#22633)
Adds a Fuchsia compatibility function that allows for connecting to a
specific Isolate by name when running Flutter Driver on a Fuchsia
device.  This will check over multiple Dart VM's in an attempt to find
an Isolate by its name.
2018-10-08 11:09:07 -07:00
Greg Spencer 2d81adf74c
Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
This reverts commit e438632165
because it breaks 160 benchmarks, and several devicelab tests,
due to changing the format of the output.
2018-10-05 22:29:37 -07:00
Greg Spencer e438632165
Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).

Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.

Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.

Since wrapping is now turned on, also removed many redundant '\n's in the code.
2018-10-05 20:00:11 -07:00
Yegor 3184b7cb66
Revert "Use mixin syntax for Flutter's super-mixins (#22435)" (#22748)
This reverts commit 3c56e6c77d.

It breaks the AOT build.
2018-10-05 15:09:38 -07:00
Yegor 3c56e6c77d
Use mixin syntax for Flutter's super-mixins (#22435)
* first pass

* revert WidgetsBindingObserver

* disable prefer_mixin

* docs and more mixins

* newer engine; binding fixes

* upgrade dependencies

* fix test binding

* remove whitespace

* remove the obsolete `enableSuperMixins: true`

* upgrade dartdoc to 0.22.0

* temporarily use git version of dartdoc

* fix pub global activate syntax

* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
Greg Spencer 407ce13792
Temporarily disabling Docs deployment again. (#22705)
This reverts commit fef759f410, because apparently
the service is still "unavailable".
2018-10-04 18:00:23 -07:00
Greg Spencer fef759f410
Revert "Temporarily disabling Docs deployment (#22588)" (#22683)
This reverts commit 9eca083006 to turn on
docs generation again, since now we have paid...
2018-10-04 17:39:04 -07:00
Alexandre Ardhuin d340e2f229
apply lint prefer_void_to_null in dev/ (#22661) 2018-10-04 18:44:23 +02:00
Danny Tuppeny d43155695d
Revert "Use (processors-1) for test runs (test defaults to processors/2)" (#22628)
* Revert "Custom offset functionality for Popup Menu Button (#22534)"

This reverts commit f44b277fa6.

* Revert "Updated the ColorScheme dartdoc: a11y (#22618)"

This reverts commit aa6a27e8a2.

* Revert "Added support for the Khmer (km) language (#22617)"

This reverts commit 3a87b93fce.

* Revert "Use 'Future<void>' insted of 'Future<Null>' in SystemChrome (#22583)"

This reverts commit 37c10acb97.

* Revert "Choice Chip Fix (#22589)"

This reverts commit 8d76d37f33.

* Revert "Throw if trying to set fs.currentDirectory in tests (#22037)"

This reverts commit 2f6155bf18.

* Revert "Use (processors-1) for test runs (test defaults to processors/2) (#22085)"

This reverts commit d44f003079.
2018-10-03 21:35:36 +01:00
Danny Tuppeny d44f003079
Use (processors-1) for test runs (test defaults to processors/2) (#22085)
* Use (processors-1) for test runs (test defaults to processors/2)

* Add missing import 🙄
2018-10-03 19:06:48 +01:00
xster 9b893b1430
Set the upload key in cirrus when publishing (#22581) 2018-10-02 18:34:20 -07:00
Greg Spencer 9eca083006
Temporarily disabling Docs deplyment (#22588)
Merging on read to unbreak the build.

TBR= @Hixie
2018-10-02 16:15:04 -07:00
Greg Spencer 9a9ef594bc
Compare the Cirrus OS env var with the right value for macOS (darwin) (#22533) 2018-10-02 10:20:09 -07:00
Yegor d91f1608c5
upgrade packages (#22524) 2018-10-01 14:42:53 -07:00
Alexandre Ardhuin f62afdcf57
add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00
Janice Collins dc5f85e72c
Upgrade dartdoc to version 0.21.1. (#22143) 2018-09-24 09:20:15 -07:00
Ian Hickson 6d134e0c86
Animation API improvements (#21540) 2018-09-23 00:43:05 -07:00
Ian Hickson 989cf18b0d
[H] Cleanup (#21542)
* Improve documentation and clean up code.

* Remove "Note that".

The phrase "note that" is basically meaningless as a prefix to an
otherwise fine sentence.
2018-09-22 02:02:56 -07:00
Danny Tuppeny 7dd82813f2
Remove -j1 to run tools tests concurrently (#22038)
Fixes #21113.
2018-09-19 17:47:06 +01:00
Alexandre Ardhuin e2d0b062d9
remove unnecessary ignore prefer_const_constructors (#21934) 2018-09-18 05:54:03 +02:00
Alexandre Ardhuin a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Alexandre Ardhuin d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Alexandre Ardhuin 976cffa24d
lint unnecessary_new on samples (#21539)
* lint unnecessary_new on samples

* fix tests
2018-09-07 11:00:05 +02:00
Alexandre Ardhuin 3c58195350
lint unnecessary_const on samples (#21155) 2018-09-07 09:13:13 +02:00
TL Lee e2167b9f53
Add build test for Flutter codelabs (#19579)
* Add build test for Flutter codelabs

* Fix indentation in build test script

* Correct filename for the codelabs build test run by travis

* Change if statement to elif

* Replace echo statements with set -x

* Add BSD-style license

* Add codelabs build test to Cirrus

* Remove codelabs_build_test from Travis.

* Remove codelabs_build_test from travis_script.sh

* Update documentation for codelabs_build_test.sh

* Update readme for build test

* Add link to open a new issue to MDC-Flutter

* Add phrase to address "if you think you really need to break this test, please escalate this"
2018-09-06 17:16:22 -04:00
Chris Bracken 3519eabe8a
Do not pass --preview-dart-2 to Dart VM (#21455)
--preview-dart-2 is no longer necessary as it is now the default for the
standalone Dart VM.
2018-09-06 10:59:37 -07:00
Todd Volkert 2f32166f4b
Update packges (#21241)
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Alexander Aprelev eab5cd9853
Fix analysis shard of dev/bots/test.dart so it works on Windows. (#21203)
Normalize file path to non-Windows so string path comparison works.
2018-08-30 14:47:04 -07:00
Alexander Aprelev 391e91c996
Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart (#21174)
* Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart.

This allows to run analysis step with command line arguments that are only applicable to flutter analyze(like --dart-sdk, needed for dart-flutter-engine head-head-head bot).

* Add forgotten dev/bots/analyze.dart

* Refactor common code from analyze.dart and test.dart into run_command.dart

* Remove comments, add header
2018-08-30 07:30:25 -07:00
Janice Collins e7d87af4d2
Update dartdoc to 0.20.4. (#21131) 2018-08-28 14:58:52 -07:00
Ian Hickson 53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00