Previously, a disabled floating action button always had zero
elevation, which looks dumb.
This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.
This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
Adds asserts on required constructor parameters to a transition widgets.
This improves debuggability for those who aren't developing with live
analysis. e.g. when `turns` is not specified in a RotationTransition
constructor:
package:flutter/src/widgets/transitions.dart: Failed assertion: line 43 pos 15: 'listenable != null': is not true.
becomes:
package:flutter/src/widgets/transitions.dart': Failed assertion: line 259 pos 15: 'turns != null': is not true.
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
* Fix `flutter test`e xpression eval tests
We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.
* Ensure we wait for breakpoints before trying to evaluate
* Allow a widget to be specified for the textfield count, and allow no count at all
* Test all possible states for counter and counterText
* Docs for counter
* counter is a function that generates a widget
* Tests use counter as function
* Fix analyze error in docs
* InputDecoration has counter widget, TextField has buildCounter function
* InputDecorator tests expect counter to be widget again and include
buildCounter
* counter widget example that might actually fit
* Clarify accessiblity concerns in docs
* Include isFocused param for accessibility
* Fix analyze error
* Improve docs per code review
* Rearrange getEffectiveDecoration a bit for clarity
* Fix analyze error about hashValues params
* Clean up docs and redundant code per code review
* Code review doc improvement
* Automatically wrap buildCounter widget in a Semantics widget for accessibility
This was causing analysis to fail when there was an import statement in a comment, such as when snippets add imports to their examples.
I narrowed the RegExp to match only those lines which aren't commented out, but it really should probably be using the analysis server to catch all cases (e.g. if someone put the doc comment into /** */ comments, it could still match). Since this is a Flutter-specific script, it's probably not worth doing that.
17a90fbe8f...e68a3fa912
git log 17a90fbe8f23b6efb97c322e5ea67a0a55f4de0e..e68a3fa912cd1ba0e2aaf1f87e7abdec96e68aee --no-merges --oneline
e68a3fa91 Roll src/third_party/dart b0855ffd35ad4878fb3b36d8f5ff00a421719e7c..1c9eb3cef80779601f964b05a68a785bf49b084f (1 commits) 1c9eb3cef8 [Kernel] Allow constant declarations without an initializer
386cb4859 Roll src/third_party/skia 33f58abef2b7..da068c0d1d7c (1 commits) (flutter/engine#7462)
6f89a132d Roll src/third_party/dart f81dd1da9f9f879c17dda7b20a2572fa5549f3dd..b0855ffd35ad4878fb3b36d8f5ff00a421719e7c (4 commits) b0855ffd35 [infra] Fix testing on Android 8d9247b9fc dartfix README 7b5f24db6f Change wiki link to follow contents moved. 6f4e85d11f [dart2js js_runtime] Run dartfmt --fix-doc-comments
82bb5f7c8 Roll src/third_party/skia 60a2f675ddce..33f58abef2b7 (1 commits) (flutter/engine#7460)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
5722a9685e...abbc34e148
git log 5722a9685e3cba77649ba5257a91ed21933ca063..abbc34e1482d0a118a84040933f61cfa42a1fb5f --no-merges --oneline
abbc34e14 Roll src/third_party/skia 82223aae39b7..2ee498c6749a (2 commits) (flutter/engine#7454)
f817343a7 Roll src/third_party/skia e548161aba5b..82223aae39b7 (3 commits) (flutter/engine#7453)
cd0169ae2 Roll src/third_party/skia c334df71b8f9..e548161aba5b (1 commits) (flutter/engine#7452)
377ff1975 Roll src/third_party/dart f0c7d971c472066e29a949aab8826c204cfbaf35..f81dd1da9f9f879c17dda7b20a2572fa5549f3dd (2 commits) f81dd1da9f Handle super* in ir/impact.dart 99a9ae66c3 [dart2js] run dartfmt --fix-doc-comments on stragglers
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
35daf143b1...5722a9685e
git log 35daf143b1f313977b92137283d2792d3be6f16f..5722a9685e3cba77649ba5257a91ed21933ca063 --no-merges --oneline
5722a9685 Roll src/third_party/dart 651d19cdaa25d020b8f7c193c907644284029130..f0c7d971c472066e29a949aab8826c204cfbaf35 (80 commits) f0c7d971c4 [dart2js] Run dartfmt --fix-doc-comments a9ce969e53 [vm] Decouple growable_array.h and zone.h from thread.h d821a2ec96 [vm/aot/tfa] Correctly tree shake initializers of write-only fields 602aa203b2 [vm/compiler] AOT bounds check elimination 3c5501a090 Add the experiment flags for the control flow and spread collection features 71e62a6016 [gardening] mark standalone_2/io/stdout_stderr_non_blocking_test as flaky e636e1fa6f Accept experimental flags in dart2js and enable set-literal tests, now supported once we accept the flag. 7cea3cba29 Several dump-info fixes. bbc6e2dd6f [VM/Compiler] Add some missing results for inlines. e329a830da [VM/AOT] Fix shared spilling stubs on arm/arm64 and enable it 5a1e01b7c9 [gardening] mark lib_2/isolate/unresolved_ports_test as flaky 3ef595bb56 [VM/Compiler] Separate out inlined code from replacement result. 68ad94cebe Extract more hint tests into separate files 47e988b781 Clean up the remaining copyright notices in analysis_server ea9303566b [vm] Allow choosing architecture for runtime sources in generate_idefiles.py. 1842020a69 Fix empty set/map literal disambiguation rule. 6a756ac040 Add front-end test for set/map literal disambiguation. 76be911f22 Enable set literals by default in the front-end tests. 02bb4379a2 Added specification of new style function types, generalized typedefs b631eb9b2f [gardening] Mark io/http_server_close_response_after_error_test as flaky 03098c1505 Implement DillClassBuilder.mixedInType 4547066f4b Tweak Declaration API c3b13ae5c1 Collect abstract members immediately instead of counting. deb9239790 Compute type arguments of dill types. c41611d35b Add non-final fields to setters b61a085c60 Use custom thisType to signal static type precision. 9157bbcf19 [kernel] Add text (de)serialization for VariableSet ba75b4c437 Revert "Change default target to "create_sdk"." 736ac8469d Use correct way of enabling blobs on dartk-bare-{simarm,simarm64} 1314a6dbf7 [Kernel] Do not evaluate fromEnvironment constants 90d22365d1 Convenience function to parse a list of experimental flags 7b2aae5498 Handle dynamic/instance access in ir/impact.dart 5cb13961db Use typeEnvironment.nullType for `null` and custom type for 'does not complete' 5340fea835 Move more parts of impact builder to ir/impact.dart cff0d20247 Use better static types for RuntimeTypeUse 944984f015 [Kernel] Add syntax for unevaluated constants 3d7ca147a4 Add FeaturesDataInterpreter d9c5bc131d [VM] Use --use-blobs for dartk-precomp-simarm/simarm64 builders 3f90e88288 first cut adding simple non-nullable migration to dartfix 16e98d012d Update BasicWorkspace's docs and tests 03be1858e7 [vm, gc] Use the correct trap instruction when zapping ARM/ARM64 code space. e2e2a85744 [dart2js] Add --no-minify flag for compiler devs bb4da7890b [gen_snapshot] Fixes for x86 Flutter code push. fc67a19feb js_runtime: Fix bit mask to match comments a1ff5f7cd5 Ensure inlining of getter/setters is recorded in our source-map extension d44ec3a57e Remove full emitter version of Function.apply 60cf393ff3 [dartdevc] fix to pass in analysis options to analysis context c34f1b4890 [vm] Bind static calls before saving JIT snapshots. 161f9b35c7 Use preparsed experiment status in Static Type Analyzer f043f296ef [vm] More modulo tests. 29b34fa63f Set nullability for TypeName(s) based of ClassElement. bb025bfac4 Use target file in CREATE_CONSTRUCTOR fixes. 5966565f0e Re-sort file and move TODO to where it was originally 4ef8de99ac Remove full emitter 8719fb3a7b Generate homebrew script compatible with latest changes edb68daa2c DateTime decimal separator: Added ',' version to regex and docs, added unit tests 6712dca7d8 Fix the test used to differentiate between empty sets and empty maps c76fa45178 Add an analysis server diagnostics page for LSP capabilities and completions 4a80990758 Implement LSP textDocument/documentHighlight 44449e29d2 Add a custom toJson snippet for LSP ResponseMessage for null handling 7e0d65706f Include null in allowed types for `any` and prefer null to omitting values if allowed 59b252fa0a [kernel] Add text serializer/deserializer for VariableGet 0bb0072f5f [infra] Add vm-kernel-precomp-android builder to the test matrix d908743de1 update_homebrew: initial cleanup e0ede8791f Fasta: Set fileEndOffset on Fields fe079b31b0 [tools] Fix list of possible arguments for -a in --help. 705701951a Small cleanup in incremental compiler 05673b80fc Suggest uploading dill file when failing to initialize from dill 457a7355f5 [vm] Use Util::Abs instead of std::abs. 89d3276703 Revert regexp_kill_test which is flaky on all platforms. d00f1e7e8e Introduce kernel based impact builder 0109e39ca4 Report INVALID_ASSIGNMENT for prefix/postfix increment decrement when the result is not assignable to the operand. e7495724b9 Remove TypeEnvironment.hierarchy 8e5ad9b3bd Prepare the VM for removing TypeEnvironment.hierarchy 7ac495e02a Prepare DDC for removing TypeEnvironment.hierarchy ca9ea997bd Fix old treatment of {}, enable set literals tests 7e3f4516b8 Allow crashes on fasta compiler co19_2 tests of Constant-update2018. Needed to turn ci bot green. 3c9e2cf8c9 Update front-end compiler status for co19_2 tests 8da53e3120 [vm] Add Dart_SaveTypeFeedback and Dart_LoadTypeFeedback. 9f2e614e98 [fuchsia] Just use dlopen like on other OSes
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
Profile builds need access to sockets in order to launch the Dart
observatory server.
This permission used to be enabled by default in all build types,
but was moved to a build type specific manifest in
88b853f7eb
(cloned from https://github.com/flutter/flutter/pull/26399)
e5ec3cf3ea...b7f6bf0192
git log e5ec3cf3ea5ce78c6c3116271601f60d30a799d4..b7f6bf0192d175ac2c245f27524c5195140ecd50 --no-merges --oneline
b7f6bf019 Pass deadline to embedder idle notification callback (flutter/engine#7444)
5272805f1 Fix settings.advisory_script_uri in iOS createShell (flutter/engine#7235)
788dea5dd Eliminate std::string using directive (flutter/engine#7433)
cd98f6bdb Clear the font collection's cache when a font is dynamically loaded (flutter/engine#7436)
dea6a0849 Remove legacy and deprecated defaultClipBehavior (flutter/engine#7439)
5749b75af Temporary revert of Dart SDK rolls made since 2019/01/08 (flutter/engine#7437)
29c70f5fc Roll src/third_party/skia 292ece8024ea..d2fa7e33798c (8 commits) (flutter/engine#7434)
37d886ef8 Simplify rollback of dynamic patches (flutter/engine#7432)
6071286ef Download dynamic patch to separate file, then rename it to install. (flutter/engine#7428)
4c9136bdb Roll src/third_party/dart cb966bdce7a0a9d0c34149b50ae5704676cf34c8..651d19cdaa25d020b8f7c193c907644284029130 (4 commits) 651d19cdaa Ignore --fast-startup flag, assume true aeb7fccd5b Fix plugin start up to work with OverlayResourceProvider 0b0704c7c4 [vm] Use std::abs instead of regular abs(). 36b5fe0c7a Track how many analysis server requests had latency info
239f16e72 Roll src/third_party/dart 927b0cb9edda5500fed0acbd60c04487d3e526e6..cb966bdce7a0a9d0c34149b50ae5704676cf34c8 (1 commits) cb966bdce7 Unify parsing of co19 test options and regular test options.
2501eb42e Roll src/third_party/dart f4986cc78ddd884e60e7274c44f31dbcd990b912..927b0cb9edda5500fed0acbd60c04487d3e526e6 (73 commits)927b0cb9ed [vm/aot] Support optimization of modulo against a power-of-two. bf13ac85c4 Ensure LSP server clears diagnostics for removed files/analysis roots 54fffe4cca Add support for LSP workspace/didChangeWorkspaceFolders e7b783ba5d Fix bug with deprecated rootPath + add tests ad300b904d Improve handling of server-specific analysis diagnostics pages 1d096d8499 Enable the analyzer Diagnostics server for LSP 6bb1dcdfa4 Fix wording e749576caa [VM/Compiler/AOT] Do not populate unused arguments descriptor in bare instructions mode a1250467fe Move member conflict detection to own method
39a99b005 Docs improvements per @Hixie's comments (flutter/engine#7387)
26e02aaa2 Wire up support for external OpenGL textures for the embedder. (flutter/engine#7087)
20d70d2bf Eliminate unused import of ZipException (flutter/engine#7429)
b972f75db Allow embedders to add per shell idle notification callbacks. (flutter/engine#7427)
844d27cb3 Refactor dynamic patching to use clearer naming and structure. (flutter/engine#7426)
99fa3901a Roll src/third_party/skia 3560ea702f1b..292ece8024ea (9 commits) (flutter/engine#7424)
97ff4b226 Dart SDK roll for 2019-01-09
39b2e4b02 Roll src/third_party/skia 76dc683364c2..3560ea702f1b (10 commits) (flutter/engine#7420)
88e212f99 Dart SDK roll for 2019-01-09
82d3208d4 Roll src/third_party/skia 1337f5b85978..76dc683364c2 (18 commits) (flutter/engine#7418)
8657340c8 Dart SDK roll for 2019-01-09
a369ef606 Dart SDK roll for 2019-01-08
3ae5eb8c1 Dart SDK roll for 2019-01-08
42f449fa4 remove deprecated updateNode argument (flutter/engine#7413)
5e33f33a1 Refactor shared code into separate function to simplify further work. (flutter/engine#7410)
937ee8bf9 Cleanup dead code (flutter/engine#7409)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
This adds some functions to the interface for RawKeyEventData and all subclasses that allow the recipient of an event to determine which modifier keys are currently being pressed without needing to know the specific modifier bitmasks for the platform.
Also adds constants for the modifier bitmasks for each platform, for completeness (and because I needed them anyhow to implement the above).
Added tests for the RawKeyEventData subclasses, and modified the raw_keyboard manual test app to show modifier keys being pressed. I also separated the different platform-specific subclasses into separate files.
Fixes#26155.
Usages of ParagraphConstraints (from dart:ui) whose constructor could be
const as of flutter/engine#7346 are currently marked //
ignore:prefer_const_constructors in the framework until all
Google-internal embedders have been updated to an engine version that
includes the above change. These were initially updated in engine roll
flutter/flutter#26252, but broke internal embedders.
We should re-enable use of the const constructor in those cases once
internal embedders are updated.
See: https://github.com/flutter/flutter/issues/26390
* Added the superellipse (a.k.a. squircle) shape to flutter, which is needed to recreate some cupertino components, e.g. buttons in pixel-perfect detail (issue #13914).
