Commit graph

80 commits

Author SHA1 Message Date
Pierre-Louis 7855132341
Generate a demo for new icons when updating icons (#101190)
* add code to generate new icon demo and make font family optional

* remove trailing spaces

* Update update_icons_test.dart

* remove trailing space
2022-04-05 12:56:23 +02:00
Devon Carew 45f8c39052
use 'dart pub' instead of calling the pub executable directly (#97749)
use 'dart pub' instead of calling the pub executable directly
2022-02-04 12:45:20 -08:00
Pierre-Louis 6bd0b95728
[Icons] Prevent double underscores after replacement (#96904)
* Prevent double underscores after replacement

* add test

* remove trailing space
2022-01-30 13:16:32 +01:00
Pierre-Louis b23f207e2c
Improve update_icons.dart script (#93863)
* Update update_icons.dart

* formatting

* more formatting

* simplify safety checks

* add safety checks tests

* formatting

* update copyright

* naming

* revert copyright

* add `fontFamily` option

* tweak diff messages

* Update update_icons.dart

* don't exit if platform adaptive icon not found

* remove trailing spaces

* remove warning and fix insert_chart (outlined) dartdoc

* x

* add error message when exiting due to failed safety checkes

* fix icon reference

* fix rewrite for onetwothree
2021-12-08 16:31:48 +01:00
Sam Rawlins 8889ffaec3
Remove and also ignore unnecessary imports (#89796) 2021-09-14 15:32:02 -07:00
Christopher Fujino 2ba15a5aba
teach dartdoc.dart about LUCI_BRANCH env var (#86592) 2021-07-19 12:20:00 -07:00
Christopher Fujino 62d00c6d5f
Migrate flutter conductor out of dev/tools and into its own directory (#83313)
* Migrate flutter conductor out of dev/tools and into its own directory

* flesh out documentation

* fix analysis options

* fix integration test
2021-05-25 16:12:53 -07:00
Christopher Fujino 2123c93aa7
fix candidates (#82957) 2021-05-20 17:34:05 -07:00
Christopher Fujino 660ec207e6
[flutter_conductor] Re-land auto-apply dart revision (#82985) 2021-05-20 16:58:11 -07:00
Christopher Fujino 843083c93a
Revert "[flutter_conductor] Auto apply dart revision (#82601)" (#82983)
This reverts commit e86f9c7a7c.
2021-05-19 21:38:45 -07:00
Christopher Fujino e86f9c7a7c
[flutter_conductor] Auto apply dart revision (#82601) 2021-05-19 21:23:26 -07:00
Christopher Fujino 84b2f3cadb
delete skipped test (#81843) 2021-05-11 14:19:01 -07:00
Christopher Fujino a5318173fe
apply cherrypicks (#81936) 2021-05-11 13:19:05 -07:00
Sam Rawlins 208bf4bc92
Remove "unnecessary" imports in dev/ (#81004) 2021-05-07 08:59:02 -07:00
Christopher Fujino 7b3ce8c003
[flutter_conductor] Add candidates sub command (#81234) 2021-05-03 16:49:04 -07:00
Ian Hickson 6beafa7b16
Apply style guide regarding createTempSync pattern (#81090) 2021-04-27 14:59:03 -07:00
Christopher Fujino 3155972744
Skip roll-dev integration test until dev release is published (#81253) 2021-04-26 17:36:16 -07:00
Christopher Fujino 8654e4ae3e
begin migrating //flutter/dev/tools to null-safety (#80834) 2021-04-23 20:24:03 -07:00
Phil Quitslund 61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Christopher Fujino 4a7f280687
[flutter_conductor] Add "start", "status", "clean" commands to conductor release tool (#80528) 2021-04-19 15:04:04 -07:00
Christopher Fujino a219b86db8
skip roll_dev_integration_test (#80464) 2021-04-14 14:16:08 -07:00
Tong Mu 8a821ff0b5
Revert "Remove "unnecessary" imports. (#79610)" (#80070)
This reverts commit 98a9618993.
2021-04-08 11:36:30 -07:00
Sam Rawlins 98a9618993
Remove "unnecessary" imports. (#79610) 2021-04-07 22:34:03 -07:00
Ian Hickson f3c25fa07a
Align more closely with package:test (#77118) (#78343) 2021-03-16 13:58:02 -07:00
Zachary Anderson e7e1a04aa3
Revert "Align more closely with package:test (#77118)" (#78329)
This reverts commit 0cbe597540.
2021-03-16 09:26:34 -07:00
Ian Hickson 0cbe597540
Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Michael Goderbauer cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Jonah Williams 021311ed8a
Revert "[flutter_tools] move process manager into tool (#75350)" (#75639)
This reverts commit 8b6baae44c.
2021-02-08 09:21:46 -08:00
Jonah Williams 8b6baae44c
[flutter_tools] move process manager into tool (#75350)
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Christopher Fujino 353add83e7
Re-land codesign test improvement (#73997) 2021-01-25 14:04:04 -08:00
Christopher Fujino 66ba4b244d
Revert "Improve codesign script (#71244)" (#73961)
This reverts commit b7f5aef11a.
2021-01-14 18:40:29 +00:00
Christopher Fujino b7f5aef11a
Improve codesign script (#71244) 2021-01-14 18:22:08 +00:00
Christopher Fujino b8887f47f7
fix and re-enable integration test (#70666) 2020-11-18 11:13:04 -08:00
Christopher Fujino b8e39b1ad0
skip roll_dev_integration_test (#70653) 2020-11-16 14:11:22 -08:00
Christopher Fujino 772437627b
[flutter_conductor] update dev/tools with release tool (#69791) 2020-11-06 11:14:04 -08:00
Shi-Hao Hong b80b432555
Move gen_l10n into flutter_tools (#65025) 2020-09-03 09:26:58 -07:00
Shi-Hao Hong fd22fc3e35
[gen_l10n] Synthetic package generation by default (#62395)
* synthetic packages by default in gen_l10n tool

* Refactor default path for synthetic package

* Remove unused import

* Code cleanup

* Further improvements to help text

* Refactor synthetic package path

* Remove newlines

* Test cleanup

* clean up logic in inputs and outputs list function

* Update l10n.yaml usage

* only add option if value is non-null

* Update stocks app as proof of concept for synthetic package usage

* Address nits

* print pubspec contents

* add print statements

* Do not allow null value for useSyntheticPackage

* +

* +

* +

* +

* Cleanup

* Add test

* Fix text

* Dont parse pubspec directly

* Test using context

* WIP: generate synthetic packages on pub get -- needs tests

* Allow null value

* Update null handling

* Refactor to properly handle null case

* Fix yamlMap condition

* Fix yaml node for real

* WIP: struggling to write tests

* WIP - take absolute path as an option

* Add tests

* Use environment project directory for synthetic package generation pathway

* Fix typo

* Improve help text

* Update defaults

* Remove unauthorized path import

* Fix pathing issues at synthetic package generation

* Fix typo in test

* Use path.join so projectDir matches up based on OS

* Fix Windows pathing in test

* Remove unnecessary replaceApp code for projectDir.path

* Use globals.fs.currentDirectory.path in resident_runner_test.dart

* Fix merge conflict

* Add test to ensure that synthetic package is generated on pub get

* Fix resident_runner_test.dart tests

* Fix tests

* Use package:file instead of dart:io

* WIP - exploration

* Remove synthetic package use from stocks example

* Update integration test to not use synthetic packages

* Remove trailing whitespace

* flutter pub get runs synth package generation

* Remove more print statements

* Add license header

* WIP - minimally working pub.get

* Use own MockBuildSystem

* Modify test and implementation to be a little cleaner

* Fix flutter pub get invocation

* Use synthetic packages in stocks app

* Revert "Use synthetic packages in stocks app"

This reverts commit 45bf24903c.

* Add environment and buildSystem params to flutter test

* Address code review feedback

* +

* Isolate codegen into its own API

* Fix imports

* Slight refactor

* Add one more test for no l10n.yaml file

* Remove unneeded mock class and import in pub_get_test.dart

* More code review feedback

* Remove unnecessary imports

* Remove `return await`s that I missed

* use arrow functions instead
2020-08-31 13:19:41 +08:00
Shi-Hao Hong 0a7c6243fa
[gen_l10n] Absolute project path parameter (#63368) 2020-08-13 05:11:05 -07:00
Shi-Hao Hong 1e6e7150f3
[gen_l10n] Update the arb filename parsing logic (#60185)
* Update the arb filename parsing to account for underscores

* Generalize the locale searching algorithm

* Update filename and @@locale behavior to require them to match
2020-06-26 12:01:59 +08:00
Per Classon 56a7dacd46
[flutter_tools] For l10n with deferred loading, use loadLibrary for non-web too (#59539)
After Dart VM change we are now required to use loadLibrary on an import whenever it is imported as deferred.

See: https://dart-review.googlesource.com/c/sdk/+/149613
2020-06-16 13:36:28 -07:00
Christopher Fujino 807b60250a
[flutter_tools] Update roll_dev.dart (#59215) 2020-06-16 09:30:04 -07:00
Christopher Fujino 3e31dbd29d
fix ref (#56721) 2020-05-11 12:05:02 -07:00
Christopher Fujino d56af3ca5e
Add --force to roll_dev.dart (#56501) 2020-05-07 18:24:03 -07:00
Shi-Hao Hong eadd30eb6c
Improve arb FormatException error message (#56373) 2020-05-07 18:09:03 -07:00
Shi-Hao Hong 13501af6e6
[gen_l10n] Optionally generate list of inputs/outputs (#56490) 2020-05-07 11:46:02 -07:00
Shi-Hao Hong de4f052703
[gen_l10n] Fix unintended breaking change introduced by output-dir option (#55909)
* Fix breaking change introduced by gen_l10n output-dir option
2020-04-28 16:25:59 -07:00
Shi-Hao Hong 9d7af39a5b
[gen_l10n] Output directory option (#55792)
* Add new output-dir option for gen_l10n tool
2020-04-28 13:10:27 -07:00
Christopher Fujino 2bb361c9f7
[flutter_tools] Fix roll dev script, add tests (#54783) 2020-04-16 10:10:04 -07:00
Per Classon 4451ffca23
Add option for deferred loading to gen_l10n (#53824) 2020-04-09 03:57:01 -07:00
Shi-Hao Hong 5d63637e43
[gen_l10n] Fallback feature for untranslated messages (#53374)
* Generate methods using template resources if they do not exist in other locales

* Added a flag to either output of messages that have not been translated with detail into a file, or display a summary on the terminal.

* Add integration test for fallback message usage
2020-04-08 18:55:50 -07:00