Commit graph

14721 commits

Author SHA1 Message Date
Darren Austin f7ee440207
Migrate yet even more widget framework tests to null safety. (#67941)
Migrate yet even more widget framework tests to null safety.
2020-10-15 11:12:02 -07:00
Jonah Williams 27936e9f22
Revert "[flutter_tools] ensure android log reader works in flutter drive (#68131)" (#68222)
This reverts commit d962c8f2a2.
2020-10-15 10:50:56 -07:00
Jonah Williams 2321b72dfb
[flutter_tools] move gradle download failure handling into tool (#68140)
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
2020-10-15 09:20:52 -07:00
Jonah Williams 46ff57d6f1
Revert "Improve performance of collectAllElements (#68065)" (#68207)
This reverts commit 8ba5732c4c.
2020-10-15 08:04:59 -07:00
Michael Goderbauer aaaf37418b
Migrate last batch of tests (#68163) 2020-10-14 22:52:05 -07:00
Hans Muller bf6460f935
Updated Builder API doc (#68151) 2020-10-14 22:47:04 -07:00
Michael Goderbauer e3184b38be
Migrate some widget tests to NNBD (#68150) 2020-10-14 22:42:05 -07:00
Shi-Hao Hong dfc6c4386a
[NNBD] More widget tests (#68088)
* NNBD widget test migration
2020-10-15 13:39:06 +08:00
Dan Field 8ba5732c4c
Improve performance of collectAllElements (#68065) 2020-10-14 21:32:04 -07:00
Pedro Massango ff85d97ae5
Expose the tileColor property (#67135) 2020-10-14 21:27:07 -07:00
Sam Rawlins 12bea61c29
Mark unusuallyLongTimeout as internal (#68038) 2020-10-14 15:57:04 -07:00
Albert Wolszon e8343c0ec4
Add missing margin to SnackBarAction (#67167) 2020-10-14 15:47:03 -07:00
Jenn Magder 1fb94fb894
Noninteractive iOS debugger session (#68145) 2020-10-14 15:38:07 -07:00
Darren Austin 2c59a3a760
Migrate Switch tests to null safety. (#68133) 2020-10-14 15:32:04 -07:00
xubaolin f2d5f1f61f
Add test case for AndroidView clipBehavior (#67913) 2020-10-14 15:27:03 -07:00
Jenn Magder a82807d782
Run Xcode command lines tools in native ARM (#68050) 2020-10-14 15:24:32 -07:00
Yash Johri 0a130100ac
Updated tests (#67083) 2020-10-14 15:22:04 -07:00
Jonah Williams d962c8f2a2
[flutter_tools] ensure android log reader works in flutter drive (#68131) 2020-10-14 14:04:33 -07:00
Jenn Magder 537cf33a21
Move processUtils to globals (#67976) 2020-10-14 13:12:46 -07:00
Jonah Williams 767fb98a7b
[flutter_tools] partial revert of start app change (#68128)
* [flutter_tools] partial revert of start app change
2020-10-14 12:20:30 -07:00
Jenn Magder 431c599bec
Revert "[flutter_tools] If run fails to install the application on iOS, try uninstalling it and trying again. (#68078)" (#68118)
This reverts commit 61ba7dd218.
2020-10-14 10:07:30 -07:00
Jonah Williams 61ba7dd218
[flutter_tools] If run fails to install the application on iOS, try uninstalling it and trying again. (#68078) 2020-10-14 09:14:36 -07:00
Per Classon 8a7fd39b85
[Material] Parent checkbox in DataTable should deselect all, if children checkboxes are disabled or selected (#67938) 2020-10-14 08:57:06 -07:00
xubaolin 7eeab2666b
Fix DropdownButton bug (#65915) 2020-10-14 01:52:03 -07:00
HeavenOSK 66cf8d47a3
[Improvement] Add prefix Alignment. for toString of Alignment (#67860)
* modify: add prefix `Alignment.` for toString of Alignment
2020-10-14 13:47:28 +08:00
Jonah Williams 4b351ac1b4
[flutter_tools] do not allow attaching in release mode (#68071)
Do not allow attach in release mode, as there is not VM Service to connect to. Observed in crash reporting as thrown string which is changed to exception below.
2020-10-13 21:29:23 -07:00
Jonah Williams 751459df24
[flutter_tool] support --use-application-binary in flutter drive (#68060)
--use-application-binary allows running with an already built APK. This can be useful for speeding up CI test cases, or in our case eventually supporting some sort of build server. Demonstrate that this works by updating the old gallery test to use it. Fixes #56604

Co-authored-by: Jenn Magder <magder@google.com>
2020-10-13 19:27:30 -07:00
Darren Austin ca065f6456
Migrate more Material framework tests to null safety. (#67790)
* Migrate more Material framework tests to null safety.
2020-10-13 16:48:41 -07:00
Greg Spencer ef119187d0
Convert some widgets tests to NNBD (#67782)
Migrating some more widget tests to NNBD.
2020-10-13 14:41:24 -07:00
Kate Lovett 085f1daa43
Clean up after large refactor (#67939) 2020-10-13 13:42:02 -07:00
Kate Lovett 46d1b7d8e8
[NNBD] Migrate some Widgets tests (#68034) 2020-10-13 13:07:05 -07:00
Jonah Williams 9e70180f63
[flutter_tools] do not measure progress timeout (#67959)
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jenn Magder 3e0d2741de
Detach debugger when VM connection fails on iOS (#68046) 2020-10-13 12:50:50 -07:00
Jenn Magder 4dffc851bc
Detect ARM macOS arch with sysctl hw.optional.arm64 (#67970) 2020-10-13 12:05:04 -07:00
Michael Goderbauer 0343555af1
Migrate more tests (#68037)
* Migrate more tests

* fix
2020-10-13 12:01:53 -07:00
Jonah Williams bdfb07dffd
[flutter_test] export fake from flutter_test (#68032)
Fake has been moved from mockito to test to facilitate NNBD, re-export this from flutter_test
2020-10-13 11:38:00 -07:00
Kate Lovett e48c9b5553
[NNBD] Migrating some Material tests (#67689) 2020-10-13 11:37:03 -07:00
Jonah Williams d6d06ed9f0
[flutter_tools] delete applicationPackageStore (#68026)
This class is entirely superseded by the application package factory. Only drive and install use it, and removing it from drive will allow use-application-binary support.
2020-10-13 11:33:55 -07:00
Jonah Williams 1c976933f3
[flutter_tools] support Android Studio 4.1 on Windows (#67992)
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986
2020-10-13 11:33:26 -07:00
Miguel Beltran 1aaa455f1b
Fix for "Pass RouteSettings to the internal Route in showCupertinoModalPopup" (#67990) 2020-10-13 11:32:20 -07:00
xubaolin 4982555982
Add more unit test cases for EditableText widget (#66889) 2020-10-13 11:32:03 -07:00
Jonah Williams 37ebe3d82a
Revert "prevent pageView scrolling when calling ensureVisible (#67988)" (#68036)
This reverts commit 62cf4dbf10.
2020-10-13 10:52:23 -07:00
Ren You a57f45e080
Revert "More EditableText docs (#66864)" (#68025)
This reverts commit daa6b2cc29.
2020-10-13 09:08:48 -07:00
xubaolin 62cf4dbf10
prevent pageView scrolling when calling ensureVisible (#67988) 2020-10-12 23:12:02 -07:00
Nobuhiro Tabuki 1e180062aa
[flutter_tools] Support IntelliJ 2020.1 and later on Linux and Windows (#58853)
This PR will update IntelliJ IDEA/Community validation logic for 2020.1 and later on Linux and Windows.
2020-10-12 22:03:36 -07:00
Jonah Williams ac751cc50c
[flutter_tools] verify checksum of downloaded artifacts (#67839)
All of the network requests from google cloud storage include an x-goog-hash header which contains an MD5 checksum. If present, use to validate that the downloaded binary is valid. This will rule out corrupt files as the cause of getting started crashers in the flutter_tool.

#38980

This does not fully resolve the above issue, because while we can check if the checksum matches what was expected from cloud storage, this A) may not necessarily be present and B) may not match up to what should be uploaded as part of the engine build process.

But when life gives you lemons you hash those lemons using an outdated hashing algorithm.
2020-10-12 17:44:23 -07:00
Jonah Williams 5dfe7e6d51
[flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971)
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.

A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?

(9a3a0dc caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
2020-10-12 17:00:26 -07:00
Shi-Hao Hong 46238de8c5
[NNBD] Migrate some Material tests to NNBD (#67887)
Migrates the following files to NNBD: 
* input_decorator_test.dart
* list_tile_test.dart
* localizations_test.dart
* material_button_test.dart
* material_state_property_test.dart
* material_test.dart
* mergeable_material_test.dart
2020-10-13 07:57:23 +08:00
Shi-Hao Hong 244f5ab598
Expose date symbols and patterns for en_US in framework (#67900)
* Expose date symbols and patterns for en_US in framework
2020-10-13 07:56:10 +08:00
Jonah Williams 8aee75f645
Revert "Pass RouteSettings to the internal Route in showCupertinoModalPopup (#56024)" (#67969)
This reverts commit da58f5e6fe.
2020-10-12 16:09:20 -07:00