engine-flutter-autoroll
52969a0909
Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) ( #135147 )
...
5f82fc2f6f...6f256257b7skia-flutter-autoroll@skia.org Roll Skia from fd317812bd27 to 56ce5bb201c6 (4 revisions) (flutter/engine#46096 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 16:13:25 +00:00
Camille Simon
594ff98a65
[Android] Add Java/AGP/Gradle incompatibility warning to flutter create ( #131444 )
...
Adds warning to `flutter create` command that checks if detected Java version is compatible with the template AGP and template Gradle versions. If a developer is building for Android and their Java version is incompatible with either the AGP or Gradle versions that Flutter currently supports by default for new Flutter projects, then
- a warning will show noting the incompatibility and
- steps will be shown to fix the issue, the recommended option being to configure a new compatible Java version given that Flutter knows we can support the template Gradle/AGP versions and updating them manually may be risky (feedback on this approach would be greatly appreciated!)
Given that the template AGP and Gradle versions are compatible, this PR assumes that the detected Java version may only conflict with one of the template AGP or Gradle versions because:
- the minimum Java version for a given AGP version is less than the maximum Java version compatible for the minimum Gradle version required for that AGP version (too low a Java version will fail AGP compatibility test, but not Gradle compatibility).
- the maximum Java version compatible with minimum Gradle version for a given AGP version is higher than minimum Java version required for that AGP version (too high a Java version will fail Gradle compatibility test, but not AGP compatibility test).
Fixes https://github.com/flutter/flutter/issues/130515 in the sense that `flutter create foo`; `cd foo`; `flutter run` should always be successful.
2023-09-20 16:01:04 +00:00
engine-flutter-autoroll
3a78e5c5fc
Roll Packages from d4e245421737 to 51e74b97508a (12 revisions) ( #135145 )
...
d4e2454217...51e74b9750stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945 )
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880 )
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c9ed8936504163flutter/packages#4947 )
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699 )
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713 )
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946 )
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587 )
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b1327ab7d0e8c9edflutter/packages#4944 )
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923 )
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881 )
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941 )
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 16:01:02 +00:00
Greg Spencer
8cda3bea23
Remove 'must not be null' comments from various libraries. ( #134984 )
...
## Description
This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together.
This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
## Related PRs
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994
## Tests
- Documentation only change.
2023-09-20 15:44:49 +00:00
engine-flutter-autoroll
a1f8c99f95
Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) ( #135142 )
...
6535421b30...5f82fc2f6fskia-flutter-autoroll@skia.org Roll Skia from d7f2d1083979 to fd317812bd27 (2 revisions) (flutter/engine#46094 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (flutter/engine#46093 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 15:29:06 +00:00
engine-flutter-autoroll
7212a079d9
Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) ( #135139 )
...
67d4aaef3c...6535421b30skia-flutter-autoroll@skia.org Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (flutter/engine#46092 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 14:38:24 +00:00
Kostia Sokolovskyi
98ebab58ee
Cover more test/widgets tests with leak tracking #8 ( #135045 )
2023-09-20 07:34:41 -07:00
Kostia Sokolovskyi
c3db020993
Cover more test/widgets tests with leak tracking #9 ( #135054 )
2023-09-20 07:34:23 -07:00
engine-flutter-autoroll
d0004c9513
Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) ( #135128 )
...
83b4df415b...67d4aaef3cskia-flutter-autoroll@skia.org Roll Skia from 7d9d5ac84d8f to d7f2d1083979 (1 revision) (flutter/engine#46091 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 11:52:35 +00:00
engine-flutter-autoroll
cb4b402ce5
Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) ( #135102 )
...
df4e6c0796...83b4df415bskia-flutter-autoroll@skia.org Roll Skia from 14e9b3c91c64 to 7d9d5ac84d8f (1 revision) (flutter/engine#46090 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from e3aa86332255 to 14e9b3c91c64 (1 revision) (flutter/engine#46089 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 09:24:31 +00:00
engine-flutter-autoroll
aae6c6d7fb
Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) ( #135101 )
...
9c6b250028...df4e6c0796skia-flutter-autoroll@skia.org Roll Skia from e9b9e9a4f541 to e3aa86332255 (1 revision) (flutter/engine#46088 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 08:36:30 +00:00
engine-flutter-autoroll
3c25a9f2ca
Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) ( #135098 )
...
24f7ac38df...9c6b250028skia-flutter-autoroll@skia.org Roll Dart SDK from b8f006d88c07 to b3fd178ce59f (3 revisions) (flutter/engine#46087 )
2023-09-20 bdero@google.com [Impeller] Ensure that reused textures are cleared before getting sampled by backdrop textures (flutter/engine#46084 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d6325ec2f053 to e9b9e9a4f541 (1 revision) (flutter/engine#46086 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 07:31:05 +00:00
engine-flutter-autoroll
1e56af5a2e
Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) ( #135096 )
...
36379b62be...24f7ac38dfbdero@google.com [Impeller] Use BlackTransparent clear color when backdrop filters are present. (flutter/engine#46085 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 5d916c04e9fc to d6325ec2f053 (1 revision) (flutter/engine#46083 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 06:49:05 +00:00
engine-flutter-autoroll
a5db10e43c
Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) ( #135095 )
...
81b93fc4a2...36379b62beskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZhY53WD7bFJSA3xoO... to aHtib4LBcLwx7JwK-... (flutter/engine#46082 )
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from 1a8885b9e03c to 5d916c04e9fc (6 revisions) (flutter/engine#46081 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZhY53WD7bFJS to aHtib4LBcLwx
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 06:00:03 +00:00
engine-flutter-autoroll
e300fda767
Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) ( #135093 )
...
5a924a9017...81b93fc4a2skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 06g6i7-5u8O-FOTSi... to kGkqpvcPI1TGmR4Sc... (flutter/engine#46079 )
2023-09-20 godofredoc@google.com Use magic envs to pass commit and temp folder. (flutter/engine#46015 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 06g6i7-5u8O- to kGkqpvcPI1TG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 04:51:11 +00:00
Greg Spencer
a1e49be25b
Remove 'must be non-null' and 'must not be null' comments from material. ( #134991 )
...
## Description
This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
This PR removes them from the material library.
This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134993
- https://github.com/flutter/flutter/pull/134994
## Tests
- Documentation only change.
2023-09-20 04:20:49 +00:00
Gray Mackall
f4b5fc1803
Unpin url launcher (remake) ( #134958 )
...
More up to date version of https://github.com/flutter/flutter/pull/133786 .
Fixes https://github.com/flutter/flutter/issues/111304
2023-09-20 02:43:57 +00:00
engine-flutter-autoroll
6cf7ca0137
Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) ( #135085 )
...
a7af55c56a...5a924a9017chinmaygarde@google.com [Impeller] Fix validation error about incorrect aspect on buffer to texture copies. (flutter/engine#46078 )
2023-09-19 jonahwilliams@google.com [Impeller] Affinity adjustments for Vulkan backend. (flutter/engine#46063 )
2023-09-19 chinmaygarde@google.com [Impeller] Fix validation errors in RendererTest. (flutter/engine#46076 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (flutter/engine#46075 )
2023-09-19 30870216+gaaclarke@users.noreply.github.com [Impeller] adds hardware gate for wide gamut (flutter/engine#46051 )
2023-09-19 jacksongardner@google.com Properly transfer objects between the main thread and web worker. (flutter/engine#46061 )
2023-09-19 30870216+gaaclarke@users.noreply.github.com Made the warning about downgrading wide gamut happen at the correct time (flutter/engine#46064 )
2023-09-19 matanlurey@users.noreply.github.com Conform to clang_tidy in `client_wrapper` headers. (flutter/engine#46058 )
2023-09-19 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds unit test to make sure we can encode bgr101010xr to png. (flutter/engine#46007 )
2023-09-19 ychris@google.com [ios] scenario test make parent view controller hide status bar (flutter/engine#46065 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 02:31:04 +00:00
engine-flutter-autoroll
07e70a4086
Manual roll Flutter Engine from a7af55c56aa6 to 0d7db40c27fd (7 revisions) ( #135079 )
...
Manual roll requested by zra@google.com
a7af55c56a...0d7db40c27skia-flutter-autoroll@skia.org Roll Skia from fe3568162721 to
1a8885b9e03c (6 revisions) (flutter/engine#46075 )
2023-09-19 30870216+gaaclarke@users.noreply.github.com [Impeller] adds
hardware gate for wide gamut (flutter/engine#46051 )
2023-09-19 jacksongardner@google.com Properly transfer objects between
the main thread and web worker. (flutter/engine#46061 )
2023-09-19 30870216+gaaclarke@users.noreply.github.com Made the warning
about downgrading wide gamut happen at the correct time
(flutter/engine#46064 )
2023-09-19 matanlurey@users.noreply.github.com Conform to clang_tidy in
`client_wrapper` headers. (flutter/engine#46058 )
2023-09-19 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds
unit test to make sure we can encode bgr101010xr to png.
(flutter/engine#46007 )
2023-09-19 ychris@google.com [ios] scenario test make parent view
controller hide status bar (flutter/engine#46065 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 18:41:26 -07:00
Greg Spencer
fe9a2c5477
Remove 'must not be null' comments from painting and rendering libraries. ( #134993 )
...
## Description
This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
This PR removes them from the painting and rendering libraries.
This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134994
## Tests
- Documentation only change.
2023-09-20 01:37:22 +00:00
derdilla
14b832aaf6
cover more tests with leak tracking ( #134837 )
2023-09-19 17:42:40 -07:00
Xilai Zhang
52ef9d8827
[flutter roll] Revert "Native assets support for Linux" ( #135069 )
...
Reverts flutter/flutter#134031
context: b/301051367
Looked at the error message from the broken TAP target, but seems like the failure might be non trivial to resolve. Would it be okay if we revert this for now while it is being triaged?
2023-09-20 00:06:45 +00:00
engine-flutter-autoroll
13e34bd3c2
Manual roll Flutter Engine from 10c480310926 to a7af55c56aa6 (4 revisions) ( #135071 )
...
Manual roll requested by zra@google.com
10c4803109...a7af55c56agoderbauer@google.com Enable strict-inference (flutter/engine#46062 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 559a964f9f1b to fe3568162721 (5 revisions) (flutter/engine#46069 )
2023-09-19 58529443+srujzs@users.noreply.github.com Implement JSObject instead of extending (flutter/engine#46070 )
2023-09-19 matanlurey@users.noreply.github.com `FlutterMouse.*` -> `kFlutterMouse.*`, so we can lint header files. (flutter/engine#46056 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-20 00:03:19 +00:00
Zachary Anderson
5c6b031c10
Retry Linux web tests 1 time on roll presubmit ( #135073 )
...
Reland of https://github.com/flutter/flutter/pull/134552
2023-09-19 23:17:25 +00:00
David Iglesias
c7c9d8eea6
[web] Encode AssetManifest.bin as JSON and use that on the web. ( #131382 )
...
This PR modifies the web build slightly to create an `AssetManifest.json`, that is a JSON(base64)-encoded version of the `AssetManifest.bin` file.
_(This should enable all browsers to download the file without any interference, and all servers to serve it with the correct headers.)_
It also modifies Flutter's `AssetManifest` class so it loads and uses said file `if (kIsWeb)`.
### Issues
* Fixes https://github.com/flutter/flutter/issues/124883
### Tests
* Unit tests added.
* Some tests that run on the Web needed to be informed of the new filename, but their behavior didn't have to change (binary contents are the same across all platforms).
* I've deployed a test app, so users affected by the BIN issue may take a look at the PR in action:
* https://dit-tests.web.app
2023-09-19 22:38:51 +00:00
Polina Cherkasova
ba2dde48fa
Specify suggested format in doc comment. ( #134887 )
2023-09-19 15:33:29 -07:00
engine-flutter-autoroll
6569395534
Manual roll Flutter Engine from 28f14e6eec4f to 10c480310926 (6 revisions) ( #135066 )
...
Manual roll requested by jonahwilliams@google.com
Cannot build log URL because revision "10c480310926" is invalid: Luci builds of "Linux Fuchsia" for 10c480310926d7e04a77ba8a04d321f9d225a545 was INFRA_FAILURE
2023-09-19 matanlurey@users.noreply.github.com Add TODO(name) to comply with Clang Tidy. (flutter/engine#46057 )
2023-09-19 ychris@google.com [ios]Adjust golden test threshold for TwoPlatformViewsWithOtherBackDropFilterTests based on current macOS version (flutter/engine#45891 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from d756a2f5665d to 559a964f9f1b (9 revisions) (flutter/engine#46059 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from e7cd697bd0e9 to b8f006d88c07 (1 revision) (flutter/engine#46055 )
2023-09-19 matanlurey@users.noreply.github.com Deprecate `fml::LOG_X` in favor of `kLogX`. (flutter/engine#46052 )
2023-09-19 matanlurey@users.noreply.github.com Rename `layoutGoals` to `kLayoutGoals` to enforce lints on headers. (flutter/engine#46054 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 21:39:52 +00:00
engine-flutter-autoroll
5b47fef613
Manual roll Flutter Engine from 589bde9a95c9 to 28f14e6eec4f (11 revisions) ( #135041 )
...
Manual roll requested by jonahwilliams@google.com
589bde9a95...28f14e6eecskia-flutter-autoroll@skia.org Roll Skia from d54cf63f051b to
d756a2f5665d (5 revisions) (flutter/engine#46048 )
2023-09-19 jacksongardner@google.com Update CI to Chrome 117
(flutter/engine#45842 )
2023-09-19 mdebbar@google.com [web] DOM objects implement JS object
(flutter/engine#46047 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 91adc7d289f7 to
d54cf63f051b (3 revisions) (flutter/engine#46043 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 1e84aa4509cd to
91adc7d289f7 (2 revisions) (flutter/engine#46040 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038 )
2023-09-19 kjlubick@users.noreply.github.com Add more missing Skia
#includes (flutter/engine#46034 )
2023-09-19 leroux_bruno@yahoo.fr [macOS,iOS] Expose channel buffers
'resize' and 'overflow' control co… (flutter/engine#44848 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 744807d740c7 to
1e84aa4509cd (4 revisions) (flutter/engine#46026 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O-
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 12:49:57 -07:00
Greg Spencer
4ce7fdd92b
Remove 'must be non-null' and 'must not be null' comments from non-framework libraries ( #134994 )
...
## Description
This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values.
This PR removes them from the library in the repo that don't have anything to do with the framework.
This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
## Related PRs
- https://github.com/flutter/flutter/pull/134984
- https://github.com/flutter/flutter/pull/134991
- https://github.com/flutter/flutter/pull/134992
- https://github.com/flutter/flutter/pull/134993
## Tests
- Documentation only change.
2023-09-19 17:26:07 +00:00
Jackson Gardner
d3c60569d1
Update CI to Chrome 117. ( #134761 )
2023-09-19 16:26:16 +00:00
Daco Harkes
f246dc7ae0
Bring native_assets ios tests out of staging ( #135015 )
...
Move test added in https://github.com/flutter/flutter/pull/130494 out of staging.
* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios
* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios_simulator
> Monitor the CI results of the new shard on the [Flutter build dashboard](https://flutter-dashboard.appspot.com/#/build ). After 50 consecutive passing builds without any flakes, the flake bot will create a PR to remove the bringup: true parameter from .ci.yaml in the Framework tree. This will allow the test to block the tree, preventing breakages. With this change, the new shard will start running in presubmit automatically, unless specify presubmit: false.
https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard#steps-to-add-a-new-framework-test-shard
Umbrella issue:
* https://github.com/flutter/flutter/issues/129757
2023-09-19 15:48:26 +00:00
engine-flutter-autoroll
8936504163
Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) ( #134998 )
...
e1c784e3f8...589bde9a95skia-flutter-autoroll@skia.org Roll Skia from 4122791099ce to 744807d740c7 (1 revision) (flutter/engine#46019 )
2023-09-19 jonahwilliams@google.com [Android] Add support for setting thread affinity based on core speed. (flutter/engine#45673 )
2023-09-19 chinmaygarde@google.com [Impeller] Fix STB backend to account for max texture sizes. (flutter/engine#46010 )
2023-09-19 matanlurey@users.noreply.github.com [Impeller] Hold the CommandPoolVK at a higher scope. (flutter/engine#46013 )
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 0c990ab9e097 to 4122791099ce (19 revisions) (flutter/engine#46016 )
2023-09-18 kjlubick@users.noreply.github.com Add missing include of SkPath (flutter/engine#45996 )
2023-09-18 chinmaygarde@google.com [Impeller] Respect max supported texture size when allocating glyph atlas texture. (flutter/engine#45992 )
2023-09-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3_Lh8otTpmVuf-Zwb... to qy5FU4y6sx1FscCpd... (flutter/engine#45998 )
2023-09-18 chris@bracken.jp Revert "[Windows] Update vsync on raster thread (#45310 )" (flutter/engine#46000 )
2023-09-18 matanlurey@users.noreply.github.com Provide a default `--target-variant` for `clang_tidy`. (flutter/engine#45909 )
2023-09-18 ychris@google.com Revert "[ios] use python script to generate extension safe frameworks and code sign them" (flutter/engine#46004 )
2023-09-18 john@johnmccutchan.com Disable HardwareBuffer backed Platform Views temporarily (flutter/engine#45986 )
2023-09-18 john@johnmccutchan.com Tighten up ImageReaderPlatformViewRenderTarget code (flutter/engine#45889 )
2023-09-18 ychris@google.com [ios] use python script to generate extension safe frameworks and code sign them (flutter/engine#45781 )
2023-09-18 bdero@google.com Bump impeller-cmake to HEAD. (flutter/engine#45953 )
2023-09-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS] Remove selectionDidChange call in UndoManager (flutter/engine#45657 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3_Lh8otTpmVu to qy5FU4y6sx1F
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-19 06:10:24 +00:00
Polina Cherkasova
ab66f55728
Reland Resolve breaking change of adding a method to ChangeNotifier. ( #134983 )
2023-09-18 20:31:54 -07:00
Zachary Anderson
a9183f696c
Revert "Resolve breaking change of adding a method to ChangeNotifier." ( #134978 )
...
Reverts flutter/flutter#134953
Several failures on CI
2023-09-18 23:04:06 +00:00
Polina Cherkasova
5c6ef59b90
Resolve breaking change of adding a method to ChangeNotifier. ( #134953 )
2023-09-18 15:33:06 -07:00
chunhtai
f2050e8a10
Fixes focus traversal crash if the current node can't request focus ( #134954 )
...
fixes https://github.com/flutter/flutter/issues/134854
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-18 15:17:52 -07:00
Vasiliy Ditsyak
43407cf155
Access to fragment in router state on page refresh ( #131123 )
...
This PR fixes the issue #108614
Particularly this behaviour https://github.com/flutter/flutter/issues/108614#issuecomment-1645231915
2023-09-18 21:12:08 +00:00
Michael Goderbauer
da0f9a997a
Enable private field promotion for framework ( #134473 )
...
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020 . Feature is enabled by bumping the min SDK version to 3.2.
Part of https://github.com/flutter/flutter/issues/134476 .
2023-09-18 20:51:09 +00:00
Kostia Sokolovskyi
2396a417e3
Cover more test/widgets tests with leak tracking #6 ( #134884 )
2023-09-18 13:46:29 -07:00
Polina Cherkasova
658710b6f9
Cover more tests with leak tracking. ( #134805 )
2023-09-18 13:45:38 -07:00
Kostia Sokolovskyi
56cbf3e1d9
Cover more test/widgets tests with leak tracking #5 ( #134869 )
2023-09-18 13:44:55 -07:00
Victoria Ashworth
abf8361ad4
Don't uninstall before retrying to connect during app launch ( #134542 )
...
When retrying to connect to the device during app launch, don't uninstall the app first.
Latest test flake for https://github.com/flutter/flutter/issues/120808 :
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8770202475999850785/+/u/run_hot_mode_dev_cycle_ios__benchmark/test_stdout
Shows that it uninstalled and then tried debugging and failed, which would make sense since the app wasn't installed anymore.
```
[2023-09-11 18:02:24.555646] [STDOUT] stdout: [ +6 ms] Lost connection to device. Trying to connect again...
[2023-09-11 18:02:24.556949] [STDOUT] stdout: [ +1 ms] executing: /opt/s/w/ir/x/w/recipe_cleanup/tmp53fs1szo/flutter sdk/bin/cache/artifacts/libimobiledevice/idevicesyslog -u 00008030-00144DA10185402E
[2023-09-11 18:02:24.557323] [STDOUT] stdout: [ ] executing: script -t 0 /dev/null /opt/s/w/ir/x/w/recipe_cleanup/tmp53fs1szo/flutter sdk/bin/cache/artifacts/ios-deploy/ios-deploy --id 00008030-00144DA10185402E --bundle build/ios/iphoneos/Flutter Gallery.app --app_deltas build/ios/app-delta --uninstall --noinstall --debug --no-wifi --args --enable-dart-profiling --disable-vm-service-publication --enable-checked-mode --verify-entry-points
[2023-09-11 18:02:24.578010] [STDOUT] stdout: [ +20 ms] [....] Waiting for iOS device to be connected
[2023-09-11 18:02:24.712631] [STDOUT] stdout: [ +134 ms] [....] Using 00008030-00144DA10185402E (N104AP, iPhone 11, iphoneos, arm64e, 16.2, 20C65) a.k.a. 'iPhone 11'.
[2023-09-11 18:02:24.712725] [STDOUT] stdout: [ ] ------ Uninstall phase ------
[2023-09-11 18:02:24.818293] [STDOUT] stdout: [ +105 ms] [ OK ] Uninstalled package with bundle id io.flutter.examples.gallery
[2023-09-11 18:02:24.906833] [STDOUT] stdout: [ +88 ms] ------ Debug phase ------
[2023-09-11 18:02:24.906924] [STDOUT] stdout: [ ] Starting debug of 00008030-00144DA10185402E (N104AP, iPhone 11, iphoneos, arm64e, 16.2, 20C65) a.k.a. 'iPhone 11' connected through USB...
[2023-09-11 18:02:25.285252] [STDOUT] stdout: [ +378 ms] [ 0%] Looking up developer disk image
[2023-09-11 18:02:25.529937] [STDOUT] stdout: [ +244 ms] [ 90%] Mounting developer disk image
[2023-09-11 18:02:25.545261] [STDOUT] stdout: [ +15 ms] [ 95%] Developer disk image already mounted
[2023-09-11 18:02:25.587923] [STDOUT] stdout: [ +42 ms] Detected path to iOS debug symbols: "Symbol Path: /Users/swarming/Library/Developer/Xcode/iOS DeviceSupport/16.2 (20C65) arm64e/Symbols"
[2023-09-11 18:02:25.857177] [STDOUT] stdout: [ +269 ms] Script started, output file is /dev/null
[2023-09-11 18:02:25.857259] [STDOUT] stdout: [ ] Script done, output file is /dev/null
[2023-09-11 18:02:25.857511] [STDOUT] stdout: [ ] ios-deploy exited with code 0
[2023-09-11 18:02:25.858066] [STDOUT] stderr: [ ] Could not run build/ios/iphoneos/Flutter Gallery.app on 00008030-00144DA10185402E.
[2023-09-11 18:02:25.858130] [STDOUT] stderr: [ ] Try launching Xcode and selecting "Product > Run" to fix the problem:
[2023-09-11 18:02:25.858214] [STDOUT] stderr: [ ] open ios/Runner.xcworkspace
[2023-09-11 18:02:25.858537] [STDOUT] stdout: [ ] Installing and launching... (completed in 52.4s)
[2023-09-11 18:02:25.858956] [STDOUT] stderr: [ ] Error launching application on iPhone 11.
```
2023-09-18 19:55:06 +00:00
Xilai Zhang
6425a3b431
[flutter roll] Revert "LinkedText (Linkify)" ( #134955 )
...
Reverts flutter/flutter#125927
context: b/300804374
Looks like a g3 fix might involve changing the names of widget on the customer app, and I am not sure if that would be the right approach forward. Putting up a revert to be safe for now.
2023-09-18 19:49:10 +00:00
Kostia Sokolovskyi
9dd3e1e6fc
Fix memory leak in _DarwinViewState. ( #134938 )
2023-09-18 11:39:01 -07:00
engine-flutter-autoroll
bac5e5d518
Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) ( #134956 )
...
be7a039c54...e1c784e3f8skia-flutter-autoroll@skia.org Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) (flutter/engine#45979 )
2023-09-18 mdebbar@google.com [web] ScreenOrientation singleton (flutter/engine#45304 )
2023-09-18 mdebbar@google.com [web] De-singletonize MouseCursor for multi-view (flutter/engine#45295 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 18:13:13 +00:00
huycozy
b195c944cc
Migrate the "Missing frames / speed related performance issues" issue template to use Github forms ( #134033 )
...
Closes #119921
### Demo
- Demo issue template: [Issue: My app is slow or missing frames](https://github.com/huycozy/flutter/issues/new?assignees=&labels=from%3A+performance+template&projects=&template=5_performance_speed.yml )
- Demo a filed issue: https://github.com/huycozy/flutter/issues/5
2023-09-18 16:40:07 +00:00
engine-flutter-autoroll
b7d0e8c9ed
Roll Packages from bc8c2f20910b to d4e245421737 (6 revisions) ( #134945 )
...
bc8c2f2091...d4e2454217me@nils.re [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924 )
2023-09-17 engine-flutter-autoroll@skia.org Roll Flutter from e5e36ad3401b18b1327aflutter/packages#4940 )
2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter from 72b69f9449e5e36ad340flutter/packages#4938 )
2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891 )
2023-09-15 engine-flutter-autoroll@skia.org Roll Flutter from 58ba6c295d72b69f9449flutter/packages#4934 )
2023-09-15 stuartmorgan@google.com [image_picker] Add missing entitlements to macOS example (flutter/packages#4931 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 16:22:46 +00:00
engine-flutter-autoroll
06e346a8a0
Roll Flutter Engine from 4107ee0dc8b1 to be7a039c5451 (1 revision) ( #134937 )
...
4107ee0dc8...be7a039c54skia-flutter-autoroll@skia.org Roll Dart SDK from 5c56e0f3fe13 to 5b0e7bda1379 (1 revision) (flutter/engine#45974 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 14:47:21 +00:00
Daco Harkes
2337c64d0c
Native assets support for Linux ( #134031 )
...
Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
For more info see:
* https://github.com/flutter/flutter/issues/129757
### Implementation details for Linux.
Mainly follows the design of https://github.com/flutter/flutter/pull/130494 .
Some differences are:
* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.
The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
### Tests
This PR adds new tests to cover the various use cases.
* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
* Unit tests the Linux-specific part of building native assets.
It also extends various existing tests:
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
2023-09-18 11:13:37 +00:00
engine-flutter-autoroll
d6d90b0f52
Roll Flutter Engine from 77965cabbaf9 to 4107ee0dc8b1 (1 revision) ( #134927 )
...
77965cabba...4107ee0dc8skia-flutter-autoroll@skia.org Roll Dart SDK from 5eef4301567f to 5c56e0f3fe13 (1 revision) (flutter/engine#45966 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 10:55:33 +00:00
