Commit graph

10662 commits

Author SHA1 Message Date
Chris Bracken f570e046c9
Inline buildScriptSnapshot calls (#16940) 2018-04-24 16:07:14 -07:00
Chris Bracken 993f3947da
Generalise FakeGenSnapshot output generation (#16938)
Pre-factoring for addition of AOT snapshotting unit tests, which emit a
different set of expected outputs.
2018-04-24 15:51:10 -07:00
Chris Bracken 7ffcd3d22d
Extract KernelCompiler class (#16937)
Wraps the compile function in a class injected via the global context,
which makes it easier to mock in unit tests -- specifically tests for
AOT snapshotting, which already require pretty significant amounts of
mock inputs.
2018-04-24 14:03:41 -07:00
Alexander Aprelev a21c93dd70
Fix boolean flag parsing in gradle. Track 'trackWidgetCreation' as property of the build. (#16901) 2018-04-24 09:51:25 -07:00
Zachary Anderson c7ee37a0d8
[fuchsia] Pass a dummy command to the ssh tunnel setup (#16906)
* [fuchsia] Pass a dummy command to the ssh tunnel setup

* Address analyzer lint

* Update fuchsia_remote_debug_protocol
2018-04-23 21:26:51 -07:00
Yegor c816cee20e
Roll engine to ec61147 (#16908)
Changes include:

flutter/engine@ec61147 replace nextNodeId/previousNodeId with hitTestPosition
flutter/engine@2970c09 Use the default microtask scheduler on all isolates except the UI isolate
flutter/engine@96af3b2 ios: remove geometric order; it will be supplied by framework
flutter/engine@3b84a47 Apply unaddressed comments in pull/5062
flutter/engine@29816a6 Roll src/third_party/skia/ 3d0e8507f..5209d7fce (14 commits)
flutter/engine@4691a0b Import intrusively ref counted shared pointers into FML.
2018-04-23 17:40:32 -07:00
Hans Muller cdb82fce92
Put the backdrop demo controls on the right (#16902) 2018-04-23 17:19:39 -07:00
Alexander Aprelev b1330eff5f
Fail test execution if compiler reported errors. (#16895)
Fixes https://github.com/flutter/flutter/issues/16496
2018-04-23 17:08:11 -07:00
Chris Bracken de8a53c55b
Rename buildSnapshot to buildScriptSnapshot (#16905)
Renames buildSnapshot to build buildScriptSnapshot in preparation for
AOT snapshot tests.
2018-04-23 16:51:34 -07:00
xster cf8f800e59
Update gallery icons with new logo (#16900) 2018-04-23 16:00:16 -07:00
Hans Muller fee0374f9e
Added Vietnamese translations (#16896) 2018-04-23 15:54:17 -07:00
Yegor d354096299
a11y traversal: sort locally; use new sorting algorithm (#16253)
New a11y traversal:

- sort direct sibling SemanticsNodes only
- use new sorting algorithm
- implement RTL
- test semantics in traversal order by default
- add AppBar traversal test
- breaking: remove nextNodeId/previousNodeId from the framework
- breaking: remove DebugSemanticsDumpOrder.geometricOrder
2018-04-23 14:23:49 -07:00
Hans Muller d3d4976f63
InputDecorator input and hint widgets have the same width (#16894) 2018-04-23 13:53:15 -07:00
血心 286cd35951 Fix bug for calling isEmpty on null object. (#16782) 2018-04-23 13:53:00 -07:00
debuggerx01 ff58db4ac3 Fix hue to 0.0 when red == green == blue. (#16872)
When passing a Color object with same R/G/B code ( e.g. [new Color.fromRGBO(100, 100, 100, 1.0)] ) to HSVColor.fromColor(Color color) , the hue in return will be NaN .
2018-04-23 13:47:47 -07:00
Emmanuel Garcia d43b4d0ad8 Fix #16247: SizeTransition clamps negative size factors (#16579)
As pointed out in the bug, the issue is fixed by just clamping sizeFactor.value.

Fixes #16247
2018-04-23 13:47:07 -07:00
Greg Spencer a043ac41f6
Adding an API for capturing an image of a RenderRepaintBoundary. (#16758)
This adds a toImage function to RenderRepaintBoundary that returns an uncompressed raw image of the RenderRepaintBoundary and its children. A device pixel ratio different from the physical ratio may be specified for the captured image. A value of 1.0 will give an image in logical pixels.
2018-04-23 12:28:17 -07:00
Greg Spencer 037df5f2ff
Remove unneeded assert in UnconstrainedBox (#16778)
This addresses #16593 by removing the unneeded assert in the setter for constrainedAxis. Null was meant to be allowed there.

This replaces #16599 and fixes #16593, reported by @maksimr
2018-04-23 12:27:33 -07:00
Chris Bracken b5af0a9114
Use GenSnapshot class for AOT snapshotting (#16891)
This replaces the existing manual invocation with the GenSnapshot class,
which allows for better configuration and testability.
2018-04-23 11:21:19 -07:00
PJ Essien fd7222eea8 Fix error with 'flutter packages get' in package projects (#16861)
Package projects were erroneously being treated as apps
2018-04-22 18:03:46 -07:00
Todd Volkert fb18ac650e
Notify test timeouts differently than test completions. (#16842)
This avoids notifying the coverage collector that we
completed the test when in fact we timed out, which in
turn avoids a downstream exception caused by the fact
that coverage collector assumes it has a valid observatory
port by which it can gather coverage data.

Fixes https://github.com/flutter/flutter/issues/16839
2018-04-21 19:52:46 -07:00
Todd Volkert a742b11a50
Roll engine to cb3376c5dedb71cec7a88b8a8904acc5dd6c6ba1 (#16841)
This contains the following commit:

flutter/engine@cb3376c Support different encodings in Image.toByteData() (#16635)
2018-04-21 16:10:39 -07:00
Devon Carew f544f4d1c7
have flutter flormat use the sdkBinaryName method (#16752) 2018-04-21 08:29:07 -07:00
xster 8e7139a049
Make the gallery about dialog open the website in Safari (#16830) 2018-04-20 19:03:03 -07:00
Devon Carew 36cf1158ec
add the full path to a flutter command (#16720)
* add the full path to a flutter command

* remove an unused import

* review comments
2018-04-20 17:39:32 -07:00
xster 90ca815242
Make bottom app bar safe area friendly (#16820) 2018-04-20 17:14:03 -07:00
Michael Goderbauer 2eb290e718
Wire up SemanticsFlag.isHidden (#16772) 2018-04-20 17:10:40 -07:00
Michael Goderbauer 4f31a3f518
Revert "Enable sync-async" (#16825) 2018-04-20 16:33:07 -07:00
Yegor ee735c4f25
Be specific about which exceptions are retried (#16818) 2018-04-20 14:45:50 -07:00
Yegor a90a850462
bump benchmark timeouts (#16817) 2018-04-20 13:57:06 -07:00
Mikkel Nygaard Ravn 776cf24764
Make flutter_driver work with sync-async (#16798) 2018-04-20 19:31:43 +02:00
Mikkel Nygaard Ravn 315993efb3
Enable sync-async (#16790) 2018-04-20 14:49:33 +02:00
Todd Volkert 44b7e7d3f4
Fix capitalization in README.md (#16788) 2018-04-20 01:02:44 -07:00
Todd Volkert 12bbaba9ae
Do exponential backoff for all exceptions in VMService::defaultOpenChannel. (#16785)
We were trying to only catch WebSocketException, but in fact
SocketException can be thrown as well.
2018-04-19 23:36:15 -07:00
Chinmay Garde 060a1adec1 Roll engine to 09d05a3891. (#16780)
This engine roll contains the following commits:

* flutter/engine@09d05a389: Prepare and run child isolates on a VM managed (i.e. no UI) task runner.
* flutter/engine@adee35142: Throw an error or return null if FlutterView.getBitmap fails
2018-04-19 20:33:40 -07:00
Devon Carew 6a82b1044a
use the --dart-sdk parameter to flutter analyze if passed in (#16751) 2018-04-19 18:44:46 -07:00
Yegor 85473d0941 retry VMService connection; expect missing PRODUCT_BUNDLE_IDENTIFIER (#16770)
Fixes #13655
2018-04-19 18:29:49 -07:00
Jonah Williams e7cd5d3867
Throw FlutterError when calling setState in State constructor (#16759)
* log error when calling setState in constructor
2018-04-19 18:00:38 -07:00
Jonah Williams 034a663d33
Semantics object support for edge triggered semantics (#16081)
Semantics object support for edge triggered semantics
2018-04-19 17:59:19 -07:00
xster d05bc9c0e3
Remove UI with the word 'demo' from the gallery (#16767) 2018-04-19 16:53:21 -07:00
Greg Spencer b83eb465fd
Updating the Chip demo in the Gallery to include all the new types of chips. (#16522)
This chip demo is more interactive than the last one, trying to exercise all of the types of chips for a demo that lets you select different types of "chips" (like tortilla, wood, micro, etc.), and then filter them and select an action on them.
2018-04-19 16:43:22 -07:00
xster cdf80b642b
Don't show the 'preview' banner on published gallery (#16727) 2018-04-19 16:18:05 -07:00
xster 133c98a85b
Fine-tune iOS's scroll start feel (#16721)
* Fine-tune iOS's scroll start feel

* remove negations in doc

* Our own dart-side gesture arena also contributes to the 'jerk'. Make sure that snap is accounted as well.

* Added more code comments from review.
2018-04-19 16:17:44 -07:00
Michael Goderbauer 1ba99b94f2
SliverList works with changing children that are keyed (#16724)
Fixes #14590.
2018-04-19 16:05:41 -07:00
Chris Bracken cf5778810b
Move script snapshot argumtents to Snapshotter (#16722)
This moves --vm_snapshot_data and --isolate_snapshot_data argument
hardcoding from GenSnapshot (a minimal wrapper around gen_snapshot
invocations) to Snapshotter.buildScriptSnapshot(). These arguments are
present in both AOT and script snapshots, but differ semantically: for
script snapshots they're inputs from the host engine artifacts
directory, for AOT snapshots they're outputs to the build directory.
2018-04-19 16:03:07 -07:00
Greg Spencer 0b389fc92e
Change CircleAvatar to use BoxFit.cover for images (#16649)
This is a PR giving some love to the abandoned PR #16263 by @harrisonturton

I've added a test, and formatted it to be readable.

Currently the CircleAvatar does not set a fit property on the DecorationImage it uses to paint images. This causes non-square images to not fully cover the circle, which looks pretty bad. This PR sets it to BoxFix.cover.

Fixes #13478.
2018-04-19 15:52:40 -07:00
Todd Volkert 9da0ec2736
Add a few timeouts to FlutterDriver.connect() (#16762)
We're seeing occasional test timeouts trying to call `FlutterDriver.connect()`.
Unfortunately, when the test is timed out at the test runner level, you don't
get a meaningful test failure or stack trace of where the timeout occurrred.
Your test harness also doesn't get to clean up, which can include things like
saving the device logs to see what was going on in the device.

Thus, this change adds timeouts in the places where we've most
commonly observed hangs during tests.
2018-04-19 15:09:07 -07:00
Chinmay Garde 07e5056b4e Roll Flutter Engine to 637e921. (#16761)
This roll includes the following commits.

* flutter/engine@637e921d6: Use the raster cache when rendering screenshots as bitmaps (#5050)
* flutter/engine@a23fa923c: Look for an assets path specification in the Info.plist. (#5049)
2018-04-19 14:59:05 -07:00
Devon Carew c058c6a6d7
revert an older workaround for a pub/vm failure (#16749) 2018-04-19 13:11:42 -07:00
Chinmay Garde 48ab8648bf
On simulators, don't pass file paths to the engine that done exist. (#16756) 2018-04-19 12:42:56 -07:00