Commit graph

802 commits

Author SHA1 Message Date
Loïc Sharma f2931dbd8c
Remove the 'Windows_arm64 plugin_test' Devicelab test (#136379)
This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.
2023-10-11 18:31:04 +00:00
Christopher Fujino 5a4497d47f
extend timeout from default 30 min to 1 hour for windows build tests (#136300)
Fixes https://github.com/flutter/flutter/issues/136299
2023-10-11 18:10:52 +00:00
Loïc Sharma c6aeab930a
[Windows] Add Arm64 benchmarks (#135514)
Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* ✅ [hot_mode_dev_cycle_win_target__benchmark](2079b030ac/+/build.proto?server=chromium-swarm.appspot.com)
* ✅ [windows_home_scroll_perf__timeline_summary](56a3b258e4/+/build.proto?server=chromium-swarm.appspot.com)
* ✅ [flutter_tool_startup](fa6a1056fc/+/build.proto?server=chromium-swarm.appspot.com)

/cc @pbo-linaro
2023-10-11 16:36:20 +00:00
Jonah Williams a106b81cc5
[framework] restore old zoom page transition for benchmarking. (#133346)
In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI.

https://github.com/flutter/flutter/issues/129742
https://github.com/flutter/flutter/issues/121325
2023-10-10 22:27:07 +00:00
Loïc Sharma 39b9d8fd6d
[Windows] Add first Arm64 plugin tests (#135512)
Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* ✅ [plugin_test_windows](277ffb2c7b/+/build.proto?server=chromium-swarm.appspot.com)
* ⚠️ [plugin_test](c9daccd5b3/+/build.proto?server=chromium-swarm.appspot.com) - This test fails as no existing Windows Arm64 builder install the `android_sdk` and `open_jdk` dependencies

I will add `plugin_dependencies_test` and `gradle_plugin_bundle_test` in a follow-up pull request. These tests also depend on `android_sdk` and `open_jdk`, I'll be able to test them manually using the new `plugin_test` builder added by this pull request. 

/cc @pbo-linaro
2023-10-06 22:28:08 +00:00
Zachary Anderson 68d47e55d4
Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (#136097)
Reverts flutter/flutter#135566
2023-10-06 15:10:49 -07:00
Flutter GitHub Bot 420ec92e72
Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (#135566)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22).
This test can be marked as unflaky.
2023-10-06 20:27:15 +00:00
Flutter GitHub Bot 8796955e98
Marks Windows module_custom_host_app_name_test to be unflaky (#135961)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.
2023-10-06 11:19:14 -07:00
Flutter GitHub Bot c6d884ea7e
Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be unflaky (#135960)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary"
}
-->
The issue https://github.com/flutter/flutter/issues/135118 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary%22).
This test can be marked as unflaky.
2023-10-04 22:46:40 +00:00
Ricardo Amador d7739dff68
Temporarily disable NexusLowRes, version=29 (#135785)
There are too many flakes to leave this version enabled. Temporarily disabled and following up with FTL.

*List which issues are fixed by this PR. You must list at least one issue.*
Related to https://github.com/flutter/flutter/issues/135784

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-30 01:57:05 +00:00
keyonghan 951653a1c0
Add arch property for windows_arm64 platform (#135725)
Window arm64 bots are using x64 built python, which gave incorrect arch info. This PR adds the arch info explicitly so that recipes can get this value and populate to benchmark tags.

Part of https://github.com/flutter/flutter/issues/135722
2023-09-29 00:57:06 +00:00
Flutter GitHub Bot 55c7a2efc4
Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (#135565)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
The issue https://github.com/flutter/flutter/issues/134631 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20flutter_gallery__start_up_delayed%22).
This test can be marked as unflaky.
2023-09-28 22:44:52 +00:00
auto-submit[bot] f76c150cc8
Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (#135692)
Reverts flutter/flutter#135567
Initiated by: ricardoamador
This change reverts the following previous change:
Original Description:
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.
2023-09-28 18:36:26 +00:00
Flutter GitHub Bot c35515a079
Marks Windows module_custom_host_app_name_test to be unflaky (#135567)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.
2023-09-28 17:38:51 +00:00
godofredoc d3c45f1499
Config changes for linux coverage. (#135604)
This build runs for over and hour and it does not need to run on presubmit or release candidate branches.
2023-09-27 16:42:54 +00:00
Flutter GitHub Bot 9fedb1a6ce
Marks Linux_pixel_7pro hello_world_impeller to be unflaky (#135564)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro hello_world_impeller"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22).
This test can be marked as unflaky.
2023-09-27 08:35:32 -07:00
Loïc Sharma 7143284102
[Windows] Add more Arm64 compile and run tests (#135475)
Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* Compile tests
    * ✅ [flutter_gallery_win_desktop__compile](a23b73ca25/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR2Yv8iS9YbTxMZKS2i5zmAz9E8FCNjW6waLq4e8HwtaFtMlapl66UHf73w)
* Start up tests
    * ✅ [windows_startup_test](e615b28993/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR1YtPTpAr6FRq71fy392orp6PO8t9jN8n-mpWvlDF0xRnnOsq3zsAPabWg)
    * ✅ [flutter_gallery_win_desktop__start_up](a0148122f8/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR29O3jW-LyaVAwD54jUmnhfZ2mswqtaZascRoGvteT5gaHihxKI4IastgM)
    * ✅ [flutter_view_win_desktop__start_up](6dac552365/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR2_irHDuoZ0V-PSjYDW082yx8ZeDVhOIk0yjQBAZNVa5iKVIGAWZs8v4lo)
    * ✅ [platform_view_win_desktop__start_up](e6522c77bc/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR2X7KJDGjQUWJtpq7KY-nUFK-LA6LvmrAinzj0QuF8pEbpwfsAz6Kv3OkM)
    * ✅ [complex_layout_win_desktop__start_up](a811334185/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR0gIiXFMnB_MSaqUxVyTpgpJqc37xSKqOzEsf2oD_oU-AhKPqrGQ-ZD7IY)
* `flutter run` console output tests
    * ✅ [run_debug_test_windows](1b275a8b16/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR1IlBr0824cq9UKi46j_11eto6HTEQ9KVXF5Is1ZxcSIO7G6IlN-slsyI8)
    * ✅ [run_release_test_windows](5b259bb5e2/+/build.proto?server=chromium-swarm.appspot.com&fbclid=IwAR3DSHzCGL-KN26E-7hQL58qxV2p0Dtb9hE4AZ0HvEY4hp8mCMzX9jznsFQ)

/cc @pbo-linaro
2023-09-26 19:27:00 +00:00
Zachary Anderson 16ae8c0109
Revert "Marks Linux_pixel_7pro hello_world_impeller to be unflaky" (#135388)
Reverts flutter/flutter#135372
2023-09-25 14:13:30 +00:00
godofredoc 07ce6a76a0
Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (#135399)
Reverts flutter/flutter#135373
2023-09-25 04:29:39 +00:00
Flutter GitHub Bot 2f56288a4e
Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (#135373)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22).
This test can be marked as unflaky.
2023-09-25 01:49:07 +00:00
Flutter GitHub Bot 797d34e5af
Marks Linux_pixel_7pro hello_world_impeller to be unflaky (#135372)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro hello_world_impeller"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22).
This test can be marked as unflaky.
2023-09-24 16:40:10 +00:00
Flutter GitHub Bot a6e98d3006
Marks Windows_android channels_integration_test_win to be unflaky (#135374)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/134636 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22).
This test can be marked as unflaky.
2023-09-24 16:40:07 +00:00
Flutter GitHub Bot 8bc223e3e5
Marks Mac_ios draw_atlas_perf_ios__timeline_summary to be unflaky (#134626)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios draw_atlas_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_atlas_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 05:14:20 +00:00
Flutter GitHub Bot 2c1f517d10
Marks Mac_ios draw_vertices_perf_ios__timeline_summary to be unflaky (#134625)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios draw_vertices_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_vertices_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 05:06:26 +00:00
Flutter GitHub Bot 417aaf5b2b
Marks Windows module_test to be unflaky (#134121)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_test"
}
-->
The issue https://github.com/flutter/flutter/issues/133639 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_test%22).
This test can be marked as unflaky.
2023-09-24 04:12:53 +00:00
Flutter GitHub Bot c0bde99e0f
Marks Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary to be unflaky (#133128)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20dynamic_path_tessellation_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 04:11:19 +00:00
Flutter GitHub Bot 6240c899b9
Marks Mac_ios draw_points_perf_ios__timeline_summary to be unflaky (#127933)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios draw_points_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_points_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 04:07:20 +00:00
Flutter GitHub Bot 260c16cfb8
Marks Linux_pixel_7pro picture_cache_perf__timeline_summary to be unflaky (#134118)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro picture_cache_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20picture_cache_perf__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 04:04:54 +00:00
Flutter GitHub Bot 82a972bf1a
Marks Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary to be unflaky (#134629)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20very_long_picture_scrolling_perf_ios__e2e_summary%22).
This test can be marked as unflaky.
2023-09-24 03:52:33 +00:00
Flutter GitHub Bot 389d482aac
Marks Mac_ios animated_advanced_blend_perf_ios__timeline_summary to be unflaky (#132630)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios animated_advanced_blend_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 02:49:37 +00:00
Flutter GitHub Bot 3ba8472a15
Marks Mac_ios static_path_tessellation_perf_ios__timeline_summary to be unflaky (#133127)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios static_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20static_path_tessellation_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2023-09-24 02:49:35 +00:00
Flutter GitHub Bot 4f5c815559
Marks Linux_android platform_channels_benchmarks to be flaky (#135106)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android platform_channels_benchmarks"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135105
2023-09-23 23:07:08 +00:00
Flutter GitHub Bot 6d4a5e3d31
Marks Linux_android flutter_gallery__start_up_delayed to be flaky (#134632)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134631
2023-09-23 23:07:06 +00:00
Flutter GitHub Bot 6d88ade70a
Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be flaky (#135119)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135118
2023-09-23 23:03:13 +00:00
Zachary Anderson 70fd335041
Move some tests from staging to prod (#135333)
This PR moves tests running on Pixel 7 Pro that use Skia from staging to prod.
2023-09-23 00:32:16 +00:00
Ricardo Amador 76a938bfa6
Reenable 'Linux packages_autoroller' in prod with kms key update (#135316)
The Github token was recreated and uploaded to GCS. I have verified a passing run with the new key here: 
bc5d1e6662/+/build.proto

And the bot is now generating pull requests: https://github.com/flutter/flutter/pull/135315

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131968

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-22 18:23:14 +00:00
Daco Harkes 2def951924
Reland "Native assets support for Linux" (#135097)
Reland of #134031. (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.

Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for Linux.

Mainly follows the design of https://github.com/flutter/flutter/pull/130494.

Some differences are:

* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.

The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.

### Tests

This PR adds new tests to cover the various use cases.

* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
  * Unit tests the Linux-specific part of building native assets.

It also extends various existing tests:

* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
2023-09-22 06:07:06 +00:00
Gray Mackall b433b17539
Upgrade AGP version in tracing_tests (#134671)
Related to https://github.com/flutter/flutter/issues/134419
2023-09-20 20:56:25 +00:00
Xilai Zhang 52ef9d8827
[flutter roll] Revert "Native assets support for Linux" (#135069)
Reverts flutter/flutter#134031

context: b/301051367
Looked at the error message from the broken TAP target, but seems like the failure might be non trivial to resolve. Would it be okay if we revert this for now while it is being triaged?
2023-09-20 00:06:45 +00:00
Zachary Anderson 5c6b031c10
Retry Linux web tests 1 time on roll presubmit (#135073)
Reland of https://github.com/flutter/flutter/pull/134552
2023-09-19 23:17:25 +00:00
Jackson Gardner d3c60569d1
Update CI to Chrome 117. (#134761) 2023-09-19 16:26:16 +00:00
Daco Harkes f246dc7ae0
Bring native_assets ios tests out of staging (#135015)
Move test added in https://github.com/flutter/flutter/pull/130494 out of staging.

* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios
* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios_simulator

> Monitor the CI results of the new shard on the [Flutter build dashboard](https://flutter-dashboard.appspot.com/#/build). After 50 consecutive passing builds without any flakes, the flake bot will create a PR to remove the bringup: true parameter from .ci.yaml in the Framework tree. This will allow the test to block the tree, preventing breakages. With this change, the new shard will start running in presubmit automatically, unless specify presubmit: false.

https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard#steps-to-add-a-new-framework-test-shard

Umbrella issue:

* https://github.com/flutter/flutter/issues/129757
2023-09-19 15:48:26 +00:00
Daco Harkes 2337c64d0c
Native assets support for Linux (#134031)
Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for Linux.

Mainly follows the design of https://github.com/flutter/flutter/pull/130494.

Some differences are:

* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.

The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.

### Tests

This PR adds new tests to cover the various use cases.

* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
  * Unit tests the Linux-specific part of building native assets.

It also extends various existing tests:

* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
2023-09-18 11:13:37 +00:00
gaaclarke 43260cced9
moved hello_world_impeller to a 7pro (#134830)
arm64 is necessary for this test

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-15 12:28:16 -07:00
Zachary Anderson 1e4a1be681
Move two tests on Pixel 7 from staging to prod (#134784)
Related https://github.com/flutter/flutter/issues/134698
2023-09-14 19:10:37 -07:00
Victoria Ashworth eb4b97d63c
Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (#134693)
Test added in https://github.com/flutter/flutter/pull/134493 requires an
older version of Xcode because default version of Xcode is not
compatible with macOS version in CI.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-14 13:56:00 -05:00
gaaclarke 57ad4ff018
Added a devicelab test for vulkan validation layers (#134685)
This makes sure validation layers are being used and that there are no
validation errors

fixes https://github.com/flutter/flutter/issues/134175

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-14 09:13:35 -07:00
Victoria Ashworth af5ac930d8
Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device (#134493)
Xcode uses the CONFIGURATION_BUILD_DIR build setting to determine the location of the bundle to build and install. When launching an app via Xcode with the Xcode debug workflow (for iOS 17 physical devices), temporarily set the CONFIGURATION_BUILD_DIR to the location of the bundle so Xcode can find it.

Also, added a Xcode Debug version of the `microbenchmarks_ios` integration test since it uses `flutter run --profile` without using `--use-application-binary`.

Fixes https://github.com/flutter/flutter/issues/134186.
2023-09-13 18:08:35 +00:00
Flutter GitHub Bot f38dcb1229
Marks Windows module_custom_host_app_name_test to be flaky (#134645)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134644
2023-09-13 09:36:18 -07:00
Flutter GitHub Bot 639c092b5d
Marks Windows_android channels_integration_test_win to be flaky (#134637)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134636
2023-09-13 09:35:22 -07:00