Commit graph

13569 commits

Author SHA1 Message Date
Jonah Williams 2a1c078b76
[flutter_tools] add null safety argument to unbreak frob (#60102) 2020-06-23 11:20:49 -07:00
chunhtai 4953cbce23
Fix the layout calculation in sliver list where the scroll offset cor… (#59888) 2020-06-23 11:18:01 -07:00
Jonah Williams e34c591252
[flutter_tools] fix root directory tests (#60060)
* fix test compiler test
* fix project test
* fix flutter_platform_test
* fix cocoapods test
2020-06-23 11:14:38 -07:00
MH Johnson 1c1326ad81
add check for DefaultTextHeightBehavior in EditableText + tests (#59913) 2020-06-23 12:39:35 -04:00
Dan Field e8fa87e303
Make upscaling images opt-in (#59856)
* Make upscaling images opt-in
2020-06-23 09:20:28 -07:00
Tonic Artos 65550d0f0c
New license page. (#57588)
This is a PR addressing #57226 - Proposal: New UI for Licenses Page.

This PR replaces the previous single panel license page with one that uses a master/detail flow (MDFlow) to display packages and their respective licenses.

The License Page API remains unchanged. The logic for processing the license data is kept largely the same. This PR changes how the licenses are displayed, by introducing a responsive UI using the master/detail UI pattern. For now I am calling it Master Detail Flow, or MDFlow.

MDFlow manifests as two layouts depending on the screen size. On small and medium displays, as determined by the breakpoints given by the Material Design Spec, MDFlow utilises a nested layout. On large displays, MDFlow uses a two panel (lateral) layout. MDFlow is implemented in this PR using a Navigator for the nested layout, and a Stack for the lateral layout. The master and detail views are built using builders. For the interactive component, detail pages are requested from the master view using a proxy obtained by a widget lookup on the build context; MasterDetailFlow.of(context).
2020-06-23 09:19:45 -07:00
renyou 15a28159bc
Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686)" (#59992)
This reverts commit fe15d1e793.
2020-06-23 04:52:58 -07:00
Robert Ancell 8c3b826ebd
Support GTK keycodes (#59961) 2020-06-23 15:19:57 +12:00
Robert Ancell 65ea2be51b
Remove Linux shell window_configuration.cc (#59802)
Remove Linux shell window_configuration.cc/.h

It was a temporary solution while the shell was changing.
2020-06-23 15:18:30 +12:00
stuartmorgan b5ddf85595
Fix typo in Linux CMake template (#60017) 2020-06-22 19:08:02 -07:00
Justin McCandless c105708426
RTL caret position (#60009) 2020-06-22 18:58:03 -07:00
zichangg fc64e75a32
Update tooltip_theme_test to unblock Dart SDK roll (#59937) 2020-06-22 18:53:03 -07:00
Jenn Magder d82ef3517c
Use assemble build system directly for build ios-framework (#60041) 2020-06-22 18:44:27 -07:00
Jenn Magder 6a2bc2617e
Replace ANDROID_HOME user messages with ANDROID_SDK_ROOT (#59867) 2020-06-22 18:43:04 -07:00
Tong Mu 9470b9e2ce
Add material state mouse cursor to TextField (#59363) 2020-06-22 18:38:03 -07:00
Jonah Williams 3406870d24
Fix newly added test to opt out of NNBD (#60042) 2020-06-22 17:40:48 -07:00
Jenn Magder 2c538be421
Parse build ios framework build mode from params (#59874) 2020-06-22 17:13:03 -07:00
Darren Austin cc36608f14
Keyboard navigation for the Material Date Picker grid (#59586) 2020-06-22 17:08:03 -07:00
Jia Hao dd6dd7aef1
Fix tracing of startup events (#59982)
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing.

This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time.

Related: #58430
2020-06-23 08:07:05 +08:00
Jonah Williams 55abbb6be6
[flutter_tools] track null safety usage (#59822)
* [flutter_tools] track null safety usage

* Update flutter_command_test.dart

* cleanups
2020-06-22 17:05:01 -07:00
Jonah Williams 09f1764d14
[flutter_tools] android test cleanups (#59996)
Fixes several tests that were failing under tester. Minor style cleanups otherwise
2020-06-22 17:04:39 -07:00
Jonah Williams a734693ff5
[flutter_tools] cleanup iOS test (#59999)
The test needs to look up HOME, but one wasn't provided. This would end up using the real home directory, crashing on windows
2020-06-22 17:04:17 -07:00
Jonah Williams 8e9b78728f
[flutter_tools] switch linux desktop feature on (#60018)
Enable linux desktop feature on dev channel
2020-06-22 17:04:01 -07:00
rami-a e676024d37
[Material] Redesign Time Picker (#59191) 2020-06-22 17:03:04 -07:00
Jonah Williams 2cd205bb5a
[flutter_tools] cleanup fuchsia tests (#59997)
Cleanup fuchsia tests that failed under tester.
2020-06-22 16:47:28 -07:00
renyou eaf9ff738a
Revert "Implement Comparable<TimeOfDay> (#59317)" (#59981)
This reverts commit 2933e895e5.
2020-06-22 11:53:54 -07:00
renyou a88e2c8742
Revert "fix the widget span layout when text scale factor != 1 (#59711)" (#59986)
This reverts commit 747fe345f1.
2020-06-22 11:53:14 -07:00
Jonah Williams 04ce9d288c
Revert "Fix outline button solid path when BorderSize.width is used (#51581)" (#60000)
This reverts commit 5995661777.
2020-06-22 10:13:37 -07:00
Ferhat 5995661777
Fix outline button solid path when BorderSize.width is used (#51581) 2020-06-19 16:15:58 -07:00
Sam Rawlins 252a3261c4
Remove unused import which shares prefix name with a used import. (#59160)
Due to a bug in analyzer [1], some unused imports are not reported when
multiple import directives share a prefix name, and one or more are unused.

[1] https://github.com/dart-lang/sdk/issues/38784
2020-06-19 15:25:13 -07:00
Anna Gringauze aac836c6ad
Enabled expression evaluation by default (#59826) 2020-06-19 15:23:03 -07:00
Jonah Williams fbdc79e448
[versions] update all versions (#59832)
Fixes #59718

Update all versions, specifically dwds which has a hot restart fix
2020-06-19 14:48:57 -07:00
Helin Shiah f7a09bd2df
Add integration tests for structured error (#59809) 2020-06-19 13:58:03 -07:00
Justin McCandless b9af6551b2
Label unnecessarily ellided (#59807) 2020-06-19 13:53:05 -07:00
Tong Mu 65b1956005
Add benchmark for Mouse region (web) (#59803) 2020-06-19 13:48:04 -07:00
Michael Goderbauer e48b7e99cd
More word substiturions (#59497) 2020-06-19 13:43:02 -07:00
Jason Simmons 4173881bbf
Fix the paste button label in the new version of the filtered text pasting test (#59865) 2020-06-19 12:41:29 -07:00
Andrew Chen 2933e895e5
Implement Comparable<TimeOfDay> (#59317) 2020-06-19 12:18:03 -07:00
Christopher Fujino 5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino 0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801.
2020-06-19 10:52:52 -07:00
Ian Hickson 8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Jonah Williams dec7423b44
Revert "Add the ability to ignore lines depending on comments (#58656)" (#59813)
This reverts commit df02518dc9.
2020-06-18 17:15:50 -07:00
Robert Ancell e6de0de8f7
Fix Linux shell window default size (#59630)
The previous call set the minimum size, not just the initial size.
2020-06-19 11:56:01 +12:00
Jenn Magder f41f795640
Clean up PollingDeviceDiscovery dispose (#59709) 2020-06-18 16:38:02 -07:00
Justin McCandless 339f0363a6
Reland modernize selection menu appearance (#59617) 2020-06-18 16:33:03 -07:00
Robert Ancell dd9fd2c851
Use a HeaderBar for Linux applications. (#59714) 2020-06-19 11:30:36 +12:00
Chris Bracken e0f60918d4
Roll the engine from 965fbbe to b5f5e63 (#59804)
This rolls the engine from:
965fbbed1776545ee681cb57f3fb1d0c2000bbcb to
b5f5e6332cb4987e9e38ffaa267733ec0a8705ba. A Dart SDK roll in this range
changed the format of the compileExpression RPC VMService endpoint,
necessitating a tool patch.
2020-06-18 16:12:54 -07:00
James D. Lin bdbe6774a3
[flutter tools] Change the desktop device names and IDs (#58812)
In google3, the Linux device is always available, and it has confused
people who run the Flutter doctor and see
"• Linux • Linux • linux-x64 • Linux" listed.

Rename the Linux device name to "Linux desktop" and the device ID to
be "linux". Make similar changes to the Windows and macOS
devices for consistency.  This is also  consistent with the web
devices.

The device ID change shouldn't be break -d usage since that does a
case-insensitive prefix match.
2020-06-18 15:30:00 -07:00
Jonah Williams e72d26a720
Revert "flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294)" (#59810)
This reverts commit 947b48e062.
2020-06-18 15:19:12 -07:00
Igor Akkerman 947b48e062
flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294) 2020-06-18 14:08:01 -07:00
stuartmorgan e85655c48e
Specify encoding for vswhere output (#59607)
On Windows, Process.run assumes the output uses the system codepage by default. This allows specifying it in our wrapper, and sets the encoding for vswhere to UTF-8 since we're passing a flag that forces it to use UTF-8 output.

Fixes #53515
2020-06-18 14:00:46 -07:00
Michael Goderbauer 32be39bf16
Fix doc for DecoratedBox (#59791) 2020-06-18 13:58:02 -07:00
Jonah Williams 01e09ea8af
[flutter_tools] add missing null-safety flags (#59773)
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety.

Fixes #59769

Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
2020-06-18 12:34:35 -07:00
Darren Austin 06de567811
Dismiss modal routes with a keyboard shortcut (#59310) 2020-06-18 11:53:02 -07:00
Jose Alba c6f6de6d1b
Chips text scaling (#57745) 2020-06-18 11:48:03 -07:00
Jonah Williams 5e77083b8d
[flutter_tools] make parent logger optional (#59786)
The addition of the non-optional parent logger broke the google3 roll. Make it optional so we can roll
2020-06-18 11:44:29 -07:00
Pasindu De Silva df02518dc9
Add the ability to ignore lines depending on comments (#58656)
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments.

// coverage:ignore-line to ignore one line.
// coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive.
// coverage:ignore-file to ignore the whole file.
2020-06-18 10:34:42 -07:00
Jonah Williams 447e3d3f38
[flutter_tools] remove globals from compilers (#59184)
Refactors KernelCompiler and ResidentCompiler to no longer use globals (except as a fallback for g3 migration). Improves the compilation error when running flutter test on a package without a flutter_test dependency.

Updates machine mode to output trace text to stderr
2020-06-18 10:33:17 -07:00
Jonah Williams e1f4cfb4f4
[flutter_tools] add toggle b and service extension to change platform brightness (#59571)
A frequent request from the last Flutter developer survey was for an easier method of testing light/dark mode changes. Currently, a user needs to manually change the theme settings or adjust phone settings to see the difference. Instead we should add a toggle from the CLI, and eventually devtools/Intellij/Vscode that allows developers to override the current setting.

Fixes #59495

Adds flutter.ext.brightnessOverride service protocol which either queries the current platform brightness, or overrides it to a new value. This accepts either Brightness.light or Brightness.dark as a value.

Adds a CLI toggle b which allows the setting to be toggled manually.

Requires an update to the MediaQuery, to conditionally use a debug override when not in release mode
2020-06-18 10:32:43 -07:00
Chris Bracken f39ab52221
Revert "Manual engine roll to update format of compileExpression RPC response (#59717)" (#59774)
Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c72c2.
2020-06-18 09:52:44 -07:00
Ben Konyi c7a37c72c2
Manual engine roll to update format of compileExpression RPC response (#59717) 2020-06-18 09:18:03 -07:00
chunhtai 747fe345f1
fix the widget span layout when text scale factor != 1 (#59711) 2020-06-18 08:28:03 -07:00
Jonah Williams 719ea5a8c0
[flutter_tools] make expando on vm service null safe to handle web stuff (#59624) 2020-06-18 08:18:04 -07:00
Per Classon dbc6dca5d0
Set upper limit on text scaling for AppBar.title (#58094) 2020-06-18 08:13:02 -07:00
Ming Lyu (CareF) 9c3f0faa6d
Add comments to flutter_driver for timeline class (#58823)
* Add comments to flutter_driver for timeline class

Mostly about explanation for the json items from
timeline.dart and timeline_summary.dart.
2020-06-17 18:47:54 -04:00
liyuqian 42e02d60d3
Reland non-breaking "Add clipBehavior to widgets with clipRect #55977" (#59364)
* Revert "Revert "Add clipBehavior to widgets with clipRect (#55977)" (#58344)"

This reverts commit 1d395c5e18.

* Add missed Overflow
2020-06-17 10:57:40 -07:00
Jonah Williams 802c4b0f12
[flutter_tools] handle NPE in list views method(#59626)
Fixes #59608

The VmService getter can be null, handle that in the listViews method. NNBD when
2020-06-17 10:53:54 -07:00
Jenn Magder b8c64d7014
Don't crash when pubspec isn't a map (#59632) 2020-06-17 10:33:02 -07:00
Alexandre Ardhuin 1fe677a3af
update _isolates_io.dart for better nnbd migration (#59666) 2020-06-17 18:58:21 +02:00
renyou a99d146ba9
Revert "Characters Package (#53381)" (#59677)
This reverts commit e0ed12c73a.
2020-06-17 08:39:34 -07:00
Ayush Bherwani 37cb7b7b48
[ExpansionPanelList] adds dividerColor property (#59641) 2020-06-17 01:58:01 -07:00
Alex Vincent fe15d1e793
[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686) 2020-06-16 23:58:01 -07:00
Justin McCandless e0ed12c73a
Characters Package (#53381) 2020-06-16 16:53:04 -07:00
Greg Spencer c5527dc8c4
Remove dependency on package:collection by moving mergeSort into foundation/collections.dart (#59521)
This removes a dependency from Flutter (package:collection) by copying the implementation of mergeSort into Flutter's foundation/collections.dart.

Also, removed a reference to UnmodifiableSetView from the shortcuts code by just returning a copy instead.
2020-06-16 14:41:05 -07:00
Per Classon 56a7dacd46
[flutter_tools] For l10n with deferred loading, use loadLibrary for non-web too (#59539)
After Dart VM change we are now required to use loadLibrary on an import whenever it is imported as deferred.

See: https://dart-review.googlesource.com/c/sdk/+/149613
2020-06-16 13:36:28 -07:00
stuartmorgan 61c198e766
Switch Linux to the GTK embedding (#59287)
Updates the tooling to use the GTK embedding, rather than the GLFW embedding:
- Adds new requirements to `doctor`
- Updates the app and plugin templates to make GTK-based runners and plugins
- Stops downloading and installing the GLFW artifacts

Final part of #54860, other than cleanup.
2020-06-16 13:31:24 -07:00
Kenzie Schmoll 5b147520bf
Cancel tooltip show timer when state is deactivated (#57244) 2020-06-16 13:14:43 -07:00
Jonah Williams 15154b115f
[flutter_tools] deprecate build aot (#59487)
This command was previously used by the re-entrant build scripts in xcode_backend.sh and build.gradle. These have since been refactored to use flutter assemble.

Deprecation the command in preparation for removal in a future release of flutter. The only current use is a test on HHH
2020-06-16 13:00:11 -07:00
MH Johnson 7042be8816
Re-land "[Widgets] Add DefaultTextHeightBehavior inherited widget." (#59350) 2020-06-16 12:50:02 -07:00
Diego Henrique Domingues 95ee633f66
[flutter_tools] fix the event attribute used to skip waiting (#59568) 2020-06-16 11:15:02 -07:00
renyou deec88bb97
Revert "Build routes even less. (#58202)" (#59503) 2020-06-16 10:40:04 -07:00
Ayush Bherwani dde1249937
[MergeableMaterial] adds dividerColor property (#59481) 2020-06-16 10:35:03 -07:00
Justin McCandless b429ec1e8f
InteractiveViewer mouse scale bug (#59478) 2020-06-16 10:30:06 -07:00
Jenn Magder 5a4bb5050d
Remove last references to ideviceinstaller (#59508) 2020-06-16 10:25:10 -07:00
Michael Joseph Rosenthal 42666df9b7
Add link to ListTile replacement guide (#59474) 2020-06-16 10:25:06 -07:00
Gary Qian 1b62b805ca
Handle backspace edgecase in trailing whitespace formatter. (#59379) 2020-06-16 10:20:04 -07:00
Christopher Fujino 807b60250a
[flutter_tools] Update roll_dev.dart (#59215) 2020-06-16 09:30:04 -07:00
Darren Austin e66a5cf55d
Removed an unused static local key from ScrollAction. (#59436) 2020-06-16 09:25:10 -07:00
Greg Spencer 2163731c99
Remove DiagnosticableMixin in favor of Diagnosticable (#58635) 2020-06-16 09:25:04 -07:00
Gary Qian 73560d4bff
Docs 'that that' fix (#50237) 2020-06-16 09:20:07 -07:00
Gary Qian a41855fa95
Docs 'that that' fix (#50236) 2020-06-16 09:20:03 -07:00
Jonah Williams 958f7c5b55
[flutter_tools] ensure generated entrypoint matches test and web entrypoint language version (#59291)
Ensure that the language version of the test/web generated entrypoint matches the language version of the test file to run, or the overall package language version if no annotation is provided.
2020-06-16 09:17:12 -07:00
Michael Goderbauer 584fd5f913
Word substitutions (#59484)
* Word substitutions

* ++
2020-06-16 09:15:43 -07:00
Michael Goderbauer 1bb40aee1b
Replace collection's SetEquals with flutter's own (#59514) 2020-06-16 09:15:14 -07:00
Zachary Anderson f8a4008e41
Revert "Modernize selection menu appearance (#59115)" (#59561)
This reverts commit b3c237ce54.
2020-06-16 08:41:22 -07:00
Jenn Magder e114ab99bb
Remove flutter_goldens_client package dependency from tool (#59365) 2020-06-15 09:55:02 -07:00
Justin McCandless 77859c682e
Characters package (#59267) 2020-06-15 09:50:02 -07:00
Justin McCandless b2a2cb7e03
Add instructions for updating a localized string (#59273)
* Add instructions for updating a localized string

* gem_missing_localizations does nothing when I test this out, seems to not be required

* Explain generation of new locale strings
2020-06-15 09:45:25 -07:00
Jason Simmons 959f5dca83
Revert "Prevent WhitelistingTextInputFormatter to return a empty string if the current value does not satisfy the formatter (#57264)" (#59221) 2020-06-15 09:45:04 -07:00
Ian Hickson f7f019aa94
More useful error messages when you use Stack without a textDirection. (#59360) 2020-06-15 09:40:10 -07:00