Commit graph

16861 commits

Author SHA1 Message Date
Alexandre Ardhuin ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Chris Bracken fa0c49d775
Dispatch hover events to PlatformViewController (#46124)
This adds support to PlatformViewLayer for handling hover events. Prior
to this, PlatformViewLayers only supported events forwarded by the
gesture recognizers associated with the PlatformViewRenderBox. Hover
events don't participate in gesture recognition and as such are dropped
in GestureBinding. That said, hover event processing in platform views
is expected for desktop and other platforms with hover event support.

This adds support for passing an optional MouseTrackerAnnotation to
PlatformViewLayer. PlatformViewRenderBox populates this with a mouse
tracker annotation that forwards hover events to
PlatformViewController.dispatchPointerEvent() for handling by users.
2019-12-05 13:31:50 -08:00
gaaclarke 86dd664fef
Made the behavior for caching large images modular. (#46010)
Introduced LargeImageHandler to ImageCache class.
2019-12-05 12:46:59 -08:00
Alexandre Ardhuin ec0842e0d3
implicit-casts:false in examples (#45805) 2019-12-05 21:33:07 +01:00
Greg Spencer c6fe7bb9e1
Normalizes all of the "See also" blocks in comments. (#46121)
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
2019-12-05 12:27:05 -08:00
Tong Mu f8027a795d Only schedule callback when there is mouse (#46113) 2019-12-05 12:18:03 -08:00
Jenn Magder fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Zachary Anderson e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Todd Volkert 6d848ebf37 Name the docker_builer shard (#46103) 2019-12-05 12:13:01 -08:00
Zachary Anderson 99684ce159 [flutter_tool] Make Device.dispose() abstract (#46006) 2019-12-05 08:48:00 -08:00
Alexandre Ardhuin 649e188562
implicit-casts:false in flutter/lib/src/painting (#45621) 2019-12-05 09:41:49 +01:00
Jenn Magder d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams 2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
godofredoc 1657075914
Move technical_debt_cost to use a cloud vm. (#45996) 2019-12-04 16:26:41 -08:00
Greg Spencer f7d1616173
Overridable default platform key bindings (#45102)
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
2019-12-04 16:07:01 -08:00
Kate Lovett 9011cece25
Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00
Emmanuel Garcia 9e94eb93bc
Remove flutterBuildPluginAsAarFeature flag (#46101) 2019-12-04 15:42:08 -08:00
Christopher Fujino d88345e726 only run codecov on master (#46100) 2019-12-04 15:18:01 -08:00
engine-flutter-autoroll f213f92587
Roll engine 07aab98212cb..fdaa7cf12175 (2 commits) (#46095)
git@github.com:flutter/engine.git/compare/07aab98212cb...fdaa7cf12175

git log 07aab98212cb..fdaa7cf12175 --first-parent --oneline
2019-12-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from OSk8h... to XCAOU... (#14128)
2019-12-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 75368c3a0290..ccca30aad770 (12 commits) (#14129)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-04 14:04:28 -05:00
Greg Spencer 09927b94c3
Add a VisualDensity manual test (#46083)
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
2019-12-04 10:48:06 -08:00
Janice Collins 50c8e6b2d6
Update dartdoc to 0.29.2. (#46014) 2019-12-04 09:59:16 -08:00
Christopher Fujino dfc108c66c improve resetChanges() dartdoc (#46008) 2019-12-04 09:58:01 -08:00
engine-flutter-autoroll 19f8f497f4
07aab9821 Fix one more use of deprecated path fill type API (flutter/engine#14127) (#46092)
git@github.com:flutter/engine.git/compare/1cdfc99314df...07aab98212cb

git log 1cdfc99314df..07aab98212cb --first-parent --oneline
2019-12-04 brianosman@google.com Fix one more use of deprecated path fill type API (#14127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-04 12:55:27 -05:00
Brian Egan 3ea8c87ce9
Api Samples and Diagrams for 10 more classes / functions (#45603)
* Api Samples and Diagrams for the following classes and methods:

  - AlertDialog
  - SimpleDialog
  - SingleChildScrollView
  - showDatePicker
  - RichText
  - InputDecoration
  - Divider
  - StreamBuilder
  - DataTable
  - BottomSheet
    - showBottomSheet
    - showModalBottomSheet

* Update packages/flutter/lib/src/material/divider.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/widgets/basic.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/data_table.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/scaffold.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Move animation out of sample

* Remove "widget.size", replace with "60"
2019-12-04 13:27:23 +01:00
Alexandre Ardhuin 4956bcc2f9
implicit-casts:false in flutter_driver (#45175)
* implicit-casts:false in flutter_driver

* address review comments
2019-12-04 11:10:50 +01:00
Alexandre Ardhuin a5f9b3b036
implicit-casts:false in flutter/lib/src/rendering (#45720)
* implicit-casts:false in flutter/lib/src/rendering

* address review comments
2019-12-04 10:27:04 +01:00
Alexandre Ardhuin 166d422b05
implicit-casts:false in flutter/lib/src/widgets (#45728)
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
2019-12-04 09:43:54 +01:00
engine-flutter-autoroll 54e7b2ba62
1cdfc9931 Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits) (flutter/engine#14107) (#46059)
git@github.com:flutter/engine.git/compare/3e6d6bc612fd...1cdfc99314df

git log 3e6d6bc612fd..1cdfc99314df --first-parent --oneline
2019-12-04 bkonyi@google.com Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits) (#14107)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-04 03:31:08 -05:00
Alexandre Ardhuin 4049460d31
implicit-casts:false in flutter/lib/src/semantics (#45722) 2019-12-04 08:59:19 +01:00
Alexandre Ardhuin 1c7a1c3873
implicit-casts:false in flutter/lib/src/services (#45723) 2019-12-04 07:51:54 +01:00
engine-flutter-autoroll f908e18287
3e6d6bc61 add pointer data santizing in flutter web engine (flutter/engine#14082) (#46049)
git@github.com:flutter/engine.git/compare/90e28c027c0b...3e6d6bc612fd

git log 90e28c027c0b..3e6d6bc612fd --first-parent --oneline
2019-12-04 47866232+chunhtai@users.noreply.github.com add pointer data santizing in flutter web engine (#14082)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 23:44:08 -05:00
Sebastian Döll 417db34d35 Set track color in Cupertino Switch and Adaptive Switch (#45074) 2019-12-03 20:42:48 -08:00
Jacek Marchwicki 50532f387a [Driver] correct type for getWidgetDiagnostics (#45985) 2019-12-03 20:33:02 -08:00
Zachary Anderson 4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Todd Volkert 066a992a5c
Ensure that docker tag is legal (#46035) 2019-12-03 19:53:39 -08:00
Todd Volkert 4c95bbd1c6
Re-enable hostonly tests on non-master branches (#46037)
This is a follow-on to #45455 - the test failures indicated a
real problem, so re-enabling the tests on non-master.

https://github.com/flutter/flutter/issues/45453
2019-12-03 19:53:28 -08:00
Greg Spencer 185da9b0af
Add Density API to ThemeData, implement for buttons. (#43547)
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
2019-12-03 19:49:56 -08:00
Michael Goderbauer 1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
engine-flutter-autoroll 1b05cb2b1c
Roll engine 617938024315..90e28c027c0b (3 commits) (#46043)
git@github.com:flutter/engine.git/compare/617938024315...90e28c027c0b

git log 617938024315..90e28c027c0b --first-parent --oneline
2019-12-04 bkonyi@google.com Roll src/third_party/dart 89e31069e8..19fc1016da (6 commits) (#14093)
2019-12-03 dworsham@google.com Relanding: Add Flow unittests and fixtures (#14091)
2019-12-03 bkonyi@google.com Roll src/third_party/dart a4d799c402..89e31069e8 (14 commits) (#14089)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 22:46:08 -05:00
Emmanuel Garcia 09126abb22
Enable Android embedding v2 on the beta, dev and stable channel (#46040) 2019-12-03 17:43:00 -08:00
engine-flutter-autoroll 50d81a0b8a
Roll engine 1a96087747ac..617938024315 (5 commits) (#46023)
git@github.com:flutter/engine.git/compare/1a96087747ac...617938024315

git log 1a96087747ac..617938024315 --first-parent --oneline
2019-12-03 caseyhillers@gmail.com Update fallback to Roboto url to be HTTPS (#14086)
2019-12-03 iska.kaushik@gmail.com Revert "Fix fml_unittests (#14062)" (#14087)
2019-12-03 liyuqian@google.com Revert PRs to unblock David and Jim's work (#14088)
2019-12-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6QxEZ... to OSk8h... (#14085)
2019-12-03 bkonyi@google.com Roll src/third_party/dart e4344a568f..a4d799c402 (7 commits) (#14083)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 20:41:08 -05:00
Ian Hickson 97495d8938
Simplify logging code in flutter_driver (#45945)
* Simplify logging code in flutter_driver

It appears nobody is benefitting from this logic, so we may as well not pay the cost.

* Make all of the driver interface public.

This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists.

See #45733 for original attempt.

This reverts commit 0ce9206ef4 (PR #45924).
2019-12-03 17:14:43 -08:00
Ian Hickson 2991dc28a5
Update PULL_REQUEST_TEMPLATE.md (#45944)
Update for recent changes to policies.
2019-12-03 14:19:29 -08:00
Dan Field b61dec79c7
Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Jonah Williams b96d818c19
Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00
engine-flutter-autoroll a484db665a
1a9608774 Update to newer path fill-type API in Skia (flutter/engine#14070) (#46002)
git@github.com:flutter/engine.git/compare/faa11214c09b...1a96087747ac

git log faa11214c09b..1a96087747ac --first-parent --oneline
2019-12-03 brianosman@google.com Update to newer path fill-type API in Skia (#14070)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 15:17:09 -05:00
Sahand Akbarzadeh f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Jonah Williams c95dafc4c6
Add printTrace when vscode package.json parsing fails (#45998) 2019-12-03 09:56:04 -08:00
Jonah Williams 0dace48932
Add comments to package scheme fix (#45997) 2019-12-03 09:55:50 -08:00
Jonah Williams 0b2bf99491
Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00