Commit graph

8124 commits

Author SHA1 Message Date
Danny Tuppeny e593dc70e8
Update all packages (#18471)
"flutter update-packages --force-upgrade"
2018-06-14 21:09:32 +01:00
Ian Hickson d1cc8b6de8
Clean up output of "flutter run --release" (#18380)
(second attempt)
2018-06-14 12:30:20 -07:00
Danny Tuppeny 48f4ff6dda
Ensure errors launching emulators are exposed to the daemon (#18446) 2018-06-14 07:59:50 +01:00
Ben Konyi ab6df25103 Fixed concurrent list modification in vmservice.dart 2018-06-13 19:25:07 -07:00
Michael Thomsen 87351bd958
Fix outdated link for how to edit plugin code (#18069)
* Fix readme link to plugin edit instructions

* Fix flutter tools link
2018-06-13 13:40:55 -07:00
Chris Bracken 2ae48845a8
Revert elimination of Dart 1 (#18460)
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.

Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.

This also reverts migration to Dart 2 typedef syntax.

This reverts commit 6c56bb2. (#18362)
This reverts commit 3daebd0. (#18316)
2018-06-13 12:46:39 -07:00
xster 210e2fa333
Fix ListView dartdoc where a paragraph doesn't flow with the section heading and the other paragraphs in the section (#18430) 2018-06-13 12:37:51 -07:00
Andrew Davies 5ed029059e
[frdb] Add support for env connection variable. (#18429)
Similar to the flutter driver, now the fuchsia_remote_debug_protocol can
connect via an environment variable. This can also be used to point to
the SSH config location.

This makes it so that tests written using the FRDB do not have to write
extra information about where their device is on the network.
2018-06-13 11:37:06 -07:00
Yegor b401e76554
fix some TextInputType dartdocs (#18427) 2018-06-13 09:20:19 -07:00
Danny Tuppeny ed05e933f4
Minor flutter daemon doc fixes (#18447)
* Fix anchors for GitHub

For some reason GitHub lowercases the anchor names so although these links all work in the local VS Code preview, the ones with capitals didn't work in the GitHub UI!

* Fix some typos
2018-06-13 16:01:23 +01:00
Alexandre Ardhuin e45836f271
enable lint avoid_field_initializers_in_const_classes (#18415) 2018-06-13 07:20:18 +02:00
Hans Muller 0f0cc4490b
Scaffold bottomSheet parameter: persistent, not a route (#18379) 2018-06-12 14:28:24 -07:00
Keerti Parthasarathy aecb7d9607
Fixes for Dart 2 failures in tests (#18371) 2018-06-12 09:30:10 -07:00
Danny Tuppeny b8b34def39
Fix misplaced quote (#18354) 2018-06-12 15:25:38 +01:00
Sigurd Meldgaard d1aaa406ac
Find AppFrameworkInfo.plist relative to Flutter app (#18358)
This works better for an add2app scenario.
2018-06-12 11:04:49 +02:00
Dan Field b760ce0f5d
expose PathOperation (#18383) 2018-06-12 01:25:49 -04:00
Jonah Williams e3d9ecaead
Add ability to cache images by size (#18135) 2018-06-11 17:21:22 -07:00
Ian Hickson dac2ebf0c0
More flexible timeout logic in flutter_test (#18256)
This should reduce the number of flakes without actually increasing
the timeout, so we'll still find out quickly if a test is hanging.

The numbers here might need tweaking. Maybe the default two seconds is
too short for CI bots.
2018-06-11 16:28:01 -07:00
Greg Spencer 6c56bb2420
Update typedef syntax to use Function notation and turn on lint for old notation. (#18362)
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
2018-06-11 15:51:45 -07:00
Mehmet Fidanboylu 3019ad976d
Passing any to named params require the name of the parameter itself. (#18361) 2018-06-11 11:31:25 -07:00
Edman P. Anjos d454629a06 Add @isTest annotation to testGesture (#18311)
Notifies IDEs this is a test method, and helps e.g. the flutter plugin
recognize test methods and display them in the structure view in intellij.
2018-06-11 07:16:39 -07:00
Dan Field 625ac52360
update tests for TextStyle changes in engine (#17982)
* update tests for TextStyle changes in engine

* roll engine, support Foreground on TextStyle

* Support for saving Dart compilation trace on device
2018-06-10 14:08:35 -04:00
Hans Muller 691cbee613
Add locale parameter to EditableText (#18222) 2018-06-09 08:23:59 -07:00
Stanislav Baranov 581a343b34
Fix gradle dependency for gen_snapshot in AOT builds. (#18322) 2018-06-08 18:45:07 -07:00
Chris Bracken 4db7daf751
Handle malformed depfiles in Fingerprinter (#18321)
Fingerprinter.doesFingerprintMatch() now returns false rather than
throwing if a depfile is malformed.
2018-06-08 17:56:14 -07:00
Chris Bracken 3daebd059c
It's time to #deleteDart1 (again) (#18316)
* It's time to #deleteDart1 (#18293)

Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.

* Fix indentation, remove no longer necessary .toList()

* Only push udpated kernel if >0 invalidated srcs
2018-06-08 15:49:24 -07:00
Chris Bracken 9495df4bc3
Revert "It's time to #deleteDart1 (#18293)" (#18313)
Several benchmarks started failing during kernel compile:
1. Timeouts:
   * commands_test
   * hot_mode_dev_cycle__benchmark
   * run_machine_concurrent_hot_reload
   * service_extensions_test

2. Kernel compiler crash:
   * hot_mode_dev_cycle_linux__benchmark
   * routing_test

3. Unexpected termination:
   * hot_mode_dev_cycle_win__benchmark

This reverts commit ed63e7082a.
2018-06-08 12:43:11 -07:00
Chris Bracken ed63e7082a
It's time to #deleteDart1 (#18293)
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.
2018-06-08 11:04:57 -07:00
Jonah Williams e186a164c8
Add 'header' SemanticsFlag to AppBar, NavBar (#18289) 2018-06-08 10:28:12 -07:00
Yegor 3983815de5
fix setTextEntryEmulation docs (#18298) 2018-06-07 22:01:59 -07:00
Chris Bracken 0e4770e809
Count kernel bytes in bytes synced by DevFS.update (#18288)
DevFS.update() returns the number of bytes synced from the host to the
target device. When running in Dart 2 mode, ensure that the size of the
kernel file is included in the count of bytes synced.
2018-06-07 18:27:08 -07:00
Chris Bracken 0628a1fb24
Eliminiate concurrent map key set modification (#18284)
Iterates over a copy of the dirty entries list rather than the original,
in order to avoid the potential for a concurrent modification exception
when fileUris are removed/added later in the loop.

This occurs when non-asset URIs (Dart sources) are listed in the dirty
set when --preview-dart-2 is enabled (the default).
2018-06-07 16:45:09 -07:00
Chris Bracken 3c25817bc7
Make kernel compiler stdoutHandler private (#18283)
Thie field is never used outside of the class and has a private type,
making it impossible to subclass/mock.
2018-06-07 16:44:25 -07:00
Jonah Williams d803f02d4f
Add activeIcon property to BottomNavigationBarItem (#18125) 2018-06-07 15:42:54 -07:00
Jonah Williams 0891a1136b
update a11y for material slider (#18005) 2018-06-07 15:41:35 -07:00
matthew-carroll 3bc906d372
Extracted an ImplicitlyAnimatedWidgetState from AnimatedWidgetBaseState (#18181)
Extracted a superclass from AnimatedWidgetBaseState that is called ImplicitlyAnimatedWidgetState. ImplicitlyAnimatedWidgetState implicitly animates, but it does not call setState() automatically. Subclasses must respond to animation changes themselves. This is a useful optimization for Widgets whose render objects listen to animations directly. (#18173)
2018-06-07 14:04:30 -07:00
Michael Goderbauer 3b9b5acefc
showOnScreen Improvements (#18252) 2018-06-07 10:07:52 -07:00
Michael Goderbauer 06140f2b14
Closing search with system back button works (#18174)
Fixes #18145.
2018-06-06 16:35:05 -07:00
amirh 0a26ac0970
_markNeedsClip() when clipper type has changed. (#18248)
A bug in _RenderCustomClip was compaeing the type of oldClipper to
itself instead to the type of newClipper.

This was the root cause for the crash #14937 worked around.
This also reverts the workaround introduced in #14937.
2018-06-06 15:28:20 -07:00
Stanislav Baranov 4a2ed22b0e
Propagate flutter tool verbose flag through gradle to flutter build bundle. (#18246) 2018-06-06 13:43:32 -07:00
Edman P. Anjos 4bbd4ce981 Surface border parameter in CupertinoSliverNavigationBar (#18194)
* Surface border parameter in CupertinoSliverNavigationBar (#18152)

* Add tests for CupertinoSliverNavigationBar border

* Remove unused keys, find by descendant
2018-06-06 11:44:06 -07:00
Danny Tuppeny 199d945b9e
Add emulators to docs (#18231) 2018-06-06 19:06:17 +01:00
Alan Knight b135fb3795 Remove tests that rely on 'ar' locale information which will change (#18217) 2018-06-05 15:53:15 -07:00
xster ac0c44fc1a
Small fidelity adjustments for Cupertino (#18104) 2018-06-05 15:38:05 -07:00
Alexander Aprelev f11c8d967c
Add compile-expression service. (#16161)
This registers compile-expression service that is used by dart vm to evaluate expressions when debugging flutter applications.
2018-06-05 13:22:13 -07:00
Keerti Parthasarathy da7670c2ee
Fixes for test failures in Dart 2 mode (#18122) 2018-06-05 12:38:30 -07:00
Michael Goderbauer 12eeb94c89
Compare SemanticsHandler# at end of test to value at beginning of test (#18183) 2018-06-05 12:24:56 -07:00
Hans Muller 04e0fcb00e
Fixed a typo in the render paragraph locale setter (#18189) 2018-06-05 10:55:11 -07:00
Hans Muller e8bceabbb8
Correct OutlineBorder gapStart when InputDecoration icon is specified (#18182) 2018-06-05 10:40:49 -07:00
Ian Hickson 25c4bc32b8
Try to make the test framework a little more resilient to timeouts (#18180) 2018-06-05 09:51:19 -07:00