Commit graph

11396 commits

Author SHA1 Message Date
Greg Spencer e2c5fd6c24
Fix route focusing and autofocus when reparenting focus nodes. (#42554)
This fixes a problem with reparenting of focus nodes where it would remove the node from the scope's focused children when reparented, even if it was being reparented to another place under the same scope. This only occurred if the scope in question didn't have focus.

This caused nodes to not get autofocused when they were a child of another node within the scope, and were reparented, and then the scope was given focus (as when a route is pushed).

This keeps the node in the scope's child list where it was if the node is reparented under a parent within the same scope.

- Added a test that tries to autofocus a TextField when the route is pushed and there is another 
  FocusNode above the text field. This was how this was first noticed: the autofocus got ignored in 
  this configuration.

- Added a test to focus_manager_test that tests for the specific case of reparenting a node when 
  it's in the focused children of the scope.
2019-10-14 12:32:06 -07:00
Darren Austin a49470556c
Update BottomAppBar to use elevation overlays when in a dark theme (#41864)
* Updated the BottomAppBar to use elevation overlays when a dark theme is used.

* Moved the code for calculating the overlay color to a new utility
ElevationOverlay class and made it private by not including in the material package.
2019-10-14 11:02:15 -07:00
Tjong Anthony dd43da71fe Add isDismissible configuration for showModalBottomSheet (#42404)
* Allow showModalBottomSheet to present bottom sheet that is not dismissible by tapping on the scrim

* Add guards, improve styling and tests for BottomSheet
2019-10-14 10:00:00 -07:00
Mouad Debbar ba70e0e074
Print correct hostname when web server is launched (#42531) 2019-10-14 09:54:36 -07:00
Alexey Ivanov 8cc9a53ee3 Improve routers performance (#42526) 2019-10-14 09:25:00 -07:00
Shi-Hao Hong 877c6a62d0
Localization refresh (#42025)
* Refresh .arb files

* Refresh localizations
2019-10-14 09:07:06 -07:00
Jonah Williams 04e04ffa95
Deflake wildcard asset test (#42597) 2019-10-14 08:49:02 -07:00
Justin McCandless e7ffac2d67
Fix typo in docs: EdgeInserts->EdgeInsets (#42445) 2019-10-14 08:45:57 -07:00
Keshava Muraari 19899db223 Default colorScheme data in ButtonThemeData (Fix for #38655) (#39627)
* Set default colorScheme for ButtonThemeData
2019-10-14 08:40:02 -07:00
Greg Spencer dee7583908
Only dismiss dropdowns if the orientation changes, not the size. (#42482)
This changes the DropDownButton so that instead of dismissing itself when any metrics change occurs, it only dismisses itself when the orientation changes.

This gets around the fact that we can't currently have a dropdown and a text field on the same page because the keyboard disappearing when the dropdown gets focus causes a metrics change, and the dropdown immediately disappears when activated.

It still will cause the keyboard to jump up and down between controls, but that's a larger issue. At least now we can use the two together again.
2019-10-14 08:00:11 -07:00
chunhtai 9423a01204
fix flutter error report correct local widget (#41224) 2019-10-13 18:41:22 -07:00
Emmanuel Garcia 532a8fed41
Print message and log event when app isn't using AndroidX (#42548) 2019-10-12 18:58:22 -07:00
Dan Field 3fea2838df
Skip test (#42557) 2019-10-11 16:18:00 -07:00
Dan Field de499c2a93
Gradient transform (#42484) 2019-10-11 13:40:16 -07:00
Zachary Anderson af93b6af80
[flutter_tool] Improve yaml font map validation (#42538) 2019-10-11 12:17:37 -07:00
Ian Hickson 08643c41d7
Always fake ProcessManager when you fake Filesystem in tests (#42369)
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Ian Hickson 292519be98
Roll dart package dependencies (#42496) 2019-10-11 11:12:31 -07:00
Jason Simmons db9a035e7c
Wait for isolate start before proceeding with expression evaluation tests (#42464)
Fixes https://github.com/flutter/flutter/issues/42359
2019-10-11 11:04:39 -07:00
Tong Mu 0aafdfa55a
Redo: Rewrite MouseTracker's tracking and notifying algorithm (#42486)
* Revert "Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478)"

This reverts commit eede792923.

* Fix tests
2019-10-11 10:10:56 -07:00
Jonah Williams 7ab653c6ca
Add error logging to flutter generate (#42209) 2019-10-11 07:16:11 -07:00
Lau Ching Jun 4416c4f8d6 Add Android x64 profile artifacts (#42508) 2019-10-11 06:57:45 -07:00
Ian Hickson 53be552ae1
Be more verbose when pub fails (#42187) 2019-10-10 19:37:01 -07:00
Jonah Williams eede792923
Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478) 2019-10-10 16:44:10 -07:00
Jonah Williams 2b635816c6
Wrap dwds in async guard, only catch known error types (#42364) 2019-10-10 16:34:27 -07:00
Jonah Williams 03a45dc383
Add support for Android x86_64 ABI to Flutter (#42401) 2019-10-10 16:34:16 -07:00
Tong Mu 53636374dc
Rewrite MouseTracker's tracking and notifying algorithm (#42031)
* Redesigns the algorithm with which MouseTracker keeps track of states and dispatches events.
2019-10-10 16:28:56 -07:00
Greg Spencer ce1509714c
Re-land keyboard traversal PRs (#42278)
This attempts to reland #40186 and #41220, that were reverted in #41945.

The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.

I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)

Fixes #40101
2019-10-10 13:49:33 -07:00
Shi-Hao Hong a95a84ebfb
Revert removing DropdownMenuItem hint/disabledHint wrapper (#42456) 2019-10-10 13:43:28 -07:00
Emmanuel Garcia 53cc59f82c
Add transitive dependencies back (#42441) 2019-10-10 12:47:34 -07:00
Tong Mu a71d69ba67
Add opacity control to MouseRegion. Add findAnnotations to Layer. (#37896)
* Adds a new parameter bool opaque to MouseRegion
* The same to RenderMouseRegion and AnnotatedRegionLayer
* Add findAnnotations to Layer
2019-10-10 12:46:12 -07:00
tauu 6b4a10ae53 PlatformView: recreate surface if the controller changes (#40280)
Currently the surface of a platform view is only created only one when the state of PlatformViewLink is created. When the PlatformViewLink widget changes, the PlatformViewController in the corresponding state is also updated. Just the surface is not updated even though it depends on the controller.

This PR changes this behavior to recreate the surface whenever the controller is updated.
2019-10-10 12:27:20 -07:00
Gary Qian d62565a5f0
Add font fallback clarification docs (#42365) 2019-10-10 13:48:09 -04:00
Ryan Macnak 2a40c2ddb5
Pass -Ddart.developer.causal_async_stacks=true to frontend_server invocations. (#42354)
Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
2019-10-10 10:41:24 -07:00
Darren Austin 812e0387c3
TextStyle.fontFamily should override fontFamily parameter in ThemeData constructor. (#42366)
Also updated the documentation for the ThemeData constructor to include
descriptions of parameters that don't map to specific fields directly.
2019-10-10 10:39:41 -07:00
Sahil Soni ff15a39c07 [BUG] Process all children of intent-filter instead of just the first one to identify default activity (#40029) 2019-10-10 10:05:43 -07:00
Danny Tuppeny e8c5d66b5a
Use processManager.run() instead of manually capturing streams in test_utils getPackages() (#41687)
* Capture stdout in test helper

* Simplify running getPackages() in test utils

* Remove unused import
2019-10-10 07:47:26 +01:00
Lau Ching Jun 5a41374ac3
Add option to precache unsigned mac binaries. (#42376) 2019-10-09 22:24:15 -07:00
Emmanuel Garcia 9eaac9c414
Add smoke test for the new Android embedding (#42360)
* Add smoke test for the new Android embedding

* Update AndroidManifest.xml in app template

* Update test README.md

* Remove widget_test.dart

* Update pubspec.yaml

* Force GeneratedPluginRegistrant.java
2019-10-09 21:57:19 -07:00
Jonah Williams 480342899e
Switch desktop build commands to use process utils (#42373) 2019-10-09 18:58:27 -07:00
Tong Mu 94515ba590
Make MouseTracker.sendMouseNotifications private (#41879)
* Make sendMouseNotifications private
2019-10-09 18:29:02 -07:00
Jonah Williams 10ddb7db78 remove println (#42378) 2019-10-09 17:49:31 -07:00
Dwayne Slater 2adda80c10
Expose wait conditions in the public flutter_driver API (#42162) 2019-10-09 16:58:41 -07:00
Shi-Hao Hong 8fcc1d4151
Fix DropdownButton crash when hint and selectedItemBuilder are simultaneously defined (#42342)
* Fix DropdownButton crash when hint and selectedItemBuilder are simultaneously defined
2019-10-09 16:47:44 -07:00
tery lim 9b29e830ca Fix documentation for the required argument (#41675) 2019-10-09 16:32:17 -07:00
Remi Rousselet 79cbe25b95 No longer rebuild Routes when MediaQuery updates (#41763)
* No longer rebuild Routes when MediaQuery updates

fixes #37878

* Fix tests

* PR feedback

* Add missing endline
2019-10-09 16:32:07 -07:00
Pieter van Loon e3195c2629 Fixed media query issues and added test to prevent it from coming back (#41803) 2019-10-09 16:31:48 -07:00
Ian Hickson 96276630bf Improve documentation around animations. (#42267) 2019-10-09 16:31:29 -07:00
Christopher Fujino ed482c3e09
Stop leaking iproxy processes (#42026) 2019-10-09 16:30:27 -07:00
Hans Muller b770f3443d Reprise: Dropdown Menu layout respects menu items intrinsic sizes (#42033)
* Reprise: Dropdown Menu layout respects menu items intrinsic sizes

* updated per review feedback

* updated per review feedback
2019-10-09 16:29:40 -07:00
Emmanuel Garcia 1d2eaaf204
Ensure that flutter assets are copied in the AAR (#42306) 2019-10-09 16:29:20 -07:00