Commit graph

8366 commits

Author SHA1 Message Date
Greg Spencer e262817ac2
Fix the gradle templates so that they default to values rather than throw build exceptions. (#19916)
When creating a new project, the build fails with an error similar to:

"versionCode not found. Define flutter.versionCode in the local.properties file."

This puts developers in the untenable situation of having to edit a file with local paths, but being unable to check it in.

This changes the templates to default to using versionCode 1 and version "1.0" if they are not defined in the local.properties file.

Fixes #18983.
2018-07-27 18:24:13 -07:00
David Shuckerow 0b1ef6bb1c
Reduce the haptic feedback on the draggable widget. (#19585) 2018-07-27 14:53:51 -07:00
Jonah Williams 1b81b6127b
swap default of card widget (#19898) 2018-07-27 14:00:30 -07:00
Todd Volkert 78a00cb13a
Revert "Revert "roll engine to 6f7bdc9fabef810b14577deef5cf330029fd290e" (#19878)" (#19880)
This reverts commit e52eeba367.
2018-07-27 09:02:44 -07:00
Todd Volkert e52eeba367
Revert "roll engine to 6f7bdc9fabef810b14577deef5cf330029fd290e" (#19878)
* Revert "Revert flutter/flutter#19592 (#19861)"

This reverts commit 00aac68e2d.

* Revert "roll engine to 6f7bdc9fabef810b14577deef5cf330029fd290e (#19848)"

This reverts commit 8b05629658.
2018-07-27 09:01:15 -07:00
Todd Volkert 00aac68e2d
Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Jonah Williams 8b05629658
roll engine to 6f7bdc9fabef810b14577deef5cf330029fd290e (#19848) 2018-07-26 19:12:04 -07:00
Jonah Williams b5b1cbebde
handle case where image is null as well (#19797) 2018-07-26 18:23:18 -07:00
creativecreatorormaybenot e6fa45d63f Added 35 icons (#19725) 2018-07-26 17:47:57 -07:00
Todd Volkert 7ea164ecb5
More dart 2 fixes to fuchsia_tester.dart (#19846) 2018-07-26 17:46:08 -07:00
Jonah Williams 730a534fbb
Make Card explicitChildNodes vs container be configurable (#19693) 2018-07-26 17:27:45 -07:00
Jonah Williams 9c159638bc
Revert "Clean up startProgress logic. (#19695)" (#19842)
This reverts commit 0636c6fe60.
2018-07-26 16:44:27 -07:00
Ian Hickson 0636c6fe60
Clean up startProgress logic. (#19695)
Disallow calling stop() or cancel() multiple times. This means that
when you use startProgress you have to more carefully think about what
exactly is going on.

Properly cancel startProgress in non-ANSI situations, so that
back-to-back startProgress calls all render to the console.
2018-07-26 14:02:25 -07:00
Jonah Williams f516074a98
Add header SemanticsFlag to bottom nav bar (#19803) 2018-07-26 13:29:28 -07:00
Leaf Petersen 70791c3087
Roll pubspec forward to new json_schema, matcher and vector_math (#19802)
Pull in new versions of packages with fixes for SCREAMING CAPS CONSTANTS.
2018-07-26 12:23:24 -07:00
stevemessick f72c514c59
Add IJ module definitions for modules (#19722) 2018-07-26 05:08:11 -07:00
Greg Spencer 1a414990ab
Move commit range determination inside of test.dart (#19777)
Our Cirrus Windows tests were not really working: they reported success even when failing.

This should fix several problems with the Cirrus Windows tests.
2018-07-25 15:19:57 -07:00
jslavitz 28dc007450
Added single open panel functionality (#19624)
* Just commiting two files now

* Fixed one tab

* Fixed latest changes

* Changed the data structure from a map to a single radio panel object

* A few more changes

* Fixed change from expansion radio to regular list

* Fixed change from expansion radio to regular list2

* Changed the radio constructor

* Last fixes

* Final commit

* Actual final commit

* Last change
2018-07-25 14:35:17 -07:00
Jonah Williams d098dc3408
Add excludeSemantics flag to semantics widget (#19650) 2018-07-25 14:33:36 -07:00
amirh 1269863dd0
Fix touch event conversion bugs. (#19780)
These are bugs uncovered by the integration test for embedded Android
views:

  * Some PointerEvents were constructed with radiusMinor set to
  radiusMajor.
  * Some PointerEvents were missing radiusMajor/radiusMinor.
  * The pressure parameter was not passed to PointerUpEvent.
  * radiusMin, radiusMax, radiusMinor, and radiusMajor were not
  converted from physical pixels to logical.

Sending the fixes without a test as the bugs are covered by the integration
test that is going to land soon.
2018-07-25 14:04:48 -07:00
Greg Spencer ed0f4e0380
Enhance SizeTransition docs (#19721)
Updated documentation of SizeTransition, since I found it less than intuitive.

I added some constructor asserts to make the (existing) contract more clear.
2018-07-25 11:25:20 -07:00
Danny Tuppeny 93dd3f193c
Skip integration tests that use flutter-tester on Windows (#19773)
* Skip integration tests that use flutter-tester on Windows

This is known to be broken. I will un-skip all of these once a fix for flutter-tester lands on Windows.

* Save with added import!
2018-07-25 18:31:50 +01:00
Danny Tuppeny b3c319e4f1
Add integration tests to ensure flutter run does not quit at startup (#19473)
* Add tests to ensure flutter run does not quit at startup

These tests require https://github.com/dart-lang/vm_service_client/pull/38 to be merged and currently the third test (pause-on-exceptions) fails because of a bug.

* Remove TODO

Probably makes most sense this way for now.

* Address PR comments
2018-07-25 17:29:35 +01:00
Danny Tuppeny 2a679bd858
Look up breakpoints rather than relying on magic numbers (#19708)
* Look up breakpoints rather than relying on magic numbers

* Make breakpoint comment more obvious
2018-07-25 15:31:57 +01:00
Danny Tuppeny bdf0dd466d
Skip attach test on Windows due to #17833 (#19763) 2018-07-25 14:56:29 +01:00
Danny Tuppeny d71d10094d
Rename file -> _test so it runs on CI! (#19749) 2018-07-25 13:43:36 +01:00
Paweł Polański da0e898da9 Added SM-G960F to the list of known physical devices (#18966)
Samsung Galaxy S9 is not an emulator and installation of
the release packages with 'flutter run --release' should be possible.
2018-07-24 16:39:23 -07:00
moznion 46da8536b6 Add some options to format subcommand (#18360)
* Add `--dry-run` option to `flutter format` sub command

* Add `--set-exit-if-changed` option to `format` sub command

* Add `--machine` option to `format` sub command

* Make variable names to be not shorthand: cmd -> command

Fix https://github.com/flutter/flutter/pull/18360#discussion_r199656120
2018-07-24 16:37:00 -07:00
Todd Volkert 6258f322d4
Make Fuchsia tools Dart 2 clean (#19727) 2018-07-24 16:33:49 -07:00
Jonah Williams 12aa7ec427
remove trailing whitespace (#19728) 2018-07-24 15:21:40 -07:00
Jonah Williams fba4fdb4e6
Fix off by one error in TextPainter. (#19429) 2018-07-24 14:26:06 -07:00
Jonah Williams 810a29d663
Semantics framework updates (#18758)
Changes:

- Move the SemanticsConfiguration update from RenderToggleable to each subclass, so that Switch can use toggled.
- Add image, liveRegion, toggled properties to Semantics, SemanticsConfiguration, SemanticsNode
- Added semanticsLabel and excludeFromSemantics to Image (the latter so that we avoid creating a semantics node)
- Added onDismiss semantics action which maps to the modal escape on iOS and dismiss action on Android.
- Added dismiss and liveRegion to snackbar widget
- Updated custom painter semantics to handle image, liveRegion, toggle
- Updated relevant tests to use correct flag/action
2018-07-24 13:10:17 -07:00
matthew-carroll 687f059a89
Fix Flutter.java initialization crash (#19628) 2018-07-24 11:58:59 -07:00
Hans Muller 0863367c6e
Extend InputDecoration borders for disabled/error/focused states (#19694)
Added five InputBorder properties to InputDecoration etc so that apps can control the appearance of an InputDecorator's border:  errorBorder, focusedBorder, focusedErrorBorder, disabledBorder, enabledBorder.
2018-07-24 08:57:27 -07:00
Ian Hickson 56800d8fa1
Improve docs for FutureBuilder (#19687) 2018-07-23 22:56:03 -07:00
Danny Tuppeny 18a6a2aa33
Run "flutter update-packages --force-upgrade" (#19679) 2018-07-24 06:51:40 +01:00
sandrasandeep 834fb7b9a8
Add cursorWidth and cursorRadius to TextField (Material) cursor (#19317)
* fixed segmented control golden test

* fixed segmented control golden test

* made the comments more explanatory

* changed comment, wrapped tests with if statements so they only run on MacOS

* changed formatting

* added width and radius fields to TextField; to do: tests and Material defaults

* weak warnings

* added tests

* added default cursor width; changed default EditableText width

* only run golden file tests on linux

* changed goldens version

* actually changed goldens.version

* style changes

* small fixes

* added default material cursor color

* changed goldens.version

* changed goldens version again

* changed goldens.version again (3)

* added todo

* deleted whitespace
2018-07-23 16:33:39 -07:00
Jonah Williams d61b4fae64
Add ignoringSemantics argument to AbsorbPointer (#19651) 2018-07-23 15:28:34 -07:00
Ian Hickson b4d3808a15
Fix the checksum verification to be more sensitive (#19290)
* Fix the checksum verification to be more sensitive

* update packages
2018-07-23 13:01:22 -07:00
Gary Miguel a7b59b51b8 Remove redundant check for platform.isLinux. (#19441)
We don't actually care if we're on linux, we care only if the lcov
tool is available. We check for that explicitly just below.
Additionally there is code below which indicates that lcov is available
for macOS. Before this change that code would never execute.
2018-07-23 08:38:20 -07:00
Alexandre Ardhuin 27018359d2
re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Lukas Piliszczuk 1cb2677234 Change material RefreshIndictor.onRefresh signature from Future<Null> to Future<void> (#18775)
* Change material refresh indicator onRefresh signature from Future<Null> to Future<void>.

* Update authors.

* Explicitly name void argument.
2018-07-21 15:30:53 -07:00
Jonah Williams e154298e0b
Roll engine to 96f5f5b96c7220ffc8c4ce22ed895616a15ad3a0 (#19615) 2018-07-21 00:45:16 -07:00
amirh debd50158e
Introduce an AndroidView widget and a RenderAndroidView render object. (#19565)
RenderAndroidView is responsible for sizing and displaying an embedded
Android view.
AndroidView is responsible for creating and disposing the Android view
and is using RenderAndroidView to display it.
2018-07-20 15:58:55 -07:00
jslavitz 9a4db21129
Changed duration (#19015)
* Changed duration

* Fixed column width for ios build error messages

* fixed a couple things

* fixed a couple things

* accidental changes

* added spaces

* added spaces

* Added test for default snackbar duration

* Fixed link:

* Final commit

* Final commit2

* Actual final commit
2018-07-20 15:17:44 -07:00
Leaf Petersen 32f94443cc
Remove uses of deprecated constants and change int.parse to int.tryParse (#19575)
* Remove uses of deprecated constants
* Change int.parse to int.tryParse where appropriate
2018-07-20 15:07:24 -07:00
Ian Hickson 35346b4966
Increase verbosity on bots during setup and other minor cleanup (#19526)
The verbosity change is to help track down timeouts that currently look like:

```
C:\Windows\Temp\flutter sdk>call bin\flutter.bat config --no-analytics
Checking Dart SDK version...
Downloading Dart SDK from Flutter engine c5a63d28bf3735569c8187753bc490d8351a8363...
Unzipping Dart SDK...
Updating flutter tool...
```
2018-07-20 11:01:45 -07:00
Michael Goderbauer 8a00318e89
Whitespace fixes to make Travis happy (#19611)
Follow-up to https://github.com/flutter/flutter/pull/18562, which passed Travis before the check was added.
2018-07-20 10:51:41 -07:00
Norbert Kozsir a14b4f621e Making the space between keyboard and text-field when the keyboard pops up a variable. (#18562) 2018-07-20 09:46:24 -07:00
Sarah Zakarias f0639bb022
add more uses of FlutterProject to locate files (#19403) 2018-07-20 09:21:41 +02:00