Commit graph

4328 commits

Author SHA1 Message Date
Bogdan Lukin 80a14af582
[flutter_tools] ensure track-widget-creation can be changed on devcompiler (#56564)
Workaround for cached web builds with --[no-]track-widget-creation flags.
Similar PR: #23299
2020-05-07 18:58:43 -07:00
Jenn Magder 0a4f6cdef0
Add split-debug and obfuscation to build aar (#56342) 2020-05-07 18:14:02 -07:00
Jonah Williams 2d26cbb2bf
[flutter_tools] reduce initial cache size on web (#56103) 2020-05-07 17:59:02 -07:00
Jonah Williams 8f7b2f9bee
[flutter_tools] throw StateError instead of null (#56481) 2020-05-07 11:41:03 -07:00
xster f6b47a5f35
let the embedding maven engine dependency reference the storage proxy (#56164) 2020-05-07 11:36:02 -07:00
Jonah Williams 9bfe50cb81
[flutter_tools] fix windows vscode lookup (#56491) 2020-05-06 16:51:01 -07:00
Zachary Anderson 6f0ed5e142
[flutter_tools] Restore base/platform.dart (#56410) 2020-05-06 08:15:39 -07:00
Jonah Williams 0ecc7a4bee
[flutter_tools] support multiple fuchsia devices (#55780)
Fixes #55765

We are currently only returning the first device from dev-finder, instead we need to look at the whole list.
2020-05-05 13:40:38 -07:00
Jonah Williams 9b7b9d795e
[flutter_tools] reland remove flutter view cache (#56387)
Fixes #56194

Remove caching of FlutterView and poll forever if the list of flutter views is empty. Added test for missing release mode logic.
2020-05-05 12:09:51 -07:00
Jonah Williams d98d3a973f
Revert "[flutter_tools] remove flutter view cache (#56223)" (#56385)
This reverts commit 209bdcb669.
2020-05-05 11:15:33 -07:00
Jonah Williams 209bdcb669
[flutter_tools] remove flutter view cache (#56223)
Remove caching of FlutterView. Perhaps the FlutterView RPC might return an empty list if the VM is not quite up yet? We had some old logic to poll the flutter views RPC for up to 200ms. That doesn't seem like a great approach, so instead we could forgo it entirely and trust that either the views come up before the developer tries to interact, or we crash.
2020-05-05 10:47:01 -07:00
Jenn Magder 06fcf5146b
Inject logger and fs into printHowToConsumeAar, test without context (#56331) 2020-05-04 18:38:00 -07:00
Jenn Magder 90233746b7
BuildInfo tests without context (#56329) 2020-05-04 18:37:44 -07:00
Jenn Magder c587d73ec6
Use androidSdk globals variable everywhere (#56330) 2020-05-04 17:48:10 -07:00
David Morgan 0830c75c59
Turn implicit casts in code generated by flutter_platform.dart into explicit casts. (#56290) 2020-05-04 12:44:01 -07:00
Devon Carew 3f9ede1311
fix the reload and restart service extension methods (#56240) 2020-05-04 11:34:02 -07:00
Jonah Williams 6d1966efcc
[flutter_tools] make gallery hot reload 5x faster with one neat trick (#56224) 2020-05-04 11:32:30 -07:00
Jenn Magder c8c55b4098
Check Xcode build setting FULL_PRODUCT_NAME for bundle name (#55799) 2020-05-04 11:31:08 -07:00
Peter Lauri f6db8ccd20
[flutter_tools] fix version tag v stripping and support old "dev" and new "pre" tags (#55602) 2020-05-04 11:24:03 -07:00
Jonah Williams 6dc1e83f12
[flutter_tools] ensure track-widget-creation can be disabled on Android/macOS (#56203)
Ensure --no-track-widget-creation is piped through android/macOS. Adds integration testing for iOS/android/macOS
2020-05-04 11:22:15 -07:00
Jonah Williams ec93c51eaf
[flutter_tools] add support for faster incremental build (#56067)
Introduce BuildSystem.buildIncremental, which keeps an in-memory cache of timestamps instead of file hashes. This will be used to implement localization generation through the same build system API.
2020-05-01 17:30:26 -07:00
Jonah Williams 2a5690f097
[flutter_tools] fix iOS build inconsistencies and pipe through performance file (#56094)
Ensure iOS and android builds can be correctly cached. Use the performance-measurement-file to verify that all targets were skipped on the second invocation. This is only run on the flutter_gallery build.
2020-05-01 15:34:28 -07:00
Jonah Williams d6cbf2591a
[flutter_tools] don't recreate license, manifest, asset if unchanged (#56107)
Avoid syncing unchanged versions of these files during hot restart/reload. This happens if the asset bundle needs to be built but produces identical manifests/licenses due to only asset contents changing
2020-05-01 12:03:31 -07:00
Jonah Williams 368da5bb59
[flutter_tools] support bundling SkSL shaders in flutter build apk/appbundle (#56059)
Support bundling SkSL shaders into an android APK or appbundle via the --bundle-sksl-path command line options. If provided, these are validated for platform engine revision and then placed in flutter_assets/io.flutter.shaders.json
2020-04-30 13:39:08 -07:00
Jonah Williams bd6ccb606a
[flutter_tools] android device stopApp handles null apk (#55990)
The resident runner does not check if the ApplicationPackage is null when trying to stop the app. Update AndroidDevice.stopApp to handle this case by returning false.

The package will be null when flutter attach is used.
2020-04-29 16:31:42 -07:00
Jonah Williams 0889e14361
[flutter_tools] increase stopApp timeout for FlutterDevice.exitApps (#55984) 2020-04-29 15:08:34 -07:00
Jonah Williams a58d50deb1
[flutter_tools] allow pulling performance data from assemble (#55699) 2020-04-29 13:04:59 -07:00
Jonah Williams 534b0608ce
[flutter_tools] remove vm service (#55794)
Finishes the gradual vm service migration by deleting the flutter tooling's vm_service
2020-04-29 11:52:46 -07:00
Jonah Williams c55b32204e
[flutter_tools] fix performance of tree-shake-icons (#55417)
Fixes the performance issue with tree-shake-icons and filters to ttf mime type. Does not change default or error behavior.
2020-04-29 11:43:47 -07:00
Jonah Williams 72397fd448
[flutter_tools] Lazily inject logger into web devices (#55961)
Constructing the WebDevices with the global logger too early will lead to them grabbing the StdoutLogger when running in daemon mode. This prevents IDEs from seeing the correct debug message.
2020-04-29 11:35:40 -07:00
michaellee8 9d770c1091
[flutter_tools] fix pm serve ipv6 linklocal addr issue (#55664) 2020-04-29 09:29:02 -07:00
Jonah Williams 7b1d24216e
[flutter_tools] Make packages not required for local engine (#55882) 2020-04-28 14:53:53 -07:00
James D. Lin b7fd24a7dc
[flutter tools] Move _informUserOfCrash into crash_reporting.dart (#55614) 2020-04-28 10:34:03 -07:00
Jonah Williams c15aa87442
restore quit timeout, adjust some integration test behaviors (#55812) 2020-04-28 10:05:52 -07:00
Jonah Williams ffcf1db3ca
[flutter_tools] reland migrate FlutterViews to package:vm_service (#55797)
Move FlutterView and related RPCs to the package:vm_service implementation. Update some getIsolate calls with catchError to match previous behavior.

- Updates tests that were previously mocking FlutterViews to use real views
- Moves the FlutterView cache from VM to FlutterDevice
- Catch SentinelException during Isolate.kill
2020-04-27 17:41:42 -07:00
Jenn Magder 958ab9336f
Revert "[flutter_tools] reland migrate FlutterView to new vmservice (#55774)" (#55788)
This reverts commit a18e6361cf.
2020-04-27 16:19:25 -07:00
Jonah Williams a18e6361cf
[flutter_tools] reland migrate FlutterView to new vmservice (#55774) 2020-04-27 15:54:59 -07:00
Jenn Magder d40699a3b8
Remove v prefix in doctor version (#55773) 2020-04-27 15:48:22 -07:00
Emmanuel Garcia e524a303a4
Print stdout and stderr when the ssh command failed (#55762) 2020-04-27 15:44:01 -07:00
Christopher Fujino 069dc9c72d
[flutter_tools] catch ProcessException and throw ToolExit during upgrade (#55759) 2020-04-27 15:04:02 -07:00
Jonah Williams 2aa9016652
[flutter_tools] ensure etag headers are ascii (#55704) 2020-04-27 15:02:15 -07:00
michaellee8 34b8f830b8
[flutter_tools] add --dart-define option for fuchsia build (#55715) 2020-04-27 14:59:03 -07:00
Jonah Williams 1ab3878996
[flutter_tools] support --enable-experiment in flutter test (#55564)
Support --enable-experiment in flutter test (for flutter_tester). Required minor change for null safety.
2020-04-27 14:47:43 -07:00
Jonah Williams 07c451fea9
Revert "[flutter_tools] migrate FlutterView to new vm_service (#55341)" (#55772)
This reverts commit 2e50fd75eb.
2020-04-27 14:26:56 -07:00
Jonah Williams 2e50fd75eb
[flutter_tools] migrate FlutterView to new vm_service (#55341)
Move FlutterView and related RPCs to the package:vm_service implementation. Update some getIsolate calls with catchError to match previous behavior.

- Updates tests that were previously mocking FlutterViews to use real views
- Moves the FlutterView cache from VM to FlutterDevice
- Catch SentinelException during Isolate.kill
2020-04-27 14:16:28 -07:00
Jonah Williams dd88b20435
[flutter_tools] quality pass on Linux build (#55556)
- Update the Linux build to support most of the build configuration, though like windows most only make sense for profile/release.
- Ensure VERBOSE_SCRIPT_LOGGING is set when the logger is verbose
- Automatically run pub get like other build commands
2020-04-25 19:02:03 -07:00
Jonah Williams d72eea539e
[flutter_tools] precache and unpack updates for desktop release artifacts (#55510)
- Update windows precache to include placeholder profile/release artifacts
- Update Linux and windows unpack to account for the cpp_client_wrapper code to live separate from the engine binaries
- Cleanup testing in unpack_linux and remove test cases that are covered in build_system_test.dart
2020-04-25 14:27:55 -07:00
Jonah Williams c5554cdf41
[flutter_tools] remove trailing eth info from fuchsia package server (#55617) 2020-04-24 21:35:23 -07:00
Christopher Fujino 4552af155c
[flutter_tools] enable flutter upgrade to support force pushed branches (#55594) 2020-04-24 17:55:16 -07:00
Jonah Williams cf0fcd4536
[flutter_tools] detect ipv6 in fuchsia server url (#55605) 2020-04-24 17:03:04 -07:00
Jonah Williams 35edbe3d9d
Revert "[flutter_tools] fix version tag v stripping (#55385)" (#55577)
This reverts commit c91a3a74ec.
2020-04-24 09:38:49 -07:00
Peter Lauri c91a3a74ec
[flutter_tools] fix version tag v stripping (#55385) 2020-04-24 09:11:54 -07:00
Jonah Williams 2f0d41b2a6
[flutter_tools] set test directory base as additional root, allow running without index.html (#55531) 2020-04-24 09:09:53 -07:00
Christopher Fujino 37ac9015ad
[flutter_tools] check first for stable tag, then dev tag (#55342) 2020-04-23 15:19:27 -07:00
Jonah Williams 543186f105
[flutter_tools] quality pass on windows build (#55436) 2020-04-23 12:29:48 -07:00
Jonah Williams bb683c4cdb
[flutter_tools] fix package config invalidation (#55420) 2020-04-23 11:34:01 -07:00
Jonah Williams 8df0d68633
[flutter_tools] remove globals from pub (#55412) 2020-04-22 16:34:12 -07:00
Jonah Williams 27d11da88f
Revert "[flutter_tools] default tree-shake-icons to enabled and improve performance (#54923)" (#55413)
This reverts commit 0b93a9219b.
2020-04-22 15:43:09 -07:00
xster 72986f7bcf
remove intellij references to the v1 embedding jars now that the v2 embeddings are referenced via maven (#55353) 2020-04-22 13:33:13 -07:00
Jonah Williams 0b93a9219b
[flutter_tools] default tree-shake-icons to enabled and improve performance (#54923) 2020-04-22 13:17:46 -07:00
Jonah Williams c8164dad80
[flutter_tools] migrate windows to assemble (#55187) 2020-04-22 12:26:49 -07:00
Jonah Williams 94ddf56b9e
[flutter_tools] unpin package config and update (#55348) 2020-04-22 10:16:34 -07:00
Jonah Williams f2761b6b04
[flutter_tools] refactor Chrome launch logic to remove globals/statics (#55160) 2020-04-22 01:28:51 -07:00
James D. Lin 566c1d1124
flutter_tools: Prefer using .of() over .from() when possible (#55250)
Prefer using `.of()` (which is statically type-checked) over
`.from()` (which is dynamically type-checked) when possible.
2020-04-21 22:09:50 -07:00
Jonah Williams 0b3f5cfcc0
[flutter_tools] initial support for enable experiment, run, apk, ios, macos (#54617) 2020-04-21 20:39:36 -07:00
Jonah Williams d46da3ae11
[flutter_tools] remove PackageMap and finish PackageConfig migration (#55244) 2020-04-21 19:55:15 -07:00
Katarina Sheremet d8f353af5b
Support tags when running tests from command line (#55152) 2020-04-21 10:35:13 -07:00
Jenn Magder 8109dcc2b4
CrashReportSender dependency injection (#54924) 2020-04-20 15:23:09 -07:00
Jonah Williams 9202e54704
[flutter_tools] move service extensions off of deprecated vm service (#55012) 2020-04-20 15:15:54 -07:00
Jonah Williams b7e30cfc26
[flutter_tools] update compilation to use package config (#54467) 2020-04-20 14:02:49 -07:00
Jonah Williams 77c05f7501
[flutter_tools] check if requireloader is defined (#55085) 2020-04-20 13:02:26 -07:00
Jonah Williams 6a390aa7dc
[flutter_tools] fix type error in symbolize (#55212) 2020-04-20 12:21:44 -07:00
Jonah Williams 9e72bf565e
[flutter_tools] don't compute hashes of well known artifacts (#53848) 2020-04-20 12:21:20 -07:00
Devon Carew f050ee67e6
prettify the flutter web bootstrap file (#55125) 2020-04-20 08:24:50 -07:00
Jenn Magder fc76fc2a96
Move GitHubTemplateCreator into reporting library (#55002) 2020-04-17 10:47:12 -07:00
Anna Gringauze bc1c1b2ff8
Add flag to enable expression evaluation for web (#55003)
* Add flag to enable expression evaluation for web

Added flag --web-enable-expression-evaluation to flutter run commmand
that enables expression evaluation from IDEs for web target. Disabled
by default.

Helps https://github.com/flutter/flutter/issues/54520

* Update packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-04-17 10:42:02 -07:00
Anna Gringauze b69b2a8c9e
Convert expression evaluation exceptions to errors (#54916) 2020-04-17 10:40:02 -07:00
Zachary Anderson bec63a54bf
[flutter_tools] Provide global options with subcommand help text (#54884) 2020-04-17 08:54:48 -07:00
Jonah Williams bd068f50d5
[flutter_tools] remove bogus same repo check (#54294) 2020-04-16 15:50:03 -07:00
Jonah Williams 4ee618bb72
[flutter_tools] don't elapse real time during fallback test (#54717) 2020-04-16 15:49:08 -07:00
Jonah Williams e6abda7f00
[flutter_tools] remove Isolate implementations of vm_service methods (#54920) 2020-04-16 15:48:21 -07:00
Jenn Magder 66d77ca048
Support armv7s architecture (#54989) 2020-04-16 15:18:33 -07:00
Jenn Magder ce83aaf38d
git pull --ff-only (#54987) 2020-04-16 14:20:48 -07:00
tauu f1d522d503
fixed flutter run for projects containing a watchOS companion (#54959)
Co-authored-by: Georg Wechslberger <wechslbe@ma.tum.de>
2020-04-16 10:58:45 -07:00
Jonah Williams e092dcfa22
[flutter_tools] Reland: fix multiple dart defines (#54973) 2020-04-16 10:56:49 -07:00
Jonah Williams 11ab2fa35c
Revert "[flutter_tools] fix multiple defines in flutter tooling, web (#54909)" (#54967)
This reverts commit b8bd09db21.
2020-04-16 08:33:16 -07:00
Jonah Williams b8bd09db21
[flutter_tools] fix multiple defines in flutter tooling, web (#54909) 2020-04-15 22:25:32 -07:00
Jonah Williams ac20b614c5
[flutter_tools] ensure EventPrinter handles a null parent (#54918) 2020-04-15 20:10:16 -07:00
Jenn Magder 457972b757
Move doctor into globals (#54912)
* Move doctor into globals

* Fix tests
2020-04-15 19:44:42 -07:00
tauu 56b7c93584
[flutter_tools] fix build for projects with watchOS companion app (#51126)
Co-authored-by: Georg Wechslberger <wechslbe@ma.tum.de>
2020-04-15 12:13:06 -07:00
Jonah Williams c141a53f9a
[flutter_tools] support any as a special web-hostname (#54715) 2020-04-15 10:55:01 -07:00
Jonah Williams b6262e7c1c
[flutter_tools] remove runFromSource, move runInView to vm_service extension (#54700) 2020-04-15 10:35:01 -07:00
Jonah Williams 159710ecc5
[flutter_tools] fix response format of flutterVersion, flutterMemoryInfo (#54786) 2020-04-14 15:37:49 -07:00
Jenn Magder a6b39a230f
Migrate Runner project base configuration (#54691) 2020-04-14 13:01:54 -07:00
Jenn Magder ddf63a8b05
Remove Finder extended attributes from iOS project files (#54488) 2020-04-14 11:07:51 -07:00
Zachary Anderson 57dd045cef
[flutter_tools] Handle empty gzip file on Windows (#54679)
* [flutter_tools] Handle empty gzip file on Windows

* Update packages/flutter_tools/test/general.shard/base/os_test.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update packages/flutter_tools/test/general.shard/base/os_test.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update packages/flutter_tools/test/general.shard/base/os_test.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-04-14 09:42:26 -07:00
Jonah Williams 9cc69d47a5
[flutter_tools] support machine and coverage together but for real (#54692) 2020-04-13 19:00:02 -07:00
Jonah Williams 8ed40ddd4b
[flutter_tools] refactor FlutterManifest to be context-free (#54555) 2020-04-13 18:55:01 -07:00
Jonah Williams 723bc76847
[flutter_tools] update coverage collector to use vmservice api (#54682) 2020-04-13 16:10:02 -07:00
Jonah Williams ee43de0476
[flutter_tools] support enable-experiment in flutter analyze (#54613) 2020-04-13 16:00:03 -07:00
Jonah Williams 9cb9bfbd7c
[flutter_tools] use new output location for the apk (#54328) 2020-04-13 15:55:02 -07:00
Herbert Poul 3441743c5c
[macos] build: add build-number and buid-name arguments (#53928) 2020-04-11 13:20:01 -07:00
Jonah Williams d081364d3c
[flutter_tools] remove indirection around App.framework production (#53853) 2020-04-10 13:34:45 -07:00
Jonah Williams 5adfd38dde
[flutter_tools] Move service methods to VmService extension methods (#54337) 2020-04-10 10:33:07 -07:00
Jonah Williams de84c1e18a
[flutter_tools] attempt to fix benchmark mode test (#54414) 2020-04-10 10:10:04 -07:00
Jenn Magder df63c82c9c
Convert iOS simulator log reader to simctl, use unified logging filters (#54154) 2020-04-09 14:35:01 -07:00
Jonah Williams d390f4d9c6
switch benchmark to isolate runnable (#54374) 2020-04-09 09:48:54 -07:00
Kirill Pertsev d6806392a8
Implements --machine flag for devices command (#50581) 2020-04-09 09:14:16 -07:00
Jonah Williams 74a1b9b33e
[flutter_tools] make verbose macOS builds actually verbose (#54320) 2020-04-09 09:00:44 -07:00
Jonah Williams 0d459f2326
[flutter_tools] Remove packageMap usage and update package_config (#54301)
* remove PackageMap

* Update flutter_web_platform.dart
2020-04-08 21:32:25 -07:00
Jonah Williams cb8bafb38d
[flutter_tools] surgically remove outputs from shared directory (#53962) 2020-04-08 19:09:59 -07:00
Filip Hracek 1593788cd9
Rename GPU thread to raster thread in API docs (#53422) 2020-04-08 18:57:03 -07:00
Jonah Williams cf5e4b544e
[flutter_tools] fix routing test (#54313) 2020-04-08 14:53:19 -07:00
Jonah Williams 412e4dd50e
[flutter_tools] migrate devfs web to package_config (#54299) 2020-04-08 14:41:11 -07:00
Christopher Fujino 19c8948e61
Fix frameworkVersionFor for flutter doctor and usage (#54217) 2020-04-08 12:47:05 -07:00
Jonah Williams 4851888864
[flutter_tools] Migrate to package:vm_service 4: trigonometric boogaloo (#54132) 2020-04-08 12:33:33 -07:00
Zachary Anderson 090fc5cc53
[flutter_tools] Use gzip level 1 for devfs transfer compression (#54123) 2020-04-08 09:07:02 -07:00
Jonah Williams fa35698ee3
[flutter_tools] allow passing non-config inputs (#54228) 2020-04-08 09:04:32 -07:00
Danny Tuppeny 589b14d841
Add a switch to use WebSockets for web debug proxy (#54083) 2020-04-08 09:02:03 -07:00
Jonah Williams 981afe39ae
[flutter_tools] ensure build fails if asset files are missing (#54233)
Ensure build fails if asset files are missing and that stderr messages are forwarded through Gradle
2020-04-07 19:42:57 -07:00
Jason Simmons c663cd55a7
[flutter_tools] Refresh VM state before executing hot reload (#53960) 2020-04-07 15:41:02 -07:00
Jonah Williams 9c41e57099
[flutter_tools] migrate engine location check (#54208) 2020-04-07 14:05:49 -07:00
Jonah Williams 08fe78fff9
[flutter_tools] write SkSL file to local file (#53859) 2020-04-07 12:17:39 -07:00
Konstantin Scheglov b0492cc976
Fix newly reported prefer_const_constructors lints. (#54176) 2020-04-07 08:59:01 -07:00
Jonah Williams 98e43bc6ae
[flutter_tools] ensure the tool can find SDK manager on windows (#54133) 2020-04-06 13:41:14 -07:00
Alexandre Ardhuin f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
stuartmorgan 2d623278e7
Restructure the Windows app template (#53600)
This moves the app template more toward being a more generic starting
point for any Flutter application, eliminating some hard-code
assumptions about there being a single window/engine pair that is
directly bound to the life of the application:
- Moves the runloop into its own class, making it capable of servicing
  any number of engine instances.
- Moves the logic for setting up a window containing only a Flutter view
  into a window subclass for ease of re-use.
- Makes quit-on-window-close an optional property. (Long term this
  should be even more generic, like a quit-when-last-window-closes
  option, but this is a short-term improvement that removes the binding
  between the runloop and the window).
- Allows for multiple instances of Win32Window to exist without issues
  relating to the window class registration.

Since there are getting to be a non-trivial number of files associated
with the runner, this moves the source into a runner/ directory, as is
already done on some other platforms.

Note that creating multiple Flutter windows at the same time still
doesn't work correctly even with this change, but this addresses some of
the known issues, and makes it easier to test in the future (e.g., for
debugging engine-level issues with multiple instances).

Fixes #45397
2020-04-06 12:24:05 -07:00
Jonah Williams 4037e5069e
[flutter_tools] update asset manifest to use package_config instead of package_map (#53944) 2020-04-06 11:25:05 -07:00
Jenn Magder 602475e56f
Sanitize error message sent to GitHub crash reporter (#53936) 2020-04-06 11:00:22 -07:00
Jonah Williams 61b3361781
Revert "[flutter_tools] Migrate to vm service 3 (reland): electric boogaloo (#53957)" (#54114)
This reverts commit d6b09626f2.
2020-04-06 10:36:14 -07:00
Jonah Williams d6b09626f2
[flutter_tools] Migrate to vm service 3 (reland): electric boogaloo (#53957) 2020-04-06 10:18:41 -07:00
Jonah Williams f9c58bea49
[flutter_tools] also listen to web stderr stream (#53949) 2020-04-04 21:31:55 -07:00
Zachary Anderson fef9d4d7cd
[flutter_tools] Launch DevTools with 'v' (#53902) 2020-04-04 19:51:01 -07:00
Jonah Williams 58acf4e7b0
Revert "[flutter_tools] surgically remove outputs from shared directory (#53773)" (#53956)
This reverts commit 8a3bede1d3.
2020-04-03 14:22:37 -07:00
Jonah Williams 8a3bede1d3
[flutter_tools] surgically remove outputs from shared directory (#53773) 2020-04-03 14:11:01 -07:00
Jonah Williams 66f4907754
Revert "[flutter_tools] update to package vm_service: electric boogaloo (#53809)" (#53951)
This reverts commit 66d7a6c266.
2020-04-03 14:00:07 -07:00
Jonah Williams 1e86c1fb12
[flutter_tools] re-enable debug extension (#53765) 2020-04-03 13:26:15 -07:00
Jonah Williams 66d7a6c266
[flutter_tools] update to package vm_service: electric boogaloo (#53809) 2020-04-03 12:38:56 -07:00
Francisco Magdaleno e012752634
[flutter_tools] Don't generate native registrant classes if no pluginClass is defined (#53785) 2020-04-03 11:51:01 -07:00
Jenn Magder 85ad699865
Remove URL shortening from GitHub reporter similar issues URL (#53882) 2020-04-03 10:32:55 -07:00
Christopher Fujino 2396616e09
Support old and new git release tag formats (#53715) 2020-04-03 09:39:28 -07:00
Jenn Magder 77ea848c46
Inject Usage dependency into FallbackDiscovery and BuildEvent (#53443)
* Usage dependency injection

* Review edits
2020-04-02 10:57:37 -07:00
Zachary Anderson 6fddb7ee8c
[flutter_tools] Handle full device when creating a temp directory (#53691) 2020-04-02 10:31:03 -07:00
Anna Gringauze 3a0d837741
Enable expression evaluation in debugger for web platform (#53595) 2020-04-02 10:26:03 -07:00
stuartmorgan 445b5a14f2
Precache platform filter change (#53701)
Makes the following changes to the behavior of precache:
- The --all-platforms flags now fetches all artifacts, rather than just
  turning off platform filtering of selected artifacts.
- Explicitly requested artifacts are no longer subject to platform
  filtering. E.g., 'precache --ios' will download iOS artifacts on
  Windows and Linux (but 'precache' without an 'ios' flag will still
  only download iOS artifacts on macOS).
- Desktop platform artifacts now respect the bypassing of platform
  filtering.

Fixes #53272
2020-04-01 10:54:59 -07:00
Lau Ching Jun 587b622396
Fuchsia device is ephemeral. (#53717) 2020-04-01 00:51:02 -07:00
Jonah Williams bb5c340066
[flutter_tools] cache the base URL as index.html (#53666) 2020-04-01 00:36:02 -07:00
Jenn Magder ad07c4041a
Delete unused NDK location checks (#53694) 2020-03-31 14:53:49 -07:00
Mubarak Imam df90bb5fd6
fix issue with multiple java runtimes on macOS (#52474) 2020-03-31 11:36:01 -07:00
Jonah Williams 7bf74c3460
[flutter_tools] handle unsafe build outputs (#53601) 2020-03-31 11:01:01 -07:00
stuartmorgan a2d62df3ee
Use feature flags for desktop cache (#53608) 2020-03-30 21:51:48 -07:00
Jonah Williams 72343ee0e4
[flutter_tools] refactor build_system and targets to be context-free (#53268) 2020-03-30 12:51:04 -07:00
Jonah Williams 4605b51a7e
[flutter_tools] use package Uuid consistently (#53492) 2020-03-30 12:46:06 -07:00
Dan Field c8efcb632b
Only fetch tags when not on dev/beta/stable (#53450) 2020-03-27 22:31:01 -07:00
Jonah Williams dfc3318e87
[flutter_tools] dont create synthetic sdk when running consumer-only (#53466) 2020-03-27 22:25:09 -07:00
Jonah Williams 8403930d41
[flutter_tools] unpin SDK deps when upgrading packages (#53429) 2020-03-27 22:11:01 -07:00
Jenn Magder ce40fbaf51
Include metadata in GitHub crash template (#53118) 2020-03-27 16:21:45 -07:00
Jenn Magder 57b0ddbd60
Uninstall app flag (#53385) 2020-03-27 10:13:54 -07:00
Jonah Williams be3a4b37b3
[flutter_tools] don't trim log messages from the web (#53379) 2020-03-26 18:08:05 -07:00
Dmitry Borodin 5a3e7e4366
Updated obsolete URL (#52158) 2020-03-26 14:34:00 -07:00
Zachary Anderson 9d97918c60
[flutter_tools] Prepare for OSError to implement Exception (#53258) 2020-03-26 09:51:01 -07:00
Jenn Magder 8a9023522c
Push iMobileDevice and iosDeploy instantiation into XCDevice constructor (#53307) 2020-03-25 18:12:13 -07:00
Jonah Williams e23c4796a3
Expose extra frontend options through build apk/ios/macOS (#53273)
This will allow experimenting with the remove to string transformer before we're ready to turn it on by default. This doesn't work for web yet since we use dart2js instead of the frontend_server for producing kernel
2020-03-25 16:56:41 -07:00
xster 1376746237
Reland #53153 to attach to existing modules and apps for Android (#53289) 2020-03-25 16:45:49 -07:00
Angjie Li 6083f15805
Allow user to specify which Chrome binary to use. (#53275)
* Allow user to specify which Chrome binary to use.
2020-03-25 15:55:32 -07:00
Jenn Magder ee3920c208
Remove SimControl from context (#53304) 2020-03-25 15:40:42 -07:00
Jenn Magder ba57ea09d1
Revert "Move processUtils into globals (#53209)" (#53301) 2020-03-25 14:59:03 -07:00
Jenn Magder 86389be66e
Convert CocoaPods tests to testWithoutContext (#53291) 2020-03-25 13:27:10 -07:00
Jenn Magder ec3653f41d
Remove XcodeValidator from context (#53213) 2020-03-25 11:57:05 -07:00
Dan Field 31175eb008
Revert "Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)" (#53269) 2020-03-25 11:26:02 -07:00
Jenn Magder 9ccac00599
Move processUtils into globals (#53209) 2020-03-25 11:23:08 -07:00
Michael Thomsen 29913c9011
Expose new pub outdated command (#53251) 2020-03-25 11:21:03 -07:00
Jenn Magder b860a3912b
Increase xcdevice timeout to 2 seconds (#53184) 2020-03-25 11:14:22 -07:00
Jenn Magder 207efd4cee
Convert idevicescreenshot and upgradePbxProjWithFlutterAssets tests to testWithoutContext (#53208) 2020-03-25 11:14:00 -07:00
Zachary Anderson 52e4011a3a
[flutter_tool] Timeout the Azure bot detector http request (#53217) 2020-03-25 11:11:03 -07:00
Jenn Magder b684041bb8
Revert "Let flutter attach find the service port by looking through old logs again (#53153)" (#53282)
This reverts commit 0c5ffdc9ef.
2020-03-25 10:53:45 -07:00
xster 0c5ffdc9ef
Let flutter attach find the service port by looking through old logs again (#53153) 2020-03-24 23:26:01 -07:00
Leaf Petersen 6563b0de34
Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)
This reverts commit 6c7c2e372a.
2020-03-24 23:02:41 -07:00
Leaf Petersen 6c7c2e372a
Replace uses of deprecated CastError with TypeError (#53221) 2020-03-24 22:11:46 -07:00
Jenn Magder c93847d187
Remove IOSDeploy from globals, hoist to XCDevice constructor (#53203) 2020-03-24 16:50:35 -07:00
Jenn Magder 778c2ce923
Convert some code_signing_tests to testWithoutContext (#53142) 2020-03-24 15:30:35 -07:00
Jenn Magder 151c8db7dc
Remove dead vmservice.RPCError catch (#53193) 2020-03-24 13:35:29 -07:00
Jonah Williams 8e492fa845
[flutter_tools] fix type error with AppDomain current directory (#53181) 2020-03-24 12:58:40 -07:00
Jonah Williams b5cd3ce854
[flutter_tools] test and catch more exception types in web runner (#53183) 2020-03-24 12:58:30 -07:00
Devon Carew d6614dbafd
save and restore the chrome session local storage information (#53030)
save and restore the chrome session local storage information
2020-03-24 12:20:13 -07:00
Jenn Magder c9323bdccd
Convert cocoapods_validator_test to testWithoutContext (#53177) 2020-03-24 11:34:57 -07:00
Jenn Magder 70c651b0a4
Move BuildSystem to globals (#53139) 2020-03-24 11:23:10 -07:00
Jenn Magder 0b321e6715
Remove IMobileDevice from globals, hoist to XCDevice constructor (#53144)
* Convert ios_device_logger_test.dart to testWithoutContext

* Remove IMobileDevice from globals, hoist to XCDevice constructor
2020-03-24 11:22:54 -07:00
Lasse R.H. Nielsen af5194dbfd
Prepare Flutter for SDK changes to runZoned. (#52953)
The `runZoned` method deprecates the `onError` parameter.
Invocations using that parameter must use `runZonedGuarded` instead.

This prepares Flutter for the deprecation. The same places need to be migrated to using
`runZonedGuarded` when the SDK change has been ported to Flutter.
Then the deprecated member will be removed in a follow-up CL when the most important
packages have been migrated.
2020-03-24 08:34:17 -07:00
Jonah Williams 10571920c0
[flutter_tools] update to latest dwds API (#52936)
Should fix issues introduced in web-server device and allow loading org-dartlang-app URIs
2020-03-23 18:47:50 -07:00
stuartmorgan 685e9d1e47
Add pre-stable support for create on Windows (#51895)
Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.

Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.

Fixes #30704
2020-03-23 10:42:26 -07:00
Jonah Williams b1664a27d9
ensure default value for report timings (#52978) 2020-03-20 14:30:33 -07:00
Jonah Williams 441665e21a
[flutter_tools] split logger test and create log reader testing interface (#52934) 2020-03-20 13:46:39 -07:00
Jonah Williams 590f22ce82
[flutter_tools] restore report timings functionality to build aot (#52918) 2020-03-20 13:46:19 -07:00
Christopher Fujino 7d1fbcae1a
Refactor exits happy (#52916) 2020-03-20 13:05:19 -07:00
Jonah Williams a13c9cfc48
[flutter_tools] fix toFilePath called on null (#52931)
In certain circumstances, the .packages file or dart cache could be missing - since the tool runs from a snapshot this is otherwise fine.
2020-03-19 22:20:15 -07:00
Jonah Williams 62c9c89d6b
[flutter_tools] split start app android tests into new file (#52906) 2020-03-19 16:53:19 -07:00
Kirill Pertsev bae2f2c108
Enables log reader on iOS Simulator to (rudimentary) process multiline messages (#52452) 2020-03-19 15:41:39 -07:00
Jason Simmons bbc9d4f3a6
Do not check the executable status of gen_snapshot if it has not yet been downloaded (#52574) 2020-03-19 15:01:02 -07:00
Jonah Williams b21e780aee
[flutter_tools] refactor AotBuilder, removing globals and duplicated kernel compilation (#52896)
Reland of #52091
2020-03-19 14:52:42 -07:00