Commit graph

16193 commits

Author SHA1 Message Date
Mouad Debbar ba70e0e074
Print correct hostname when web server is launched (#42531) 2019-10-14 09:54:36 -07:00
Alexey Ivanov 8cc9a53ee3 Improve routers performance (#42526) 2019-10-14 09:25:00 -07:00
Shi-Hao Hong 877c6a62d0
Localization refresh (#42025)
* Refresh .arb files

* Refresh localizations
2019-10-14 09:07:06 -07:00
Jonah Williams 04e04ffa95
Deflake wildcard asset test (#42597) 2019-10-14 08:49:02 -07:00
Justin McCandless e7ffac2d67
Fix typo in docs: EdgeInserts->EdgeInsets (#42445) 2019-10-14 08:45:57 -07:00
Keshava Muraari 19899db223 Default colorScheme data in ButtonThemeData (Fix for #38655) (#39627)
* Set default colorScheme for ButtonThemeData
2019-10-14 08:40:02 -07:00
Greg Spencer dee7583908
Only dismiss dropdowns if the orientation changes, not the size. (#42482)
This changes the DropDownButton so that instead of dismissing itself when any metrics change occurs, it only dismisses itself when the orientation changes.

This gets around the fact that we can't currently have a dropdown and a text field on the same page because the keyboard disappearing when the dropdown gets focus causes a metrics change, and the dropdown immediately disappears when activated.

It still will cause the keyboard to jump up and down between controls, but that's a larger issue. At least now we can use the two together again.
2019-10-14 08:00:11 -07:00
chunhtai 9423a01204
fix flutter error report correct local widget (#41224) 2019-10-13 18:41:22 -07:00
Emmanuel Garcia 532a8fed41
Print message and log event when app isn't using AndroidX (#42548) 2019-10-12 18:58:22 -07:00
Dan Field 3fea2838df
Skip test (#42557) 2019-10-11 16:18:00 -07:00
Greg Spencer 8a2762c19e
Revert "Roll engine eed171ff3538..00f330068d3e (5 commits) (#42541)" (#42551)
This reverts commit e76160703f because it breaks the framework build.
2019-10-11 14:14:51 -07:00
Dan Field de499c2a93
Gradient transform (#42484) 2019-10-11 13:40:16 -07:00
engine-flutter-autoroll e76160703f
Roll engine eed171ff3538..00f330068d3e (5 commits) (#42541)
git@github.com:flutter/engine.git/compare/eed171ff3538...00f330068d3e

git log eed171ff3538..00f330068d3e --no-merges --oneline
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from U4IBp... to ShVbh... (flutter/engine#13092)
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fk6ou... to LsxeL... (flutter/engine#13083)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6c2b2bb02402..df640e6d14a5 (1 commits) (flutter/engine#13080)
2019-10-11 dnfield@google.com Gen package output corrected (flutter/engine#13086)
2019-10-11 dnfield@google.com Print more output when gen_package fails (flutter/engine#13085)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 16:24:43 -04:00
Zachary Anderson af93b6af80
[flutter_tool] Improve yaml font map validation (#42538) 2019-10-11 12:17:37 -07:00
engine-flutter-autoroll 1ada412d1b
Roll engine 8dabfb90a110..eed171ff3538 (2 commits) (#42537)
git@github.com:flutter/engine.git/compare/8dabfb90a110...eed171ff3538

git log 8dabfb90a110..eed171ff3538 --no-merges --oneline
2019-10-11 iska.kaushik@gmail.com [dart_aot_runner] Add rules to generate dart_aot binaries (flutter/engine#13074)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7fd7a8aef06c..6c2b2bb02402 (3 commits) (flutter/engine#13079)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 15:16:43 -04:00
Ian Hickson 08643c41d7
Always fake ProcessManager when you fake Filesystem in tests (#42369)
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Ian Hickson 292519be98
Roll dart package dependencies (#42496) 2019-10-11 11:12:31 -07:00
Jason Simmons db9a035e7c
Wait for isolate start before proceeding with expression evaluation tests (#42464)
Fixes https://github.com/flutter/flutter/issues/42359
2019-10-11 11:04:39 -07:00
Tong Mu 0aafdfa55a
Redo: Rewrite MouseTracker's tracking and notifying algorithm (#42486)
* Revert "Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478)"

This reverts commit eede792923.

* Fix tests
2019-10-11 10:10:56 -07:00
Janice Collins 4dcf1ab828
Update dartdoc to 0.28.7 (#42136) 2019-10-11 08:47:12 -07:00
Dan Field bb7acc1346
add WAKE_LOCK back to abstract method test (#42530) 2019-10-11 08:26:53 -07:00
Jonah Williams 7ab653c6ca
Add error logging to flutter generate (#42209) 2019-10-11 07:16:11 -07:00
Lau Ching Jun 4416c4f8d6 Add Android x64 profile artifacts (#42508) 2019-10-11 06:57:45 -07:00
engine-flutter-autoroll 72d5c1c805
Roll engine a5c1c6813091..8dabfb90a110 (2 commits) (#42503)
git@github.com:flutter/engine.git/compare/a5c1c6813091...8dabfb90a110

git log a5c1c6813091..8dabfb90a110 --no-merges --oneline
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 3GwxH... to U4IBp... (flutter/engine#13078)
2019-10-11 bkonyi@google.com Roll src/third_party/dart 48e93d3d3b..965b8cb1d8 (31 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 03:58:43 -04:00
engine-flutter-autoroll f3cc889e1f
Roll engine e78c3f59c1a1..a5c1c6813091 (4 commits) (#42501)
git@github.com:flutter/engine.git/compare/e78c3f59c1a1...a5c1c6813091

git log e78c3f59c1a1..a5c1c6813091 --no-merges --oneline
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v8utw... to fk6ou... (flutter/engine#13072)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia b484e7ce24c9..7fd7a8aef06c (4 commits) (flutter/engine#13069)
2019-10-11 iska.kaushik@gmail.com Reland dart_aot_runner shims
2019-10-11 iska.kaushik@gmail.com Revert "[dart_aot_runner] Add support for generating dart_aot snapshots (#13071)" (flutter/engine#13075)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 02:46:43 -04:00
engine-flutter-autoroll 124acfb1c5
Roll engine cef6751dba87..e78c3f59c1a1 (2 commits) (#42495)
git@github.com:flutter/engine.git/compare/cef6751dba87...e78c3f59c1a1

git log cef6751dba87..e78c3f59c1a1 --no-merges --oneline
2019-10-11 iska.kaushik@gmail.com [dart_aot_runner] Add support for generating dart_aot snapshots (flutter/engine#13071)
2019-10-10 chinmaygarde@gmail.com Put Metal renderer selection behind runtime flag and plist opt-in. (flutter/engine#13056)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 01:38:43 -04:00
Ian Hickson 53be552ae1
Be more verbose when pub fails (#42187) 2019-10-10 19:37:01 -07:00
Michael Klimushyn 6d18d31b5c
Fix abstract_method_smoke_test flakiness (#42454)
The flake appears to be coming from the Google Maps plugin. This test
just needs a platform view plugin without the interface method
implemented in general, not Maps specifically. Update it here to avoid
the issue in Maps until that's fixed.

Create a very simple platform view implementation that exercises this
potential bug in order to create a minimal test case with less risk of
causing second order issues like depending on any kind of full package
would cause.
2019-10-10 18:23:23 -07:00
Jonah Williams eede792923
Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478) 2019-10-10 16:44:10 -07:00
Jonah Williams 2b635816c6
Wrap dwds in async guard, only catch known error types (#42364) 2019-10-10 16:34:27 -07:00
Jonah Williams 03a45dc383
Add support for Android x86_64 ABI to Flutter (#42401) 2019-10-10 16:34:16 -07:00
Tong Mu 53636374dc
Rewrite MouseTracker's tracking and notifying algorithm (#42031)
* Redesigns the algorithm with which MouseTracker keeps track of states and dispatches events.
2019-10-10 16:28:56 -07:00
Greg Spencer ff2fdf4039
Fix semantics testing now that dropdown can take a11y focus again. (#42475)
Fixes the android_semantics_testing integration test to have the right criteria now that ce15097 has landed.
2019-10-10 15:19:58 -07:00
engine-flutter-autoroll ffcd0cd121
Roll engine 5162413111b8..cef6751dba87 (3 commits) (#42469)
git@github.com:flutter/engine.git/compare/5162413111b8...cef6751dba87

git log 5162413111b8..cef6751dba87 --no-merges --oneline
2019-10-10 chinmaygarde@gmail.com Revert "Test child isolates are terminated when root is shutdown (#13048)" (flutter/engine#13067)
2019-10-10 garyq@google.com Test child isolates are terminated when root is shutdown (flutter/engine#13048)
2019-10-10 chinmaygarde@google.com Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 18:17:43 -04:00
Emmanuel Garcia 6430b440d7
Update docker_builder dependencies (#42462) 2019-10-10 14:14:53 -07:00
engine-flutter-autoroll 89a4fe3a83
Roll engine c8f665c3a7b0..5162413111b8 (2 commits) (#42459)
git@github.com:flutter/engine.git/compare/c8f665c3a7b0...5162413111b8

git log c8f665c3a7b0..5162413111b8 --no-merges --oneline
2019-10-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 69537d798994..b484e7ce24c9 (8 commits) (flutter/engine#13065)
2019-10-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from xd5Jj... to 3GwxH... (flutter/engine#13064)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 16:51:43 -04:00
Greg Spencer ce1509714c
Re-land keyboard traversal PRs (#42278)
This attempts to reland #40186 and #41220, that were reverted in #41945.

The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.

I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)

Fixes #40101
2019-10-10 13:49:33 -07:00
Shi-Hao Hong a95a84ebfb
Revert removing DropdownMenuItem hint/disabledHint wrapper (#42456) 2019-10-10 13:43:28 -07:00
Emmanuel Garcia 53cc59f82c
Add transitive dependencies back (#42441) 2019-10-10 12:47:34 -07:00
Tong Mu a71d69ba67
Add opacity control to MouseRegion. Add findAnnotations to Layer. (#37896)
* Adds a new parameter bool opaque to MouseRegion
* The same to RenderMouseRegion and AnnotatedRegionLayer
* Add findAnnotations to Layer
2019-10-10 12:46:12 -07:00
tauu 6b4a10ae53 PlatformView: recreate surface if the controller changes (#40280)
Currently the surface of a platform view is only created only one when the state of PlatformViewLink is created. When the PlatformViewLink widget changes, the PlatformViewController in the corresponding state is also updated. Just the surface is not updated even though it depends on the controller.

This PR changes this behavior to recreate the surface whenever the controller is updated.
2019-10-10 12:27:20 -07:00
engine-flutter-autoroll 75f7546388
Roll engine 0b6aa5e3201a..c8f665c3a7b0 (2 commits) (#42453)
git@github.com:flutter/engine.git/compare/0b6aa5e3201a...c8f665c3a7b0

git log 0b6aa5e3201a..c8f665c3a7b0 --no-merges --oneline
2019-10-10 jason-simmons@users.noreply.github.com Allow embedders to disable causal async stacks in the Dart VM (flutter/engine#13004)
2019-10-10 jason-simmons@users.noreply.github.com Integration with more of Skia's SkShaper/SkParagraph APIs (flutter/engine#13008)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 15:20:43 -04:00
engine-flutter-autoroll 6a63ef7d81
Roll engine a05803a0d2ba..0b6aa5e3201a (2 commits) (#42443)
git@github.com:flutter/engine.git/compare/a05803a0d2ba...0b6aa5e3201a

git log a05803a0d2ba..0b6aa5e3201a --no-merges --oneline
2019-10-10 yjbanov@google.com Add "felt clean" command (flutter/engine#13042)
2019-10-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0fc9b3829b47..69537d798994 (1 commits) (flutter/engine#13061)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 13:49:43 -04:00
Gary Qian d62565a5f0
Add font fallback clarification docs (#42365) 2019-10-10 13:48:09 -04:00
Ryan Macnak 2a40c2ddb5
Pass -Ddart.developer.causal_async_stacks=true to frontend_server invocations. (#42354)
Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
2019-10-10 10:41:24 -07:00
Darren Austin 812e0387c3
TextStyle.fontFamily should override fontFamily parameter in ThemeData constructor. (#42366)
Also updated the documentation for the ThemeData constructor to include
descriptions of parameters that don't map to specific fields directly.
2019-10-10 10:39:41 -07:00
Michael Klimushyn 29bfb11c04
Partial deflaking of abstract_method_smoke_test (#42379)
1. The platform code to show the keyboard wasn't working on certain
devices. From my testing it appears to be related to when the code was
firing. IMM won't show the soft input (or shows and then immediately
hides it, it's hard to tell) if it's called before the Flutter UI is
loaded. Change this to instead show the soft keyboard after a message
from Flutter that main() has been started.

2. A text field was visible in the UI, and the test was run under a
fuzzer that random tapped portions of the screen. Remove the text field
so that the fuzzer can't accidentally open the keyboard on its own at a
random time.

3. The keyboard was left open even after the app was closed. Also toggle
the input off when the app was closed, so that this test can be ran
multiple times in succession relatively hermetically.
2019-10-10 10:36:24 -07:00
Sahil Soni ff15a39c07 [BUG] Process all children of intent-filter instead of just the first one to identify default activity (#40029) 2019-10-10 10:05:43 -07:00
engine-flutter-autoroll 7e46192dc2
Roll engine d25a623d7f90..a05803a0d2ba (2 commits) (#42438)
git@github.com:flutter/engine.git/compare/d25a623d7f90...a05803a0d2ba

git log d25a623d7f90..a05803a0d2ba --no-merges --oneline
2019-10-10 dnfield@google.com Android targets create final zip artifacts (flutter/engine#13059)
2019-10-10 sjindel@google.com Remove use of the blobs snapshot format from unittests (flutter/engine#12563)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 12:26:43 -04:00
engine-flutter-autoroll 166fd5975d
d25a623d7 Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw... (flutter/engine#13060) (#42425)
git@github.com:flutter/engine.git/compare/5a8605444187...d25a623d7f90

git log 5a8605444187..d25a623d7f90 --no-merges --oneline
2019-10-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from QIjex... to v8utw... (flutter/engine#13060)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-10 11:04:43 -04:00