Commit graph

2796 commits

Author SHA1 Message Date
Hans Muller 1a08ce7400
Updated the remaining obsolete button references in flutter_gallery (#67437) 2020-10-06 13:21:08 -07:00
Jenn Magder e5131fa31b
Increase device discovery timeout in devicelab health check (#67337) 2020-10-06 12:23:02 -07:00
keyonghan 74c3ea4d41
Remove deployment to play store for linux case in deploy_gallery test (#67349) 2020-10-05 19:12:02 -07:00
Ming Lyu (CareF) 277a72e3fe
move resampler to handlePointerEvent and fix complex_layout_android__scroll_smoothness with PointerEvent (#66745) 2020-10-05 17:17:03 -07:00
Jonah Williams ddb01a0c81
[null-safety] add integration tests for sound null safety modes, add support for sound null safety in dart2js (#67171)
Add integration tests to verify that ddc and dart2js can be built and run in sound mode. Updates dart2js compilation to insert a language version comment into the generated entrypoint if necessary.

dart-lang/sdk#42253
2020-10-02 21:52:38 -07:00
Dan Field 33fb35e951
Add benchmark/test for drawing images across frames (#67176) 2020-10-02 16:41:49 -07:00
Ming Lyu (CareF) 76c0d69b14
migrate textfield_perf to e2e (#64503) 2020-10-02 14:47:03 -07:00
Yuqian Li e45157fc08
5x startup test repitition to reduce noise (#67147) 2020-10-02 12:22:05 -07:00
Ming Lyu (CareF) db2532a949
migrate color_filter_and_fade_perf (#64484) 2020-10-01 17:32:02 -07:00
Yuqian Li b92d250116
Let perf tests measure memory by default (#66570)
Fixes https://github.com/flutter/flutter/issues/66569
2020-10-01 15:20:17 -07:00
Jacob MacDonald b95c3d7d56
update stack_trace dep (and others) (#67057) 2020-10-01 09:54:07 -07:00
Michael Goderbauer 19e07d2beb
Migrate flutter_test (#66663) 2020-09-30 17:03:40 -07:00
Ming Lyu (CareF) 07e56d4893
fix smoothness (#66611) 2020-09-29 17:27:03 -07:00
Chris Yang 2d26bafec2
remove --trace-startup (#66568) 2020-09-29 17:22:04 -07:00
Ben Konyi 65a81c7cd3
Roll package:dds to 1.4.0 and update error handling (#66836) 2020-09-29 10:28:17 -07:00
Yuqian Li 4728892753
Roll gallery to the newest version (#66693)
The previously broken test should be fixed by
https://github.com/flutter/gallery/pull/331
2020-09-28 22:45:54 -07:00
Yuqian Li 04152f82d5
Mark nonflaky tests as such (#66595) 2020-09-28 10:26:52 -07:00
Yuqian Li 54ac7bc936
Reland "Default measureCpuGpu to true (#66386)" (#66604)
This reverts commit 2d9e500523.

In addition, this fixes broken Android tests of the original PR.
2020-09-28 10:26:35 -07:00
Jenn Magder 65159afb55
Force plugins to inherit minimum iOS version from Flutter app (#66590) 2020-09-28 10:14:47 -07:00
Jonah Williams 14722d3166
[gallery] add linux and windows files to gallery example (#66736)
Check in linux and windows platform code now that they are stable, so that we could use in devicelab in the future. Removed the ICO from the windows example to avoid analysis check, and since it won't be important for benchmarking or UI tests
2020-09-28 10:07:35 -07:00
godofredoc fd0e223b74
Add Firebase tests to flutter dashboard. (#66677)
This PR also enables firebase tests on presubmit and removes code that
won't be used anymore from test runner.

Bug:
  https://github.com/flutter/infra/pull/225
2020-09-25 14:26:39 -07:00
Jason Simmons e6b9b5efb7
Add a compressionState value to HttpResponse mocks (#66679)
The Dart SDK now requires non-null enum values if the enum is used in an
exhaustive switch statement on a non-nullable type.

See https://github.com/flutter/flutter/issues/66674
2020-09-25 14:14:45 -07:00
Yuqian Li 3e8fb33c08
Revert "Roll gallery to the newest version (#66584)" (#66666)
This reverts commit 2ae09caace.
2020-09-25 12:18:28 -07:00
godofredoc 4eedca089f
Make Gradle plugin light apk test blocking again. (#66587) 2020-09-25 11:17:03 -07:00
Yuqian Li 2ae09caace
Roll gallery to the newest version (#66584)
This shouldn't break our tests as
https://github.com/flutter/gallery/issues/275 is closed.
2020-09-25 11:05:33 -07:00
Android Dev Notes ace7860e41
Fix typos (#66029) 2020-09-25 11:41:37 +02:00
Jenn Magder a6a8a14d02
Do not cleanup Gradle in non-Android integration tests (#66487) 2020-09-24 18:34:07 -07:00
Yuqian Li 2d9e500523
Revert "Default measureCpuGpu to true (#66386)" (#66594)
This reverts commit 48ce83a833.
2020-09-24 15:17:57 -07:00
Yuqian Li 48ce83a833
Default measureCpuGpu to true (#66386) 2020-09-24 13:42:03 -07:00
Will Larche ee6d4c6590
[Docs] [Material] Fix Icons api docs (#66508)
* [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs.

* Better documentation and that special awful case.

* Couple more places to remove.
2020-09-24 15:18:10 -04:00
Darren Austin 11f7ff0049
Complete the migration to the TextSelectionTheme by deprecating the opt-in flag and text selection properties in ThemeData. (#66482) 2020-09-24 12:13:00 -07:00
Jonah Williams 90d83e37a6
[flutter_tools] register service worker after first frame event (#66082)
Registering the service worker immediately after the documented has loaded may cause SW initialization to compete with framework initialization. It was recommended to us that we defer the service worker setup until after the framework is done with setup, which should be sometime after the first frame.

To implement this, I augmented the binding setup to dispatch an event on the document after the binding has initialized. I don't see any obvious risks with this setup.

Fixes #66066
2020-09-23 18:58:05 -07:00
godofredoc 57cda51f7e
Fix gradle_plugin_light_apk test. (#66496) 2020-09-23 16:52:02 -07:00
Jonah Williams fb8163260c
[devicelab] increase timeout for cull bench (#66481) 2020-09-23 12:34:00 -07:00
Greg Spencer bbd7b97664
Change the default visual density to be adaptive based on platform. (#66370)
Based on feedback from various desktop developers, and to be consistent between the defaults and the sample code, this PR switches the default for visual density in desktop themes to be compact instead of standard.

It also removes the same setting from the sample code generated by "flutter create" because it is no longer needed now that it is the default.
2020-09-23 11:14:58 -07:00
Jacob MacDonald 9cee75ba61
update to the latest null safe packages (#66384)
Updates all null safe dependencies to versions that allow 2.10 stable and 2.11 dev releases.

Also updates flutter_goldens and flutter_goldens_client to allow 2.11 dev.
2020-09-23 11:03:29 -07:00
Ming Lyu (CareF) f681fcf32b
migrate backdrop_filter_perf (#64482) 2020-09-22 19:52:02 -07:00
Jonah Williams f1472e1fc4
[flutter_tools] only lock if an upgrade/download will be performed (linux/macos) and output building messages to stderr (#65422)
Currently an invocation of flutter/dart will always attempt to acquire a lock. This can pose problems for tools that attempt to run multiple dart/flutter instances.

Instead update the lock logic (on Linux/macOS) so that we only attempt to acquire it if an update/snapshot needs to be performed. To avoid repeatedly performing downloads/snapshots if multiple flutter/dart invocations are fired off concurrently when an update needs to be performed, do a second check of the download/snapshot condition after the lock is released.

Additionally, moves all of the building/debug output to stderr on both the bash and batch scripts. This allows machine mode consumption of the tool to ignore needing to parse/handle the rebuild messages.
2020-09-22 17:44:08 -07:00
Jenn Magder d5b715d7cb
Stream logging from attached debugger on iOS 13+ (#66399) 2020-09-22 17:16:45 -07:00
Dan Field de85509171
Mark Windows gradle_plugin_light_apk_test as flaky (#66391)
This test is failing and was recently added.
2020-09-22 14:49:43 -07:00
Michael Goderbauer 923eb765f0
Bump dartdoc to 0.34.0 (#66048) 2020-09-22 12:57:13 -07:00
Jenn Magder 68fd603dd0
Revert "Turn off flutter_gallery__transition_perf_e2e_ios32 in devicelab (#66187)" (#66302) 2020-09-22 12:22:06 -07:00
godofredoc 35c8f19f1e
Fix windows hostonly_devicelab tests. (#66195) 2020-09-22 12:07:05 -07:00
Dan Field 7eb8447485
Allow new methods to be added to ui.Image for tests (#65876)
Remove fake image implementations, add createTestImage to flutter_test
2020-09-22 11:55:39 -07:00
Yuqian Li 3907e490a0
Mark animated_placeholder_perf__e2e nonflaky (#66284) 2020-09-21 15:27:07 -07:00
Yegor 905feb7771
roll source_span 1.8.0-nullsafety.2 (#66290) 2020-09-21 15:02:07 -07:00
godofredoc cfe53fd3c5
Enable linux and win hostonly devicelab tests. (#66085) 2020-09-21 11:27:06 -07:00
Jonah Williams 36a6ef6486
[devicelab] fix manifest definition (#66277) 2020-09-21 11:02:30 -07:00
Jonah Williams 689ca09cd0
[versions] update to latest source span and roll engine to 4b8477d11573d233e6791204191c0090f733b05d (#66136) 2020-09-19 11:22:07 -07:00
Jenn Magder ae630b42a6
Turn off flutter_gallery__transition_perf_e2e_ios32 in devicelab (#66187) 2020-09-19 10:58:44 -07:00
Darren Austin 4253e42b43
Add .DS_Store to ignore list for the analyzer to run on macos cleanly. (#65530) 2020-09-18 14:37:04 -07:00
chunhtai 70f21de9de
reland always adds alert label for alert dialog in Android (#66057) 2020-09-17 16:17:05 -07:00
godofredoc 8cb09cf44b
Enable pre/post submit hostonly tests. (#65985) 2020-09-17 15:32:09 -07:00
Jonah Williams b1d17c914d
Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor (#66043)
We've gotten feedback that the VelocityTracker change was disruptive, though it did not break any of the flutter framework or customer tests. In order to make the change non-breaking, PointerDeviceKind parameter can be made optional.

Nevertheless, this parameter should be provided so that the existing touch handlers can use more accurate gestures on mouse/stylus inputs, so we can encourage this by deprecating the default constructor and pointing users towards the VelocityTracker.withKind constructor that takes a non-optional parameter
2020-09-17 15:18:31 -07:00
Jenn Magder c61c8f303b
Check that header exists instead of content (#65961) 2020-09-17 15:17:31 -07:00
Ben Konyi fb08acf10c
Roll packages to fix #66038 (#66052)
PR #65873 enabled DDS for non-web Flutter applications. This change
surfaced a bug where DDS would not send ServiceRegistered events to VM
service clients when they subscribed to the Service stream. This would
cause tools and tests that rely on these events (e.g., hot reload in
VSCode) to fail.

Fixes #66038.
2020-09-17 12:28:49 -07:00
Ben Konyi a17b330980
Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#65873)
This reverts commit 66b01c1f29.

* Add DDS ipv6 support

* Use --dds-port for DDS instead of hijacking --host-vmservice-port
2020-09-16 16:27:42 -07:00
Michael R Fairhurst 7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Yuqian Li 82e459fcf3
Mark nonflaky tests as such (#65898) 2020-09-16 14:12:05 -07:00
Hans Muller 3e6384b4f1
Updated references to obsolete Material button classes in microbenchmarks (#65950) 2020-09-16 14:10:51 -07:00
George Wright bb2ab8838a
[manual roll] Roll Engine from 1ef10b240e28 to f84e7a019663 (12 revisions) (#65949) 2020-09-16 11:22:02 -07:00
Hans Muller 82706d730b
Updated references to obsolete Material button classes in benchmarks/macrobenchmarks (#65900) 2020-09-16 07:57:04 -07:00
godofredoc 24b2b55c20
Enable mac sdk tests and remove them from cirrus. (#65896) 2020-09-16 07:52:04 -07:00
Ming Lyu (CareF) b3f19a3e1a
migrate animated_placeholder_perf (#64478) 2020-09-16 07:47:03 -07:00
Tong Mu a48e14308e
Expose GestureBinding.handlePointerEvent, replacing dispatchEvent as the preferred way to dispatch events (#64846) 2020-09-15 22:17:06 -07:00
Greg Spencer 199a7c1964
Fix the character field of the RawKeyEvent to hold correct data on non-Android platforms. (#65667)
This fixes a problem where the character field of the RawKeyEvent was not being set at all for non-Android platforms.

I also updated the key maps, and corrected a problem with the Windows key map where the backquote character wasn't correctly mapped.
2020-09-15 13:02:16 -07:00
Yuqian Li b8a39c15f8
Collect memory metrics (#65798) 2020-09-15 12:47:05 -07:00
Jenn Magder 7e27b140f0
Avoid thinning frameworks in iOS extensions (#65198) 2020-09-15 11:10:25 -07:00
Jonah Williams b88f308af7
[flutter_tools] port deprecated settings test to flutter integration shard (#65806)
Port the deprecated settings devicelab test to tool integration shard. Tests that apps can be built using the deprecated android/settings.gradle file.

Part of #65790
2020-09-15 10:55:07 -07:00
Hans Muller 0e4cca4f69
Updated references to obsolete Material button classes in benchmarks/test_apps/stocks (#65799) 2020-09-14 19:22:06 -07:00
Jonah Williams 4e20f00053
[ci] remove create offline tests (#65791)
Currently these tests are taking CI time without providing any value, because there is no verification that network connectivity is avoided. This is better covered by a unit test that verifies that --offline is passed to pub.
2020-09-14 17:54:59 -07:00
Jenn Magder 7e41425d4a
Match benchmark iOS project bundle identifiers (#65793) 2020-09-14 14:31:56 -07:00
Greg Spencer 94592acb71
Creates a way to test private APIs in the Flutter package. (#65505) 2020-09-13 15:52:03 -07:00
Ming Lyu (CareF) 51f1c98490
migrate cubic_bezier_perf to e2e (#64487) 2020-09-11 20:02:03 -07:00
Tong Mu 87617e4cc3
New benchmark: bench_mouse_region_mixed_grid_hover (#63808)
* Adds a new web benchmark bench_mouse_region_mixed_grid_hover
2020-09-11 18:05:15 -07:00
Yuqian Li e1eddb401d
Revert the revert (#65602) 2020-09-11 16:20:03 -07:00
godofredoc 53f9653e6b
Add mac builders to try configurations. (#65578) 2020-09-10 20:20:04 -07:00
Ben Konyi 577de1c44e
Roll forward package:test to 1.16.0-nullsafety.4 to prepare for (#65571) 2020-09-10 15:55:03 -07:00
xster 65ae30c8cc
Update create templates to 1.0.0 (#65234) 2020-09-10 12:57:56 -07:00
godofredoc f246a8ce8b
Add mac builder in prod. (#65566) 2020-09-10 12:50:10 -07:00
Chris Yang ad5370e43c
mark as flaky (#65577) 2020-09-10 12:48:00 -07:00
godofredoc 9e315985d0
Remove mac prod builder. (#65481)
This is in preparation to enable the new mac builders.

Bug:
  https://github.com/flutter/flutter/issues/65223
2020-09-09 09:47:46 -07:00
Tong Wu abeaf11829
[devicelab] Remove ~/.gradle after each devicelab task run (#65434) 2020-09-09 01:50:03 -07:00
Yuqian Li 46d1aba2e2
Remove flutter_gallery_ios32__transition_perf test (#65415) 2020-09-08 15:55:12 -07:00
Jonah Williams 29898812d4
[framework] make hit slop based on device pointer kind for drag/pan/scale gestures (#64267)
Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.

One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.

This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.

This PR does not adjust:

kTouchSlop used in scroll_physics.dart's minFlingDistance
kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
2020-09-08 15:53:36 -07:00
Ian Hickson e10bdbbd9d
Fix RangeMaintainingScrollPhysics (#65135) 2020-09-07 11:40:03 -07:00
Jim Graham 9f4d4a5c59
re-enable the post_backdrop_filter test with CPU/GPU measurements (#65201) 2020-09-04 18:00:02 -07:00
Yuqian Li d7d1461f75
Increase simple animation delay and duration (#64002)
Previously, the CPU/GPU measurement using gauge happened after the
driver test is done. Now, the measurement happens within the driver
test. So we need to properly increase the delay and duration to get a
comparable reading as the old gauge measurements.
2020-09-03 13:25:19 -07:00
Yuqian Li 1135002b0f
Mark nonflaky tests as such (#65054)
Those 2 tests have been green for the last 10 runs
2020-09-03 12:46:24 -07:00
Shi-Hao Hong b80b432555
Move gen_l10n into flutter_tools (#65025) 2020-09-03 09:26:58 -07:00
Jenn Magder ace54425e0
Add observatory Bonjour service to built iOS Info.plist bundle (#65138) 2020-09-02 18:47:56 -07:00
Jenn Magder 259deec221
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (#65138)" (#65141)
This reverts commit 5e0aa8b9fc.
2020-09-02 18:31:45 -07:00
Jenn Magder 5e0aa8b9fc
Add observatory Bonjour service to built iOS Info.plist bundle (#65138) 2020-09-02 17:57:43 -07:00
gaaclarke 37de94d7d2
devicelab: started averaging startup time for ios test (#64978) 2020-09-02 16:35:03 -07:00
Jenn Magder 2e67bf2e32
Require xcode_backend.sh arguments (introduced in Flutter v0.0.7) (#65124) 2020-09-02 16:33:26 -07:00
Jenn Magder cb819504f3
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (#64988)" (#65109)
This reverts commit 4fde217dea.
2020-09-02 12:31:17 -07:00
Christopher Fujino 237c0ab424
Delete catalog generator android/ios tests (#64977) 2020-09-02 11:25:04 -07:00
Yuqian Li 484f3f2646
Add FrameTiming delay to watchPerformance (#64780) 2020-09-02 11:15:08 -07:00
Pedro Massango 7fdd9218b0
Proposal: deprecate autovalidate parameter of the Form, FormField and TextFormField widget (#61648) 2020-09-02 11:15:05 -07:00
Jenn Magder 4fde217dea
Add observatory Bonjour service to built iOS Info.plist bundle (#64988) 2020-09-02 11:11:07 -07:00