Commit graph

8988 commits

Author SHA1 Message Date
sjindel-google db9fe3f827
Fix text field clipping when erasing rapidly. (#23894)
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.

This fixes #22288 and #14121
2018-11-04 03:20:44 +01:00
jslavitz a4a0ff9ab4
Makes FlexibleSpaceBarSettings public (#23803)
* Makes FlexibleSpaceSettingsPublic and adds a test
2018-11-02 17:38:38 -07:00
Yegor f03b00706f
code readability: fix awkward variable shadowing (#23886) 2018-11-02 17:07:00 -07:00
Hans Muller dd30efa190
Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888)
This reverts commit 76a1abd4c7.
2018-11-02 15:32:02 -07:00
Hans Muller 76a1abd4c7
Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00
Jonah Williams d52f315c35
Add new benchmark to track cost of dependencies to a User (#23856) 2018-11-02 13:38:54 -07:00
Jason Simmons 36b9983212
Dartdoc comment for FontLoader.loadFont (#23882) 2018-11-02 13:22:09 -07:00
jslavitz 3aa104fe60
Allows progress indicator height to be controlled by parent (#23540)
* Adds functionality for progress indicator height to be controlled by the parent.
2018-11-02 09:50:14 -07:00
Jason Simmons 00565c2dda
An API for dynamically loading fonts (#23595)
See https://github.com/flutter/flutter/issues/17910
2018-11-02 09:44:26 -07:00
liyuqian 744b872f65
Add unit tests to mutate layer fields (#23599)
So we're sure that:
1. We won't break the API by not allowing to mutate fields
2. We won't forget to markNeedsAddToScene after mutation
2018-11-02 08:02:22 -07:00
Alexandre Ardhuin 6c32c15f3c
add some const classes (#21954) 2018-11-02 14:25:06 +01:00
Jonah Williams d80999d6b8
Support attach on fuchsia devices (#23436) 2018-11-01 20:04:52 -07:00
Alexander Aprelev 47f62109d2
Specify UDID for idevicelistener. (#23854)
This is needed to run flutter app on multiple iOS devices at a time.
2018-11-01 20:04:42 -07:00
Jonah Williams 0b35937b13
Revert "Flutter gallery: updated Shrine demo (#23539)" (#23848)
This reverts commit 949cfcf172.
2018-11-01 19:30:11 -07:00
Hans Muller 949cfcf172
Flutter gallery: updated Shrine demo (#23539) 2018-11-01 12:48:24 -07:00
Amir Hardon fe503dc4ba
Add creation parameters to UiKitView. (#23800) 2018-11-01 11:14:43 -07:00
Yegor 072cd94839
call hapticFunction directly (#23830) 2018-11-01 10:35:09 -07:00
Jonah Williams aac5b04858
CupertinoPicker semantics (#23551) 2018-11-01 10:20:19 -07:00
Stefano Rodriguez a9b8796a60 Use maybePop in place of pop in ModalBarrier dismiss interaction (#22023)
* Use maybePop in place of pop in ModalBarrier
2018-11-01 09:45:13 -07:00
jslavitz 0d68fccc1e
Add DropDownButtonFormField convenience class (#23611)
* Adds DropDownFormField Convenience Class
2018-10-31 17:14:25 -07:00
Dan Field fd6b2e198c
Re-reland Xcode backend refactor (#23762)
* Use Xcode build configurations to drive Flutter build mode

* Proper check wrt local_engine, print error if profile mode misisng

* Remove unused code, update tests, fix template problem, update warning

* fix up warning

* add explanatory dev comment

* fix whitespace

* missing words, change lambda arrow to function body

* error indentation

* Test early exits for xcode_backend.sh

* only on macOS, use right test

* Update error messages

* case insensitive compare for build config

* Update gallery podfile

* update projects to add profile configuration

* make compatible with flavors

* add missing plist files

* add FLUTTER_FRAMEWORK_DIR back, set swift version for profile, tell Podfile about profile
2018-10-31 16:37:53 -07:00
Michael Goderbauer fab109cef5
endTemplate -> endtemplate (#23785) 2018-10-31 16:26:01 -07:00
Michael Goderbauer 5a57d80cb7
Simple doc fix (#23753) 2018-10-31 16:24:59 -07:00
jslavitz a63ed4e391
Scaffold drawer fix (#23689)
* Adds drawer state query functions
2018-10-31 16:23:44 -07:00
Amir Hardon 8de86d412e
Re-land "Initial framework support for iOS platform views." (#23781)
Re-landing #23412 with a fix to the PlatformLayer's addToScene signature.

#23412 was broken by the change to Layer done in #23434.

It seemed green as the presubmits were done before #23434 was landed, and when #23412 landed it broke the build.

Reverts #23779
2018-10-31 15:07:09 -07:00
Amir Hardon b20e7a2671
Revert "Initial framework support for iOS platform views. (#23412)" (#23779)
This reverts commit 67ffe1c2cb.
2018-10-31 07:06:05 -07:00
Amir Hardon 67ffe1c2cb
Initial framework support for iOS platform views. (#23412)
This PR adds the full framework stack (layer->render object->widget, and
service) for embedding iOS views with minimal functionality.

I allowed myself to throw the entire framework stack in one PR since we're mostly
mirroring the structure we already established for embedded Android views, so this PR
is a little bigger than usual. I'm happy to break it down to the
different pieces of the stack if reviewers prefer.

Specifically this PR adds:
* A UiKitView widget for embedding a UIView in the widget tree.
* A RenderUiKitView which is the render object for showing a
  UIView.
* A PlatformViewLayer which denotes the position of a UIView in the
  layer tree.
* The iOS platform_views system channel client code in services/platform_views.dart
* Splits the fake platform views controller to an Android and iOS
  controllers.

TBD in following PRs:
* Plumb the layout direction all the way to the platform view (currently
  there is still no engine support for it).
* Integrate with gesture arenas (engine support is still missing as
  well).
2018-10-31 06:01:28 -07:00
MH Johnson 50098f149d
[Material] Theme for Dialogs (#23569)
* [Material] Add dialog theme.

* Address Hans' first round comments.

* Address Hans' Second round comments.

* Fix theme tests

* Address Will's comments, add golden test

* Update goldens

* Custom Border radius 16.0

* Address Hans' Comments

* Second round comments

* fix imports
2018-10-30 22:54:49 -04:00
Greg Spencer 1b9cba4b42
Make sure we refer to 'stable', and not 'release' branch. (#23745) 2018-10-30 16:57:54 -07:00
MH Johnson b8c3e0dbae
[Material] Create TabBarTheme.of constructor (#23702)
* Create TabBarTheme of(...) constructor

* First round comments

* fix imports
2018-10-30 19:13:16 -04:00
Greg Spencer f9c6f30576
Allow users to create samples using flutter create. (#23584)
This adds flutter create --sample which allows users to execute a command which will create a working sample app from samples embedded in the API docs.

The command looks something like this:

flutter create --sample=chip.DeletableChipAttributes.onDeleted mysample
2018-10-30 16:01:14 -07:00
Greg Spencer 4559ae1a6b
Stop wrapping adb, gradle and ios logger output, and update terminal wrapping column dynamically. (#23592)
Subcommand output (gradle, adb, etc) is no longer wrapped, and wrapping notices when the terminal column width changes dynamically now.

Fixes #23267.
Fixes #23266.
2018-10-30 16:00:50 -07:00
jslavitz be7226f08e
Adds sample code to TextFormField (#23680)
* Adds sample code to TextFormField
2018-10-30 13:54:19 -07:00
Devon Carew 72b1a2b895
update the docs for the module template (#23699)
* update the docs for the module template

* update text
2018-10-30 13:30:10 -07:00
Gary Qian 40fc45ace3
Remove '' as countryCode in localization tests (#23709) 2018-10-30 11:33:46 -07:00
jslavitz 503ae8cbfd
Adds Text Direction functionality to the TextField (#23609)
* added textDirection to TextField
2018-10-30 11:21:48 -07:00
Hans Muller 419be22340
More debugCheckHasMaterialLocalizations() asserts (#23740) 2018-10-30 11:08:21 -07:00
Danny Tuppeny a2c9dd8180
Add a hot reload test that modifies code and verifies it executes (#23725) 2018-10-30 16:59:49 +00:00
Hans Muller 06cc1d9ec0
Resolve MaterialApp.locale, WidgetsApp.locale per supportedLocales (#23707) 2018-10-30 09:53:21 -07:00
Dan Field 7217999a9a
Revert "Reland Xcode backend refactor" (#23737)
* Revert "Update templates (#23698)"

This reverts commit 5b0de6d679.

* Revert "Verify that date/number translations exist for all supported languages (#23692)"

This reverts commit 3449edf256.

* Revert "Reland Xcode backend refactor (#23574)"

This reverts commit 7270f2845d.
2018-10-30 09:36:31 -07:00
Ian Hickson 5b0de6d679
Update templates (#23698)
Removes some `new`s and other minor cleanup.
2018-10-30 07:58:41 -07:00
Hans Muller 3449edf256
Verify that date/number translations exist for all supported languages (#23692) 2018-10-30 07:28:00 -07:00
Dan Field 7270f2845d
Reland Xcode backend refactor (#23574)
* Use Xcode build configurations to drive Flutter build mode

* Proper check wrt local_engine, print error if profile mode misisng

* Remove unused code, update tests, fix template problem, update warning

* fix up warning

* add explanatory dev comment

* fix whitespace

* missing words, change lambda arrow to function body

* error indentation

* Test early exits for xcode_backend.sh

* only on macOS, use right test

* Update error messages

* case insensitive compare for build config

* Update gallery podfile

* update projects to add profile configuration

* make compatible with flavors

* add missing plist files
2018-10-30 07:23:19 -07:00
Michael Thomsen 262faf906f
Update template comments (#23665)
* Update template comments

Make template comments consistent with recent tools changes

* Update packages/flutter_tools/templates/app/lib/main.dart.tmpl

Co-Authored-By: mit-mit <mit-mit@users.noreply.github.com>

* Fix merge conflict
2018-10-30 15:06:08 +01:00
Devon Carew e30f9a9447
add explicit const keywords (#23652) 2018-10-29 22:39:40 -07:00
Gary Qian ec5719a1e0
Default locales test for flutter tester. Roll engine 162b2e98c03..7be0217d67969 (#23596)
162b2e98c036a8f8c355fd475dbe0db4f4bc886c..7be0217d6796954694753647b7a757b8e3907f64
7be0217d6 Roll back _countryCode assert - breaking change (#6693)
91a019cfd Fix popSystemNavigator (#6691)
2b2fbf0f6 Add Locale.fromSubtags and support for scriptCode. (#6518)
58c8e30e5 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (#6690)
3b17cfb68 Flutter tester default locales (#6689)
96bbd2b36 Roll buildroot to 11a934e99eaa4aa8e278cd2772aff4f51f1f3c41 (#6687)
0e9defbd6 Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (#6688)
cc686d7ae Don't populate the external view embedder in PaintContext. (#6686)
ab782faa7 Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (#6685)
c4aa8d343 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (#6684)
7352251eb Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (#6683)
3dac47e4d Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (#6682)
2f06a53a8 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (#6681)
a1d7cad70 Fix inconsistent include syntax (#6680)
236661cd8 Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (#6679)
c4f50611d Roll buildroot to pick up Mac toolchain updates. (#6678)
ba8f6aa71 Handle Windows headers defining ERROR to 0 in log levels. (#6677)
505d2a923 Roll buildroot to pick up updates to custom toolchains. (#6674)
6c2a0b3a6 Undefine ERROR in platform_view_layer.cc (#6675)
55e12993a Update FlutterPlugin.h docs, suppress warning for older API (#6672)
f7970048d Attach and position embedded UIVIews (#6614)
df85722fa Plumb the iOS PlatformViewsController into flow. (#6603)
2bfb893cf iOS Embedding Refactor (#6447)
2018-10-29 21:40:45 -07:00
Ian Hickson c319b890b3
Allow ChangeNotifier to be mixed in again (#23631)
Luckily this class didn't actually need to extend its superclass, it
only implements the interface. So we can change `extends` to
`implements` and that's close enough, while allowing the class to be
mixed in again.
2018-10-29 19:44:36 -07:00
Ian Hickson 4a094de290
[H] Cleanup (#23632)
* Avoid abbreviations

* Sample code for AppBar.leading

* Add a test for OverflowBox/FractionallySizedBox

* Minor wording improvements in the text.

The words "note that" here don't really contribute to the flow.
2018-10-29 19:44:00 -07:00
Alexander Aprelev 5fc6b87174
Reland change that speeds up multiple devices hot-reload (#23695)
* Revert "Revert "Run reload asynchronously so that multiple devices can reload in parallel. (#22693)" (#23598)"

This reverts commit 0b68068d6a.

* Fix refreshViews so it sends app-wide(rather than per-isolate) service request.

Sending per-isolate request caused dead-lock in the engine in case of more-than-one ui isolate.
2018-10-29 18:51:57 -07:00
Devon Carew 0dada102fe
remove unnecessary overrides (#23650) 2018-10-29 18:51:29 -07:00