Commit graph

7473 commits

Author SHA1 Message Date
Alexandre Ardhuin da925c7d71 Replace @checked with covariant (#8300)
Fixes #7734
2017-02-21 09:30:22 -08:00
Michael Thomsen 1e1f7703cc Revert "Revert "Update /examples/ to new gradle based build flow (#8173)"" (#8291) 2017-02-21 12:22:26 +00:00
Jakob Andersen 421258baea Remove SHA1 check from AndroidDevice.isAppInstalled() (#8290)
* Remove SHA1 check from AndroidDevice.isAppInstalled()

The docs for isAppInstalled say 'check if a version of the given app is
already installed', however the current code returns true only if it's
the latest build that's installed.

This made sense in the past, when the use pattern was:

  if (!isAppInstalled(...)) installApp(...);

but now the usage is:

  if (isAppInstalled(...)) uninstallApp(...);
  installApp(...);

This has the probably unintended consequence that if you run `flutter
install` or `flutter run` two times in a row with no source changes, the
second invocation will uninstall the app, but the first invocation might
not.

Removing the SHA1 check makes us always uninstall the app if it's
installed.

Fixes #8172
2017-02-21 10:18:12 +01:00
Alexandre Ardhuin 2888139c6b prefer const constructor (#8292) 2017-02-20 14:07:16 -08:00
Jakob Andersen 8b820ccc54 One more fix for finding Android Studio on macOS. (#8288)
Finally found the command to run tests in checked mode on my system. This one should've been caught by the IDE, but wasn't.
2017-02-20 14:27:03 +01:00
Jakob Andersen 0f3cc6e943 Fix finding Android Studio on macOS. (#8287) 2017-02-20 13:19:22 +01:00
Jakob Andersen 77efc38b67 Teach flutter tools to find gradle (#8241)
* Teach flutter tools to find gradle

Flutter tools will now use Gradle from Android Studio, which is now found automatically.

flutter doctor will verify that Android Studio has been installed, and that the included Gradle is at least version 2.14.1.

It is still possible to manually configure the path to Android Studio (flutter config --android-studio-dir=XXX) or Gradle (flutter config --gradle-dir=XXX), but this should only be necessary if they're installed somewhere non-standard.

Only tested on Linux and macOS for now.

Fixes #8131
2017-02-20 11:02:50 +01:00
Adam Barth df149c0b4b PageView should be able to resize from zero (#8286)
When resizing a PageView from 0x0, we weren't sure what the old page
number was because all the pages are collapsed at zero. Now we avoid the
divide by zero and default to the initialPage.

Fixes #8285
2017-02-19 14:12:57 -08:00
Adam Barth 64bae978f1 Add some dartdocs for slivers (#8284) 2017-02-18 21:00:27 -08:00
Adam Barth a8e847aba9 PageView shouldn't crash in zero-size container (#8282)
Previously, we were dividing by zero.

Fixes #8281
2017-02-18 13:38:56 -08:00
Adam Barth 257be181fd Add some more dartdocs (#8259) 2017-02-17 21:38:20 -08:00
Ian Hickson c4127ee60b Fix the transforms for horizontal glows. (#8252)
Also, make all painters have a toString by default.
2017-02-17 20:03:23 -08:00
Adam Barth 4a02afade1 Rev the version of the flutter framework (#8257)
Now that all the breaking scrolling changes are in, this seems like a reasonble
time to rev package:flutter's version number.
2017-02-17 19:55:52 -08:00
Ian Hickson f9c2d7d9aa Introduce a quick way to test across platforms (#8262) 2017-02-17 17:47:49 -08:00
Todd Volkert c233f38291 Update package:test dependencies to 0.12.18+2 (#8247) 2017-02-17 17:35:11 -08:00
Michael Goderbauer 4e531f64c6 make download_android_tools fail when the download fails (#8261) 2017-02-17 16:00:12 -08:00
Adam Barth e0b12ca17e Two becomes one (#8253)
Rename all the "2" classes related to scrolling to remove the "2". Now that the
old scrolling code is gone, we don't need to use the suffix.
2017-02-17 14:06:15 -08:00
Michael Goderbauer e2ff674f31 add windows binaries to allPlatforms (#8250) 2017-02-17 13:40:56 -08:00
Chris Bracken 36e3260bfe Do not attempt to merge non-fat frameworks in Xcode build (#8251)
* Do not attempt to merge non-fat frameworks in Xcode build

During the Xcode build, we strip code irrelevant to the target
architecture in frameworks used by the application. In the case of
non-fat executables, no stripping occurs, so the frameworks can be used
as-is. No merge & replace step is necessary.

* fixup! Do not attempt to merge non-fat frameworks in Xcode build
2017-02-17 13:38:47 -08:00
Ian Hickson 0962dd6a94 More better toStrings and more vigorous smoke testing of gallery (#8237)
* More better toStrings and more vigorous smoke testing of gallery

* Update scroll_controller.dart

* Update sliver.dart
2017-02-17 12:56:25 -08:00
xster 9610ff6b8e Add --start-paused doc (#8233)
* Add --start-paused doc

* correcting > Observatory

* Updating --start-paused option w/feedback
2017-02-17 11:17:05 -08:00
Michael Goderbauer cd8434d931 Refactor how Artifacts are located (#8234)
Artifacts are now located in a central place.
This will enable us to downlaod artifacts when we need them (instead of
downloading them all upfront).
This also makes replacing sky_snapshot with gen_snapshot easier.
2017-02-16 23:10:11 -08:00
Adam Barth cc808cda5c Fix travis_install.sh 2017-02-16 20:49:25 -08:00
Ian Hickson 6303a32d63 Pesto crash (#8238) 2017-02-16 20:44:33 -08:00
Adam Barth a44d3b7f7f Shard Travis job into three pieces (#8232) 2017-02-16 20:40:07 -08:00
Michael Goderbauer a55a745c73 Fail tests with an actionable message when FLUTTER_ROOT is not set (#8236)
Also: Fix some analyzer warnings.
2017-02-16 18:50:28 -08:00
xster d7b0f7db14 Support iOS screenshot 1/2 (#8210)
* Support iOS screenshot 1/3

* Use path.join

* use fs.path instead
2017-02-16 18:35:36 -08:00
Ian Hickson 0736fac441 DrivenScrollActivity._end didn't handle being already disposed (#8219) 2017-02-16 17:15:03 -08:00
Ian Hickson 1bd7dbc2ec Rename "Over-scroll" demo to "Pull to refresh" (#8224)
Fixes https://github.com/flutter/flutter/issues/5935
2017-02-16 17:14:01 -08:00
Phil Quitslund c458fb9d2c Bump Dart SDK to 1.23.0-dev.0.0 (#8222)
* ups pinned `test` to `0.12.15+9` (to play nice w/ the latest analyzer)
* integrates `analyzer` with analysis driver defaulting to ON
2017-02-16 16:50:35 -08:00
Todd Volkert b59982eccd Properly await future when starting app in daemon mode (#8227)
Fixes #8209
2017-02-16 16:46:38 -08:00
Adam Barth 90574b0478 Remove Scrollable1 (#8225)
All the clients have migrated to Scrollable2.
2017-02-16 16:41:24 -08:00
Ryan Macnak 9ec5330f32 Roll engine to ab0953092743319e0dde3a0c8f582d261c232964. (#8223)
Update stack_trace_test.dart for changes to the naming of async body functions.
2017-02-16 16:13:17 -08:00
Ian Hickson 659bc2263d Port RefreshIndicator to slivers (#8218)
This does not attempt to correct any logic, only to port it as written.

The API changed a bit to take into account what is newly available and
no longer available in the new world.
2017-02-16 14:54:34 -08:00
Michael Goderbauer e9af570f1f Enable Gradle Workflow on Windows (#8201)
* Enable Gradle Workflow on Windows

With this the app created by `flutter create` now compiles on Windows.

* Move OS check to gradle file
2017-02-16 14:17:09 -08:00
Jakob Andersen 83b9142468 Fix getMissingPackageHintForPlatform for Gradle-based projects. (#8214) 2017-02-16 13:37:53 -08:00
Adam Barth 527fddc63f Port EditableText to Scrollable2 (#8167) 2017-02-16 13:23:56 -08:00
xster 3985ddbcd4 Move simulator screenshot logic to use simctl (#8216)
* Move simulator screenshot logic to use simctl

* Add simulator screenshot tests
2017-02-16 12:50:27 -08:00
Adam Barth 1773e47b03 Remove a number of old scrolling widgets: (#8212)
- ScrollableList
 - ScrollableLazyList
 - LazyBlock
 - MaterialList

Clients should use ListView instead.
2017-02-15 21:30:51 -08:00
Adam Barth f93daa4f3d Fix issues when correcting the scroll offset (#8211)
Previously, the scroll correction code path was untested. This patch
introduces a test for the code path and fixes two issues with it.
There's likely more work we'll need to do in this area to nail down all
the cases.

Fixes #8155
2017-02-15 21:01:13 -08:00
Ian Hickson 03ae2cf366 Catch crashes during or before coverage collection. (#8207)
This assumes a fix to https://github.com/dart-lang/test/issues/542

The timeout added in this patch is a workaround for https://github.com/dart-lang/coverage/issues/165
2017-02-15 18:50:19 -08:00
Ryan Macnak d784a2378e Revert "Run coverage tests verbosely to help diagnose timeouts. (#8198)" (#8204)
This reverts commit fac9efbacd.

The timeout was fixed by 6795c4ab96.
2017-02-15 18:31:23 -08:00
Todd Volkert 54f79e5aad Roll engine to 8218674d4af35b94cd9844aad3487dcffcdf6423 (#8208)
Fixes #8200
2017-02-15 16:34:54 -08:00
Todd Volkert 0d81bdf54d Unify the format of all objects' inclusion of hashCode in toString() (#8192) 2017-02-15 16:26:49 -08:00
xster e43b40ffd7 .gitignore .DS_Store (#8206) 2017-02-15 15:39:17 -08:00
Todd Volkert 7b8705f5d9 Update analysis options (#8203)
Fixes #7166

Also cleans up from an aborted attempt at #5793
2017-02-15 14:41:54 -08:00
Dan Rubel 7138541d23 new --kernel option for flutter run to use precompiled kernel code (#8191) 2017-02-15 17:37:00 -05:00
Todd Volkert 6795c4ab96 Skip image_decoder_test to unbreak build bots (#8199) 2017-02-15 13:28:07 -08:00
Michael Goderbauer 071efec271 Implements WindowsStdoutLogger (#8189)
Replaces unprintable characters with alternative symbols.
2017-02-15 13:20:17 -08:00
Ryan Macnak fac9efbacd Run coverage tests verbosely to help diagnose timeouts. (#8198) 2017-02-15 12:55:27 -08:00