Commit graph

8611 commits

Author SHA1 Message Date
yjbanov b9d5327919 perf_tests.dart: const constructors; constructors first 2017-05-26 09:44:33 -07:00
yjbanov f59a67707d track debug build times; switch from --profile to --release 2017-05-26 09:44:33 -07:00
Michael Goderbauer 307f3569a2 Include Semantics Node in debugDumpRenderTree, if available (#10338)
Makes debugging semantics easier (e.g. which RenderObject has semantics, where is a SemanticNode seen in the semantic tree comming from, etc).

It's only printed if accessibility is turned on.
2017-05-26 09:31:39 -07:00
Hans Muller f68c6fb814 Fix package_test flakiness, init ensure terminal context entry is set (#10333) 2017-05-25 16:35:38 -07:00
Hans Muller 77c07871b4 Updated sample app production device labs task (#10326) 2017-05-25 13:49:31 -07:00
Hans Muller 3bb76961f6 Fix the devicelab task that generates sample catalog app screenshots, etc (#10324) 2017-05-25 12:52:29 -07:00
Hans Muller b4e41ff7d3 Add a devicelab task that generates sample app screenshots, etc (#10303) 2017-05-25 11:47:36 -07:00
Chris Bracken 9452a3448c Support inactive, suspending AppLifecycleStates (#10306)
* Rolls the engine to 75c74dc463d56e17be10315cfde409010fd8f90b.
* Adds framework support for the `AppLifecycleState.inactive` and `AppLifecycleState.suspending` states.

What are the new states?
------------------------
* `AppLifecycleState.inactive` is emitted on iOS only and corresponds to iOS's foreground inactive state. Current iOS state transitions are:
`resumed` <--> `inactive` <--> `paused`

* `AppLifecycleState.suspending` is currently emitted on Android only and corresponds to the
transition to Android's stopped state. Current Android state transitions are:
`resumed` <--> `paused` --> `suspending` --> `resumed`

These transitions may change in future.

This is a breaking change on iOS
--------------------------------

This changes the semantics of the `AppLifecycleState.paused` state on
iOS. The behaviour associated with this state is unchanged on Android.

For background on iOS application states see the state transition
diagram in the [App Programming Guide for iOS](https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/TheAppLifeCycle/TheAppLifeCycle.html#//apple_ref/doc/uid/TP40007072-CH2-SW6).

On iOS, prior to this change, `AppLifecycleState.paused` corresponded to
a transition to the _foreground inactive_ state. It now corresponds to a
transition to the _background state_. The newly-added
`AppLifecycleState.inactive` state now corresponds to entering the
_foreground inactive_ state, which (currently) has no exact analogue on
Android.

Briefly, the _foreground inactive_ state is the state entered when
switching from an app to the app switcher, receiving a phone call, or
responding to a TouchID request. Apps are permitted to continue
animating/updating views in this state if desired. From the _foreground
inactive_ state, the app may transition back to _active_ (e.g., entering
the app switcher then resuming the app), or to the _background_ state
(e.g., switching to the home screen or another app).

What to change
--------------
If your app does not handle the `AppLifecycleState.paused` state in a
`WidgetsBindingObserver.didChangeAppLifecycleState` implementation, no
changes are required.

If you do handle `AppLifecycleState.paused`, you may additionally wish
to also handle `AppLifecycleState.inactive`. For example, games should
probably pause on entering the app switcher rather than wait to be
backgrounded.

More details
------------
For background on Android application states see the state transition
diagram in the [Android Activity Lifecycle docs](https://developer.android.com/guide/components/activities/activity-lifecycle.html#alc).
2017-05-25 10:52:21 -07:00
jcollins-g 7fb798f5f1 Upgrade dartdoc to 0.12.0 (#10296)
* update the docs css style so the generated dartdoc matches the new flutter.io

* Change to 0.12.0 dartdoc

* Review comment
2017-05-25 09:42:55 -07:00
Chris Bracken 7566f73d0d Simplify MemoryPressureObserver test (#10308) 2017-05-24 18:18:53 -07:00
Hans Muller 07e8a62cc5 Updated removeRoute doc (#10300) 2017-05-24 16:14:09 -07:00
Hans Muller 0cadbce490 Added Navigator.removeRoute() (#10298) 2017-05-24 15:16:03 -07:00
xster 69c2542458 CupertinoTabBar (#10264)
Move some Cupertino colors to a common file. 

Create a CupertinoTabBar widget to mimic iOS looks
2017-05-24 12:23:15 -07:00
Ian Hickson f53d0fece2 Add some documentation for RenderSliver. (#10272) 2017-05-24 11:02:04 -07:00
Ian Hickson 51ba6b377b Fix DecorationImage.centerSlice (#10257)
...and rearrange a bunch of code so that all these arguments/members
are always in the same order.
2017-05-24 10:45:28 -07:00
Jason Simmons 61e938aa1e Avoid divide by zero in scroll thumb rectangle calculations (#10271) 2017-05-24 09:52:09 -07:00
Mikkel Nygaard Ravn 251d83a4b5 Add org option to flutter create (#10290) 2017-05-24 16:19:16 +02:00
Mikkel Nygaard Ravn 6762e86953 Change template indentation to 2 spaces (#10289) 2017-05-24 12:37:23 +02:00
Mikkel Nygaard Ravn 7156fc054e Update hello_world example to new template (#10287) 2017-05-24 10:59:58 +02:00
Mikkel Nygaard Ravn 10f6483003 Add Swift and Kotlin templates (#10259) 2017-05-24 08:22:50 +02:00
Devon Carew 230f108156 expose debugPaintBaselinesEnabled (#10276)
* expose debugPaintBaselinesEnabled

* Update binding.dart

review comments
2017-05-23 21:39:37 -07:00
Ian Hickson d4828986a6 More docs about keys. (#10282)
I added a bunch of sample code to the core Widget subclasses so that
people would see that you are supposed to always include the `key`
argument.
2017-05-23 20:09:13 -07:00
Chris Bracken f1816d6d23 Roll engine to af60e003d06a82310d9d5240fdb6753729edb10f (#10285) 2017-05-23 19:34:18 -07:00
Ian Hickson f9d24f652b More docs. (#10214) 2017-05-23 19:19:00 -07:00
xster 04aeef84db Let iOS flutter run auto-sign default to first profile (#10181)
* Let run default to first profile

* fix

* review notes
2017-05-23 18:05:47 -07:00
xster 437d4ab1c6 Delete the partial pod remains in examples/layer (#10187) 2017-05-23 18:05:16 -07:00
Ian Hickson 59025702db AppBar: fix bugs, add docs, add samples (#10223)
I added some tests for the bug that I fixed.
I added docs for IconButton and AppBar.
I added some new constructors for FractionalOffset.
2017-05-23 17:48:54 -07:00
Hans Muller 04d418beac Correct the initial rendering of non-scrollable dropdown menus (#10255) 2017-05-23 16:55:57 -07:00
Chris Bracken 8046f68a31 Roll engine to 1295b4718b204c627c71d80e309b3d5fea0592b8 (#10279) 2017-05-23 16:42:35 -07:00
Todd Volkert daad83880f Revert "Roll engine to 8b09c7231e0d32ec8aba476dd2b8319a8e5d6a73 (#10262)" (#10269)
This reverts commit 4a9205572b.
2017-05-23 08:01:42 -07:00
Chris Bracken 4a9205572b Roll engine to 8b09c7231e0d32ec8aba476dd2b8319a8e5d6a73 (#10262) 2017-05-22 17:12:02 -07:00
Chris Bracken 49cec4593a Apply minor formatting fixes (#10261) 2017-05-22 17:08:49 -07:00
Chris Bracken dd1456ffbc Make most ios_workflow host tool calls async (#10260)
Does not yet migrate hasIdeviceId since that results in a cascade of
breaking interface changes that's significant enough for a separate
patch.
2017-05-22 16:09:48 -07:00
Michael Goderbauer 9a908f7558 Revert "Partial rollback of #10204" (#10258)
* Revert "Test installation status when ideviceid is not installed (#10254)"

This reverts commit 0e5d4a8771.

* Revert "Partial rollback of #10204 (#10256)"

This reverts commit b291bf5d6a.
2017-05-22 16:06:22 -07:00
Chris Bracken 0e5d4a8771 Test installation status when ideviceid is not installed (#10254)
Ensure that flutter doctor returns a partial installation status when
ideviceid is not installed.
2017-05-22 14:09:37 -07:00
Michael Goderbauer b291bf5d6a Partial rollback of #10204 (#10256)
This broke Fuchsia as they haven't updated to Dart 1.24 yet :(
2017-05-22 13:28:59 -07:00
Todd Volkert aa9c782693 Add initial list of known Android hardware (#10249)
Our emulator detection was based on a simple heuristic that was
failing for the Samsung Galaxy S8. Any heuristic is flawed since
Android devices can report whatever they want to adb, but this
change attempts to tighten the detection by listing known models
(by their ro.hardware property). Again, these values could be
spoofed by emulator system images, but it's less likely to be
an issue than with our previous (and fall-back) heuristic.

Fixes #10203
Related: #10248
2017-05-22 10:47:02 -07:00
Hans Muller e3ae11e879 Updated example gitignore files per the flutter create template (#10251) 2017-05-22 10:31:50 -07:00
Michael Goderbauer d33fd923bf Print locale in flutter doctor (#10204)
This helps to debug encoding issues that are believed to only happen for certain locales (see https://github.com/flutter/flutter/issues/10198 fo example).

DO NOT SUBMIT until Dart SDK has been bumped (https://github.com/flutter/flutter/pull/10110) as this depends on new API.
2017-05-22 10:21:10 -07:00
Phil Quitslund f21abb6ead Bump Dart SDK to 1.24.0-dev.3.0. (#10110)
* Bump Dart SDK to `1.24.0-dev.3.0`.

* Fix (mega) gallery creation.
2017-05-22 10:01:22 -07:00
Ian Hickson d94ae089c7 Give an explicit path to the flutter tool. (#10235)
Maybe this will make the test work in the device lab...
2017-05-22 10:00:59 -07:00
Ian Hickson fbc5f74cad Attempt to de-emphasise the source code section (#10215)
Fixes https://github.com/flutter/flutter/issues/9377
2017-05-22 09:55:40 -07:00
Hans Muller 2a140a7752 Sample Catalog page/screenshot production (#10212) 2017-05-22 08:09:15 -07:00
Rafal Wachol ee34516491 Moved FLUTTER_HOME to FLUTTER_ROOT in gradle plugin (#10100) 2017-05-22 07:50:31 -07:00
xster 40b67bb187 Move icons stuff from material to widget (#10192)
Moved everything icons related except the material icon button and the materialicon font list to widget
2017-05-21 16:57:31 -07:00
Alexander Aprelev 5b1e972948 Filter out '\n' from terminal input. (#10220)
* Remove '\n' from terminal input.

* Use trim instead of replaceAll

* Add unit test

* Cleanup the test

* Fixed lint

* Style adjustments

* Forgotten @override

* Revert "Forgotten @override"

Accidently added extra files.

This reverts commit 0aba24fc8e.

* Just @override change
2017-05-21 15:15:44 -07:00
Chris Bracken 0ec9132248 Roll engine to 5a7e862cbeabdf021374c2b122505a5fcd6ca37b (#10222) 2017-05-20 12:36:50 -07:00
Ian Hickson a2235d910c Switch off my new test since it broke the build (#10231) 2017-05-20 11:23:19 -07:00
Adam Barth 81b76c2bb8 Make CircularProgressIndicator's stroke width configurable (#9794)
Fixes #9062
2017-05-19 21:56:07 -07:00
Ian Hickson ab8202dc5a Track missing dartdocs (#10213)
This will help catch when we accidentally break --dartdocs.
2017-05-19 21:48:51 -07:00