Commit graph

15074 commits

Author SHA1 Message Date
Anna Gringauze d5b1cc5b9f
Disable failing test due to SDK issue (#70485)
* Disable failing test due to SDK issue

* Disable failing debugger and hot reload windows tests
2020-11-13 14:15:31 -08:00
Ian Hickson 8749d95521
Simplify the flutter_web_plugins plugin registration API. (#70337)
In principle this is backwards compatible; I just merged all the classes into one and deprecated everything that became redundant as a result.
2020-11-13 14:05:34 -08:00
Jonah Williams 8436c6ab7e
remove testUsingContext (#70482) 2020-11-13 13:23:03 -08:00
Jonah Williams f98c468317
[flutter_tools] remove unused JSON schema (#70480) 2020-11-13 13:02:40 -08:00
Kate Lovett 477a4241ea
Revert "Actually consume top padding in bottomsheet if scrollcontrolled (#66257)" (#70392) 2020-11-13 12:18:03 -08:00
Jonah Williams a86dab0c40
[flutter_tools] remove automatic doctor from flutter create (#70475) 2020-11-13 11:44:10 -08:00
Michael Goderbauer b555b1a607
Enable test after engine fix (#70469) 2020-11-13 10:13:04 -08:00
Jonah Williams 0a73ecf6df
[flutter_tools] use initially parsed package config for language version, sound mode determination (#70323) 2020-11-13 09:41:11 -08:00
Jonah Williams ed977dd6a4
Revert "[integration_test] Add a run method for proper reporting of test results (#70075)" (#70466)
This reverts commit af5eb3b987.
2020-11-13 09:01:09 -08:00
Jia Hao af5eb3b987
[integration_test] Add a run method for proper reporting of test results (#70075) 2020-11-13 19:57:15 +08:00
Greg Spencer 9860f52ea5
Add casts to widgets_test.dart to fix the engine roll. (#70423) 2020-11-12 18:14:03 -08:00
Greg Spencer b47126df6c
Allow propagation to ancestor actions if actions lower down are disabled (#70404)
Change the semantics of Actions.invoke so that if the action it finds is disabled, then it keeps looking for an ancestor Actions widgets that has a matching intent where the action is not disabled.
2020-11-12 17:15:54 -08:00
Jonah Williams 0b88269807
[flutter_tools] remove branch migration and standardize constructor style for version interface (#70058) 2020-11-12 15:29:03 -08:00
Jenn Magder d11859fee7
Add -miphoneos-version-min=8.0 to App framework stub (#70405) 2020-11-12 15:14:53 -08:00
Darren Austin 1c7e34bb20
Migrate flutter_localizations to null safety. (#68645)
Migrate flutter_localizations to null safety.
2020-11-12 15:13:51 -08:00
Michael Goderbauer cca1215939
Properly initialize RestorationManager in the TestBinding (#70398) 2020-11-12 13:59:05 -08:00
Michael Goderbauer c7f092515c
Fix return type of ContextAction.invoke (#70397) 2020-11-12 13:54:03 -08:00
Jonah Williams 5fedad9173
[flutter_tools] allow using flutter test for testing the tool too (#69911) 2020-11-12 13:52:09 -08:00
Todd Volkert f8d2f58b52
Ignore DismissIntent when barrier is not dismissible (#70156) 2020-11-12 11:45:32 -08:00
Greg Spencer 86f9ab511e
Revert usages of the binding's platformDispatcher to use window instead (#70319)
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.

Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
2020-11-12 11:17:00 -08:00
Hans Muller c6d4a6ef5c
Update OutlinedButton default outline geometry to be backwards compatible (#70393) 2020-11-12 10:36:39 -08:00
Greg Spencer 0937207f5b
Fix Platform channel errors in web tests (#70252) 2020-11-12 10:24:07 -08:00
Jonah Williams 0c79659900
[flutter_tools] make most integration tests null safe (#70334) 2020-11-12 10:23:03 -08:00
Michael Goderbauer b5a4d08962
Intrinsic Width fixes for RenderParagraph (#70236) 2020-11-12 10:19:03 -08:00
Zachary Anderson 3fce16c329
Revert "Default Keyboard ScrollActions with PrimaryScrollController (#69795)" (#70391)
This reverts commit 1f0df54553.
2020-11-12 09:49:12 -08:00
Anna Gringauze edf26e756d
Move web integration tool tests to web.shard (#70226)
* Move web integration tool tests to web.shard

Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.

In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.

* Enabled verbose mode for flaky web_tool_tests

* Split out the test changes to be commited first
2020-11-11 15:42:15 -08:00
J-P Nurmi 153f3d23c3
Fix Editable(Text) shortcuts to respect read-only on desktop (#69891) 2020-11-11 15:34:05 -08:00
Jonah Williams 22ec357bc4
[flutter_tools] make getBuildInfo async (#70320) 2020-11-11 15:33:23 -08:00
Jonah Williams 0f80116a63
[flutter_tools] improve hash performance in build_system (#70065) 2020-11-11 15:31:07 -08:00
Kate Lovett 1f0df54553
Default Keyboard ScrollActions with PrimaryScrollController (#69795) 2020-11-11 15:29:05 -08:00
Omar Emara 273efff072
Correct GtkKeyHelper key codes for the Meta key (#69576) 2020-11-11 15:24:04 -08:00
Jonah Williams a40ee8a3fb
[flutter_tools] migrate .packages to package_config, partial (#70200) 2020-11-11 13:50:41 -08:00
Sanjoli Goyal 5b19328ff0
Update ReorderableListView API docs (#69650)
* Update ReorderableListView API docs

* fixed dart fmt

* added dartpad instead of code sample

* fixed parenthesis error

* Update packages/flutter/lib/src/material/reorderable_list.dart

Co-authored-by: Amit Patil <54329870+Amitpatil215@users.noreply.github.com>

* using reference List.generate instead of generate

* request changes are complete

* space eroors are fixed

* Update ReorderableListView API docs

* fixed dart fmt

* added dartpad instead of code sample

* fixed parenthesis error

* using reference List.generate instead of generate

* Update packages/flutter/lib/src/material/reorderable_list.dart

Co-authored-by: Amit Patil <54329870+Amitpatil215@users.noreply.github.com>

* request changes are complete

* space eroors are fixed

* request changes are completes

Co-authored-by: Amit Patil <54329870+Amitpatil215@users.noreply.github.com>
Co-authored-by: John Ryan <ryjohn@google.com>
2020-11-11 11:28:57 -08:00
Harsh Mehta 600c99213a
AdoptAWidget: Stepper (#70092)
* interactive dartpad sample added

* cleaner code

* removed extra spaces

* minor spaces added

* removed null returns
2020-11-11 10:03:06 -08:00
Chinmay Kabi 6f70a29c36
AdoptAWidget: WillPopScope (#69563)
* Update WillPopScope API Docs

* Update WillPopScope API Docs

* Update WillPopScope API Docs template fix

* Refactoring dartpad sample

* Refactoring dartpad sample

* Remove trailing spaces

* Minor build fix

* Remove space

* Change the dartpad sample and other minor changes

* Change the dartpad example

* Remove trailing character

* refactor code to dart preamble

* adding uncleared variable

* adding uncleared variable

* Implemented requested changes

* Implemented requested changes

* empty commit

* minor changes

Co-authored-by: Chinmay Kabi <chinmaykabi@gmail.com>
2020-11-11 10:01:46 -08:00
MH Johnson 50dc84bc17
[Material] Add support for customizing active + disabled state color for selection controls. (#68831)
* Add new MaterialStateProperty param to selection controls
2020-11-11 12:39:20 -05:00
xster aac980baac
Update cupertino and material translations (#70157) 2020-11-10 20:56:06 -08:00
Michael Goderbauer 786d0306db
Assert for RenderFlex intrinsics if using baseline alignment (#70139) 2020-11-10 14:29:41 -08:00
Jonah Williams fb28ee2860
[flutter_tools] reland: cache pub invocations (#70180)
Disabled caching of pub invocations on flutter drive.
2020-11-10 13:56:36 -08:00
Hans Muller 191d0aa4b6
Revert "AppBar draws its defaults from theme.colorScheme (#69251)" (#70212) 2020-11-10 13:54:04 -08:00
Jonah Williams 0bbd9020ed
[flutter_tools] remove experiment tracking analytics for null safety (#70183) 2020-11-10 12:49:50 -08:00
Jonah Williams 39bc68b6a2
[flutter_tools] dont use autodetect enum for web (#70189) 2020-11-10 12:49:38 -08:00
Jonah Williams 84a8bd3f5a
Revert "[flutter_tools] always use dart to run test script. (#70146)" (#70175)
This reverts commit a90880a8c3.
2020-11-10 05:21:14 -08:00
Jonah Williams a90880a8c3
[flutter_tools] always use dart to run test script. (#70146) 2020-11-10 05:02:56 -08:00
Darren Austin fb63371589
Fix for the ListTile horizontalTitleGap calculation introduced with PR #64222. (#70149) 2020-11-09 18:13:07 -08:00
Jonah Williams dbcd7868a4
[flutter_tools] remove most globals from asset system and remove Cache manipulation in unit tests (#70011) 2020-11-09 18:01:04 -08:00
Jonah Williams 1c4b50ecf1
Revert "[flutter_tools] restore pub caching functionality (#70133)" (#70144)
This reverts commit ff953e4f83.
2020-11-09 16:38:07 -08:00
Jonah Williams 3fb389c75a
[null-safety] implement null-safe autodetection for the web (#70126)
Fixes #69416
Fixes #70121
2020-11-09 16:13:38 -08:00
Jonah Williams ff953e4f83
[flutter_tools] restore pub caching functionality (#70133)
Necessary to work around #70013 (this looks like it will be fixed, but should protect us in the future)

Restores some notion of skipping pub, with differences from the prior implementation:

Off by default, and only used by the flutter command automatic pub get
A single check parameter. Uses the framework version cached per-project instead of a timestamp of the tool, to avoid cases where downloading a prebuilt framework would cause this check to no longer work.
2020-11-09 16:11:55 -08:00
Greg Spencer bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow (#69617)
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate

* remove new test platform dispatchers

* Amend documentation
2020-11-09 15:26:29 -08:00