Commit graph

15938 commits

Author SHA1 Message Date
stuartmorgan d1761f1072
Pass Linux build mode on command line (#41551)
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.

Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.

Fixes #41528
2019-09-30 09:36:40 -07:00
Justin McCandless 67ea92cbca
Fix exception when selecting in TextField (#41326) 2019-09-30 09:24:30 -07:00
Erick Ghaumez d122f09959 Fix the ThemeData.copyWith toggleButtonsTheme argument type (#40994)
* set the copyWith toggleButtonsTheme argument type to ToggleButtonsThemeData

* add a ThemeData.copyWith test
2019-09-30 23:52:35 +08:00
Jonah Williams c8b3c9b727
use IOOverrides to allow inject file system, write test, find bug (#40066) 2019-09-30 08:41:12 -07:00
Zachary Anderson 45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal (#41493)
* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Danny Tuppeny 7e73cd74b1
Fix visibility of web server device when Chrome is not available (#40757)
* Fix visbility of web server device when Chrome is not available

* Add tests

* Update workflow test

* Fix tests to not rely on Chrome being on the underlying machine
2019-09-30 14:45:30 +01:00
Alexander Aprelev 839fdbd2ed
Retry devfs uploads in case they fail. (#41406)
* Retry devfs uploads in case they fail.

Fixes #34959.
2019-09-29 21:32:06 -07:00
Jonah Williams 69af9adeac
Update minimum build_runner version and enable incremental builder (#41499) 2019-09-29 13:01:33 -07:00
liyuqian 3606300bf5
Rename the file to fix the device lab (#41579)
TBR: @goderbauer
2019-09-29 11:51:04 -07:00
liyuqian 9cc29c61df
Reland "Measure iOS CPU/GPU percentage #41426" (#41578)
This reverts commit baea9bf7cc.

Additionally,   we let the test run on mac8 with iphonexs because the test won't run on Xcode 10.1 (mac3-7). Hence we force it to run on mac8 which currently has Xcode 10.2.
2019-09-29 11:33:43 -07:00
liyuqian baea9bf7cc
Revert "Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)" (#41575)
This reverts commit 67b5bdf99b.

Reason: it broke device lab.

TBR: @goderbauer
2019-09-29 10:58:13 -07:00
liyuqian 67b5bdf99b
Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)
This reverts commit f1e7fe8142.

This fix is in https://github.com/flutter/packages/pull/39
2019-09-28 14:24:46 -07:00
Greg Spencer 0223565fd5
Reland changes to Intent.doNothing to avoid analyzer issue (#41477)
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
2019-09-28 08:55:47 -07:00
MH Johnson f4ba8d1a93
[Material] Remove text ripple from TextFields (#41320)
* remove splash logic

* update tests
2019-09-28 11:47:17 -04:00
Greg Spencer 25f2399ba3
Add flutter drive to readme. (#41509)
This adds a description of the command needed to run the driver test
2019-09-28 00:22:37 -07:00
Jonah Williams 07e5cf005c
Reland: Exit resident web runner on compilation failure (#41505) 2019-09-27 18:54:58 -07:00
Jonah Williams 7a487b2cbf
Ensure we find dart.exe on local engines (#41514) 2019-09-27 18:54:24 -07:00
LongCatIsLooong 5f9c262e66
Revert "CupertinoDatePicker & CupertinoTimerPicker dark mode (#39919)" (#41521) 2019-09-27 17:46:15 -07:00
LongCatIsLooong 97b27fafd4
CupertinoDatePicker & CupertinoTimerPicker dark mode (#39919) 2019-09-27 16:03:51 -07:00
Jonah Williams d968b7cfd6
Revert "Dont update last compiled time when compilation is rejected (#41424)" (#41515) 2019-09-27 15:18:06 -07:00
Greg Spencer b9d8918bbb
Revert engine to 5b952f286fc070e99cf192775fa5c9dfe858b692 (#41503)
This reverts the engine to a previous hash because of #41484
2019-09-27 13:19:49 -07:00
Zachary Anderson feaaa5d738
[flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) 2019-09-27 12:18:59 -07:00
Jonah Williams 618fac92c9
Revert "Exit resident web runner on initial compilation failure (#41441)" (#41498) 2019-09-27 11:50:23 -07:00
Christopher Fujino ec3baa8dc9
roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411) 2019-09-27 11:05:06 -07:00
Emmanuel Garcia 2466ca5bb0
Copy Flutter assets before merging the rest of resources (#41333) 2019-09-27 10:53:37 -07:00
krisgiesing 2b138fd7d2
Fix ReorderableListView's use of child keys (#41334) (#41338)
ReorderableListView was constructing a GlobalObjectKey using
the child key as the value. This only had the intended behavior
if the child key was identical across build method invocations.

The new strategy is to scope the child key's value to the
State object's identity, allowing child keys to have value
compare semantics while disambiguating among different list view
instances.
2019-09-27 10:48:42 -07:00
Jonah Williams d7a8dda219
Dont update last compiled time when compilation is rejected (#41424) 2019-09-27 10:32:57 -07:00
Jonah Williams a1852a1993
Exit resident web runner on initial compilation failure (#41441) 2019-09-27 10:32:38 -07:00
Jonah Williams 17feb84043
Revert "e31b2ff64 Roll src/third_party/dart 403c4af720..7901c508c8 (7 commits) (#41455)" (#41480) 2019-09-27 09:26:30 -07:00
Zachary Anderson 716a672bc8
[flutter_tools] Adds tests of mdns analytics events (#41410) 2019-09-27 08:07:26 -07:00
engine-flutter-autoroll 8a2f8adfb0
e31b2ff64 Roll src/third_party/dart 403c4af720..7901c508c8 (7 commits) (#41455)
git@github.com:flutter/engine.git/compare/18bc0b259641...e31b2ff64dc2

git log 18bc0b259641..e31b2ff64dc2 --no-merges --oneline
2019-09-27 bkonyi@google.com Roll src/third_party/dart 403c4af720..7901c508c8 (7 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-27 11:00:41 -04:00
Alexandre Ardhuin f11c34109c
fix bad indentations(mainly around collection literals) (#41355) 2019-09-27 10:46:45 +02:00
engine-flutter-autoroll 62571b4b9f
Roll engine a206557f8fb8..18bc0b259641 (3 commits) (#41452)
git@github.com:flutter/engine.git/compare/a206557f8fb8...18bc0b259641

git log a206557f8fb8..18bc0b259641 --no-merges --oneline
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia b83cc76a5e3a..296743a86281 (1 commits) (flutter/engine#12491)
2019-09-27 bkonyi@google.com Roll src/third_party/dart 327bc451f8..403c4af720 (9 commits)
2019-09-27 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from HfPKR... to zpVtV... (flutter/engine#12473)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-27 04:39:41 -04:00
Greg Spencer 957d839775
Revert "Address previous comments, fix Intent.doNothing. (#41417)" (#41449)
This reverts commit eb3e2f559f because of a suspected analyzer bug.  Reverting to investigate.
2019-09-26 22:45:21 -07:00
engine-flutter-autoroll 4e820cef9d
Roll engine ce6ab8ce25fa..a206557f8fb8 (5 commits) (#41440)
git@github.com:flutter/engine.git/compare/ce6ab8ce25fa...a206557f8fb8

git log ce6ab8ce25fa..a206557f8fb8 --no-merges --oneline
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia ec85f407bfee..b83cc76a5e3a (15 commits) (flutter/engine#12472)
2019-09-27 30870216+gaaclarke@users.noreply.github.com Added a default entrypoint variable to match android syntax. (flutter/engine#12370)
2019-09-26 tauu@h2overclock.de [web_ui] add missing dispose handler for MethodCalls to flutter/platform_view (flutter/engine#12226)
2019-09-26 tauu@h2overclock.de [web_ui] PersistedPlatformView attribute update handling to enable resizing (flutter/engine#12227)
2019-09-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from z3PaM... to HoRV8... (flutter/engine#12471)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 23:51:41 -04:00
Greg Spencer eb3e2f559f
Address previous comments, fix Intent.doNothing. (#41417)
This addresses comments in the original PR (#41245) that introduced Intent.doNothing, adds tests, and fixes an issue with it.
2019-09-26 19:54:28 -07:00
engine-flutter-autoroll b07056b107
ce6ab8ce2 Roll src/third_party/dart 6ff8d2199d..327bc451f8 (12 commits) (#41430)
git@github.com:flutter/engine.git/compare/5b952f286fc0...ce6ab8ce25fa

git log 5b952f286fc0..ce6ab8ce25fa --no-merges --oneline
2019-09-26 bkonyi@google.com Roll src/third_party/dart 6ff8d2199d..327bc451f8 (12 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 22:01:41 -04:00
Devon Carew 1044457225
add tests to ensure the sdk is well-formed (#41408)
add tests to ensure the sdk is well-formed
2019-09-26 18:22:25 -07:00
Hans Muller ecc4764fe2
Revert "Dropdown Menu layout respects menu items intrinsic sizes (#41120)" (#41422)
This reverts commit e47a1dc216.
2019-09-26 17:57:08 -07:00
engine-flutter-autoroll 54578f21f7
Roll engine 0018135a1c28..5b952f286fc0 (3 commits) (#41423)
git@github.com:flutter/engine.git/compare/0018135a1c28...5b952f286fc0

git log 0018135a1c28..5b952f286fc0 --no-merges --oneline
2019-09-26 matthew-carroll@users.noreply.github.com Forwards Flutter View to platform views and detaches when needed. (flutter/engine#12359)
2019-09-26 50856934+nturgut@users.noreply.github.com Reflect selection changes in Firefox for text editing (flutter/engine#12447)
2019-09-26 franciscojma86@gmail.com Adds support for 5 mouse buttons (flutter/engine#12450)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 20:43:41 -04:00
gaaclarke a66ea4f21b
Devicelab run.dart: Fixed check for path equality (#41403)
Fixed check for path equality.  It was too strict, disallowing leading "./".
2019-09-26 17:09:05 -07:00
Jonah Williams efd2ba296b
Flutter build bundle without --precompiled should always perform a debug build. (#41401) 2019-09-26 15:57:57 -07:00
engine-flutter-autoroll 194256cc3c
Roll engine 5b5fd7508c63..0018135a1c28 (3 commits) (#41416)
git@github.com:flutter/engine.git/compare/5b5fd7508c63...0018135a1c28

git log 5b5fd7508c63..0018135a1c28 --no-merges --oneline
2019-09-26 garyq@google.com Make kDoNotResizeDimension public so framework can use it directly (flutter/engine#12448)
2019-09-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 559ffe4a23ce..ec85f407bfee (44 commits) (flutter/engine#12463)
2019-09-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from PyQPO... to YDv3O... (flutter/engine#12462)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 18:49:41 -04:00
engine-flutter-autoroll 26465f4c65
Roll engine b126ba758533..5b5fd7508c63 (2 commits) (#41412)
git@github.com:flutter/engine.git/compare/b126ba758533...5b5fd7508c63

git log b126ba758533..5b5fd7508c63 --no-merges --oneline
2019-09-26 chinmaygarde@google.com Revert "Support accessibility labels on iOS switches. (#12404)" (flutter/engine#12466)
2019-09-26 1036976+brandondiamond@users.noreply.github.com Support accessibility labels on iOS switches. (flutter/engine#12404)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 18:02:41 -04:00
Greg Spencer a085635899
Change the way ActionDispatcher is found. (#41245)
This changes the way ActionDispatchers are found by the Actions widget, so that by default it will look for dispatchers of the parent Actions widgets instead of just creating a default ActionDispatcher. This allows overriding of the ActionDispatcher at the top level: before, the custom action dispatcher would only be invoked if explicitly set on all the Actions widgets.

This is not a breaking change because there was a default value to the dispatcher parameter before that performed this function, and not specifying the dispatcher anywhere will still result in a default dispatcher being created.
2019-09-26 14:31:08 -07:00
Greg Spencer 1a7bb1f583
Added proper focus handling when pushing and popping routes (#40166)
The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped.

This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node.

This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
2019-09-26 14:30:39 -07:00
Jonah Williams c93839131c
Fix timing issues in initialization of web resident runner (#41347) 2019-09-26 14:23:19 -07:00
stuartmorgan 56d68a9071
Add the beginnings of plugin support for Windows and Linux (#41015)
Adds very preliminary support for Windows and Linux plugins:
- Adds those platforms to the new plugin schema, initially supporting just a plugin class.
- Adds C++ plugin registrant generation for any Windows or Linux plugins found.

This doesn't have yet have any build tooling for either platform, so anyone using the generated registrant still needs to do manual build configuration. This reduces the manual work, however, and creates a starting point for future tooling work.

As with all Windows and Linux work at this time, this is not final, and subject to change without warning in the future (e.g., Windows could potentially switch to a C# interface, or
'linux' may change to 'gtk' or 'linux_gtk' in pubspec.yaml).
2019-09-26 14:01:57 -07:00
engine-flutter-autoroll 5a27e1c1ea
b126ba758 Add .mskp file to binary format (flutter/engine#12454) (#41404)
git@github.com:flutter/engine.git/compare/b520d7fd4b6d...b126ba758533

git log b520d7fd4b6d..b126ba758533 --no-merges --oneline
2019-09-26 liyuqian@google.com Add .mskp file to binary format (flutter/engine#12454)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-26 16:58:41 -04:00
Kristin Ho 034358e341 Prevent PointerEnter[or Exit]Event from erasing event.down value (#40637) (#41332)
* MouseRegion documentation claimed that onEnter and onExit
  would track entry and exit regardless of whether the pointer was
  down or up
* It did such, but when grabbing the value of `event.down` from
  the passed event, the value was always `false`
* PointerEnterEvent and PointerExitEvent were overriding the value
  passed from PointerEvent in constructors, even if the value was true
  e.g. in invocations of .fromMouseEvent((PointerMoveEvent...))
* This change now passes the value along to PointerEnter/ExitEvents
  while providing it a default of false, and updates documentation

Fixes #40637
2019-09-26 13:48:40 -07:00