Commit graph

20478 commits

Author SHA1 Message Date
Dan Field 3aa0243ab7
Remove assert about release mode (#64813)
b/150295238 has been resolved for a while now.
2020-08-31 10:03:12 -07:00
Casey Hillers ef3440b8d8
[fuchsia] Test wait for device to be up after pave (#64819) 2020-08-31 09:48:05 -07:00
engine-flutter-autoroll b093edaf7e
506d84882 Roll Skia from 85f51b2a409c to ba1e083d37f6 (1 revision) (flutter/engine#20892) (#64937) 2020-08-31 09:38:04 -07:00
ekibun 719268b43a
add different workload & add -products * to vswhere calls to check both Visual Studio IDE and standalone Build Tools. (#64251) 2020-08-31 09:33:04 -07:00
James Clarke 2d02c70ad5
[Windows] Fix unnecessary surface creation/destruction in startup path (#63301) 2020-08-31 09:28:05 -07:00
engine-flutter-autoroll 6d1242dd4b
784e6d746 Improve the precision of lerpDouble (flutter/engine#20879) (#64934) 2020-08-31 00:53:04 -07:00
Chris Bracken c0ea00ed3f
Prefer moreOrLessEquals over closeTo (#64915)
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
the `matcher` package:

   * It emits the epsilon value in the test result on failure.
   * It uses a named parameter for epsilon, which improves readability
     at the call site.
   * It has a reasonable default for epsilon in cases where something
     more specific isn't required.

Using it also has the nice property that it aids in its own discovery
when when people go looking for such functionality in new tests.

This change also includes a couple unrelated whitespace formatting cleanups.
2020-08-30 22:20:16 -07:00
Shi-Hao Hong fd22fc3e35
[gen_l10n] Synthetic package generation by default (#62395)
* synthetic packages by default in gen_l10n tool

* Refactor default path for synthetic package

* Remove unused import

* Code cleanup

* Further improvements to help text

* Refactor synthetic package path

* Remove newlines

* Test cleanup

* clean up logic in inputs and outputs list function

* Update l10n.yaml usage

* only add option if value is non-null

* Update stocks app as proof of concept for synthetic package usage

* Address nits

* print pubspec contents

* add print statements

* Do not allow null value for useSyntheticPackage

* +

* +

* +

* +

* Cleanup

* Add test

* Fix text

* Dont parse pubspec directly

* Test using context

* WIP: generate synthetic packages on pub get -- needs tests

* Allow null value

* Update null handling

* Refactor to properly handle null case

* Fix yamlMap condition

* Fix yaml node for real

* WIP: struggling to write tests

* WIP - take absolute path as an option

* Add tests

* Use environment project directory for synthetic package generation pathway

* Fix typo

* Improve help text

* Update defaults

* Remove unauthorized path import

* Fix pathing issues at synthetic package generation

* Fix typo in test

* Use path.join so projectDir matches up based on OS

* Fix Windows pathing in test

* Remove unnecessary replaceApp code for projectDir.path

* Use globals.fs.currentDirectory.path in resident_runner_test.dart

* Fix merge conflict

* Add test to ensure that synthetic package is generated on pub get

* Fix resident_runner_test.dart tests

* Fix tests

* Use package:file instead of dart:io

* WIP - exploration

* Remove synthetic package use from stocks example

* Update integration test to not use synthetic packages

* Remove trailing whitespace

* flutter pub get runs synth package generation

* Remove more print statements

* Add license header

* WIP - minimally working pub.get

* Use own MockBuildSystem

* Modify test and implementation to be a little cleaner

* Fix flutter pub get invocation

* Use synthetic packages in stocks app

* Revert "Use synthetic packages in stocks app"

This reverts commit 45bf24903c.

* Add environment and buildSystem params to flutter test

* Address code review feedback

* +

* Isolate codegen into its own API

* Fix imports

* Slight refactor

* Add one more test for no l10n.yaml file

* Remove unneeded mock class and import in pub_get_test.dart

* More code review feedback

* Remove unnecessary imports

* Remove `return await`s that I missed

* use arrow functions instead
2020-08-31 13:19:41 +08:00
Chris Bracken c935a44869
Prefer moreOrLessEquals to closeTo (#64914)
moreOrLessEquals is the preferred mechanism for checking that a value is
within some error bound epsilon, with default value for epsilon of
precisionErrorTolerance.

This patch replaces instances of closeTo using precisionErrorTolerance.
2020-08-30 22:19:16 -07:00
engine-flutter-autoroll 69f40ebed9
bada9fc5f [web] Fix path clip crash when reused (flutter/engine#20846) (#64919) 2020-08-30 21:58:04 -07:00
Chris Bracken 8fa5c55e54
Match lerped values using moreOrLessEquals (#64908)
Several of our tests make use of numbers without an exact floating point
representation (frequently 0.x where x!=5) which, when scaled, also
scale the error. The end result is that some of these tests currently
implicitly rely on an implementation detail of floating point math and
are sensitive to differences in the ~15th decimal place.

This patch reduces the sensitivity of some of these tests, checking
values using `moreOrLessEquals` from the flutter_test package
rather than requiring en exact match.
2020-08-30 19:05:20 -07:00
engine-flutter-autoroll 7a964c3593
1e302a111 Roll Fuchsia Mac SDK from Z0aq5SyVC... to _4kJfDM-L... (flutter/engine#20891) (#64913) 2020-08-30 17:58:02 -07:00
engine-flutter-autoroll 9dd6517041
Roll Engine from 695d4f1f37b9 to d6f1fef151d5 (13 revisions) (#64911) 2020-08-30 16:03:03 -07:00
engine-flutter-autoroll 90028e3f98
695d4f1f3 Roll Skia from 6fd391a016f3 to 5d3314c53ce5 (1 revision) (flutter/engine#20875) (#64870) 2020-08-30 14:58:03 -07:00
Shi-Hao Hong 34541c3073
Revert "A benchmark test case for measuring scroll smoothness (#61998)" (#64883)
This reverts commit 12b7355da1.
2020-08-30 18:42:10 +08:00
Ming Lyu (CareF) 12b7355da1
A benchmark test case for measuring scroll smoothness (#61998) 2020-08-29 04:28:03 -07:00
engine-flutter-autoroll 1d7838a8f0
Roll Engine from c097c2d87572 to 3029dcd93ed4 (2 revisions) (#64853) 2020-08-28 23:03:03 -07:00
LongCatIsLooong fe55dc2b13
Reland "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" reverted in #64091 (#64513) 2020-08-28 22:13:04 -07:00
engine-flutter-autoroll 8ce4f41e58
Roll Engine from 07e2520d5d8f to c097c2d87572 (8 revisions) (#64850) 2020-08-28 21:23:03 -07:00
engine-flutter-autoroll 7a43175198
Roll Engine from 3f4f58f5f3aa to 07e2520d5d8f (3 revisions) (#64838) 2020-08-28 20:18:04 -07:00
Tong Wu 8c2d1c49a2
[Devicelab] Temporarily remove testonly_devicelab_tests builder. (#64837) 2020-08-28 20:13:03 -07:00
Jonah Williams 2436de1391
Revert "Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#64802)" (#64845)
This reverts commit eef0050d08.
2020-08-28 18:02:15 -07:00
engine-flutter-autoroll 366da56fb2
Roll Engine from 569fd1935711 to 3f4f58f5f3aa (19 revisions) (#64809)
* 97f9f712b [web] Fix analyzer warnings in web engine. (flutter/engine#20825)

* dcb9244c3 Consolidate FlRenderer initialization into fl_renderer_start() (flutter/engine#20763)

* 80f68fd60 Roll Fuchsia Linux SDK from lqjGEhKFW... to kbanTZZRS... (flutter/engine#20830)

* 0491b6c7d Roll Fuchsia Mac SDK from fqYfP5y9V... to tG1GErEv9... (flutter/engine#20831)

* 195b1480d Roll Skia from 55f02eb3ff5f to ee58da9d6f49 (7 revisions) (flutter/engine#20832)

* 25a23baee [fuchsia] Add fuchsia_ctl func to test script (flutter/engine#20827)

* 095e5d368 Roll Dart SDK from b0f6d5483b79 to 8e50ccae259f (2 revisions) (flutter/engine#20834)

* be21aa992 Roll Skia from ee58da9d6f49 to 716e281185b5 (2 revisions) (flutter/engine#20835)

* 808f9c27e Roll Skia from 716e281185b5 to 952f088d41e1 (1 revision) (flutter/engine#20839)

* 1a034bde7 Replace FlRenderer::get_visual() with more generic FlRenderer::setup_window_attr() (flutter/engine#20833)

* e67ae1e30 [web] Fix path rendering when addPolygon is chained with other verbs. (flutter/engine#20803)

* 3ccf1ed2e Cliprect op (flutter/engine#20837)

* 52def6e88 Roll Dart SDK from 8e50ccae259f to ac54810c36a9 (1 revision) (flutter/engine#20844)

* 8e16dbf4a Roll Skia from 952f088d41e1 to d385091edd58 (4 revisions) (flutter/engine#20847)

* 81a4748d6 Roll Dart SDK from ac54810c36a9 to 066c5625ac7b (1 revision) (flutter/engine#20849)

* cca047b2c Roll Fuchsia Linux SDK from kbanTZZRS... to jyKllAGRu... (flutter/engine#20851)

* 0208c71ad Roll Fuchsia Mac SDK from tG1GErEv9... to koO5t2tfw... (flutter/engine#20850)

* 5b3a16c5a Roll Dart SDK from 066c5625ac7b to fe5c8c44701e (1 revision) (flutter/engine#20854)

* 3f4f58f5f Roll Skia from d385091edd58 to 8a43e206609e (3 revisions) (flutter/engine#20855)
2020-08-28 16:19:37 -07:00
Ben Konyi eef0050d08
Reland "Re-enable the Dart Development Service (DDS) (#64671)" (#64802)
* Reland "Re-enable the Dart Development Service (DDS) (#64671)"

This reverts commit 2ae25cc2d7.

* Fix MDNS building Observatory URI with port 0 instead of forwarding the device port

* Added MDNS test
2020-08-28 16:18:35 -07:00
callumsteele4 e37b427a2a
Fix Android autofill username hint docs (#64776) 2020-08-28 16:18:06 -07:00
gaowanqiu 619eccd2e3
Fix negative usableCrossAxisExtent in release mode (#64441) 2020-08-28 16:13:05 -07:00
xubaolin c26c2363a0
Slider paint incorrectly when the track shape is rectangular (#64534) 2020-08-28 16:08:10 -07:00
Broccolism f1a2357463
feat: Text constructor, overflow, and softWrap docs (#64175) 2020-08-28 16:08:06 -07:00
Broccolism f690577f88
Update: Documentation for ListView constructor should warn about changing widget list (#63503) 2020-08-28 16:03:04 -07:00
Zachary Anderson dff7ea1c4f
Revert "Avoid thinning frameworks in iOS extensions (#64674)" (#64829)
This reverts commit ce9cde8c4e.
2020-08-28 15:23:22 -07:00
Zachary Anderson 6f02c0b231
Revert "Roll new gallery to help flaky Crane test (#64676)" (#64824)
This reverts commit e825281745.
2020-08-28 13:54:51 -07:00
Ming Lyu (CareF) 3579f1c33e
remove flaky flag (#64770) 2020-08-28 11:08:04 -07:00
engine-flutter-autoroll ab6945f6a5
Roll Engine from 77dd1c05b99d to 569fd1935711 (10 revisions) (#64765) 2020-08-28 11:03:03 -07:00
Paul Berry 60494b4c1e
Remove unnecessary downcasts on numeric operations. (#64760) 2020-08-28 10:58:04 -07:00
Casey Hillers 4a33ce7d53
[fuchsia] Refactor fuchsia_ctl use to a function (#64736) 2020-08-28 10:53:04 -07:00
Yuqian Li e825281745
Roll new gallery to help flaky Crane test (#64676) 2020-08-28 10:48:03 -07:00
Jenn Magder ce9cde8c4e
Avoid thinning frameworks in iOS extensions (#64674) 2020-08-28 10:43:04 -07:00
xubaolin a3fe33af65
The OverscrollIndicator should not overflow the scrollable view's edge (#64239) 2020-08-28 10:38:05 -07:00
Justin McCandless 8f370dff65
SelectableText long press on iOS (#63994) 2020-08-28 10:33:05 -07:00
Ben Konyi 2ae25cc2d7
Revert "Re-enable the Dart Development Service (DDS) (#64671)" (#64797)
This reverts commit d7d12412e5.
2020-08-28 09:00:53 -07:00
Kate Lovett cad4d1333e
Fix Gold json for digest paramset (#64757) 2020-08-27 17:48:05 -07:00
Jonah Williams 5a4fa220e2
[flutter_tools] handle OsError thrown during azure detector (#64749) 2020-08-27 17:13:04 -07:00
engine-flutter-autoroll 36dc3e18ed
Roll Engine from cdf77cac6b1e to 77dd1c05b99d (2 revisions) (#64735) 2020-08-27 17:08:04 -07:00
Matt Carroll 57b6952471
Added support for lerpDuration() (#64668) 2020-08-27 16:48:05 -07:00
chunhtai fbc15384bb
Fixes router to not report route information when it is already up to… (#64596) 2020-08-27 16:43:05 -07:00
Ian Hickson 8a6a76a334
migrate rendering to nullsafety (#64621) 2020-08-27 16:38:10 -07:00
Ming Lyu (CareF) dcdee4bb0d
Add resampler unit test with widget (#64424) 2020-08-27 16:38:05 -07:00
Ben Konyi d7d12412e5
Re-enable the Dart Development Service (DDS) (#64671)
This change re-enables DDS and outputs the DDS URI in place of the VM
service URI on the console. If --disable-dds is not provided,
--host-vmservice-port will be used to determine the port for DDS rather
than the host port for the VM service, which will instead be randomly
chosen.
2020-08-27 16:35:00 -07:00
engine-flutter-autoroll 45495c7eaa
Roll Engine from 388193a67b6b to cdf77cac6b1e (20 revisions) (#64722) 2020-08-27 11:03:03 -07:00
Tong Wu 162d82db1b
Temporarily disable the mac/android test on LUCI. (#64729)
Because the test bed's CPU is too hot.

Bug: https://github.com/flutter/flutter/issues/64723
2020-08-27 10:18:36 -07:00