Commit graph

12242 commits

Author SHA1 Message Date
Dwayne Slater cab7ecb8e5 Fix out of range spring simulation in ClampingScrollSimulation (#22394)
If the scroll is out of range for any reason (for instance, changing scroll physics or manually messing with scroll position), the spring simulation causes the scroll position to slingshot towards the end. Also, before this change, `end` was unused.
2018-10-17 10:49:27 +02:00
Alexandre Ardhuin 936dea28da
enable lint prefer_void_to_null (#23174)
* enable lint prefer_void_to_null

* replace last Null by void
2018-10-17 08:09:29 +02:00
Hans Muller 7a63fac0a2
TextTheme.apply() should not assume non-null TextStyle fields (#23184) 2018-10-16 19:43:52 -07:00
Philip a0010d391c Added sample code for BottomNavigationBar widget [#21136] (#21615)
* Added sample code for BottomNavigationBar widget [#21136]

* bottomnavigationbaritems made single line
2018-10-16 16:54:26 -07:00
Hans Muller cef11417da
Added Mongolian (mn) translations (#23168) 2018-10-16 14:58:02 -07:00
Hans Muller 8521d6334f
Updated Khmer and Turkish translations (#23165) 2018-10-16 14:57:37 -07:00
Janice Collins 24717a3280
Update dartdoc to v0.24.0. (#23175) 2018-10-16 14:40:03 -07:00
Jonah Williams c9ca7c4936
Add override frontend_server snapshot for fuchsia_reload command (#23162) 2018-10-16 14:27:22 -07:00
jslavitz fd02bdf1b5
Fix disabled formfield validation (#23167)
* Fix form field validate method being called if form field is disabled
2018-10-16 14:03:49 -07:00
Francisco Magdaleno d556d2117d Finalize editing when hitting the enter key on a single line TextField (#23015)
Behavior remains the same for multiline TextFields. This behavior already happens on iOS and Android, but not desktop. #23014
2018-10-16 14:02:00 -07:00
Dan Field ffa8a1ebe8
Make it easier to use CocoaPods to Add2App for iOS (#23021)
* Make it easier to Add2App for iOS

* Use local engine if xcconfig says so

* newline
2018-10-16 13:50:20 -07:00
Max Bittker 25e40ba599 fix Curves.bounceInOut math (#22825)
* fix Curves.bounceInOut

* assert maximum slope
2018-10-16 13:49:18 -07:00
Alexandre Ardhuin 0fb84e96c7
Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
Dan Field 5efe095895
Revert "Roll engine to aed6b8c46b05c7cee4506a9757dd9ea1b40583c2." (#23170)
This reverts commit a34488dd67.
2018-10-16 12:57:07 -07:00
Ryan Macnak a34488dd67 Roll engine to aed6b8c46b05c7cee4506a9757dd9ea1b40583c2.
aed6b8c46 Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (#6549)
3ba6270b2 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (#6550)
2018-10-16 11:03:52 -07:00
liyuqian 3c9e9b3410
Revert "Remove mixin so we can roll Google3 (#22819)" (#22926)
This reverts commit c689c97d05.

The Dart analyzer in Google3 has been upgraded so we won't need this.
2018-10-16 11:02:55 -07:00
jslavitz c12b99f282
Adds callback for Long Press Up (#22822)
* add onLongPressUp geasture which is fired when a long-press ends
2018-10-16 10:39:06 -07:00
escamoteur 6b79d37797 Add disabledHint to DropdownButton (#18770)
If `items` or `onChanged` is null the button will be disabled, the down arrow will be grayed out, and
the new `disabledHint` will be shown (if provided).
2018-10-16 10:16:28 -07:00
Amir Hardon 707eaf5edf
Make AndroidView take gesture recognizer factories. (#21657)
Before this PR AndroidView's gestureRecognizers field was a list of
gesture recognizers. This was problematic as when the widget was rebuilt
with the same gesture recognizer instances we would try to re-join the
recognizers to a gesture arena team and crash (as a OneSeqeunceGestureRecognizer
team can only be set once).

With this change, we instead take a set of factories.
This allows AndroidView to create the gesture recognizers just before
adding them to the team, and thus be sure that they are only added once to a
team.

The factories are identified by the type of the object they create, this
allows AndroidView to know when it is given an equivalent set of gesture
recognizer factories, and do nothing in that case.
2018-10-15 21:30:40 -07:00
Mehmet Fidanboylu 16f7d4016e
Remove unneeded flutter-assets-dir flag for the tester (#23125) 2018-10-15 20:12:14 -07:00
engine-flutter-autoroll 9dff83f49d
Roll engine 32f417db0d56..08272ee6aa33 (2 commits) (#23124)
32f417db0d...08272ee6aa

git log 32f417db0d56..08272ee6aa33 --no-merges --oneline
08272ee6a Allow specifying custom toolchains and sysroots for host builds. (flutter/engine#6548)
c6456570a Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-15 21:18:01 -04:00
Jacob Richman c6a222fa28
Revert "Run flutter tests with --track-widget-creation as part of the build. (#22596)" (#23129)
This reverts commit bf92d7f286.
2018-10-15 17:13:44 -07:00
Gary Qian bdc3dda5f2
Add support for text shadows and roll engine (26 commits) (#22449)
* Add support for shadows in text.

* Use dart:ui Shadow as base class for Shadows

* Update lerp definition

* Roll engine 3ffa3629523..84fe4a9f7e24e4 - Text Shadows and update goldens for skia roll.

git log 50c2e69daff4e207c54e463d2304139985c7511c..32f417db0d566d354605305cb29c251276fa65ee --oneline --no-merges
32f417db0 Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541)
4ee77256c Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537)
964acafeb Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536)
d4bae4ca4 Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535)
ff93ccf47 Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534)
a4161c895 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532)
116072e46 Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531)
ef0b0f6e9 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530)
f46b7b971 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529)
9033c3902 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528)
e6887a412 Add missing imports for unicode/utf16.h (#6524)
1242f6dfe Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527)
a1bbea77c Add a no-op platform view layer. (#6505)
2bb3afad8 Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526)
75e875240 Fix the Mac embedder build (#6525)
436f9707b Add version check for dismissable (#6522)
7767c785b Provide a default GL function resolver in the embedder (#6523)
32841dd89 Case-insensitive matching of family names for custom fonts (#6519)
a9076c7e6 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520)
f2e7441b5 An API for loading fonts from a buffer provided by the application (#6508)
05aac0f27 fix ResourceExtractor npe. (#6461)
cf5a2a145 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517)
84fe4a9f7 Re-revert invalid line height tests (#6516)
5f529566c Add support for text shadows (#6385)
e44c10c96 Reland "Share engine layers with the framework" (#6412) (#6468)
ba0449971 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
2018-10-15 15:03:02 -07:00
Jacob Richman bf92d7f286
Run flutter tests with --track-widget-creation as part of the build. (#22596) 2018-10-15 13:46:25 -07:00
Hans Muller 4f4005ee65
TextTheme.apply() corrections (#23108)
TextTheme.apply was incorrectly applying displayColor to the TextTheme's headline, title, subhead, body1, and body2 TextStyle colors. In all cases it should have been bodyColor.
2018-10-15 12:18:13 -07:00
Michael Klimushyn 6fef292f44
Wire decodedCacheRatioCap from PaintingBinding to Codec (#22452)
Users can set `PaintingBinding.decodedCacheRatioCap` to control the max
amount of memory used per image to avoid decoding frames each animation
loop.

This depends on flutter/engine#6310.

Fixes #20998, and fixes #14344
2018-10-15 11:22:27 -07:00
Mouad Debbar 43001a3ab6 Correctly throw when MaterialPageRoute's builder returns null (#22885) 2018-10-15 09:49:16 +02:00
Michael Goderbauer 8e2ca93f52
Remove all service extensions from release mode (#23038)
Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size:

Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB)
APK (compressed): minus 38,136 Bytes (-37.24KB)
iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB)

For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit

**Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
2018-10-12 21:07:55 -07:00
matthew-carroll 04a26778c5
Revert "Reversion for roll (#22984)" (#23029)
This reverts commit 80f80ab08c.
2018-10-12 16:31:34 -07:00
liyuqian 53de41cac6
Roll engine to 50c2e69da with goldens fix (#23016)
Goldens updated due to Skia AA changes. We previously also made a mistake by having a golden test run on MacOS.

git log 3ffa36295234..50c2e69da --no-merges --oneline
50c2e69da Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2a1 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10ad1 Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)
2018-10-12 13:15:25 -07:00
Artur Rymarz a3670a2f85 Add parameters to allow hiding icons and border of the Cupertino TabBar (#22804) 2018-10-12 09:08:57 -07:00
engine-flutter-autoroll 490d369a7f
Roll engine 35ba11eb49e8..3ffa36295234 (1 commits) (#22993)
35ba11eb49...3ffa362952

git log 35ba11eb49e8..3ffa36295234 --no-merges --oneline
3ffa36295 Add a callback for iOS when the first Flutter frame is rendered (flutter/engine#6135)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-12 01:22:17 -04:00
engine-flutter-autoroll c4b72d61a6
Roll engine daf4447a2eb2..35ba11eb49e8 (2 commits) (#22990)
daf4447a2e...35ba11eb49

git log daf4447a2eb2..35ba11eb49e8 --no-merges --oneline
35ba11eb4 Roll src/third_party/skia e7588323d586..2a138544646d (2 commits) (flutter/engine#6510)
f95bad849 Roll src/third_party/skia a631669e50a2..e7588323d586 (8 commits) (flutter/engine#6509)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-12 00:31:17 -04:00
matthew-carroll 80f80ab08c
Reversion for roll (#22984)
For G3 Roll:

* Revert "MaterialButton must honor its minWidth and height parameters (#22919)"

This reverts commit a02332335a.

* Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"

This reverts commit 655bf6a290.

* Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"

This reverts commit a590940e45.

* Revert "Bring TextTheme into alignment with the current Material spec (#22330)"

This reverts commit 8bfb4b3ee5.

* Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"

This reverts commit eea3465ae7.

* Manual adjustments to fix reversion issues.
2018-10-11 18:17:46 -07:00
engine-flutter-autoroll 74d677b58a
Roll engine 9cad7b663ee2..daf4447a2eb2 (3 commits) (#22986)
9cad7b663e...daf4447a2e

git log 9cad7b663ee2..daf4447a2eb2 --no-merges --oneline
daf4447a2 Reland &#34;Allow raster caching any layer subtree (#6442)&#34; (flutter/engine#6507)
c6e6da512 Revert &#34;Allow raster caching any layer subtree (#6442)&#34; (flutter/engine#6506)
6447418f7 Allow raster caching any layer subtree (flutter/engine#6442)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-11 20:51:17 -04:00
jslavitz 673d56d1b7
Fix test template (#22982)
* added test
2018-10-11 16:25:34 -07:00
Greg Spencer ba1323929a
Re-enable docs generation. (#22979) 2018-10-11 15:56:22 -07:00
Jonah Williams 313059cdb6
Add labeled tappable target guideline and gallery tests (#22824) 2018-10-11 15:05:10 -07:00
engine-flutter-autoroll 3188e5c6cf
Roll engine 22522c0b3e69..9cad7b663ee2 (2 commits) (#22978)
22522c0b3e...9cad7b663e

git log 22522c0b3e69..9cad7b663ee2 --no-merges --oneline
9cad7b663 Roll src/third_party/skia 9c37cd96e4c8..a631669e50a2 (12 commits) (flutter/engine#6501)
ee53ae1ea Roll src/third_party/skia 932759e9b414..9c37cd96e4c8 (1 commits) (flutter/engine#6498)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-11 17:56:17 -04:00
Janice Collins 3b68ae8422
Remove extraneous flags from dartdoc invocation (#22972) 2018-10-11 13:27:43 -07:00
Alexandre Ardhuin 0e76cb4c10
prefer_void_to_null in flutter_test (#22847)
* prefer_void_to_null in flutter_test

* fix CI
2018-10-11 18:00:46 +02:00
Jason Simmons dba54316f4 Android API version check for the call to Activity.reportFullyDrawn (#22918) 2018-10-11 08:57:33 -07:00
engine-flutter-autoroll 502697f916
Roll engine 7ea8b9968dce..22522c0b3e69 (1 commits) (#22946)
7ea8b9968d...22522c0b3e

git log 7ea8b9968dce..22522c0b3e69 --no-merges --oneline
22522c0b3 Roll src/third_party/skia f03d4eaa2487..932759e9b414 (2 commits) (flutter/engine#6497)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-11 10:20:23 -04:00
engine-flutter-autoroll 29feac1939
Roll engine f307c7fd070b..7ea8b9968dce (1 commits) (#22939)
f307c7fd07...7ea8b9968d

git log f307c7fd070b..7ea8b9968dce --no-merges --oneline
7ea8b9968 Roll src/third_party/skia 9835dd51b320..f03d4eaa2487 (1 commits) (flutter/engine#6496)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-11 01:24:23 -04:00
engine-flutter-autoroll 7e94d9a5ce
Roll engine daed2b7d61f3..f307c7fd070b (3 commits) (#22936)
daed2b7d61...f307c7fd07

git log daed2b7d61f3..f307c7fd070b --no-merges --oneline
f307c7fd0 Remove VM options that are on by default now. (flutter/engine#6495)
61cf4c01f Pass scriptcode and variantcode to dart:ui Window. (flutter/engine#6493)
0eda0cfd4 Roll src/third_party/skia 04ac46135f23..9835dd51b320 (7 commits) (flutter/engine#6494)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-11 00:28:23 -04:00
Alexander Aprelev e274ed866a [dart] Roll engine to dart roll 2018-10-10 20:45:22 -07:00
Alexander Aprelev fde2347cfe [dart] Roll engine to pre-dart roll 2018-10-10 20:45:22 -07:00
Hans Muller a02332335a MaterialButton must honor its minWidth and height parameters (#22919) 2018-10-10 20:22:07 -07:00
Greg Spencer 081d2a7a86
Re-land text wrapping/color PR (#22831)
This attempts to re-land #22656.

There are two changes from the original:

I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.

I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.

As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.

*     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)

    This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).

    Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.

    Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.

    Since wrapping is now turned on, also removed many redundant '\n's in the code.
2018-10-10 18:17:56 -07:00
Andrew Davies 1531ef60ec
[frdp] Add configurable timeouts for VM. (#22893)
This adds configurable timeouts for the Dart VM. Due to some testing
machines running things quite slowly, this is becoming more necessary.
2018-10-10 16:11:01 -07:00