development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
21864 commits 770 branches 974 tags 1.7 GiB
Commit graph

15320 commits

Author SHA1 Message Date
Kate Lovett 477a4241ea
Revert "Actually consume top padding in bottomsheet if scrollcontrolled (#66257)" (#70392) 2020-11-13 12:18:03 -08:00
Jonah Williams a86dab0c40
[flutter_tools] remove automatic doctor from flutter create (#70475) 2020-11-13 11:44:10 -08:00
Michael Goderbauer b555b1a607
Enable test after engine fix (#70469) 2020-11-13 10:13:04 -08:00
Jonah Williams 0a73ecf6df
[flutter_tools] use initially parsed package config for language version, sound mode determination (#70323) 2020-11-13 09:41:11 -08:00
Jonah Williams ed977dd6a4
Revert "[integration_test] Add a run method for proper reporting of test results (#70075)" (#70466) 
This reverts commit af5eb3b987.
 2020-11-13 09:01:09 -08:00
Jia Hao af5eb3b987
[integration_test] Add a run method for proper reporting of test results (#70075) 2020-11-13 19:57:15 +08:00
Greg Spencer 9860f52ea5
Add casts to widgets_test.dart to fix the engine roll. (#70423) 2020-11-12 18:14:03 -08:00
Greg Spencer b47126df6c
Allow propagation to ancestor actions if actions lower down are disabled (#70404) 
Change the semantics of Actions.invoke so that if the action it finds is disabled, then it keeps looking for an ancestor Actions widgets that has a matching intent where the action is not disabled.
 2020-11-12 17:15:54 -08:00
Jonah Williams 0b88269807
[flutter_tools] remove branch migration and standardize constructor style for version interface (#70058) 2020-11-12 15:29:03 -08:00
Jenn Magder d11859fee7
Add -miphoneos-version-min=8.0 to App framework stub (#70405) 2020-11-12 15:14:53 -08:00
Darren Austin 1c7e34bb20
Migrate flutter_localizations to null safety. (#68645) 
Migrate flutter_localizations to null safety.
 2020-11-12 15:13:51 -08:00
Michael Goderbauer cca1215939
Properly initialize RestorationManager in the TestBinding (#70398) 2020-11-12 13:59:05 -08:00
Michael Goderbauer c7f092515c
Fix return type of ContextAction.invoke (#70397) 2020-11-12 13:54:03 -08:00
Jonah Williams 5fedad9173
[flutter_tools] allow using flutter test for testing the tool too (#69911) 2020-11-12 13:52:09 -08:00
Todd Volkert f8d2f58b52
Ignore DismissIntent when barrier is not dismissible (#70156) 2020-11-12 11:45:32 -08:00
Greg Spencer 86f9ab511e
Revert usages of the binding's platformDispatcher to use window instead (#70319) 
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.

Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
 2020-11-12 11:17:00 -08:00
Hans Muller c6d4a6ef5c
Update OutlinedButton default outline geometry to be backwards compatible (#70393) 2020-11-12 10:36:39 -08:00
Greg Spencer 0937207f5b
Fix Platform channel errors in web tests (#70252) 2020-11-12 10:24:07 -08:00
Jonah Williams 0c79659900
[flutter_tools] make most integration tests null safe (#70334) 2020-11-12 10:23:03 -08:00
Michael Goderbauer b5a4d08962
Intrinsic Width fixes for RenderParagraph (#70236) 2020-11-12 10:19:03 -08:00
Zachary Anderson 3fce16c329
Revert "Default Keyboard ScrollActions with PrimaryScrollController (#69795)" (#70391) 
This reverts commit 1f0df54553.
 2020-11-12 09:49:12 -08:00
Anna Gringauze edf26e756d
Move web integration tool tests to web.shard (#70226) 
* Move web integration tool tests to web.shard

Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.

In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.

* Enabled verbose mode for flaky web_tool_tests

* Split out the test changes to be commited first
 2020-11-11 15:42:15 -08:00
J-P Nurmi 153f3d23c3
Fix Editable(Text) shortcuts to respect read-only on desktop (#69891) 2020-11-11 15:34:05 -08:00
Jonah Williams 22ec357bc4
[flutter_tools] make getBuildInfo async (#70320) 2020-11-11 15:33:23 -08:00
Jonah Williams 0f80116a63
[flutter_tools] improve hash performance in build_system (#70065) 2020-11-11 15:31:07 -08:00
Kate Lovett 1f0df54553
Default Keyboard ScrollActions with PrimaryScrollController (#69795) 2020-11-11 15:29:05 -08:00
Omar Emara 273efff072
Correct GtkKeyHelper key codes for the Meta key (#69576) 2020-11-11 15:24:04 -08:00
Jonah Williams a40ee8a3fb
[flutter_tools] migrate .packages to package_config, partial (#70200) 2020-11-11 13:50:41 -08:00
Sanjoli Goyal 5b19328ff0
Update ReorderableListView API docs (#69650) 
* Update ReorderableListView API docs

* fixed dart fmt

* added dartpad instead of code sample

* fixed parenthesis error

* Update packages/flutter/lib/src/material/reorderable_list.dart

Co-authored-by: Amit Patil <54329870+Amitpatil215@users.noreply.github.com>

* using reference List.generate instead of generate

* request changes are complete

* space eroors are fixed

* Update ReorderableListView API docs

* fixed dart fmt

* added dartpad instead of code sample

* fixed parenthesis error

* using reference List.generate instead of generate

* Update packages/flutter/lib/src/material/reorderable_list.dart

Co-authored-by: Amit Patil <54329870+Amitpatil215@users.noreply.github.com>

* request changes are complete

* space eroors are fixed

* request changes are completes

Co-authored-by: Amit Patil <54329870+Amitpatil215@users.noreply.github.com>
Co-authored-by: John Ryan <ryjohn@google.com>
 2020-11-11 11:28:57 -08:00
Harsh Mehta 600c99213a
AdoptAWidget: Stepper (#70092) 
* interactive dartpad sample added

* cleaner code

* removed extra spaces

* minor spaces added

* removed null returns
 2020-11-11 10:03:06 -08:00
Chinmay Kabi 6f70a29c36
AdoptAWidget: WillPopScope (#69563) 
* Update WillPopScope API Docs

* Update WillPopScope API Docs

* Update WillPopScope API Docs template fix

* Refactoring dartpad sample

* Refactoring dartpad sample

* Remove trailing spaces

* Minor build fix

* Remove space

* Change the dartpad sample and other minor changes

* Change the dartpad example

* Remove trailing character

* refactor code to dart preamble

* adding uncleared variable

* adding uncleared variable

* Implemented requested changes

* Implemented requested changes

* empty commit

* minor changes

Co-authored-by: Chinmay Kabi <chinmaykabi@gmail.com>
 2020-11-11 10:01:46 -08:00
MH Johnson 50dc84bc17
[Material] Add support for customizing active + disabled state color for selection controls. (#68831) 
* Add new MaterialStateProperty param to selection controls
 2020-11-11 12:39:20 -05:00
xster aac980baac
Update cupertino and material translations (#70157) 2020-11-10 20:56:06 -08:00
Michael Goderbauer 786d0306db
Assert for RenderFlex intrinsics if using baseline alignment (#70139) 2020-11-10 14:29:41 -08:00
Jonah Williams fb28ee2860
[flutter_tools] reland: cache pub invocations (#70180) 
Disabled caching of pub invocations on flutter drive.
 2020-11-10 13:56:36 -08:00
Hans Muller 191d0aa4b6
Revert "AppBar draws its defaults from theme.colorScheme (#69251)" (#70212) 2020-11-10 13:54:04 -08:00
Jonah Williams 0bbd9020ed
[flutter_tools] remove experiment tracking analytics for null safety (#70183) 2020-11-10 12:49:50 -08:00
Jonah Williams 39bc68b6a2
[flutter_tools] dont use autodetect enum for web (#70189) 2020-11-10 12:49:38 -08:00
Jonah Williams 84a8bd3f5a
Revert "[flutter_tools] always use dart to run test script. (#70146)" (#70175) 
This reverts commit a90880a8c3.
 2020-11-10 05:21:14 -08:00
Jonah Williams a90880a8c3
[flutter_tools] always use dart to run test script. (#70146) 2020-11-10 05:02:56 -08:00
Darren Austin fb63371589
Fix for the ListTile horizontalTitleGap calculation introduced with PR #64222. (#70149) 2020-11-09 18:13:07 -08:00
Jonah Williams dbcd7868a4
[flutter_tools] remove most globals from asset system and remove Cache manipulation in unit tests (#70011) 2020-11-09 18:01:04 -08:00
Jonah Williams 1c4b50ecf1
Revert "[flutter_tools] restore pub caching functionality (#70133)" (#70144) 
This reverts commit ff953e4f83.
 2020-11-09 16:38:07 -08:00
Jonah Williams 3fb389c75a
[null-safety] implement null-safe autodetection for the web (#70126) 
Fixes #69416
Fixes #70121
 2020-11-09 16:13:38 -08:00
Jonah Williams ff953e4f83
[flutter_tools] restore pub caching functionality (#70133) 
Necessary to work around #70013 (this looks like it will be fixed, but should protect us in the future)

Restores some notion of skipping pub, with differences from the prior implementation:

Off by default, and only used by the flutter command automatic pub get
A single check parameter. Uses the framework version cached per-project instead of a timestamp of the tool, to avoid cases where downloading a prebuilt framework would cause this check to no longer work.
 2020-11-09 16:11:55 -08:00
Greg Spencer bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow (#69617) 
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate

* remove new test platform dispatchers

* Amend documentation
 2020-11-09 15:26:29 -08:00
redsolver 3b7718c27d
AdoptAWidget: Table (#69488) (#69588) 
* Added Dartpad sample for Table widget

* Changed template to stateless_widget_scaffold

* Removed trailing character
 2020-11-09 15:20:42 -08:00
Jonah Williams 8c02c300d9
[flutter_tools] always run pub with prebuilt applicaitons on drive (#70136) 2020-11-09 14:55:04 -08:00
Kate Lovett 31c0291af4
Remove old todo (#70131) 2020-11-09 14:44:04 -08:00
xubaolin 935185ac45
Fix the PopupMenuButton offset bug (#69383) 2020-11-09 13:54:02 -08:00
Yegor 879466eac2
default to unsound nullability for web (#70120) 2020-11-09 13:49:02 -08:00
Jonah Williams f1cdf2e6f3
Revert "[flutter_tools] restore pub caching functionality on run/test (#70056)" (#70132) 
This reverts commit 6e5845f025.
 2020-11-09 13:31:01 -08:00
Jonah Williams 6e5845f025
[flutter_tools] restore pub caching functionality on run/test (#70056) 2020-11-09 12:52:22 -08:00
Emmanuel Garcia 21e802746b
Migrate Flutter Gallery test to null safety (#70116) 2020-11-09 12:29:14 -08:00
Jonah Williams 4c511fbde2
[flutter_tools] remove workaround for caching sound dill (#70014) 2020-11-09 11:53:56 -08:00
chunhtai 0bc0cc6192
Fix crash when widgetspan does not produce a semantics node in render… (#69919) 
* Fix crash when widgetspan does not produce a semantics node in render paragraph

* fix comments

* fixed corner case, added test, refactored semantics widget

* addressing comment
 2020-11-09 11:31:56 -08:00
Hans Muller a8f9d4cebf
AppBar draws its defaults from theme.colorScheme (#69251) 2020-11-09 10:59:39 -08:00
Michael Thomsen 168ad5dc4d
Roll engine and fix pubspecs that do not have a Dart SDK constraint (#70078) 2020-11-09 19:02:10 +01:00
xster d18bd9a5bb
move cupertino_icon template to 1.0.1 for null safety (#69997) 2020-11-09 09:54:42 -08:00
Jia Hao f5933dbad3
[integration_test] Add a setter for defaultTestTimeout (#70073) 
* [integration_test] Add a setter for defaultTestTimeout

* type annotation

* More type annotations

* Fix doc
 2020-11-09 08:39:05 -08:00
Yuqian Li 8e7748e74c
Reland migration (#69996) 
This reverts ae0a9cb560 and therefore relands #69629.

Additionally, `flutter update-packages --force-upgrade` has been run to update `pubspec.yaml` to resolve the analyze test failures.
 2020-11-08 20:32:04 -08:00
Konstantin Scheglov cc52b32b65
Ignore several import_of_legacy_library_into_null_safe (#69904) 
* Ignore import_of_legacy_library_into_null_safe instead of un-migrating.
 2020-11-08 17:46:16 -08:00
Zachary Anderson e59ab90ae1
Add Dart SDK constraint to a pubspec (#70030) 
This will unblock the roll of the next Dart SDK
 2020-11-07 11:42:05 -08:00
Michael Thomsen e4d94f7ccd
Revert "Migrate Flutter gallery test to null safety (#69048)" (#70023) 
This reverts commit 7ba775a994.
 2020-11-07 12:15:22 +01:00
Emmanuel Garcia 7ba775a994
Migrate Flutter gallery test to null safety (#69048) 2020-11-06 20:38:12 -08:00
Jonah Williams 52d49fb358
[flutter_tools] remove material design schema, use dart code (#69987) 
Instead of loading the use-material-design asset data from a yaml file in the repo, leave it in dart code and simplify. Remove some of the globals, but not enough to update to testWithoutContext
 2020-11-06 19:55:55 -08:00
Hans Muller a35aa3fdeb
Add new ListTile parameters to ListTileTheme (#69982) 2020-11-06 16:39:02 -08:00
David Iglesias e148bf8785
[flutter_web_plugins] Migrate to null safety. (#69844) 2020-11-06 15:34:10 -08:00
George Wright 2b512781a0
Add a --dart-entrypoint-args flag to flutter run to pass through Dart entrypoint arguments on Flutter Desktop (#69607) 2020-11-06 15:34:02 -08:00
Jonah Williams 2fb53d83f2
[flutter_tools] remove all globals from cache and cache_test (#69505) 2020-11-06 15:26:45 -08:00
Dan Field 16dce76577
Fix excessive rebuilds of DSS (#69724) 2020-11-06 12:09:02 -08:00
Jonah Williams 1f210275aa
[flutter_tools] wrap http send in async guard (#69972) 2020-11-06 11:00:20 -08:00
Mokusesei 6269abb75b
Reland: fix android studio 4.1 plugin path for mac (#69954) 2020-11-06 10:57:04 -08:00
Devon Carew 5ba2d79ad2
remove the use of the analysis server --enable-experiments flag from flutter analyze (#69966) 2020-11-06 10:56:34 -08:00
Jonah Williams e18533e7ab
[flutter_tools] remove globals from android_workflow (#69548) 2020-11-06 10:55:52 -08:00
Jonah Williams ef288c1720
[flutter_tools] work around bug in plugins CI (#69971) 2020-11-06 10:55:40 -08:00
Gary Roumanis 16daed86c3
Persist Chrome Default Directory (#69921) 2020-11-06 10:54:04 -08:00
Playhi 8cb2665118
Allow modification of ListTile's horizontalTitleGap, minVerticalPadding, minLeadingWidth (#64222) 
Allow modification of ListTile's horizontalTitleGap, minVerticalPadding, minLeadingWidth
 2020-11-06 00:02:19 -08:00
Jonah Williams 6fe800abd5
[null-safety] remove enable experiment flags (#69930) 2020-11-05 23:58:11 -08:00
Darren Austin 4c1d015e9e
Reland "Updated SearchDelegate to follow custom InputDecorationTheme" (#69653) 2020-11-05 23:54:01 -08:00
Tong Mu e1712ccefc
Reland: Fix a multiple pointers bug 
This relands #68587
 2020-11-05 18:38:15 -08:00
Dan Field 76784651d4
Move package:integration_test to flutter/flutter (#69622) 2020-11-05 17:28:47 -08:00
Jonah Williams a3f6ea6f38
[flutter_tools] split web integration tests into new shard (#69914) 2020-11-05 17:21:44 -08:00
Shi-Hao Hong a1a096e35a
[gen-l10n] Fix untranslated messages (#68553) 2020-11-05 16:24:02 -08:00
Jonah Williams dd8820bcc1
[flutter_tool] initialize flutter root in executable (#69549) 
initialize the flutter root as early as possible. This allows all interfaces to be normally injected into commands, even if those objects might read from the flutter root.
 2020-11-05 15:21:05 -08:00
Jenn Magder bc2a4a6498
Update CocoaPods recommended version to 1.9 (#69809) 2020-11-05 15:13:22 -08:00
Jonah Williams ed1189259e
[flutter_tools] forward all args to pub (#69784) 
Change forwarding command to pass through all args, even -h - this allows flutter to support all of the pub flags without needing to declare them.
 2020-11-05 14:23:24 -08:00
Jenn Magder 1be922c353
Build either iphoneos or iphonesimulator App.framework, not both (#69840) 2020-11-05 14:22:24 -08:00
Jonah Williams 0823d625bc
[null-safety] update version constraint (#69900) 2020-11-05 11:39:26 -08:00
LongCatIsLooong 24c6266230
Adaptive constructor / TextInputAction docs (#69346) 2020-11-05 10:49:03 -08:00
Dan Field cfcb9887c9
Do not use --first-parent when determining version on master (#69726) 2020-11-05 10:11:32 -08:00
Yegor 496efca12f
choose higher-res images on low-DPR screens (#69799) 2020-11-05 10:10:53 -08:00
Jonah Williams e8efde6a54
[versions] update more null safe versions (#69892) 2020-11-05 09:09:03 -08:00
Chinmoy 0afea99b26
added enableFeedback property to ListTile (#69088) 2020-11-05 08:43:02 -08:00
Vyacheslav Egorov 4c24eb10b8
Revert "Fix: fix android studio 4.1 plugin path for macOS" (#69870) 
This reverts commit 422a97d1e5 due to https://github.com/flutter/flutter/issues/69863
 2020-11-05 11:18:00 +01:00
Jenn Magder 58ba70a6e7
Remove add-to-app Xcode build phase input files (#69846) 2020-11-04 23:26:59 -08:00
Jason Simmons 9470a7e864
Revert "[null-safety] update Dart SDK constraints (#69831)" (#69854) 
This reverts commit e375651cc5.
 2020-11-04 21:49:59 -08:00
Lazy Llama 300e1df737
Reduce refresh indicator pull-down distance and update related tests (#69783) 
Co-authored-by: altherat <contact@altherat.com>
 2020-11-05 12:34:10 +08:00
Jenn Magder 2f3cccc4f5
Run more xcodebuild commands in native arm on Apple Silicon (#69837) 2020-11-04 19:54:02 -08:00
Jenn Magder 3145c835ed
Deprecate build ios-framework --universal (#69720) 2020-11-04 19:44:04 -08:00
Mokusesei 422a97d1e5
Fix: fix android studio 4.1 plugin path for macOS (#69364) 2020-11-04 17:25:53 -08:00
Jonah Williams e375651cc5
[null-safety] update Dart SDK constraints (#69831) 2020-11-04 16:50:24 -08:00
Arpan Patel 52b4f725f7
AdoptAWidget: Shortcut (#69568) 
* Added Interactive Sample
 2020-11-05 08:21:02 +08:00
LongCatIsLooong 319722997c
fix typo in computeMaxIntrinsicWidth implementation (#69812) 2020-11-04 16:19:04 -08:00
LongCatIsLooong b26970b143
Cancel drag or hold when scrolling is disabled. (#69732) 2020-11-04 16:14:04 -08:00
Shi-Hao Hong 0963d72582
Make resource attributes optional for simple cases (#68774) 2020-11-05 08:11:53 +08:00
chunhtai 6688e63f68
Improve backbuttondispatcher (#68735) 
* Improve backbuttondispatcher

* update

* update

* fix analyzer

* addressing comments

* make takeprioirty recursive by default

* fix comment

* addressing comment
 2020-11-04 16:00:28 -08:00
Yehuda Ringler 972fb0c85c
router.dart: fix grammer mistake (#68751) 2020-11-04 15:50:10 -08:00
Michael Goderbauer cee6d46b3d
Do not crash if RichText has recognizers without handlers (#69793) 2020-11-04 15:49:05 -08:00
Jenn Magder cb5263e191
Methods in build_ios_framework for universal and XCFrameworks (#69736) 2020-11-04 15:44:03 -08:00
Jonah Williams 580cacf4bd
[versions] roll versions (#69810) 2020-11-04 15:38:58 -08:00
Jonah Williams 7ceb20417c
disable hot reload web tests on CI due to flakes (#69802) 2020-11-04 12:36:33 -08:00
Jonah Williams 0ddb1ae713
fix hot reload benchmark data (#69798) 2020-11-04 11:43:24 -08:00
Madhur Maurya 595df47f2b
Tab bar improvements (#63683) 
* indicatorPadding now does not get ignored

* Removing unnecessary comments

* Throw FlutterError on indicatorPadding

* Tests for indicatorPadding

* Migrate test to NNBD

* Tests Renamed
 2020-11-04 11:20:27 -08:00
Jonah Williams 6cec03c7c1
[flutter_tools] do not reload sources if no sources changed (#69450) 
If no source files were changed by a hot reload, do not send the reload sources RPC. This slightly speeds up the no-op reloads and gives users a faster way to force a re-render.
 2020-11-04 11:15:30 -08:00
Hans Muller b73cae17a4
ButtonStyle style side should default to shape.side (#69713) 2020-11-04 11:14:05 -08:00
Shi-Hao Hong ad9b30b38d
Center the AnimatedPositioned code sample (#69644) 2020-11-04 10:44:05 -08:00
Per Classon 2f611f1477
Make header optional in PaginatedDataTable (#69610) 2020-11-04 10:39:06 -08:00
Aneesh Rao 96a78c0883
Enable customization of TabBar's InkWell (#69457) 2020-11-04 10:34:05 -08:00
Jenn Magder 53410c4bb9
Compile snapshot_assembly with sdk root set in Xcode (#69731) 2020-11-04 10:32:01 -08:00
xubaolin 9b564e9a8a
Make TabBar indicator color automatic adjustment optional (#68171) 2020-11-04 10:29:05 -08:00
Anna Gringauze 5034d57546
Disable web expression evaluation tests (#69728) 
Temporarily disable web expression evaluation tests,
until we figure out how to disable the only on non-web bot.
 2020-11-03 23:36:54 -08:00
Jenn Magder 91b82347af
Build App.framework directly to build directory (#69699) 2020-11-03 12:48:25 -08:00
Hans Muller 23198d4eef
Revert TextField.adaptive (#69631) 2020-11-03 12:28:41 -08:00
Emmanuel Garcia 212967449b
Update plugins dependencies for the Gallery test (#69630) 2020-11-03 12:03:18 -08:00
Jonah Williams d0202131fd
[flutter_tools] support --extra-gen-snapshot-options everywhere --extra-front-end-options is specified (#69592) 
support --extra-gen-snapshot-options everywhere --extra-front-end-options is specified
 2020-11-03 10:11:14 -08:00
Jonah Williams 9ec5d7131b
Remove usage of --enable-experiment to analysis server (#69614) 2020-11-03 08:02:19 -08:00
Abhishek Ghaskata c4bd14cc79
removed an (#69654) 2020-11-03 06:48:03 -08:00
Ayush Bherwani 4019956fc8
[ExpansionTile] adds collapsedBackgroundColor property (#69575) 2020-11-02 22:58:04 -08:00
Smarak Das d618b81075
AdoptAWidget: SnackBar (#69555) 2020-11-02 22:53:04 -08:00
Jonah Williams fb90544cab
[flutter_tools] remove unused or no longer useful code (#69547) 2020-11-02 22:48:03 -08:00
Jonah Williams a2a4e9eda4
Revert "Build App.framework directly to build directory (#69612)" (#69641) 
This reverts commit b77088319a.
 2020-11-02 20:12:47 -08:00
Jenn Magder b77088319a
Build App.framework directly to build directory (#69612) 2020-11-02 18:48:03 -08:00
Greg Spencer 872c9d7ba7
Add maybeLocaleOf to Localizations (#68911) 2020-11-02 18:43:02 -08:00
Jonah Williams 9383ec793b
mark flaky tests as flaky (#69633) 2020-11-02 18:15:20 -08:00
Greg Spencer 01c07e18b9
Remove nullOk parameter from Cupertino color resolution APIs (#68905) 
* Remove nullOk from cupertino color resolution

* Add CupertinoDynamicColor.maybeResolveFrom

* Remove CupertinoDynamicColor.maybeResolveFrom again
 2020-11-02 16:36:22 -08:00
Shi-Hao Hong 55a1d0ae9a
Offstage Docs Sample (#69567) 
* Add a code sample for the [Offstage] widget
 2020-11-03 08:34:40 +08:00
Jason Simmons 88bf732ec5
Make the launch background drawable compatible with older Android API levels (#69255) 2020-11-02 16:08:03 -08:00
Hans Muller 23cc1401f0
Updated the button.icon factory constructors for NNBD (#69596) 2020-11-02 15:45:38 -08:00
LongCatIsLooong 7d539043ba
dont mess with user supplied list (#69594) 2020-11-02 13:43:02 -08:00
Greg Spencer 88809aa247
Standardize dartdoc macro names (#69445) 2020-11-02 13:28:05 -08:00
David Garcia 03a3457f10
fix(itemExtent): Fix rounded issue using precisionErrorTolerance (#68199) 2020-11-02 13:23:04 -08:00
Pieter van Loon b7a92f05d2
Actually consume top padding in bottomsheet if scrollcontrolled (#66257) 2020-11-02 13:18:06 -08:00
YeungKC 60a8b333b0
fix mouse wheel scroll miscontrol of ScrollPosition. (#66039) 2020-11-02 13:13:03 -08:00
Jonah Williams 8291f4810f
[flutter_tools] add canvaskit hot reload integration test (#69550) 2020-11-02 10:40:46 -08:00
Michael Goderbauer 0490fd75aa
Make Theme.of non-nullable (#68922) 2020-11-02 09:20:42 -08:00
Michael Goderbauer 3aba15f95d
move to onTapUp (#69422) 2020-11-02 09:18:58 -08:00
Justin McCandless 22f3cd8a67
Rename AutocompleteCore to RawAutocomplete to match similar naming elsewhere in Flutter (#69419) 
We are standardizing around the term Raw for lower level widgets.
 2020-11-02 09:11:10 -08:00
Andy Weiss c4ceea397a
[flutter_tools] Support zipped application bundles for macOS (#68854) 
* [flutter_tools] Support zipped application bundles for macOS

It is not possible to directly produce a directory (.app) in some build systems
but rather it must be zip'ed before being passed to the tool for
running. This adds support for attempting to extract an application
bundle from a zip file if the bundle is not already a directory. This
uses very similar code from lib/src/application_package.dart which is
used for extracting an ipa for iOS.

This introduces tests for the macos/application_package.dart behavior which did not exist before. These tests cover the changes in the PR and some of the existing behavior, but do not cover everything in that file.
 2020-11-02 08:58:33 -08:00
Abdullah Deshmukh 8328b56ef3
AdoptAWidget: Dismissible (#69535) 2020-11-02 05:48:03 -08:00
Jivansh Sharma ee5c080d7b
Update Draggable API Docs (#69527) 2020-11-02 03:58:05 -08:00
Yash Johri 50970cd777
[RadioListTile] Adds shape, tileColor and selectedTileColor to RadioListTile (#69399) 2020-11-02 03:53:05 -08:00
Chintan Patel 734d2a22fe
AdoptAWidget: SliverWithKeepAliveWidget (#69470) (#69557) 2020-11-02 01:53:02 -08:00
Abhishek Ghaskata 57a13c3e3b
Add Scaffold to Tooltip code samples (#69532) 2020-11-01 23:48:03 -08:00
Tadas Petra a371fbcc1b
AdoptAWidget: MaterialBanner (#69530) 2020-11-01 23:43:06 -08:00
Anas35 97eaf58baa
AnimatedPositioned (#69513) 2020-11-01 23:38:04 -08:00
Rinish Sam 2f18e0b23d
update docs for AbsorbPointer (#69521) 2020-11-01 07:28:04 -08:00
Suryanshu Singh e9b183d47d
AdoptAWidget: FittedBox (#69503) 2020-11-01 06:48:04 -08:00
Amit Patil 72025f0ee5
AdoptAWidget: aspectRatio (#69509) 2020-11-01 06:43:02 -08:00
Tekeshwar Singh 5511abd90f
AdoptAWidget: Tooltip (#69518) 2020-11-01 02:43:03 -08:00
Shi-Hao Hong 4996f60b20
[gen_l10n] Fix unintended use of raw string in generateString (#69382) 
* Fix failing tests from introducing raw string generation in gen_l10n tool
 2020-10-31 19:24:53 +08:00
Greg Spencer c0ef94780c
Fix spelling errors (#69451) 
My yearly pass to fix spelling errors in the API dartdocs.
 2020-10-31 03:12:27 -07:00
najeira 72267a6cd0
Add HeroMode widget (#48223) 2020-10-30 21:23:02 -07:00
Michael Goderbauer f2a25c5bd2
Make Directionality.of non-null (#69060) 2020-10-30 15:43:03 -07:00
Dwayne Slater 1fad8acb10
Fix crash when a MultiFrameImageStreamCompleter is disposed during frame decoding (#69219) 2020-10-30 15:33:03 -07:00
Jonah Williams 324b78eb12
[null-safety] enable null safety (#69440) 
* [null-safety] enable null safety

* opt expression evaluation web test out of null safety
 2020-10-30 15:26:22 -07:00
Jenn Magder de5bf09e7a
Show macOS arm64 architecture in doctor and devices list (#69245) 2020-10-30 13:48:04 -07:00
Jonah Williams 3e41962dff
[null-safety] update tests and tool auto-detection for null safe dart (#69405) 
Disable null safety auto-detection for the web
 2020-10-30 13:42:54 -07:00
Michael Goderbauer c83dd3cc75
Fix build (#69426) 2020-10-30 11:34:18 -07:00
Jonah Williams 22724370cb
[flutter_tools] do not delete web directory during flutter build web (#69115) 2020-10-30 11:00:24 -07:00
Jacek Marchwicki 32b9af6996
Use the correct pleace for the system navigation bar color adjustment (#68102) 2020-10-30 10:48:03 -07:00
Jonah Williams a0860f6e87
[flutter_tools] retry sever socket setup (and port selection if port is unspecified) (#69351) 
Fixes #69348

If the web development server fails to bind, then retry up to 5 times. If a port was not provided, select a new free port each time.
 2020-10-29 20:07:34 -07:00
Jonah Williams 44d0e52d20
[flutter_tools] remove fallback discovery and observatory timeout (#68756) 
The flutter run failures are cause by the application occasionally taking a long time to start up. This caused the ios fallback discovery to kick in, which will always fail if the application hasn't started. Solution: remove the iOS fallback discovery and wait up to 30 seconds.

This has not proven to reduce the flakes, but it does at least remove one error case and removes code that will no longer work without the mDNS fallback.
 2020-10-29 18:43:47 -07:00
George Wright e48446af17
Send command line arguments through to the Flutter Engine on Windows (#68931) 2020-10-29 18:08:04 -07:00
George Wright 678f3cb4fb
Update Linux template app to pass through command line arguments to the Dart entrypoint (#68535) 2020-10-30 12:26:16 +13:00
Jonah Williams ca47b4e12c
[flutter_tools] disable failing gen l10n test (#69340) 2020-10-29 15:04:46 -07:00
Angjie Li 3056f4194a
Fix issue with --web-renderer. (#69319) 2020-10-29 14:43:06 -07:00
Yegor 2fa03438de
add web_long_running_tests shard containing long-running web tests (#67324) 2020-10-29 14:23:02 -07:00
Shi-Hao Hong 7b0f38b117
Remove intl_translation from tool integration test (#69155) 2020-10-29 14:05:39 -07:00
Shi-Hao Hong a2b93b86f6
[gen_l10n] Add base method code comments for improved discoverability (#69016) 2020-10-29 14:03:05 -07:00
Greg Spencer fa3d2e2116
Remove nullOk parameter from Focus.of, FocusTraversalOrder.of, and FocusTraversalGroup.of (#68917) 
This removes the nullOk parameter from Focus.of, FocusTraversalOrder.of and FocusTraversalGroup.of, and creates maybeOf equivalents for each. The of methods now return non-nullable values, and the maybeOf equivalents return nullable values.
 2020-10-29 14:02:09 -07:00
Greg Spencer 4fa5fe5f0b
Remove nullOk from Scaffold.of and ScaffoldMessenger.of, create maybeOf for both (#68908) 2020-10-29 14:01:32 -07:00
Greg Spencer e5f7726c7b
Remove nullOk parameter from AnimatedList.of and SliverAnimatedList.of (#68925) 
This removes the nullOk parameter from AnimatedList.of and SliverAnimatedList.of, and creates maybeOf equivalents for each. The of methods now return non-nullable values, and the maybeOf equivalents return nullable values.
 2020-10-29 14:01:05 -07:00
Greg Spencer 85a252569b
Remove nullOk parameter from Router.of and make it return a non-nullable value (#68910) 
This removes the nullOk parameter from Router.of, and createsRouter.maybeOf. Router.ofnow returns a non-nullable value, and the Router.maybeOf returns a nullable value.
 2020-10-29 14:00:47 -07:00
Greg Spencer 4f586fa355
Remove nullOk parameter from Shortcuts.of, Actions.find, and Actions.handler (#68921) 
This removes the nullOk parameter from Shortcuts.of, Actions.find and Actions.handler and created Shortcuts.maybeOf and Actions.maybeFind. Shortcuts.of and Actions.find now return non-nullable values, and the maybe versions return a nullable value. I didn't create a non-nullable version of Actions.handler, since it needs to be able to return null if an action is not enabled, but I did remove the nullOk parameter, effectively setting it to true permanently, since setting it to false doesn't make much sense if the function can still return null when the action is not enabled.
 2020-10-29 13:59:36 -07:00
Mateus Felipe C. C. Pinto 70d253b9a6
Remove references to CupertinoDialog (#68508) 2020-10-29 13:58:04 -07:00
Ian Hickson 5317330904
Remove the defaults for textBaseline (#68646) 2020-10-29 13:13:06 -07:00
Jonah Williams 246bf60fb3
[flutter_tools] allow default driver log to fail due to IO error (#69316) 2020-10-29 12:52:30 -07:00
Jonah Williams 470346f775
[flutter_tools] Reland: Stage web tests (#69264) 
Enable web tool integration tests: expression evaluation, stepping, and basic hot restart
 2020-10-29 09:56:28 -07:00
Jonah Williams f68911ee1d
[framework] increase threshold for compute to 50Kb (#69307) 2020-10-29 09:34:33 -07:00
Yegor 46b1b67797
fix stack frame parser (#69253) 2020-10-28 19:27:04 -07:00
Sarbagya Dhaubanjar e5c4c4b27a
replaced null check with hasContentDimensions (#69164) 2020-10-28 19:22:03 -07:00
Jonah Williams 2ceb34e6fb
Revert "[flutter_tools] enable web integration tests (#69114)" (#69261) 
This reverts commit d0cdfa4176.
 2020-10-28 18:22:41 -07:00
Jonah Williams 7629758ed7
[flutter_tools] measure driver success and failure (#69226) 
Currently we only have a test that measures if flutter drive can fail. Unfortunately it has been failing for multiple years based on the fact that the error is due to a missing Gradle config.

Add a smoke success test case, and update both tests to use the test API and the tester-device.
 2020-10-28 18:15:23 -07:00
Darren Austin 69d7637796
Revert "Updated SearchDelegate to follow custom InputDecorationTheme (#55209)" (#69241) 2020-10-28 17:52:05 -07:00
Sam Rawlins 68a87ee791
Ignore "unused" analysis for dart:ui imports for web-only API. (#68814) 2020-10-28 17:47:04 -07:00
Danny Lin 62741337b8
Fix links to GitHub bug template (#68374) 2020-10-28 17:42:05 -07:00
Ian Hickson 01201b5faf
Add documentation talking about ScrollPhysics.applyTo(null) (#67585) 2020-10-28 17:37:06 -07:00
Michael Goderbauer 396cd24770
Allow adding/removing onTap/onDismiss to Semantics (#69230) 2020-10-28 17:32:12 -07:00
Angjie Li 2bbd004682
Support --web-renderer options which would allow user to specify which rendering backend to use. (#68848) 2020-10-28 17:32:09 -07:00
Jonah Williams ed5d8718c4
[flutter_tools] conditionally invoke pub run test for drive scripts based on presence of dependency (#69246) 
* [flutter_tools] conditionally invoke pub run test for drive scripts based on presence of dependency
 2020-10-28 17:32:05 -07:00
Jonah Williams d0cdfa4176
[flutter_tools] enable web integration tests (#69114) 
* [flutter_tools] stage web integration tests
 2020-10-28 17:31:44 -07:00
Jonah Williams 735f6eec2c
[flutter_tools] support ws scheme in use-existing-app (#69244) 2020-10-28 15:09:46 -07:00
David Reveman 4aad058a49
Improve resampling of up and remove events. (#69096) 
* Improve resampling of up and remove events.

This improves resampling of these events by searching
for them until the next approximate sample time.

Co-authored-by: David Reveman <reveman@google.com>
 2020-10-28 17:02:37 -04:00
Jonah Williams d306c37bc4
[flutter_tools] fix --use-existing-app (#69237) 2020-10-28 13:55:29 -07:00
xubaolin 58a74af8a6
Revert "Revert "change TextEditingController.clear() behavior (#68775)" (#68920)" (#69156) 
(Reland) Fixes a bug where keyboard capitalization behavior was reset by TextEditingController.clear.
 2020-10-28 13:51:21 -07:00
Jacob MacDonald 506d0f09c0
opt out the listener.dart generated file (#69223) 2020-10-28 12:52:04 -07:00
Jonah Williams 8b9e9680d2
[flutter_tools] use throwToolExit in flutter drive (#69220) 
* [flutter_tools] use throwToolExit

* Update drive.dart
 2020-10-28 11:40:39 -07:00
xubaolin 91ab73ab23
Mouse drag should not show selection handles (#69101) 
Fixes a bug where selection handles sometimes showed on web.
 2020-10-28 11:24:46 -07:00
Per Classon 5434dd59a7
[Material] Add splash radius property to selection controls (#69197) 2020-10-28 11:22:04 -07:00
Michael Goderbauer 8cbc849222
Fix dropdown crash (#69211) 2020-10-28 11:17:53 -07:00
Danny Tuppeny e71655b7e9
Include VS Code + Android Studio URLs in the No IDE message (#69194) 2020-10-28 11:17:06 -07:00
Per Classon 92d9630eaf
Add side property to Chips, and resolve it and the state of Chips to be MaterialState aware (#68596) 2020-10-28 11:12:09 -07:00
Anurag Roy f03caeafa7
Add useDeleteButtonTooltip property for Chip (#68237) 2020-10-28 11:07:04 -07:00
Konstantin Scheglov 7b86be228e
Use runZonedGuarded() instead of deprecated onError. (#69160) 2020-10-28 08:43:31 -07:00
Greg Spencer 55289324c6
Remove nullOk in MediaQuery.of (#68736) 
Adds MediaQuery.maybeOf to replace calling MediaQuery.of(context, nullOk: true), and removes the nullOk parameter. Also changes MediaQuery.of to return a non-nullable value, and removes many instances of the ! operator, reducing the possible places where a null dereference could occur.
 2020-10-28 07:56:41 -07:00
Daniel Edrisian 35a94f70e1
Adaptive progress indicator (#69143) 2020-10-27 23:47:04 -07:00
Jacob MacDonald fb508db94d
allow 2.12 prerelease sdks in flutter_goldens[_client] (#69148) 2020-10-27 17:16:24 -07:00
Kate Lovett b86fa13235
Add horizontal gesture support for CupertinoScrollbar (#69063) 2020-10-27 15:57:03 -07:00
Daniel Edrisian d3a8b03574
Adaptive TextField (#68918) 2020-10-27 15:27:03 -07:00
Jonah Williams 9e5e763ebe
[flutter_tools] document flutter root initialization (#67884) 
Moves the flutter root initialization to a static method on the cache. This is a small step towards making this functionality non-static and instead injected like normal members - however, completely removing all of the static-ness at once was too large of a change.

Instead document and add unit tests and change existing code as little as possible.

#47161
 2020-10-27 15:20:07 -07:00
Michael Goderbauer f5ce638959
Add Directionality.maybeOf (#69117) 2020-10-27 14:44:50 -07:00
Gildásio Filho 48a9fc13d5
Updated SearchDelegate to follow custom InputDecorationTheme (#55209) 
Updated SearchDelegate to follow InputDecorationTheme
 2020-10-27 14:08:43 -07:00
Anurag Roy cd690f9559
[flutter_tools] Add --verify-only flag to flutter upgrade (#68866) 
* Add --verify-only flag for flutter upgrade
 2020-10-27 14:06:39 -07:00
Jonah Williams 18f0a2288e
[flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 (#69067) 
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query

Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
 2020-10-27 13:55:32 -07:00
Dan Field 36f9af3f55
reland driver vm_service migration (#69126) 
* One more reland of "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)"

This reverts commit e5814756a2.

* pub run test
 2020-10-27 11:30:24 -07:00
Justin McCandless 09dc5599dd
Selecting spaces (#68227) 
When attempting to select a space on mobile, Flutter will try to select the word before the space too, if one exists.
 2020-10-27 11:30:07 -07:00
Yuqian Li 891bd95e1a
Add clipBehavior to BoxFit doc (#68662) 2020-10-27 11:07:04 -07:00
Jonah Williams 8c3d564ded
[flutter_tools] fix test expectation in resident_runner.dart (#69121) 2020-10-27 10:11:02 -07:00
Justin McCandless c12d9b9c19
IME private command docs improvement (#68630) 
Just a docs-only improvement in EditableText and text input.
 2020-10-27 09:22:47 -07:00
Jonah Williams 3300a1bd68
[flutter_tools] eagerly set asset directory path, cache flutter views, simplify error handling (#68978) 
Performs some small cleanup on the hot reload code path.

- Combines nested try/catch into single try catch, update on clause now that package:vm_service is used and Map does not need to be caught.
- Cache FlutterViews for the lifetime of the hot reload method handler
- Set asset directory path once during startup and remove conditional set during hot reload
 2020-10-27 09:20:05 -07:00
Michael Goderbauer 95563ff197
Make WidgetsLocalizations.of non-nullable (#69055) 2020-10-27 09:16:41 -07:00
Justin McCandless 291ee94506
AutocompleteCore (#62927) 
A new widget that chooses an item from a list based on text input. Just the core widget, with Material and Cupertino versions to come.
 2020-10-27 08:58:52 -07:00
Jonah Williams 4b017b6220
remove unnecessary null aware operator (#69107) 2020-10-27 07:24:27 -07:00
Michael Goderbauer 9fb1c521b1
InheritedTheme updates (#69050) 2020-10-27 06:57:03 -07:00
Shi-Hao Hong d50bfd5f66
Fix null issue with dynamically updating from zero tabs for TabBar (#69005) 2020-10-27 06:52:04 -07:00
Michel Feinstein 60a58ab780
Update form.dart (#68968) 2020-10-27 06:47:04 -07:00
xubaolin b99443c7ff
Apply Desktop specs for Tooltip (#68681) 2020-10-27 06:42:03 -07:00
Daniel Edrisian e818c47059
Added CupertinoSearchTextField (#68074) 2020-10-27 06:37:03 -07:00
Dan Field e5814756a2
Revert "Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)" (#69089) 
This reverts commit 05ab0eba19.
 2020-10-27 01:47:03 -07:00
Dan Field 05ab0eba19
Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077) 
This reverts commit 19ce7a86af.
 2020-10-26 19:22:25 -07:00
Jonah Williams 19ce7a86af
Revert "Driver vm service (#68654)" (#69074) 
This reverts commit 3ecac303b4.

Co-authored-by: Dan Field <dfield@gmail.com>
 2020-10-26 18:56:34 -07:00
Jonah Williams 6cd847c767
[flutter_tools] update test platform to use buildInfo instead of mode + additional params (#69033) 2020-10-26 18:50:17 -07:00
Dan Field 3ecac303b4
Driver vm service (#68654) 
Migrate flutter_driver to use package:vm_service
 2020-10-26 17:09:14 -07:00
Michel Feinstein e949ff54af
Error on FocusTraversalGroup or Focus docs (#68981) 2020-10-26 16:56:12 -07:00
Jonah Williams e0ec9a06dc
[flutter_tools] Make ApplicationPackageFactory inject dependencies for Android Builds (#67827) 
* [flutter_tools] simplication of application store logic

* maybe return null

* fix install tests

* Clean up imports

* revert windows test

* remove unused import
 2020-10-26 16:51:32 -07:00
chunhtai 6cfb86fbcb
Fix crash if update pages right after a navigator pop (#68923) 2020-10-26 16:50:54 -07:00
Michael Goderbauer 27e1efc159
Delay Route disposal until OverlayEntries are unmounted (#68913) 2020-10-26 16:22:37 -07:00
Jonah Williams e7b66ac7ad
[flutter_tools] do not include AS validator if android is not enabled (#69047) 2020-10-26 15:59:00 -07:00
Yegor 7a10b46ee0
Print errors in all build modes (#69046) 2020-10-26 15:57:02 -07:00
Jonah Williams 2e54c4a8ea
[flutter_tools] implement safe file copy with multiple fallbacks (#69000) 
The tool observes a large number of unhandled exceptions during the file copy portion of flutter create. it is difficult to tell whether the permission issue is caused by the source/destination, or whether it is due to a bug in dart:io.

To work around this, implement a permission check for both the source and dest files. If either fails, the tool can exit with a more specific message.

If these checks pass, then perform the actual copy. If the copy fails, fallback to manually copying the bytes
 2020-10-26 15:49:07 -07:00
Jonah Williams 8b973f01c4
[flutter_tools] add package_config.json to analyze_once_test.dart (#69059) 
* [flutter_tools] add package_config.json to analyze_once_test.dart
 2020-10-26 15:46:51 -07:00
MH Johnson 70aa1227c2
[Material] Fix BottomNavTheme.showSelectedLabels bug (#67342) 2020-10-26 14:47:02 -07:00
Jacob MacDonald 193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041) 
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
 2020-10-26 14:31:13 -07:00
Alexandre Ardhuin 17cdf5559d
enable unnecessary_string_escapes and use_raw_strings (#68302) (#69025) 2020-10-26 12:42:05 -07:00
Jonah Williams 183fe75d58
[flutter_tools] reland: drive service (#68887) 
Overhaul of flutter drive in order to deliver a better experience, namely:

* flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
* Removes web-initialize-platform as this is no longer used
* flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
* VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)

Web changes

* Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
 2020-10-26 10:11:30 -07:00
Justin McCandless b76253b60a
minScale docs reference the need for a larger boundaryMargin when scaling below 1.0 (#68494) 2020-10-26 08:42:04 -07:00
Justin McCandless c2bb928981
Proper light/dark colors, and test that text is not color of background (#67679) 2020-10-26 08:37:03 -07:00
Justin McCandless b9195d807c
Revert "change TextEditingController.clear() behavior (#68775)" (#68920) 
This reverts commit 95909c2a04.
 2020-10-26 08:03:09 -07:00
Dan Field 9951638f3b
retry getting the main isolate (#68894) 2020-10-23 15:55:32 -07:00
Jonah Williams 0f28edac65
[flutter_tools] null safety mode is used for dill naming (#68898) 
* [flutter_tools] null safety mode is used for dill naming

* add bad test case
 2020-10-23 15:39:58 -07:00
Roc Boronat 8d6ba3ebe9
Fix a typo: "Its weight" instead of "It's weight" (#68883) 2020-10-23 14:17:04 -07:00
Jenn Magder 832d776b15
Stop debugger when iOS app crashes (#68844) 2020-10-23 14:12:04 -07:00
Yash Johri f3562c6f1d
[SwitchListTile and CheckboxListTile] Adds selectedTileColor property (#68358) 2020-10-23 14:07:05 -07:00
Justin McCandless 0c63d63b1f
InteractiveViewer constrained docs (#68327) 2020-10-23 14:02:03 -07:00
Jenn Magder 59544e377d
Apple silicon arch -arm64 -> -arm64e (#68855) 2020-10-23 13:48:38 -07:00
Jonah Williams 424ea0958b
[flutter_tools] make android deps no longer required for flutter doctor (#68533) 2020-10-23 12:37:04 -07:00
Jonah Williams cb67513f29
[flutter_tools] Reland: simplify pub cache logic (#67589) 
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.

Also takes an opportunity to fix the kernel snapshot depending on the .packages or package_config. Due to the generated: date field this causes extra rebuilds. Instead when pub get is run, write out an additional file with just the package contents and version.

Fixes #66777
Fixes #65723
 2020-10-23 10:00:56 -07:00
Michael Goderbauer 6cb6eef615
Make Material/CupertinoLocalizations non-nullable (#68807) 2020-10-23 09:12:42 -07:00
Jenn Magder 351ccf7eaf
Better error message when export options plist does not a fix (#68826) 2020-10-22 23:28:51 -07:00
Jenn Magder aea070790f
Turn off CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in CocoaPod targets (#68817) 2020-10-22 22:02:04 -07:00
Cyp 45e02daf22
Correctly handle centerSlice with resoultion-aware assets. (#68325) 2020-10-22 21:57:03 -07:00
Jonah Williams 1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845) 
This reverts commit 2e75f52ae4.
 2020-10-22 19:39:33 -07:00
Jonah Williams b25ce5b16c
Revert "Fix a multiple pointers bug (#68587)" (#68841) 
This reverts commit bde85ea3bb.
 2020-10-22 19:16:08 -07:00
xubaolin bde85ea3bb
Fix a multiple pointers bug (#68587) 
* Fix mutiple pointers bug

* Add unit test case

* Remove unnecessary map clone
 2020-10-22 16:09:47 -07:00
xubaolin 95909c2a04
change TextEditingController.clear() behavior (#68775) 
Fixes a bug where keyboard capitalization mode was exited when pressing clear.
 2020-10-22 15:56:26 -07:00
Kate Lovett 8e8f61856a
Fix overscroll edge case that puts NestedScrollViews out of sync (#68644) 2020-10-22 15:37:06 -07:00
YeungKC c5c2b24a07
Fix floating behavior of long label and outline input border (#68727) 
Corrects the space available to the label in an outlined text field
 2020-10-22 15:36:06 -07:00
Alexander Brusher 099ae9b417
Re-enables tests previously failing due to new semantics flag. (#66916) 2020-10-22 15:32:03 -07:00
Jonah Williams 2e75f52ae4
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451) 
Overhaul of flutter drive in order to deliver a better experience, namely:

flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
Removes web-initialize-platform as this is no longer used
flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes

Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
 2020-10-22 15:07:02 -07:00
xubaolin 1bd661f4d4
fix a widgetspan hittest bug (#68694) 2020-10-22 14:27:04 -07:00
Ian Hickson 6a434ab9ec
Fix grammar and writing style for some of the Router documentation (#68513) 2020-10-22 14:22:09 -07:00
stuartmorgan 3da995adec
Handle backspace in text fields (#68812) 
Currently the framework handles delete, but not backspace, so embeddings
all have to implement backspace handling themselves. This eliminates
that inconsistency and allows simplified code in embeddings by adding
backspace handling.

It also fixes a bug uncovered in the delete handling where deleting a
selection would also delete the next character after the selection.
 2020-10-22 13:51:07 -07:00
Jenn Magder f63d56e455
App.framework must support iOS 8 for older Flutter projects (#68729) 
* App.framework must support iOS 8 for older Flutter projects

* Fix test
 2020-10-22 13:50:54 -07:00
stuartmorgan 3ff334d68d
Add a missing include to the Linux plugin template (#68737) 
The template uses strcmp (to check the received method), so should
include <cstring>
 2020-10-22 13:50:39 -07:00
Jonah Williams 37470dfc0b
[devicelab] de-flake iOS launch (#68790) 
* [devicelab] de-flake iOS launch
 2020-10-22 13:37:57 -07:00
Jonah Williams 21ca1f9ba5
[flutter_tools] use --no-print-incremental-dependencies for non-resident and test compiles (#68678) 2020-10-22 13:34:59 -07:00
Dan Field 4af674285b
Move service extension to correct binding so images are repainted after enabling/disabling, update test (#68793) 
* Move service extension to correct binding so images are repainted after enabling/disabling, update test

* Update binding.dart
 2020-10-22 13:34:21 -07:00
Jonah Williams 37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality (#68650) 
* [flutter_tools] remove iOS screenshot on failure functionality

* remove all screenshot code
 2020-10-22 13:34:07 -07:00
puelo 24d3999783
Generate RawKeyEvents for iOS 13.4+ (#65193) 
* Added RawKeyEvent support for iOS

* Removed unused remnant

* added some missing keys

* Removed trailing whitespaces

* commit for build

* Added mapping names

* Made iOS keycodes generatable and collectable

* Fixed naming and formatting issues

* fixed raw_keyboard_test
 2020-10-22 13:33:51 -07:00
Jenn Magder f877266139
Add CocoaPods sudo installation note (#68542) 
* Add CocoaPods sudo installation note

* Refer to instructions
 2020-10-22 13:33:35 -07:00
chunhtai 6cab3f6008
fix simple dialog introducing additional node for semantics label (#68804) 
* fix simple dialog introducing additional node for semantics label

* add test
 2020-10-22 13:33:17 -07:00
Jenn Magder 04657354f5
Build IPA command (#67781) 
* Build IPA command

* xcarchive -> ipa
 2020-10-22 13:32:51 -07:00
Michael Goderbauer 91478d96a8
Do not instantiate intermediate tabs during transition (#68124) 2020-10-22 13:32:47 -07:00
Jaime Blasco 52c715fe43
Add textSelectionControls to TextField etc. (#66785) 
Enables custom text selection menus by allowing selectionControls to be passed to TextField et. al.
 2020-10-22 13:31:51 -07:00
Robert Ancell 16b9933d85
Disable header bar when not using GNOME Shell. (#68452) 
Fixes https://github.com/flutter/flutter/issues/68253
 2020-10-22 10:24:19 +13:00
Robert Ancell b200baebd7
Try the Wayland GDK backend, the engine now supports it (#66519) 
* Try the Wayland GDK backend, the engine now supports it

* Update comment from review

* Just do default GTK behaviour
 2020-10-22 09:38:11 +13:00
Jacob Richman 0884236504
Fix assert due to VSCode passing in an isolateId as well as the expected args to setPubRootDirectories. (#68721) 2020-10-21 12:13:10 -07:00
Michael Goderbauer 42f3709a5a
Sound null safety for framework and flutter_test (#68642) 2020-10-21 10:09:11 -07:00
Justin McCandless 955e07461b
Revert "Fix text field label width on outline input border (#67736)" (#68672) 2020-10-21 08:52:03 -07:00