Commit graph

3251 commits

Author SHA1 Message Date
Jenn Magder 5b503c7c93
Revert "Mark firebase tests as flaky (#73586)" (#73591)
This reverts commit f364bcb5bd.
2021-01-08 12:20:21 -08:00
Yegor 1f8501f0a4
web benchmark choose renderer explicitly (#73582) 2021-01-08 12:04:03 -08:00
Jenn Magder f364bcb5bd
Mark firebase tests as flaky (#73586) 2021-01-08 11:19:10 -08:00
jensjoha 5bc725bea8
[dev] Don't use await for on stdout and stdin; pass local engine argument (#72136)
* [dev] Don't use await for on stdout and stdin; pass local engine argument

1) Don't use await for on stdout followd by await for on stderr.
   This can cause nothing to happen. E.g. if one didn't do something
   like `flutter pub upgrade` dev/automated_tests and the version in the
   old one was pre-nnbd (but flutter itself use lots of nnbd stuff) lots
   of errors would be emitted, but because we basically only listen to
   stdout nothing will happen (deadlock once stderr buffer runs out).
   Note that it still awaits the exit-code below.
2) Pass --local-engine (if given) so there won't be any crashes because
   of that.
2021-01-08 08:12:36 +01:00
Michael Goderbauer 5d1306e7ab
Update outdated links (#73514) 2021-01-07 16:28:12 -08:00
Jenn Magder 45d71e25ab
Build iOS apps using Swift Packages (#73508) 2021-01-07 15:59:09 -08:00
Ian Hickson 544a41eb55
Remove an obsolete comment from pubspec.yaml (#73505) 2021-01-07 15:59:04 -08:00
Jenn Magder f596fdc008
Revert "Exclude arm64 from valid iOS simulators (#73458)" (#73511)
This reverts commit 273630c09d.
2021-01-07 14:06:32 -08:00
Jenn Magder 273630c09d
Exclude arm64 from valid iOS simulators (#73458) 2021-01-07 13:03:52 -08:00
Jenn Magder b78b17630a
Run pod repo update in iOS extension test (#73442) 2021-01-07 11:59:40 -08:00
Jenn Magder 74d58105d1
Revert "Build iOS apps using Swift Packages (#72761)" (#73437)
This reverts commit 28db5a0fae.
2021-01-06 15:04:16 -08:00
Jenn Magder 6891928a1f
Optionally include CocoaPods xcconfig (#73112) 2021-01-06 13:55:23 -08:00
Jenn Magder 28db5a0fae
Build iOS apps using Swift Packages (#72761) 2021-01-06 13:54:53 -08:00
Jenn Magder 3082a2806e
build ios-framework simulator slices for profile/release (#73378) 2021-01-06 12:12:23 -08:00
Jenn Magder e21d822074
Remove build ios-framework --universal flag (#73383) 2021-01-06 11:14:05 -08:00
Shi-Hao Hong 01d2325be1
Complete migration to null safety in api documentation (#72939)
* Remove all usage of no_null_safety in API docs workflows
2021-01-06 08:27:34 +08:00
nturgut 985e5ff324
[web] add web-renderer option to flutter test. run web tests with this option (#73069)
* add web-renderer option to flutter test. run web tests with this option

* remove debug lines
2021-01-05 10:57:01 -08:00
xubaolin 27b7ec348c
Fix Gallery subtitle not updating correctly upon selection (#73303) 2021-01-05 23:27:59 +08:00
Jenn Magder f08b1ae637
Avoid broken symlinks in embedded Flutter frameworks (#73052) 2020-12-28 14:39:02 -08:00
nturgut 272b23cabd
[web] make sure tests and benchmarks use correct backend - add autodetect false (#73047)
* add autodetect false

* fix typo
2020-12-28 10:55:53 -08:00
Darren Austin a6117269c6
Migrated some services and widgets doc comments to null safety. (#72792) 2020-12-23 17:14:04 -08:00
Casey Hillers 849784e262
[devicelab] Add results path flag to test runner (#72765) 2020-12-22 16:45:38 -08:00
nturgut 10c358bafa
run framework unit tests on html backend (#72756) 2020-12-21 16:07:51 -08:00
nturgut 14206399c3
make sure tests and becnhmarks use correct backend (#72628) 2020-12-21 09:55:23 -08:00
keyonghan bb0e6ce9b0
Unflaky remaining linux tasks (#72563)
* remove flaky flag

* remove from manifest

* fix test
2020-12-17 17:23:35 -08:00
Todd Volkert 9a9339fbcb
Fix bug in docs.dart (#72544)
Add a check that a pubspec file exists before trying to read it.
2020-12-17 14:47:45 -08:00
Jenn Magder d6857bc026
Build/copy macOS frameworks to built products instead of ephemeral directory (#72378) 2020-12-17 14:47:05 -08:00
Jenn Magder 1c18cf3da8
Move macOS Podfile logic into the tool (#72020) 2020-12-17 11:48:16 -08:00
Ming Lyu (CareF) 9f7e785c7b
add doc for scroll_smoothness metrics (#72479) 2020-12-17 09:59:03 -08:00
Yuqian Li db9c389259
Add SkiaPerfGcsAdaptor and its tests (#70674) 2020-12-16 22:14:04 -08:00
keyonghan 4833f8f93d
remove flaky flag & disable devicelab tests (#72455) 2020-12-16 12:23:02 -08:00
xster c980c2413e
update cupertino icons to 1.0.2 (#72420) 2020-12-16 12:03:51 -08:00
xster ca82c572b7
Revert "let NOTICES be double gzip wrapped to reduce on-disk installed space (#71899)" (#72438) 2020-12-16 10:58:19 -08:00
keyonghan b11521ada5
enable remaining linux builders (#72445) 2020-12-16 10:18:05 -08:00
keyonghan 169bba8ee4
fix builder name (#72413) 2020-12-15 22:10:33 -08:00
keyonghan 152cd8a2c0
use __ instead in builder name (#72405) 2020-12-15 18:28:50 -08:00
keyonghan 01f63b27a9
fix builder names (#72403) 2020-12-15 18:01:03 -08:00
keyonghan 824c8cd08d
add first ten linux devicelab luci tests (#72401) 2020-12-15 17:48:57 -08:00
xster 795b23ef44
Fix cupertino icons mapping which was misaligned by 1 (#72384) 2020-12-15 16:21:27 -08:00
xster 4ed3432e8f
let NOTICES be double gzip wrapped to reduce on-disk installed space (#71899) 2020-12-15 13:29:14 -08:00
Kate Lovett e9a8315fd2
Remove deprecated CupertinoTextThemeData.brightness (#72017) 2020-12-15 12:48:04 -08:00
Jenn Magder 1129e6f86c
Move embedding and linking macOS Flutter frameworks into the tool (#72372) 2020-12-15 12:05:44 -08:00
Casey Hillers 3d5348b289
Deduplicate plugin_test win (#72366) 2020-12-15 11:43:04 -08:00
Casey Hillers 8db2d85356
Migrate linux vm tests to LUCI (#72360) 2020-12-15 10:43:04 -08:00
Michael Goderbauer c9cb43ce1a
Migrate the first batch of API samples to null safety (#72169) 2020-12-14 11:20:45 -08:00
Casey Hillers f35238c804
[devicelab] Migrate web_benchmarks_canvaskit to LUCI (#72166) 2020-12-14 09:28:04 -08:00
Amir Hardon d075b979f8
Run the flutter/plugins tests on presubmit, make it part of the tree status (#71502) 2020-12-11 15:02:33 -08:00
Jenn Magder f123f64deb
Reenable module_test_ios UI tests (#72145) 2020-12-11 13:52:19 -08:00
Jenn Magder a48a57d369
macos_content_validation_test integration test (#72114) 2020-12-11 13:52:02 -08:00
Michael Goderbauer ff05ca2503
Prepare to migrate API doc samples and snippets to null safety (#72040) 2020-12-11 13:39:36 -08:00
Martin Kustermann 72aa23eb93
Revert "Pass --local-engine* flags from dev/bots/test.dart down to pub test via env variables (#71721)" (#72141)
This reverts commit 4300226a50.

Reason for revert: The original PR correctly passes down the local
engine flags to subprocesses of the tests. Though this causes issues
because some tests assume a specific target but do not modify the
value for `--local-engine` (which is set to `host_debug`) to reflect
that.

See more discussion here:

    https://github.com/flutter/flutter/pull/71721#issuecomment-743218994
2020-12-11 17:10:32 +01:00
Michael Goderbauer 78cbfbff42
Revert "Migrate devicelab to package:vm_service (#71882)" (#72092)
This reverts commit 9d1d0cfeb5.
2020-12-10 12:56:02 -08:00
Dan Field 9d1d0cfeb5
Migrate devicelab to package:vm_service (#71882) 2020-12-10 12:43:04 -08:00
Jenn Magder 53119af105
Add macOS to lint plugins integration test (#71953) 2020-12-09 13:35:39 -08:00
Jenn Magder be1325f18b
Add integration_test to integration tests build shard (#71934) 2020-12-09 13:07:36 -08:00
Emmanuel Garcia f172c827cb
Ensure apps can build while using AGP 3.3.0 (#71964) 2020-12-09 12:58:05 -08:00
Jenn Magder 8cd03a2e36
Run plugin tests on try builders when flutter_tools changes (#71937) 2020-12-09 11:33:04 -08:00
Jenn Magder d553aa06c7
Revert "Reland Move embedding and linking macOS Flutter frameworks into the tool (#71965)" (#72012)
This reverts commit 0b6b3eecfe.
2020-12-09 11:19:49 -08:00
Jenn Magder 0b6b3eecfe
Reland Move embedding and linking macOS Flutter frameworks into the tool (#71965) 2020-12-09 09:46:53 -08:00
George Wright a109fe68b0
Stop using the List constructor (#71957) 2020-12-08 17:03:03 -08:00
Janice Collins d1f78b48ea
Update dartdoc to 0.38.0 (#71935) 2020-12-08 16:13:04 -08:00
Casey Hillers 2565062df3
git branch flag (#71886) 2020-12-08 15:53:05 -08:00
Jenn Magder c88ab79bd2
Revert "Move embedding and linking macOS Flutter frameworks into the tool (#71764)" (#71951)
This reverts commit 70f8fdeeed.
2020-12-08 15:28:30 -08:00
Jenn Magder 70f8fdeeed
Move embedding and linking macOS Flutter frameworks into the tool (#71764) 2020-12-08 11:59:17 -08:00
Pierre-Louis 5bae3b5db3
Add previews for CupertinoIcons (#71853) 2020-12-08 09:13:07 -08:00
Pierre-Louis a51b8e4309
Fix text direction logic for material icon variants (#71852) 2020-12-08 09:08:05 -08:00
Jenn Magder 29f62b272c
Mark hot_mode_dev_cycle_macos_target__benchmark not flaky (#71866) 2020-12-07 13:43:05 -08:00
Emmanuel Garcia d35dd9f8a6
Allow flavors and build types when using plugins (#71738) 2020-12-07 09:23:04 -08:00
Jenn Magder 5b6b67aeaf
Check in manual_tests gitignores (#71761) 2020-12-04 19:31:05 -08:00
Jenn Magder f72e9c779a
Make macrobenchmarks buildable for macos (#71760) 2020-12-04 18:50:17 -08:00
Jenn Magder e1598c96c0
Update macOS Xcode compatibilityVersion (#71745) 2020-12-04 18:35:19 -08:00
Ben Konyi 89ef88c64f
Ensure attaching to an application with an existing DDS instance is not treated as a fatal error (#70847) 2020-12-04 17:16:30 -08:00
Jenn Magder e9abf5a940
Profiling Xcode app should use Flutter profile mode (#71748) 2020-12-04 16:59:19 -08:00
Casey Hillers 2bf8081e52
add test builder as flaky (#71751) 2020-12-04 16:08:06 -08:00
Jenn Magder f0b17f3e26
Remove missing macOS RunnerUITests (#71750) 2020-12-04 15:58:03 -08:00
Jenn Magder d4150d3f6d
Adopt Flutter.xcframework in tool (#71495) 2020-12-04 13:57:11 -08:00
Yegor 7efd7afdf8
Handle the glibc bug that Chrome occasionally hits (#71705) 2020-12-04 12:21:37 -08:00
Jenn Magder e5f2236aba
Turn off flaky module_test_ios FlutterUITests (#71730) 2020-12-04 10:30:13 -08:00
Martin Kustermann 4300226a50
Pass --local-engine* flags from dev/bots/test.dart down to pub test via env variables (#71721) 2020-12-04 09:33:04 -08:00
Christopher Fujino 94d574fa7f
Ensure the packaging script does not overwrite a previous upload (#71597) 2020-12-03 17:07:50 -08:00
xubaolin 8817c0d28c
RefreshIndicator can be shown when dragging from non-zero scroll position (#71303) 2020-12-03 13:28:04 -08:00
Jonah Williams 4e85a67f3e
[flutter_tools] roll deps, fix completion bug (#71671) 2020-12-03 11:58:03 -08:00
Dan Field ece7238402
remove obsolete firebase script (#71609) 2020-12-02 17:18:03 -08:00
Kate Lovett 2520d53eca
Mark hot_mode_dev_cycle_macos_target__benchmark flake (#71616) 2020-12-02 17:50:40 -06:00
Kate Lovett 1c244da28d
Add verbose flag to hot mode tests (#71610) 2020-12-02 16:47:35 -06:00
Jenn Magder f0f9a81968
Update CI to CocoaPods 1.10 (#71531) 2020-12-02 11:05:47 -08:00
Ferhat ebd794a137
[web] Add wrapbox scroll benchmark (#70966) 2020-12-02 08:30:42 -08:00
Jenn Magder 60bdcf55fe
ios_host_app Podfile search paths (#71525) 2020-12-01 21:24:21 -08:00
Emmanuel Garcia 8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 (#71446) 2020-12-01 19:01:09 -08:00
Anna Gringauze eed9835a16
Enable mac web_tool_tests (#71108) 2020-12-01 10:03:09 -08:00
Gary Roumanis 7477524db6
Upgrade deps (#71450) 2020-12-01 09:57:27 -08:00
Jonah Williams e5000f6cea
[flutter_tools] Remove usage of --precompiled flag for web tests (#70977) 2020-12-01 09:54:01 -08:00
Jonah Williams 7ab0442868
Add testing shard for release mode guard (#71411) 2020-12-01 09:53:50 -08:00
Pierre-Louis a7f5fd5360
Update documentation link (#71401) 2020-11-30 13:14:13 +01:00
Amir Hardon 2ceb371d21
Pin the version of flutter/plugins to test against (#71166) 2020-11-24 17:18:06 -08:00
Christopher Fujino 99bc4de73c
mark smoke-catalina flaky (#71188) 2020-11-24 16:59:09 -08:00
Jenn Magder 39155dcb6b
Make simulator framework test check explicit (#71100) 2020-11-23 14:08:05 -08:00
Amir Hardon 2b4a23586d
Add a post-submit test shard for flutter/plugins tests (#70887)
Adds a new Luci test shard that runs flutter/plugins tests.

For now only the analysis phase of the flutter/plugins test suite is executed.

Manual invocation on Luci completed successfully: 3210bb2dac/+/annotations
2020-11-23 12:28:28 -08:00
Amir Hardon 7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808)" (#71096)
This reverts commit 8e73bab94c.
2020-11-23 12:27:36 -08:00
Emmanuel Garcia 61dfbfe105
Wait for Android plugin to load before configuring plugin dependency (#70970) 2020-11-20 18:03:39 -08:00
Emmanuel Garcia 8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808) 2020-11-20 13:05:35 -08:00
Jonah Williams 1e0628001e
[devicelab] dont use set modified for hot reload bench (#70965) 2020-11-20 13:02:28 -08:00
Jenn Magder 9205285772
Uncomment build_ios_framework_module_test tmp cleanup (#70963) 2020-11-20 12:03:21 -08:00
Janice Collins a5519dc75e
Update dartdoc to 0.37.0 (#70882) 2020-11-20 11:18:07 -08:00
Greg Spencer de884f1afe
Remove the nullOk parameter from Navigator.of and add Navigator.maybeOf (#70726)
Adds Navigator.maybeOf to replace calling Navigator.of(context, nullOk: true), and removes the nullOk parameter. Also changes Navigator.of to return a non-nullable value, and removes many (120!) instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-11-20 09:10:46 -08:00
Kate Lovett f4a0511e8b
Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70893) 2020-11-19 17:48:04 -08:00
Jonah Williams a76289bb1b
[flutter_tools] run web unit tests in sound null safety (#70799) 2020-11-19 16:49:05 -08:00
Dan Field 45a7a2c09e
skip flaky test (#70881)
Skip flaky iOS XCUITest
2020-11-19 15:42:09 -08:00
Jenn Magder 7b40272e10
Run module tests on try builders when flutter_tools changes (#70804) 2020-11-19 10:08:29 -08:00
Jonah Williams c6290500f8
[flutter_tools] update dependencies (#70797) 2020-11-18 17:29:28 -08:00
Jonah Williams cfb63356c3
[flutter_tools] use frontend_server for web test compilation (#70714) 2020-11-18 14:55:26 -08:00
Jonah Williams 9424474793
[devicelab] update hot reload benchmark to be more representative (#70643)
update hot reload benchmark to be more representative
2020-11-18 14:54:01 -08:00
Jonah Williams f4e79e6828
[flutter_tools] add support for dart defines to flutter test (#70791) 2020-11-18 14:52:49 -08:00
Chinmoy 830bdfa301
added none property in a DismissDirection (#68987) 2020-11-18 13:28:03 -08:00
Christopher Fujino b8887f47f7
fix and re-enable integration test (#70666) 2020-11-18 11:13:04 -08:00
Pierre-Louis 2f17d4e017
Adaptive icons (#69119)
* refactor update_icons

* fix trailing space

* address feedback

* add platform adaptive icons

* fix merge conflict

* Update dartdoc

* Address feedback

* Specify types

* Add tests

* fix indentation

* Remove trailing space

* Remove isCupertino static bool
2020-11-18 16:04:38 +01:00
Dan Field be2e7bb1c0
Revert "Revert "Allow any iOS app to be added to an existing host app (#70647)" (#70739)" (#70740)
This reverts commit aab9a76ee4.
2020-11-17 22:19:50 -08:00
Dan Field aab9a76ee4
Revert "Allow any iOS app to be added to an existing host app (#70647)" (#70739)
This reverts commit abdd65fc29.
2020-11-17 21:40:28 -08:00
Jenn Magder abdd65fc29
Allow any iOS app to be added to an existing host app (#70647) 2020-11-17 18:53:03 -08:00
Jim Graham 61460d255a
preserve detailFiles entry in TaskResult JSON (#70668)
* preserve detailFiles entry in TaskResult JSON
2020-11-17 16:05:54 -08:00
Ben Konyi 4cbafda853
Roll package:dds to 1.5.1 and add isCompleted guards around completers in base/dds.dart (#70712) 2020-11-17 16:03:18 -08:00
Jenn Magder 9b238a1ff8
Turn off bitcode in ios_app_with_extensions to match normal Flutter projects (#70724) 2020-11-17 14:55:40 -08:00
Jenn Magder 95a5cbcb4a
Add extra Flutter settings to ios_app_with_extensions Podfile (#70719) 2020-11-17 13:44:51 -08:00
Casey Hillers a228a17c57
[devicelab] LUCI builder flag (#70702) 2020-11-17 11:28:03 -08:00
Jenn Magder 2529e358b6
Move Flutter.framework to build directory instead of ios/Flutter (#70224) 2020-11-17 10:09:29 -08:00
Christopher Fujino b8e39b1ad0
skip roll_dev_integration_test (#70653) 2020-11-16 14:11:22 -08:00
Anna Gringauze f9df1935fe
[flutter_tools] Add bot configuration to run web_tool_tests for linux, mac, and windows (#70412)
* Move web integration tool tests to web.shard

Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.

In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.

* Enabled verbose mode for flaky web_tool_tests

* fixed local engine crash with --enable-asserts

* Disable failing tests, fix local engine with asserts

* Removed mac web_tool_tests bot

* Addressed CR comments

* Add disabled mac web_tool_tests and disable win web_tool_tests
2020-11-16 11:50:57 -08:00
Ian Hickson 6cff33832e
More lints (#70500) 2020-11-16 11:07:37 -08:00
Dan Field 90ae09334d
Increase timeouts on XCUITests (#70631) 2020-11-16 10:21:48 -08:00
tiya adc8a42b38
Add bottom to search bar (#68794) 2020-11-16 12:07:20 -05:00
Casey Hillers 0d7270ba0c
Revert "[devicelab] LUCI builder flag (#70464)" (#70496) 2020-11-13 16:38:03 -08:00
Yuqian Li 974689639e
Reland "Add SkiaPerfPoint and FlutterEngineMetricPoint (#70153)" (#70419)
This reverts commit 2a5aa29442.

Additionally, fix a few NNBD issues.

Fixes https://github.com/flutter/flutter/issues/70408
2020-11-13 16:35:08 -08:00
Yuqian Li f7811ea541
e2e perf tests don't have CPU/GPU/memory metrics (#70439)
Address comment in https://github.com/flutter/flutter/pull/66386/files#r522671103
2020-11-13 11:16:50 -08:00
Casey Hillers 004d3f0f75
[devicelab] LUCI builder flag (#70464) 2020-11-13 10:38:03 -08:00
Darren Austin 1c7e34bb20
Migrate flutter_localizations to null safety. (#68645)
Migrate flutter_localizations to null safety.
2020-11-12 15:13:51 -08:00
Jonah Williams 2a5aa29442
Revert "Add SkiaPerfPoint and FlutterEngineMetricPoint (#70153)" (#70407)
This reverts commit a0ec4d67e9.
2020-11-12 14:16:25 -08:00
Jonah Williams 5fedad9173
[flutter_tools] allow using flutter test for testing the tool too (#69911) 2020-11-12 13:52:09 -08:00
Yuqian Li a0ec4d67e9
Add SkiaPerfPoint and FlutterEngineMetricPoint (#70153)
Unit tests that cover their translations are also added.
2020-11-12 13:48:56 -08:00
Jason Simmons b20a9f8170
Set the mixWithOthers option in the Gallery video demo (#70396)
This allows the two videos in the demo to play simultaneously
(matching the behavior from before the recent upgrade to the
video player plugin)
2020-11-12 12:07:13 -08:00
Emmanuel Garcia 0436886ed5
Future can return null (#70324) 2020-11-12 10:29:04 -08:00
keyonghan 80cd32b21f
Revert "mark catalina ios tasks as flaky (#70255)" (#70328) 2020-11-11 16:59:03 -08:00
Anna Gringauze edf26e756d
Move web integration tool tests to web.shard (#70226)
* Move web integration tool tests to web.shard

Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.

In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.

* Enabled verbose mode for flaky web_tool_tests

* Split out the test changes to be commited first
2020-11-11 15:42:15 -08:00
keyonghan d26712e12f
mark catalina ios tasks as flaky (#70255) 2020-11-10 18:19:07 -08:00
Jonah Williams 28ecf05692
[null-safety] opt driver tests into null safety (#70245) 2020-11-10 16:29:13 -08:00
Greg Spencer bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow (#69617)
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate

* remove new test platform dispatchers

* Amend documentation
2020-11-09 15:26:29 -08:00
Emmanuel Garcia b18e2a1cc4
Bump Gallery version (#70130) 2020-11-09 13:05:56 -08:00
Emmanuel Garcia 21e802746b
Migrate Flutter Gallery test to null safety (#70116) 2020-11-09 12:29:14 -08:00
Konstantin Scheglov 9f36a02734
Ignore import_of_legacy_library_into_null_safe (#70115) 2020-11-09 11:41:52 -08:00
Konstantin Scheglov 99e0d3b9cf
Ignore several import_of_legacy_library_into_null_safe (#70107) 2020-11-09 10:54:49 -08:00
Michael Thomsen 168ad5dc4d
Roll engine and fix pubspecs that do not have a Dart SDK constraint (#70078) 2020-11-09 19:02:10 +01:00
Yuqian Li 8e7748e74c
Reland migration (#69996)
This reverts ae0a9cb560 and therefore relands #69629.

Additionally, `flutter update-packages --force-upgrade` has been run to update `pubspec.yaml` to resolve the analyze test failures.
2020-11-08 20:32:04 -08:00
Yuqian Li fb552edcb8
Do not analyze files that are not checked in git (#69723) 2020-11-07 05:19:02 -08:00
Michael Thomsen e4d94f7ccd
Revert "Migrate Flutter gallery test to null safety (#69048)" (#70023)
This reverts commit 7ba775a994.
2020-11-07 12:15:22 +01:00
Emmanuel Garcia 7ba775a994
Migrate Flutter gallery test to null safety (#69048) 2020-11-06 20:38:12 -08:00
Ferhat 40b4d2badc
Add PageView benchmark (representative of full screen CustomPainter) (#69990) 2020-11-06 18:49:03 -08:00
Jim Graham b8d21ad357
Remove the flaky flag from post-bdf benchmark (#69591) 2020-11-06 15:29:04 -08:00
Christopher Fujino 772437627b
[flutter_conductor] update dev/tools with release tool (#69791) 2020-11-06 11:14:04 -08:00
Jonah Williams 75e8428b6b
mark flutter_gallery_sksl_warmup__transition_perf_e2e_ios32 as flaky (#69970) 2020-11-06 10:58:41 -08:00
Jonah Williams 6e3ebc9350
[flutter_tools] only run web shard if requested (#69932) 2020-11-05 23:58:40 -08:00
Jonah Williams 6fe800abd5
[null-safety] remove enable experiment flags (#69930) 2020-11-05 23:58:11 -08:00
Dan Field 76784651d4
Move package:integration_test to flutter/flutter (#69622) 2020-11-05 17:28:47 -08:00
Jonah Williams a3f6ea6f38
[flutter_tools] split web integration tests into new shard (#69914) 2020-11-05 17:21:44 -08:00
Shi-Hao Hong a1a096e35a
[gen-l10n] Fix untranslated messages (#68553) 2020-11-05 16:24:02 -08:00
Jenn Magder bc2a4a6498
Update CocoaPods recommended version to 1.9 (#69809) 2020-11-05 15:13:22 -08:00
Jonah Williams e8efde6a54
[versions] update more null safe versions (#69892) 2020-11-05 09:09:03 -08:00
Jenn Magder 3145c835ed
Deprecate build ios-framework --universal (#69720) 2020-11-04 19:44:04 -08:00
Jenn Magder ae0a9cb560
Revert "Initial migration of metrics_center (#69629)" (#69848)
This reverts commit ada6b7e57e.
2020-11-04 19:18:38 -08:00
Yuqian Li ada6b7e57e
Initial migration of metrics_center (#69629)
For the ease of code reviews, this only includes minimal code from
MetricPoint, GoogleBenchmarksParser, and their unit tests.

See go/flutter-metrics-center-migration for the overall plan.
2020-11-04 17:13:41 -08:00
Jonah Williams 580cacf4bd
[versions] roll versions (#69810) 2020-11-04 15:38:58 -08:00
Jenn Magder c0115c2bc8
Fix prod_builders json (#69828)
This reverts commit 36ff0b2d20.
2020-11-04 14:51:36 -08:00
Jenn Magder 36ff0b2d20
Mark prod_builders tests as not flaky (#69803) 2020-11-04 12:30:01 -08:00
Jonah Williams c985fd35cd
[devicelab] re-land cocoon auto-restart (#69710)
Due to #69707 the SkSL tests need the process killing logic still.
2020-11-03 13:20:40 -08:00
Jenn Magder 91b82347af
Build App.framework directly to build directory (#69699) 2020-11-03 12:48:25 -08:00
Janice Collins c2054196a7
Update dartdoc to 0.36.2 (#69693) 2020-11-03 12:08:03 -08:00
Emmanuel Garcia 212967449b
Update plugins dependencies for the Gallery test (#69630) 2020-11-03 12:03:18 -08:00
Jonah Williams ea3551b058
Revert "[devicelab] reboot attached devices after 30 test runs (#69447)" (#69703)
This reverts commit 406ca0bc59.
2020-11-03 11:13:19 -08:00
Yegor 9e5d22d101
Say [APP] instead of [Gallery] in web benchmarks (#69624) 2020-11-03 10:13:07 -08:00
Jonah Williams 406ca0bc59
[devicelab] reboot attached devices after 30 test runs (#69447) 2020-11-03 10:10:55 -08:00
Jonah Williams 059cd3185c
mark flutter_gallery__transition_perf_e2e_ios32 flaky (#69696) 2020-11-03 10:08:32 -08:00
Jonah Williams 9383ec793b
mark flaky tests as flaky (#69633) 2020-11-02 18:15:20 -08:00
Greg Spencer 88809aa247
Standardize dartdoc macro names (#69445) 2020-11-02 13:28:05 -08:00
Shi-Hao Hong 4996f60b20
[gen_l10n] Fix unintended use of raw string in generateString (#69382)
* Fix failing tests from introducing raw string generation in gen_l10n tool
2020-10-31 19:24:53 +08:00
Greg Spencer c0ef94780c
Fix spelling errors (#69451)
My yearly pass to fix spelling errors in the API dartdocs.
2020-10-31 03:12:27 -07:00
Yegor f03ac0be81
start and stop chromedriver once per sub-shard; do not wait for it to quit (#69443)
* start and stop chromedriver once per sub-shard; do not wait for it to quit

* enable web_long_running_tests but keep them as flaky
2020-10-30 17:27:55 -07:00
Jonah Williams 3e41962dff
[null-safety] update tests and tool auto-detection for null safe dart (#69405)
Disable null safety auto-detection for the web
2020-10-30 13:42:54 -07:00
Zachary Anderson 2562224665
Disable tests that time-out on CI (#69432) 2020-10-30 12:46:44 -07:00
Yegor 6ce36198ee
disable web_long_running_tests due to flakiness (#69430) 2020-10-30 12:15:51 -07:00
Yegor aedd90fd51
enable web_long_running_tests shard (#69350) 2020-10-29 18:15:37 -07:00
Jenn Magder bb495ba90c
Do not fail if average_memory_usage is not recorded (#69339) 2020-10-29 16:09:50 -07:00
Jenn Magder 71c09484fd
Mark flutter_gallery_sksl_warmup__transition_perf_e2e_ios32 as unflaky (#69338) 2020-10-29 16:07:03 -07:00
Yegor 2fa03438de
add web_long_running_tests shard containing long-running web tests (#67324) 2020-10-29 14:23:02 -07:00
Jonah Williams 31c96b5d83
[devicelab] do not fail test if CPU measurement is not recorded (#69268) 2020-10-29 09:32:34 -07:00
stuartmorgan c23319ee9f
Enable dev/bots/ build_tests for Linux (#68658)
Enables build_test for Linux. Currently only flutter_gallery has platform directories for the desktop platforms, so this will run only that build, but this will provide an end-to-end build test for Linux.

Other example/test projects can be brought online for Linux in the future just by adding the linux/ directory to the project.
2020-10-29 09:27:59 -07:00
Jonah Williams 18341efa2f
[devicelab] retry startup of start up test (#69272) 2020-10-29 09:19:07 -07:00
Jonah Williams 83d4351e0c
[devicelab] work around occasional null values for devtools (#69273)
* [devicelab] work around occasional null values for devtools

* Update perf_tests.dart
2020-10-29 09:18:38 -07:00
Jenn Magder 13896b3bd1
Decrease device discovery timeout from 10 to 5 seconds (#69266) 2020-10-28 19:43:19 -07:00
Jenn Magder 135aab9cf5
Increase device run perf test timeout (#69260) 2020-10-28 18:29:04 -07:00
Jonah Williams 7629758ed7
[flutter_tools] measure driver success and failure (#69226)
Currently we only have a test that measures if flutter drive can fail. Unfortunately it has been failing for multiple years based on the fact that the error is due to a missing Gradle config.

Add a smoke success test case, and update both tests to use the test API and the tester-device.
2020-10-28 18:15:23 -07:00
Jonah Williams d306c37bc4
[flutter_tools] fix --use-existing-app (#69237) 2020-10-28 13:55:29 -07:00
Jonah Williams 3b9ef2e8de
[devicelab] mark routing test as flaky (#69228) 2020-10-28 12:11:58 -07:00
Phil Quitslund 0297b0b8b3
mark test packages publish_to: none (#69210) 2020-10-28 11:22:17 -07:00
Jonah Williams 18f0a2288e
[flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 (#69067)
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query

Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
2020-10-27 13:55:32 -07:00
Dan Field 36f9af3f55
reland driver vm_service migration (#69126)
* One more reland of "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)"

This reverts commit e5814756a2.

* pub run test
2020-10-27 11:30:24 -07:00
Jonah Williams e9b18c1d9c
[null-safety] fix the snippets (#69122) 2020-10-27 11:04:16 -07:00
Dan Field e5814756a2
Revert "Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)
This reverts commit 05ab0eba19.
2020-10-27 01:47:03 -07:00
Dan Field 05ab0eba19
Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)
This reverts commit 19ce7a86af.
2020-10-26 19:22:25 -07:00
Jonah Williams 19ce7a86af
Revert "Driver vm service (#68654)" (#69074)
This reverts commit 3ecac303b4.

Co-authored-by: Dan Field <dfield@gmail.com>
2020-10-26 18:56:34 -07:00
Dan Field 3ecac303b4
Driver vm service (#68654)
Migrate flutter_driver to use package:vm_service
2020-10-26 17:09:14 -07:00
Yegor 7a10b46ee0
Print errors in all build modes (#69046) 2020-10-26 15:57:02 -07:00
Jacob MacDonald 193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041)
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
2020-10-26 14:31:13 -07:00
Jonah Williams b44696626c
[null-safety] add language version to freeform template (#69043) 2020-10-26 13:22:36 -07:00
Alexandre Ardhuin 17cdf5559d
enable unnecessary_string_escapes and use_raw_strings (#68302) (#69025) 2020-10-26 12:42:05 -07:00
Pierre-Louis bacc03daf9
Refactor update_icons (#68708)
* refactor update_icons

* fix trailing space

* address feedback

* Rename to _iconsMirroredWhenRTL
2020-10-26 16:35:58 +01:00
Jonah Williams 2c12a8d917
[devicelab] remove twc enabled test and uncaught image test (#68518) 2020-10-24 13:19:51 -07:00
Jonah Williams 9f6b575ef1
[devicelab] mark uncaught exceptions as flaky (#68906)
* [devicelab] mark uncaight exceptions as flaky

* add print error output

* try and fix test
2020-10-23 12:32:08 -07:00
Jonah Williams d75cda9d82
[devicelab] never run pub (#68900) 2020-10-23 11:13:25 -07:00
Jonah Williams f0ecfff3ca
[devicelab] mark twc as flaky and fix flutter test perf (#68895) 2020-10-23 10:39:33 -07:00
Casey Hillers ce3ce20b14
[devicelab] Upload git branch (#68541) 2020-10-23 08:02:02 -07:00
Casey Hillers d2314ecfa9
[Doc Fixit 2020] Move dashboard documentation to flutter/cocoon (#68822) 2020-10-23 06:37:03 -07:00
stuartmorgan 22c502e315
Add Windows build test (#68657)
Enables build_test for Windows. Currently only flutter_gallery has platform directories for the desktop platforms, so this will run only that build, but this will provide an end-to-end build test for Windows.

Other example/test projects can be brought online for Windows in the future just by adding the windows/ directory to the project.
2020-10-22 15:14:30 -07:00
Janice Collins dcc8ced8e4
Update to dartdoc 0.36.1 (#68791) 2020-10-22 14:13:50 -07:00
stuartmorgan 4ea6d3de93
Enable dev/bots/ build_tests for macOS (#68656)
Enables build_test for Windows, macOS, and Linux. Currently only
flutter_gallery has platform directories for the desktop platforms, so
this will run only that build, but this will provide an end-to-end build
test for all three desktop platforms.

Once this lands, other example/test projects can be brought online for
desktop platforms in the future just by adding the relevant platform
directories to the project.
2020-10-22 13:52:19 -07:00
Jonah Williams 37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality (#68650)
* [flutter_tools] remove iOS screenshot on failure functionality

* remove all screenshot code
2020-10-22 13:34:07 -07:00
puelo 24d3999783
Generate RawKeyEvents for iOS 13.4+ (#65193)
* Added RawKeyEvent support for iOS

* Removed unused remnant

* added some missing keys

* Removed trailing whitespaces

* commit for build

* Added mapping names

* Made iOS keycodes generatable and collectable

* Fixed naming and formatting issues

* fixed raw_keyboard_test
2020-10-22 13:33:51 -07:00
Michael Goderbauer dd2ea7c503
Migrate all of examples/layers to sound null safety (#68744) 2020-10-22 13:33:07 -07:00
Michael Goderbauer 8273b99294
Remove dartdoc checker exclusion for class and library files (#68726) 2020-10-22 13:32:55 -07:00
Jonah Williams 16029c3868
[null-safety] try updating snippets for null safety (#68723)
Add a language version so the snippets do not opt-in automatically.

Fixes #68719
2020-10-22 13:18:06 -07:00
Jonah Williams a655a1778d
[null-safety] swap tool unit tests to tester (#68733) 2020-10-22 13:17:31 -07:00
Jacob MacDonald 78f05dfb9f
add sdk constraints where missing to prepare for nnbd flag flip (#68611) 2020-10-21 14:59:44 -07:00
Michael Goderbauer 42f3709a5a
Sound null safety for framework and flutter_test (#68642) 2020-10-21 10:09:11 -07:00
Janice Collins 4a59ee9c31
Updated dartdoc to 0.36.0 (#68641) 2020-10-21 08:47:02 -07:00
Zachary Anderson cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)" (#68714)
This reverts commit ae06c19a37.
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin ae06c19a37
enable unnecessary_string_escapes and use_raw_strings (#68302) 2020-10-21 16:34:24 +02:00
Yuqian Li 8a25557619
Mark the test as flaky again (#68636)
It seems that I was lucky to see 10 consecutive successes. Now the test
seems to be quite flaky again.
2020-10-20 11:58:49 -07:00
Jonah Williams 0e1c3fc7c4
[devicelab] remove commands test (#68539) 2020-10-20 09:50:06 -07:00
Jonah Williams ab20ae782a
[devicelab] uinstall during memory test (#68548) 2020-10-20 09:49:50 -07:00
Jonah Williams 86c6b7fa6c
Revert "update packages (#68569)" (#68622)
This reverts commit 5bee809409.
2020-10-20 09:09:30 -07:00
Dan Field 5bee809409
update packages (#68569) 2020-10-20 08:27:02 -07:00
Yegor ff9082cf6d
Refactor command utilities for tests (#68324)
* refactor command running utilities for tests

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-10-19 20:56:25 -07:00
Jenn Magder d81691d0f4
Revert "Build iOS apps using Swift Packages (#68361)" (#68546)
This reverts commit dd9323bdfb.
2020-10-19 17:57:32 -07:00
Jonah Williams 938fae9c99
remove --machine flag (#68538) 2020-10-19 17:06:28 -07:00
Jonah Williams a152c0f429
[devicelab] reland: reduce iterations of startup test, use application binary (#68532)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.

The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5

Uninstall the app after each run so temp storage does not fill up.
2020-10-19 16:51:28 -07:00
Yuqian Li 91a5a1e7f9
Mark e2e ios32 warmup test as nonflaky (#68511) 2020-10-19 15:52:05 -07:00
Jenn Magder dd9323bdfb
Build iOS apps using Swift Packages (#68361) 2020-10-19 15:47:04 -07:00
Jonah Williams 4a3e2a1af5
Revert "[devicelab] reduce iterations, uninstall at end, and use --application-binary in all startup tests (#68516)" (#68531)
This reverts commit a4c2075a45.
2020-10-19 15:05:46 -07:00
Jonah Williams 8262f808ba
Revert "[devicelab] fix flutter gallery app name (#68528)" (#68530)
This reverts commit 0f69f8e53b.
2020-10-19 15:05:10 -07:00
Jonah Williams 0f69f8e53b
[devicelab] fix flutter gallery app name (#68528) 2020-10-19 14:48:05 -07:00
Jonah Williams a4c2075a45
[devicelab] reduce iterations, uninstall at end, and use --application-binary in all startup tests (#68516)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.

The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5

Uninstall the app after each run so temp storage does not fill up.
2020-10-19 14:16:04 -07:00
Casey Hillers 1c35091a13
[devicelab] Cocoon client (#68333) 2020-10-19 13:12:04 -07:00
Jonah Williams e8dc7a2e17
[devicelab] update hostonly tests to use flutter directly or precache deps (#68487)
Fixes #67370

By running most of these executions through flutter, we get the benefit of the flutter error handling and precaching. IN the test where this is not feasible, call pre-cache directly.
2020-10-19 13:01:50 -07:00