Commit graph

11741 commits

Author SHA1 Message Date
Jonah Williams c63c576bca
Reland handle corrupt config file (#45414) 2019-11-22 12:26:51 -08:00
Jonah Williams 60869e0a93
Improve time to development by initializing frontend_server concurrently with platform build (#45236) 2019-11-22 12:26:31 -08:00
Alexandre Ardhuin 0a66d8a7a4
implicit-casts:false in fuchsia_remote_debug_protocol (#45239) 2019-11-22 20:33:47 +01:00
Kate Lovett e2cf2f0fa2
SliverOpacity (#44289) 2019-11-22 11:12:09 -08:00
xster 942707591d
Revert "catch parse error from corrupt config (#45319)" (#45412) 2019-11-22 10:56:16 -08:00
Jonah Williams 6640c8b9b4
catch parse error from corrupt config (#45319) 2019-11-22 10:09:23 -08:00
Jonah Williams 497ae83c82
Fix experimental incremental web compiler for Windows (#45286) 2019-11-22 10:08:38 -08:00
Kate Lovett 9f17a43ebe
SliverIgnorePointer (#45127) 2019-11-22 09:54:09 -08:00
Yegor aa3943316b
Fix dartDefines in daemon mode (#45317)
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Greg Spencer a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin fcb40a05bb
make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
Todd Volkert 4c64b715d9
Revert "Add option to delay rendering the first frame (#45135)" (#45385)
This reverts commit d285b8843f.
2019-11-21 22:12:24 -08:00
Todd Volkert cb35c88b34
Add widget of the week video embeddings (#45362) 2019-11-21 22:07:03 -08:00
Amir Hardon e43a69a9fe
Allow a no-op default_package key for a plugin platform (#45364) 2019-11-21 16:37:34 -08:00
Zachary Anderson 05226d2a61
Reland: [flutter_tool] Fuchsia AOT builds (#45350)
* Reland: [flutter_tool] Fuchsia AOT builds

* Fixes
2019-11-21 12:55:39 -08:00
Jonah Williams 785e557a43
remove Flags (#45320) 2019-11-21 12:52:52 -08:00
Kaushik Iska 1fae83cf2c
[fuchsia] Reland use sky_engine from Topaz (#45282)
Testes on the Fuchsia tree by reverting it locally.

This reverts commit f45bd48cca.
2019-11-21 12:48:32 -08:00
Michael Goderbauer d285b8843f
Add option to delay rendering the first frame (#45135) 2019-11-21 12:13:45 -08:00
Zachary Anderson 0216953674
Revert "[flutter_tool] Fuchsia AOT builds (#45187)" (#45349)
This reverts commit a57dddd217.
2019-11-21 09:41:46 -08:00
Alexandre Ardhuin 1f3ff5ca42
implicit-casts:false in flutter_goldens and flutter_goldens_client (#45249)
* implicit-casts:false in flutter_goldens and flutter_goldens_client

* fix type
2019-11-21 17:46:37 +01:00
Zachary Anderson a57dddd217
[flutter_tool] Fuchsia AOT builds (#45187) 2019-11-21 08:32:58 -08:00
Alexandre Ardhuin 9efaa784ad
implicit-casts:false in flutter_web_plugins (#45240) 2019-11-21 11:22:01 +01:00
Emmanuel Garcia 5df4b7db23
Reland: Attach looks at future observatory URIs (#45307) 2019-11-20 18:51:25 -08:00
Amir Hardon 53c7ca7d5a
Allow unknown fields in pubspec plugin section (#45303) 2019-11-20 17:00:46 -08:00
Gary Qian 6b66d79436
Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622) 2019-11-20 16:37:10 -08:00
Jonah Williams 106b8eb9c0
Revert "Reduce some direct package:archive usage (#44608)" (#45291)
This reverts commit 6b5634fed3.
2019-11-20 14:45:32 -08:00
Jonah Williams 6b5634fed3
Reduce some direct package:archive usage (#44608) 2019-11-20 13:32:14 -08:00
chunhtai 314eb3bae3
Moving pointer event sanitizing to engine. (#44217) 2019-11-20 13:04:29 -08:00
Todd Volkert ce8e2bb7cf
Revert "[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)" (#45268)
This reverts commit 421bf64703.

Was causing severe breakages in Google.
2019-11-20 10:42:23 -08:00
Jonah Williams f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
Anthony 421bf64703
[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
2019-11-20 18:18:40 +01:00
Danny Tuppeny 73c32545b7
Fix device daemon test when desktop or web are enabled (#45172) 2019-11-20 11:02:35 +00:00
Emmanuel Garcia fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237)
This reverts commit 2135e9fb1e.
2019-11-19 23:14:25 -08:00
Emmanuel Garcia 2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
Jonah Williams c724504142
Update Android CPU device detection (#45139) 2019-11-19 19:04:17 -08:00
Ian Hickson b75abd9f7e
Try a mildly prettier FlutterError and make it less drastic in release mode. (#44967) 2019-11-19 17:35:47 -08:00
Greg Spencer 0d27fdced9
Scroll scrollable to keep focused control visible. (#44965)
Before this change, it was possible to move the focus onto a control that was no longer in the view using focus traversal. This changes that, so that when a control is focused, it makes sure that if it is the child of a scrollable, that the scrollable attempts to keep it in view. If it is already in view, then nothing scrolls.

When asked to move in a direction, the focus traversal code tries to find a control to move to inside the scrollable first, and then looks for things outside of the scrollable only once the scrollable has reached its limit in that direction.
2019-11-19 17:10:34 -08:00
Emmanuel Garcia 7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211)
This reverts commit 6d77996d6a.
2019-11-19 16:47:39 -08:00
chunhtai 99324105da
reland add lifecycle enum and fix the scheduleforcedframe (#45133)
* reland add lifecycle enum and fix the scheduleforcedframe
2019-11-19 15:45:37 -08:00
Greg Spencer a3186fbaa1
Analyze dartpad (#45124)
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors.

Also, added a --verbose option to the sample analyzer.
2019-11-19 15:16:12 -08:00
Jenn Magder 1f296ad78c
Remove chmod to make Flutter framework headers unwritable (#45189) 2019-11-19 15:13:33 -08:00
Emmanuel Garcia 6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny 37eec86294
Allow web server device to use extension if started with --start-paused (#44263)
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
2019-11-19 20:11:53 +00:00
Jonah Williams df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jonah Williams e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Alexandre Ardhuin 0df8812681
fix type errors (#45151) 2019-11-19 09:28:24 +01:00
Alexandre Ardhuin 4bf03c6cf8
implicit-casts:false in flutter_test (#44996) 2019-11-19 08:10:24 +01:00
Alexandre Ardhuin adc7351046
implicit-casts:false on flutter_tools/lib (#44447)
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
2019-11-19 07:57:42 +01:00
Kaushik Iska f45bd48cca
Revert "[flutter_runner] Use sky_engine from the topaz tree (#44935)" (#45141)
This reverts commit f48f457350.
2019-11-18 19:36:50 -08:00
Greg Spencer 6e10719dc5
FocusableActionDetector widget (#44867)
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms.

I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it.

Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
2019-11-18 17:23:30 -08:00