Commit graph

4703 commits

Author SHA1 Message Date
Flutter GitHub Bot cfdc35859e
roll packages (#119865) 2023-02-02 23:59:49 +00:00
Christopher Fujino d820aec786
Manual pub roll with dwds fix (#119575)
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
2023-02-02 21:38:08 +00:00
Jesús S Guerrero d63987f71d
Parser machine logs (#118707)
* remove file reporter optional

* decouple stack trace from metric collections

* update tests; add collect metrics option

* add failed tests property

* add test for multiple stack failed

* change path on result

* create factory method

* throw exception when test file failed to generate

* remove catch of file exception

* handle when no stacktrace on file reporter
2023-02-02 20:04:06 +00:00
Michael Goderbauer b0f1714b7b
Make Flex,Row,Column const for real (#119673)
* Make Flex,Row,Column const for real

* dart fix --apply

* fix snippets

* fix integration test

* add comment
2023-02-02 19:33:57 +00:00
Andrew Kolos fd76ef0f26
Reland "Add API for discovering assets" (#119277)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* revert image resolution changes

* Update image_resolution_test.dart

* Update decode_and_parse_asset_manifest.dart

* make targetDevicePixelRatio optional

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* fix immutable not being imported

* return List in AssetManifest methods, fix annotation import

* simplify onError callback

* make AssetManifest methods abstract instead of throwing UnimplementedError

* simplify AssetVariant.key docstring

* tweak _AssetManifestBin docstring

* make AssetManifest and AssetVariant doc strings more specific

* use List.of instead of List.from for type-safety

* adjust import

* change _AssetManifestBin comment from doc comment to normal comment

* revert to callback function for onError in loadStructuredBinaryData

* add more to the docstring of AssetManifest.listAssets and AssetVariant.key

* add tests for CachingAssetBundle caching behavior

* add simple test to ensure loadStructuredBinaryData correctly calls load

* Update asset_manifest.dart

* update docstring for AssetManifest.getAssetVariants

* rename getAssetVariants, have it include main asset

* rename isMainAsset field of AssetMetadata to main

* (slightly) shorten name of describeAssetAndVariants

* rename describeAssetVariants back to getAssetVariants

* add tests for TestAssetBundle

* nits

* fix typo in docstring

* remove no longer necessary non-null asserts

* update gallery and google_fonts versions

---------

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2023-02-02 15:17:15 +00:00
Ian Hickson 4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. (#119587) 2023-02-01 23:57:54 +00:00
Kevin Chisholm 484d881f27
[conductor] update console link (#118338)
* update console link

* update test to include new console link
2023-02-01 14:05:45 -06:00
Hans Muller 198a51ace9
Migrate the Material Date pickers to M3 Reprise (#119033) 2023-01-31 15:31:06 -08:00
Michael Goderbauer 6a5405925d
Make MultiChildRenderObjectWidget const (#119195) 2023-01-31 11:13:59 -08:00
Chris Bracken d272a3ab80
Reland: [macos] add flavor options to tool commands (#119564)
* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Michael Goderbauer 5b6572f96d
Add debug diagnostics to channels integration test (#119579) 2023-01-31 02:55:01 +00:00
Camille Simon 59d80dc876
[Android] Add explicit exported tag to Linux_android flavors test (#117542)
* Add exported tag

* Undo testing changes
2023-01-30 18:47:51 +00:00
Flutter GitHub Bot b68cebd9ce
roll packages (#119530) 2023-01-30 18:46:35 +00:00
Flutter GitHub Bot df8ad3d2cb
roll packages (#119370) 2023-01-30 17:34:10 +00:00
Michael Goderbauer 2e8bebd178
Remove single window assumption from macrobenchmark (#119368) 2023-01-27 20:42:42 +00:00
Danny Tuppeny 0b57596712
Run "flutter update-packages --force-upgrade" (#119340) 2023-01-27 17:20:18 +00:00
Christopher Fujino a04ab7129b
Revert "Add API for discovering assets (#118410)" (#119273)
This reverts commit 2b8f2d0504.
2023-01-26 20:01:12 +00:00
Andrew Kolos 2b8f2d0504
Add API for discovering assets (#118410)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* revert image resolution changes

* Update image_resolution_test.dart

* Update decode_and_parse_asset_manifest.dart

* make targetDevicePixelRatio optional

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* fix immutable not being imported

* return List in AssetManifest methods, fix annotation import

* simplify onError callback

* make AssetManifest methods abstract instead of throwing UnimplementedError

* simplify AssetVariant.key docstring

* tweak _AssetManifestBin docstring

* make AssetManifest and AssetVariant doc strings more specific

* use List.of instead of List.from for type-safety

* adjust import

* change _AssetManifestBin comment from doc comment to normal comment

* revert to callback function for onError in loadStructuredBinaryData

* add more to the docstring of AssetManifest.listAssets and AssetVariant.key

* add tests for CachingAssetBundle caching behavior

* add simple test to ensure loadStructuredBinaryData correctly calls load

* Update asset_manifest.dart

* update docstring for AssetManifest.getAssetVariants

* rename getAssetVariants, have it include main asset

* rename isMainAsset field of AssetMetadata to main

* (slightly) shorten name of describeAssetAndVariants

* rename describeAssetVariants back to getAssetVariants

* add tests for TestAssetBundle

* nits

* fix typo in docstring

* remove no longer necessary non-null asserts

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2023-01-26 19:05:00 +00:00
Todd Volkert b319938ecd
Add more flexible image API (#118966)
This updates the framework to provide higher level wrappers around ui.instantiateImageCodecWithSize(). Functionally, this doesn't change anything (other than deprecating the older loadBuffer() method in favor of loadImage()), but it sets the stage for a simpler change that will allow us to provide a more flexible way to load sized images.

#118543
2023-01-25 21:21:28 -08:00
Flutter GitHub Bot 9037e3fe26
roll packages (#119192) 2023-01-25 23:53:42 +00:00
yaakovschectman 455e6aca50
Test integration test apps' runner files against current template app (#118646)
* Create template file test

* Add to .ci.yaml

* Add to TESTOWNERS

* Organize test script

* Push license to top of file

* Equals sign

* Utilize path.join

* Expand error message

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Fix missing newline string

* Move template file test to analyze.dart

* Fix newline

* Var name

* Fix extension length

* Use ignore-list for filenames

* Update dev/bots/analyze.dart

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Indentation

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-01-24 17:00:22 -05:00
stuartmorgan e3c51a2f2a
Add Windows unit tests to plugin template (#118638)
* Add Windows unit tests to plugin template

Adds an example native unit test to the plugin template for Windows,
matching the format we use for our 1P plugin example app unit tests.
Once these have been added for all platforms+languages, they will be
documented on a new plugin development page to explain their use.

Since we don't appear to be running our current plugin e2e tests for
Windows, this adds a new configuration to run them. I haven't
`led`-tested this, so it may not work, but this will give a starting
point for getting them running.

Part of https://github.com/flutter/flutter/issues/82458

* Minor fix

* Add test owner

* Fix typo

* Fix test feature flag
2023-01-24 18:23:57 +00:00
Christopher Fujino 64b4c69bcc
roll pub deps and remove archive, crypto, typed_data from allow-list (#119018)
* roll pub deps and remove archive, crypto, typed_data from allow-list

* un-comment code
2023-01-24 01:55:06 +00:00
yaakovschectman 5e50ed972b
Test Utf8FromUtf16 (#118647) 2023-01-23 16:07:55 -05:00
Michael Goderbauer c757df3bfa
Remove unnecessary null checks in dev/bots (#118846) 2023-01-21 01:39:19 +00:00
Michael Goderbauer 70cecf6c9e
Remove unnecessary null checks in dev/*_tests (#118844) 2023-01-21 01:36:12 +00:00
Jenn Magder 25843bdb5a
Remove macOS impeller benchmarks (#118917)
* Remove macOS impeller benchmarks

* TESTOWNERS
2023-01-21 01:34:53 +00:00
Michael Goderbauer ab3c82244e
Remove unnecessary null checks in dev/devicelab (#118842) 2023-01-20 18:56:44 +00:00
Michael Goderbauer 99b5262b21
Remove unnecessary null checks in dev/tools (#118845) 2023-01-20 04:06:09 +00:00
Michael Goderbauer 54217bd4b1
Remove unnecessary null checks in dev/benchmarks (#118840)
* Remove unnecessary null checks in dev/benchmarks

* empty
2023-01-20 04:04:11 +00:00
Michael Goderbauer ec51d3271e
Remove unnecessary null checks in ‘dev/conductor’ (#118843)
* Remove unnecessary null checks in dev/conductor

* review
2023-01-20 04:04:08 +00:00
Jenn Magder 030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool (#118421)" (#118858)
This reverts commit 73096fd96e.
2023-01-20 03:46:45 +00:00
Alex Wallen 73096fd96e
[macos] add flavor options to commands in the flutter_tool (#118421)
* Add new macos target configured for flavors

* Rename Free App copy-Info.plist to Free App Info.plist

* Remove bogus entitlements

* Remove Generated.xcconfig

* Audit project.pbxproj

* Remove unused configs

* share one info.plist

* Modify scheme so that paid app works

* Codesign automatic

* Pipe flavor as scheme into xcodebuild

* Ignore incoming flavor string

* pipe flavor for flutter run to work

* Add devicelab tests

* Error if host and target device are same for flutter install desktop

* Avoid bang (!) by promoting a local.

Co-authored-by: Jenn Magder <magder@google.com>

* Add supportsInstall property

* Override  in test classes

* Add install test on macOS

* Refactor application_package and add tests for package directory

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
2023-01-19 23:52:16 +00:00
David Landeros c5ceff11dd
[flutter_tools] Ensure service worker starts caching assets since first load (#116833)
* [Flutter_tools] Ensure service worker starts caching assets since the first launch

* [flutter_tools] add comment to give some context on self.clients.claim()

* [flutter_tools] add comment to give some context on self.clients.claim()
2023-01-19 21:52:52 +00:00
Alex Wallen 22520f54df
[macOS] Add timeline summary benchmarks (#118748)
* Add new task runner for impeller enabled complex layout test

* Add new target in .ci.yaml

* Claim ownership of complex_layout_scroll_perf_impeller_macos__timeline_summary

* Task runner for non-impeller enabled scroll test

* Add test target for non impeller complex layout scroll

* claim ownership of the last target

* mark as bringup

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 21:29:19 +00:00
Mitchell Goodwin ea36b3a5a7
Add focus detector to CupertinoSwitch (#118345)
* Add focus detector to CupertinoSwitch

* Add comment

* Remove whitespace

* Add focusColor constructor to CupertinoSwitch

* Remove whitespace

* Add color type

* Remove gap in border

* Adjust color and line thickness
2023-01-19 18:30:06 +00:00
Danny Tuppeny 06909ccfa4
Update packages + fix tests for javascript mime change (#118617)
Update test expectations from application/javascript -> text/javascript

`package:mime` now uses `text/javascript` and not `application/javascript`.

See https://github.com/dart-lang/mime/pull/76.
See https://datatracker.ietf.org/doc/html/rfc9239.

> This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is `text/javascript`; all others are considered historical and obsolete aliases of `text/javascript`.
2023-01-19 09:54:40 -05:00
Alex Wallen d53cc4a10f
[macOS] New e2e_summary benchmark fails without Cocoapods. (#118754)
* Add gems as a dep - fails without

* Add missing entitlements to run app on macos

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 08:04:22 +00:00
Jenn Magder ffcf63ae88
Add verbose flag to plugin_dependencies_test to debug flake (#118755) 2023-01-19 00:02:25 +00:00
dependabot[bot] b3059d2c09
Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (#118745)
Bumps [activesupport](https://github.com/rails/rails) from 6.1.5 to 6.1.7.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.0.4.1/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.1.5...v6.1.7.1)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-18 23:27:27 +00:00
Alex Wallen 666dccc85e
[macOS] bringup new e2e_summary devicelab test (#118717)
* Add new task runner for animated_complex_opacity_perf_impeller e2e_summary on macos

* Register new target for macos e2e_summary task

* Claim ownership in TESTOWNERS

* Add task runner for animated complex opacity without impeller

* Register new target in .ci.yaml for non-impeller test

* Claim ownership of non-impeller task

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-18 22:33:49 +00:00
Alex Wallen 3348987546
Add new macos target configured for flavors (#117352)
Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-18 07:50:25 -08:00
Ricardo Amador f989d551ce
Devicelab android emulator (#113472)
* Testing whether emulator is possible.

* Adding changes to see if emulator can be used from recipe.

* adding emulator support.

* Add the emulator flag for testing.

* Using string for boolean since it cannot be parsed in properties

* Checking to see if these changes are being used.

* Updated bool back to string

* Remove trailing whitespace from file.
2023-01-17 22:01:11 +00:00
Darren Austin 6fafbc33f2
Updated tokens to v0.152 (#118594) 2023-01-17 12:32:47 -08:00
Victoria Ashworth b4d72752bd
Add Info.plist from build directory as input path to Thin Binary build phase (#118209)
* Add Info.plist from build directory as input path to Thin Binary build phase

* fix directive ordering

* migrate benchmark, integration, and example tests
2023-01-13 13:41:08 -06:00
Loïc Sharma cea55d99d0
[Linux] Add a 'flutter run' console output test (#118279)
* Add Linux support for the UI integration test project

* Add Linux run console test
2023-01-13 19:17:12 +00:00
Andrew Kolos 5630d531b1
[tool] Generate a binary version of the asset manifest (#117233)
* initial

* update asset_bundle_package_test

* Update asset_bundle_test.dart

* Update asset_bundle_package_fonts_test.dart

* update pubspec checksum for smc dependency

* flutter update-packages --force-upgrade

* prefer += 1 over ++

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* add regexp comment

* rescope int list comparison function

* update packages

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2023-01-12 19:33:30 +00:00
Taha Tesser 0d91c0343b
Fix M3 Drawer default shape in RTL (#118185) 2023-01-12 14:22:53 +00:00
Flutter GitHub Bot 01583b7486
roll packages (#118272) 2023-01-10 23:03:04 +00:00
Jonah Williams 1d2e62b764
remove unsound mode web test (#118256) 2023-01-10 19:03:27 +00:00