Commit graph

20051 commits

Author SHA1 Message Date
Ming Lyu (CareF) c2368bdd6f
bug fix for pointer id in test gestures (#63816) 2020-08-15 10:41:02 -07:00
Dan Field d1583fc39b
drop xcpretty for tests (#63804) 2020-08-14 20:09:41 -07:00
Remi Rousselet 2b25e29192
add benchmark for ChangeNotifier.notifyListeners (#62715) 2020-08-14 17:06:03 -07:00
Tong Wu da98319de6
Add an infra issue template (#63730) 2020-08-14 16:51:04 -07:00
Konstantin Scheglov 236507f058
Provide the argument for a required parameter 'data'. (#63728) 2020-08-14 16:46:03 -07:00
LongCatIsLooong 64d76f2fb7
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413) 2020-08-14 16:41:03 -07:00
Ming Lyu (CareF) 6f26e806ab
bug fix for flutter_gallery__transition_perf(_with_semantics) (#63799)
* report failure for semantics test

* bug fix
2020-08-14 19:37:08 -04:00
Nolan Scobie ede1b15b76
Add viewport documentation breadcrumbs (#63192) 2020-08-14 15:56:02 -07:00
Zachary Anderson f360d8b8e8
[flutter_tool] Fix some create_test.dart tests on Windows (#63796) 2020-08-14 15:26:29 -07:00
Paul Berry d80aa48001
Ignore/fix dead_code checks for weak-only null checks. (#63794)
Now that https://github.com/dart-lang/sdk/issues/41985 is fixed, the
analyzer detects dead code due to "unnecessary" null checks.  Since we
want to retain null checks in Flutter even when they appear
unnecessary (in order to preserve runtime behavior in weak mode), we
need to suppress these dead code hints.

Note that one assertion is removed by this PR (`heightFactor != null
|| (heightFactor == 1.0 && heightDelta == 0.0)`).  This is because
`heightFactor == 1.0 && heightDelta == 0.0` can only be true if
`heightFactor != null`, so this assertion is equivalent to simply
asserting that `heightFactor != null`, which is already asserted two
lines above.
2020-08-14 14:18:38 -07:00
keyonghan 8d4aef0d51
Add enabled flag for try builders (#63783)
* add enabled flag

* remove flaky flag for try builders

* remove trailing space
2020-08-14 13:22:49 -07:00
Michael Goderbauer f512e86c2a
Use reportError (over onError) everywhere (#63784) 2020-08-14 12:03:18 -07:00
Michael Goderbauer 37ddad61ca
Make textfields restorable (#63401) 2020-08-14 12:02:38 -07:00
Declan Woods 03dcd1bd5a
Fix SafeArea and SliverSafeArea debug flag properties (#63455) 2020-08-14 12:01:05 -07:00
Juyeong Lee 5ec7426be7
Remove enableR8=true from gradle.properties (#63339) 2020-08-14 10:26:03 -07:00
Rami a609bb374c
Mention time picker theme in showTimePicker documentation (#63776) 2020-08-14 10:06:02 -07:00
Alexandre Ardhuin 96f3645037
migrate painting to nullsafety (#63703)
* migrate painting to nullsafety

* address review comments
2020-08-14 17:40:00 +02:00
godofredoc 48b9c3d39b
Remove hostonly_tests from cirrus as they are now running on LUCI. (#63257)
* Remove hostonly_tests from cirrus as they are now running on LUCI.

Bug:
  https://github.com/flutter/flutter/issues/63242

* Remove templates add framework tests for linux back.
2020-08-14 00:04:33 -07:00
godofredoc 58feba8edd
Update task_names to add the platform. (#63736) 2020-08-13 21:16:04 -07:00
MH Johnson bee9522f18
[Text Scaling][Material] Update BottomNavigationBar to show tooltips on long press. (#59127) 2020-08-13 22:53:27 -04:00
stuartmorgan 6f0cfc9524
Surface Windows build errors in non-verbose mode (#63707) 2020-08-13 19:46:02 -07:00
godofredoc 89f004e0d3
Add windows builders to presubmit. (#63726) 2020-08-13 19:00:20 -07:00
Wikiwix 88118bcbd1
Fix sort indicator for DataTables (#62795)
* Fix sort indicator for DataTables

As per material spec ascending order should be shown via an upward arrow
This commit changes the displayed arrows accordingly.

* Test sort indicator orientation in DataTable
2020-08-13 15:17:43 -07:00
Yuqian Li 3ff76f47fb
Add clipBehavior to ListView, GridView, PageView (#63147)
These widgets are missing from
https://github.com/flutter/flutter/pull/59364

With this change, developers can use clipBehavior for
https://github.com/flutter/flutter/issues/59424
2020-08-13 15:01:41 -07:00
Michael Goderbauer 39a46bedad
Remove decommission from RestorationBuckets (#63687) 2020-08-13 15:01:04 -07:00
Jonah Williams 06c3de3285
[flutter_tools] remove most globals from build system and tests (#63697)
Remove globals and testbed to simplify test cases, using the existing environment configuration. This is some pre-factoring work to make landing #63610 easier
2020-08-13 15:00:27 -07:00
renyou 32ee00849c
Revert "Fix RangeMaintainingScrollPhysics" (#63611) 2020-08-13 14:46:04 -07:00
Ming Lyu (CareF) 360023e2bc
Clean up flutter_gallery__transition_perf (#63609) 2020-08-13 14:41:04 -07:00
Paul Berry 8f896c9027
Ignore another dead_code hint for a weak-only null check. (#63602) 2020-08-13 14:36:08 -07:00
godofredoc 0ec50a8e63
Add win (#63594) 2020-08-13 14:31:09 -07:00
Jonah Williams 9e162cb310
Revert "Add native stacktrace field for PlatformException (#63502)" (#63705)
This reverts commit c67eafa87d.
2020-08-13 14:03:11 -07:00
LI DONGZE c67eafa87d
Add native stacktrace field for PlatformException (#63502)
* Add native stacktrace field for PlatformException

* Mute the readValue check for stacktrace.

* polish

* Add unit test and further polish

* Added more comments

* remove unnecessary import

* fill in stacktrace to JSONMethodCodec and fix tests

* fix style

* Fix format

* Remove unnecessary TODO since not all explicitly declared errors have stacktrace in it from native side.

* Handle case for exception without stacktrace on jsonMethodCodec

* Add more unit tests

* format test

Co-authored-by: Ben Li <libe@google.com>
2020-08-13 11:43:50 -07:00
stuartmorgan fcbee10da9
[windows] Propagate startup errors in template (#63612) 2020-08-13 11:31:03 -07:00
Nils Reichardt 337c5cfc52
Update finders.dart (#63600) 2020-08-13 11:30:34 -07:00
Jonah Williams 2526ef1235
[flutter_tools] update size analysis (#63617) 2020-08-13 11:28:52 -07:00
Chase Latta b1a9f56487
remove fuchsia_entrypoint_shim directory (#63605) 2020-08-13 11:26:05 -07:00
Haeseok Lee 0174af8bd7
Update LinearGradient docs (#63604) 2020-08-13 11:21:04 -07:00
Rami 1de673bcda
Ensure time picker input mode lays out correctly in RTL (#63599) 2020-08-13 14:16:15 -04:00
Kate Lovett eb60849e93
Pin goldctl (#63593) 2020-08-13 11:16:04 -07:00
Greg Spencer 21f4096267
Revert: Update prepare_package.dart to use the process_runner package instead having duplicate code. #62710 (#63608)
This reverts #62710, since it has a noSuchMethodError in some circumstances.

This isn't just a straight git revert, because I had to resolve the conflicts in the reverted pubspec.yaml files and re-run flutter update-packages --force-upgrade to make the checksums match.
2020-08-13 08:43:20 -07:00
Konstantin Scheglov bd1a58a991
Add arguments for required parameters. (#63598) 2020-08-13 08:16:33 -07:00
Shi-Hao Hong 0a7c6243fa
[gen_l10n] Absolute project path parameter (#63368) 2020-08-13 05:11:05 -07:00
Ming Lyu (CareF) 0629030a05
WidgetTester.drag with time duration (#63410) 2020-08-12 21:01:03 -07:00
engine-flutter-autoroll 4ad90c4d1c
Roll Engine from ccfc7e5179db to 7571e7c380fd (2 revisions) (#63567) 2020-08-12 18:01:05 -07:00
Emmanuel Garcia febcbcb885
Print dex when analyzing the APK (#63538) 2020-08-12 17:56:04 -07:00
Dan Field bc74ae5437
Remove unused files (#63532) 2020-08-12 15:41:05 -07:00
Mouad Debbar cbb821abe4
Hide benchmark a/b results from git (#63518) 2020-08-12 15:36:06 -07:00
Justin McCandless 441d7f3fb8
InteractiveViewer scale interpretation improvement (#63543) 2020-08-12 15:31:09 -07:00
Alexandre Ardhuin afc9509996
allow null in compute for weak mode (#63515) 2020-08-12 15:31:05 -07:00
Alexandre Ardhuin be868397be
migrate part of painting to nullsafety (#63495) 2020-08-12 15:26:09 -07:00