Commit graph

20550 commits

Author SHA1 Message Date
Juyeong Lee 551a2a6b69
Improve Stepper controlsBuilder docs (#63910) 2020-09-11 14:40:03 -07:00
renyou 51bb11f7ce
Revert "Reland "Make sure all isolates start during flutter driver tests" (#64432)" (#65635)
This reverts commit ccd4f6dd18.
2020-09-11 14:15:31 -07:00
engine-flutter-autoroll 3dfbdac6f4
983b0ef16 Roll Dart SDK from 1abce6d054ad to 14f1940f537e (1 revision) (flutter/engine#21092) (#65639) 2020-09-11 08:40:03 -07:00
engine-flutter-autoroll 620cd16cf0
Roll Engine from bdaac368f85f to a0bd862cc0d4 (2 revisions) (#65618) 2020-09-11 07:35:03 -07:00
engine-flutter-autoroll 37e2013774
Roll Engine from e831433a20ca to bdaac368f85f (13 revisions) (#65607) 2020-09-11 01:05:02 -07:00
godofredoc 53f9653e6b
Add mac builders to try configurations. (#65578) 2020-09-10 20:20:04 -07:00
engine-flutter-autoroll 652b2c2cfc
Roll Engine from fee6f9e53334 to e831433a20ca (7 revisions) (#65592) 2020-09-10 18:10:03 -07:00
Alexander Brusher 68660e127c
Disables test failing due to new semantics flag. (#65194)
This change disables a failing test prevent PR #20385 from merging.
2020-09-10 16:44:32 -07:00
Ben Konyi 577de1c44e
Roll forward package:test to 1.16.0-nullsafety.4 to prepare for (#65571) 2020-09-10 15:55:03 -07:00
Greg Spencer 3055ae4e93
Eliminate the need for the mockito package in animated_icons_private_test (#65199) 2020-09-10 15:50:03 -07:00
Hans Muller 13860a7d23
Revert "Re-land ScaffoldMessenger (#65416)" (#65482)
This reverts commit adc5f26b50.
2020-09-10 13:17:51 -07:00
stuartmorgan ee4fa1b34e
Update Windows app template (#65511) 2020-09-10 13:10:04 -07:00
Jonah Williams 0ea0e9d0b3
[flutter_tools] remove advice about running sdkmanager directly (#65426) 2020-09-10 13:05:03 -07:00
Per Classon ba1aeb409e
Reland "Add DataTableTheme to allow for themable DataTables (#64316)" (#65383) 2020-09-10 13:00:04 -07:00
xster 65ae30c8cc
Update create templates to 1.0.0 (#65234) 2020-09-10 12:57:56 -07:00
Shardul Nalegave 330db46da1
Fixed Tooltip widget docs. According to issue #53072 (#65250) 2020-09-10 12:55:05 -07:00
godofredoc f246a8ce8b
Add mac builder in prod. (#65566) 2020-09-10 12:50:10 -07:00
Brian Eaton ccd4f6dd18
Reland "Make sure all isolates start during flutter driver tests" (#64432) 2020-09-10 12:50:04 -07:00
Zachary Anderson 1b46023ebd
Manual roll of Engine to 5ddbcc7120d7c880aa2210cb4b1abca661d6acdc (#65555) 2020-09-10 12:49:16 -07:00
Chris Yang ad5370e43c
mark as flaky (#65577) 2020-09-10 12:48:00 -07:00
engine-flutter-autoroll 6c1a29e54c
Roll Engine from f7c7b41f0a0c to 564367b29781 (4 revisions) (#65507) 2020-09-09 17:05:05 -07:00
Herbert Poul 8dfd42f6b7
[gen_l10n] Support string list as preferred-supported-locales (#63649)
* [gen_l10n] Support string list as preferred-supported-locales, as documented.

* [gen_l10n] Convert preferredSupportedLocale to a list of strings. 

* [gen_l10n] Accept a multi option instead of a json string in the command line.
2020-09-10 07:32:40 +08:00
stuartmorgan 6d1c244b79
Always use POSIX paths for generated CMake files (#65493)
The Windows plugin CMake generation had code to ensure that the paths
written to it used POSIX separators, but the Linux version didn't; that
meant that plugin updates run on Windows machines would corrupt the
generated (but checked in) Linux CMake file.

This change shares that code so that both will use POSIX paths
regardless of what OS they are generated on.

Fixes https://github.com/flutter/flutter/issues/64591
2020-09-09 16:08:19 -07:00
Jonah Williams 6d360562e3
[flutter_tools] alternate the name of the dill file used for hot restart (#65435)
* [flutter_tools] alternate the name of the dill file used for hot restart

* switch alternative name to .swap
2020-09-09 15:56:25 -07:00
Jonah Williams b4551e31fc
[flutter_tools] remove globals from tracing and add unit tests (#65490)
Removes global variables and adds unit tests that can be copied for #65118
2020-09-09 15:55:52 -07:00
Markus Aksli f0f02aca86
reset and added back changes (#65460) 2020-09-09 15:50:05 -07:00
engine-flutter-autoroll a0b6538d6b
Roll Engine from d1d848e8421e to f7c7b41f0a0c (34 revisions) (#65492)
* 556cb237e Roll Skia from 6763a713f957 to d91cd6b5ee2b (3 revisions) (flutter/engine#20989)

* b6a3c5488 Roll Fuchsia Linux SDK from A0PKwETay... to gfAt63Ezd... (flutter/engine#21005)

* cceb7332e Roll Fuchsia Mac SDK from sih5f60Gt... to 9pfHLZEFU... (flutter/engine#21006)

* 5539820a6 Roll Skia from d91cd6b5ee2b to a73a84f9b8e3 (1 revision) (flutter/engine#21007)

* b4cc631cc Roll Dart SDK from f3a9ca88b664 to e59935669cb0 (1 revision) (flutter/engine#21008)

* 6cf0cc475 Roll Skia from a73a84f9b8e3 to d0fe7d37d678 (1 revision) (flutter/engine#21011)

* 5b055bbf5 Roll Skia from d0fe7d37d678 to 611a52108b01 (2 revisions) (flutter/engine#21012)

* 575a51948 Enable lazy-async-stacks by-default in all modes (Take 3) (flutter/engine#20895)

* 040a794b6 Roll Fuchsia Mac SDK from 9pfHLZEFU... to tUwahggJ8... (flutter/engine#21013)

* 22cca4cfd Roll Dart SDK from e59935669cb0 to f745f9447ddf (1 revision) (flutter/engine#21014)

* 539cb6985 Roll Fuchsia Linux SDK from gfAt63Ezd... to Ta3F40BV6... (flutter/engine#21015)

* 7d927dd4a Roll Dart SDK from f745f9447ddf to b88c06c314f4 (1 revision) (flutter/engine#21016)

* 09a5bf7ac Tweak the mdns error message (flutter/engine#20991)

* d0d9ce610 Roll Fuchsia Linux SDK from Ta3F40BV6... to coVjRTWSf... (flutter/engine#21018)

* 808bb859a Roll Fuchsia Mac SDK from tUwahggJ8... to TyNHQXzNU... (flutter/engine#21019)

* 5aa6921a5 Roll Skia from 611a52108b01 to cd54c8385c31 (2 revisions) (flutter/engine#21021)

* e7d558fbe Roll Dart SDK from b88c06c314f4 to 33b6c95936e0 (2 revisions) (flutter/engine#21023)

* af90dd366 Roll Skia from cd54c8385c31 to c0d3495e1ee2 (12 revisions) (flutter/engine#21024)

* f0fb74b8f Avoid crashing and display error if the process cannot be prepared for JIT mode Dart VM. (flutter/engine#20980)

* 6a6c23aaf Roll Skia from c0d3495e1ee2 to cf1a4f50121f (6 revisions) (flutter/engine#21026)

* 716dce086 Android 30r3 (flutter/engine#21025)

* 74310709f Roll Dart SDK from 33b6c95936e0 to a2c9cae4dcd8 (1 revision) (flutter/engine#21027)

* cef383d3f Roll Skia from cf1a4f50121f to 04b9443274cf (2 revisions) (flutter/engine#21028)

* cf8c6b8ba Update web lerpDouble to match C++ behaviour (flutter/engine#21010)

* 686667591 Roll Skia from 04b9443274cf to b8ae7fa12aa0 (1 revision) (flutter/engine#21030)

* c538f40d3 Roll Dart SDK from a2c9cae4dcd8 to ffbfa2000435 (1 revision) (flutter/engine#21031)

* 89d34b0f3 Roll Skia from b8ae7fa12aa0 to 445c8ebcb710 (1 revision) (flutter/engine#21032)

* 7766d2e2b Roll Fuchsia Mac SDK from TyNHQXzNU... to Phn3nF_BJ... (flutter/engine#21034)

* e3de8d0f1 Roll Fuchsia Linux SDK from coVjRTWSf... to eBus_y4DN... (flutter/engine#21035)

* beb7df506 Roll Skia from 445c8ebcb710 to f9d5940fef55 (3 revisions) (flutter/engine#21037)

* f3a17b63d Roll Skia from f9d5940fef55 to 81c6d6eeb4cf (1 revision) (flutter/engine#21038)

* bbcc495b1 Roll Dart SDK from ffbfa2000435 to 2e838b7b4503 (2 revisions) (flutter/engine#21039)

* 61062fdbc Roll Skia from 81c6d6eeb4cf to 81606b5d9774 (5 revisions) (flutter/engine#21041)

* f7c7b41f0 Revert "Enable lazy-async-stacks by-default in all modes (Take 3) (#20895)" (flutter/engine#21043)
2020-09-09 15:49:17 -07:00
Anatoly Pulyaevskiy bb59993ac6
Expose 3 new methods with text metrics in RenderParagraph (#65150) 2020-09-09 15:45:03 -07:00
Mouad Debbar 0d8de393aa
[web] Don't show handles when selection change is caused by keyboard (#65127) 2020-09-09 15:40:06 -07:00
Hansol Lee 389b5b6c3a
Fix TabBar jag when user interrupts ballistic scroll (#64380) 2020-09-09 15:35:05 -07:00
Michael Goderbauer 127e67902e
Revert "Nnbd widgets (#64672)" (#65488)
This reverts commit e682ec711a.
2020-09-09 15:18:54 -07:00
godofredoc 9e315985d0
Remove mac prod builder. (#65481)
This is in preparation to enable the new mac builders.

Bug:
  https://github.com/flutter/flutter/issues/65223
2020-09-09 09:47:46 -07:00
Alexandre Ardhuin e682ec711a
Nnbd widgets (#64672)
* migrate widget to nullsafety

* remove double blank line after license

* address review comments in actions.dart

* nullable ObjectKey.value

* use local variable oldElement

* make State.build non-nullable

* make State.context non-nullable

* newline at eof

* make ProxyWidget.child non-nullable

* make _InactiveElements.debugContains non-nullable

* make Element.depth non-nullable

* make ProxyElement.build non-nullable

* make StatefulElement.state non-nullable

* remove 'Notice that'

* avoid cast of list in RenderObjectElement.updateChildren

* make IndexedSlot.value non-nullable

* avoid cast of list in MultiChildRenderObjectElement.mount

* make some WidgetsApp parameters non-nullable

* hitTest take non-nullable position

* make ScrollableState.position non-nullable

* use _pixels instead of pixels

* make ViewportOffset.pixels non-nullable

* make param and return type of IndexedWidgetBuilder non-nullable

* unused_import

* make context param non-nullable for Builder in animated_list.dart

* make ScrollMetrics.viewportDimension non-nullable

* make ScrollMetrics.{min,max}ScrollExtent non-nullable

* make _Location.file non-nullable

* _WidgetForTypeTests.createElement throw UnimplementedError

* update _NullWidget.build error message

* make _ShortcutsState.manager non-nullable

* Fix childCount issues for NNBD

* fix childCount computation on web

* increase max value on js side to compute childCount

* make aspect parameter of dependOnInheritedWidgetOfExactType nullable

* merge has{min,max}ScrollExtent into hasScrollExtents

* update focus_manager.dart

* address review comments in icon.dart

* address review comments in image.dart

* address review comments in routes.dart

* address review comments in scroll_activity.dart

* update doc comments

* make UserScrollNotification.direction non-nullable and required

* rename hasScrollExtents to hasContentDimensions

* unnecessary late

Co-authored-by: Ian Hickson <ian@hixie.ch>
2020-09-09 10:52:27 +02:00
Tong Wu abeaf11829
[devicelab] Remove ~/.gradle after each devicelab task run (#65434) 2020-09-09 01:50:03 -07:00
Todd Volkert 54ade88365
Small documentation udpate (#65392) 2020-09-08 22:08:57 -07:00
Haeseok Lee 011331dce5
Fixes issue, ReorderableListView destroys children even if their key-type wasn't changed (#64855) 2020-09-08 21:25:05 -07:00
Pedro Massango 38834d36d3
Improve API docs (#65394) 2020-09-09 07:47:17 +08:00
AhHyun Choi 49f48ff224
Add sample code to RotationTransition (#64795) 2020-09-08 16:05:03 -07:00
Hans Muller adc5f26b50
Re-land ScaffoldMessenger (#65416) 2020-09-08 16:02:06 -07:00
ny927 c06755772d
Add sample code to RelativePositionedTransition (#63940) 2020-09-08 16:00:03 -07:00
sehee Jeong 23e1d8f3bf
fix text.dart documentation (#65185)
I modified TextAlign docs because the descriptions of TextAlign.center and Center Widget are so similar that they cause confusion.

Fixes https://github.com/flutter/flutter/issues/5805
2020-09-08 15:59:38 -07:00
Jonah Williams 6b444c4dd7
[flutter_tools] standardize patterns for integration.shard (#64980)
Integration tests must only go through the real file system/process manager/platform. The global indirection makes this code harder to understand than if it directly referred to the concrete instances that are being used.

Update the integration shard to use a const instance of a LocalFIleSystem, LocalProcessManager, and LocalPlatform. Remove global usage and apply testWithoutContext.
2020-09-08 15:56:00 -07:00
Yuqian Li 46d1aba2e2
Remove flutter_gallery_ios32__transition_perf test (#65415) 2020-09-08 15:55:12 -07:00
AhHyun Choi 3b744ee1ed
Add sample code for ScaleTransition (#63886) 2020-09-08 15:55:07 -07:00
Jonah Williams 29898812d4
[framework] make hit slop based on device pointer kind for drag/pan/scale gestures (#64267)
Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.

One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.

This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.

This PR does not adjust:

kTouchSlop used in scroll_physics.dart's minFlingDistance
kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
2020-09-08 15:53:36 -07:00
Aman Gupta c33d8f4e0e
updated_title_property_apidocs (#63884) 2020-09-08 15:50:04 -07:00
Angjie Li d2fa384c31
Allow Developers to enable Accessibility testing on WebFlutterDriver and get the underlying webDriver (#65051) 2020-09-08 13:15:06 -07:00
Alex Fourman 46eacc5462
adds additional guidance on how to use of correctly. (#64791) 2020-09-08 12:50:04 -07:00
Im-Kevin 418e424794
Fix the test error of "Add finders for enableFlutterDriverExtension" and resubmit (#65276) 2020-09-08 12:10:05 -07:00
Ian Hickson 1a010de89f
Make Container always clip a decoration if it has a clip edge (#64840)
This allows us to rationalize the nullability of some of our APIs.
Prior to this we'd end up in a situation where Container assumed that
getClipPath would be non-null but Decoration was ok with return null.
2020-09-08 12:06:28 -07:00