Commit graph

5235 commits

Author SHA1 Message Date
Christopher Fujino 03c566768b
[flutter_tools] Remove fromPlatform from tests (#54152) 2020-04-10 16:51:28 -07:00
Christopher Fujino 2adb1fc095
Fix environment leakage in doctor_test (#54478) 2020-04-10 13:35:38 -07:00
Jonah Williams d081364d3c
[flutter_tools] remove indirection around App.framework production (#53853) 2020-04-10 13:34:45 -07:00
Jonah Williams 0700be79e5
[flutter_tools] disable cache in devices test (#54389) 2020-04-10 10:33:23 -07:00
Jonah Williams 5adfd38dde
[flutter_tools] Move service methods to VmService extension methods (#54337) 2020-04-10 10:33:07 -07:00
Shi-Hao Hong c16c3b0443
[gen_l10n] Expand integration tests (#54314) 2020-04-10 10:25:03 -07:00
Jonah Williams de84c1e18a
[flutter_tools] attempt to fix benchmark mode test (#54414) 2020-04-10 10:10:04 -07:00
Jenn Magder df63c82c9c
Convert iOS simulator log reader to simctl, use unified logging filters (#54154) 2020-04-09 14:35:01 -07:00
Jonah Williams d390f4d9c6
switch benchmark to isolate runnable (#54374) 2020-04-09 09:48:54 -07:00
Kirill Pertsev d6806392a8
Implements --machine flag for devices command (#50581) 2020-04-09 09:14:16 -07:00
Jonah Williams 74a1b9b33e
[flutter_tools] make verbose macOS builds actually verbose (#54320) 2020-04-09 09:00:44 -07:00
Per Classon 4451ffca23
Add option for deferred loading to gen_l10n (#53824) 2020-04-09 03:57:01 -07:00
Jonah Williams 0d459f2326
[flutter_tools] Remove packageMap usage and update package_config (#54301)
* remove PackageMap

* Update flutter_web_platform.dart
2020-04-08 21:32:25 -07:00
Jonah Williams 01a47b9b1a
[versions] update all flutter versions (#54334) 2020-04-08 21:32:01 -07:00
Jonah Williams cb8bafb38d
[flutter_tools] surgically remove outputs from shared directory (#53962) 2020-04-08 19:09:59 -07:00
Filip Hracek 1593788cd9
Rename GPU thread to raster thread in API docs (#53422) 2020-04-08 18:57:03 -07:00
Shi-Hao Hong 5d63637e43
[gen_l10n] Fallback feature for untranslated messages (#53374)
* Generate methods using template resources if they do not exist in other locales

* Added a flag to either output of messages that have not been translated with detail into a file, or display a summary on the terminal.

* Add integration test for fallback message usage
2020-04-08 18:55:50 -07:00
Jonah Williams cf5e4b544e
[flutter_tools] fix routing test (#54313) 2020-04-08 14:53:19 -07:00
Jonah Williams 412e4dd50e
[flutter_tools] migrate devfs web to package_config (#54299) 2020-04-08 14:41:11 -07:00
Christopher Fujino 19c8948e61
Fix frameworkVersionFor for flutter doctor and usage (#54217) 2020-04-08 12:47:05 -07:00
Jonah Williams 4851888864
[flutter_tools] Migrate to package:vm_service 4: trigonometric boogaloo (#54132) 2020-04-08 12:33:33 -07:00
Zachary Anderson 090fc5cc53
[flutter_tools] Use gzip level 1 for devfs transfer compression (#54123) 2020-04-08 09:07:02 -07:00
Jonah Williams fa35698ee3
[flutter_tools] allow passing non-config inputs (#54228) 2020-04-08 09:04:32 -07:00
Danny Tuppeny 589b14d841
Add a switch to use WebSockets for web debug proxy (#54083) 2020-04-08 09:02:03 -07:00
Jonah Williams 981afe39ae
[flutter_tools] ensure build fails if asset files are missing (#54233)
Ensure build fails if asset files are missing and that stderr messages are forwarded through Gradle
2020-04-07 19:42:57 -07:00
Jonah Williams 0a25309fb1
[versions] update versions (#54247) 2020-04-07 19:42:02 -07:00
Jason Simmons c663cd55a7
[flutter_tools] Refresh VM state before executing hot reload (#53960) 2020-04-07 15:41:02 -07:00
Jonah Williams 9c41e57099
[flutter_tools] migrate engine location check (#54208) 2020-04-07 14:05:49 -07:00
Per Classon e8d2907595
[gen_l10n] Handle single, double quotes, and dollar signs in strings (#54185) 2020-04-07 12:21:02 -07:00
Jonah Williams 08fe78fff9
[flutter_tools] write SkSL file to local file (#53859) 2020-04-07 12:17:39 -07:00
Michael Thomsen 98e7791ec9
Roll pinned xml and petitparser versions (#54181) 2020-04-07 12:16:03 -07:00
stuartmorgan b429e7eb00
Update Windows and Linux plugin templates (#53876)
Updates Windows and Linux templates to use the new PluginRegistrarManager, improving lifetime handling and reducing boilerplate.
2020-04-07 09:03:49 -07:00
Konstantin Scheglov b0492cc976
Fix newly reported prefer_const_constructors lints. (#54176) 2020-04-07 08:59:01 -07:00
Jonah Williams 98e43bc6ae
[flutter_tools] ensure the tool can find SDK manager on windows (#54133) 2020-04-06 13:41:14 -07:00
Alexandre Ardhuin f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
stuartmorgan 2d623278e7
Restructure the Windows app template (#53600)
This moves the app template more toward being a more generic starting
point for any Flutter application, eliminating some hard-code
assumptions about there being a single window/engine pair that is
directly bound to the life of the application:
- Moves the runloop into its own class, making it capable of servicing
  any number of engine instances.
- Moves the logic for setting up a window containing only a Flutter view
  into a window subclass for ease of re-use.
- Makes quit-on-window-close an optional property. (Long term this
  should be even more generic, like a quit-when-last-window-closes
  option, but this is a short-term improvement that removes the binding
  between the runloop and the window).
- Allows for multiple instances of Win32Window to exist without issues
  relating to the window class registration.

Since there are getting to be a non-trivial number of files associated
with the runner, this moves the source into a runner/ directory, as is
already done on some other platforms.

Note that creating multiple Flutter windows at the same time still
doesn't work correctly even with this change, but this addresses some of
the known issues, and makes it easier to test in the future (e.g., for
debugging engine-level issues with multiple instances).

Fixes #45397
2020-04-06 12:24:05 -07:00
Jonah Williams 4037e5069e
[flutter_tools] update asset manifest to use package_config instead of package_map (#53944) 2020-04-06 11:25:05 -07:00
Jenn Magder 602475e56f
Sanitize error message sent to GitHub crash reporter (#53936) 2020-04-06 11:00:22 -07:00
Jonah Williams 61b3361781
Revert "[flutter_tools] Migrate to vm service 3 (reland): electric boogaloo (#53957)" (#54114)
This reverts commit d6b09626f2.
2020-04-06 10:36:14 -07:00
Jonah Williams d6b09626f2
[flutter_tools] Migrate to vm service 3 (reland): electric boogaloo (#53957) 2020-04-06 10:18:41 -07:00
Anisov Aleksey be6234d56e
Read custom app project name from gradle.properties (#52791) 2020-04-05 20:46:44 -07:00
Jonah Williams f9c58bea49
[flutter_tools] also listen to web stderr stream (#53949) 2020-04-04 21:31:55 -07:00
Zachary Anderson fef9d4d7cd
[flutter_tools] Launch DevTools with 'v' (#53902) 2020-04-04 19:51:01 -07:00
Shi-Hao Hong 4e811d2819
[gen_l10n] Fix plural parsing for translated messages (#53954) 2020-04-03 15:46:01 -07:00
Jonah Williams 58acf4e7b0
Revert "[flutter_tools] surgically remove outputs from shared directory (#53773)" (#53956)
This reverts commit 8a3bede1d3.
2020-04-03 14:22:37 -07:00
Jonah Williams 8a3bede1d3
[flutter_tools] surgically remove outputs from shared directory (#53773) 2020-04-03 14:11:01 -07:00
Jonah Williams 66f4907754
Revert "[flutter_tools] update to package vm_service: electric boogaloo (#53809)" (#53951)
This reverts commit 66d7a6c266.
2020-04-03 14:00:07 -07:00
Jonah Williams 1e86c1fb12
[flutter_tools] re-enable debug extension (#53765) 2020-04-03 13:26:15 -07:00
Jonah Williams 66d7a6c266
[flutter_tools] update to package vm_service: electric boogaloo (#53809) 2020-04-03 12:38:56 -07:00
Francisco Magdaleno e012752634
[flutter_tools] Don't generate native registrant classes if no pluginClass is defined (#53785) 2020-04-03 11:51:01 -07:00
Jenn Magder 85ad699865
Remove URL shortening from GitHub reporter similar issues URL (#53882) 2020-04-03 10:32:55 -07:00
Shi-Hao Hong 6837b0e353
[gen_l10n] Add scriptCode handling (#53868)
* [gen_l10n] Add scriptCode handling
2020-04-03 09:46:01 -07:00
Christopher Fujino 2396616e09
Support old and new git release tag formats (#53715) 2020-04-03 09:39:28 -07:00
Jenn Magder 77ea848c46
Inject Usage dependency into FallbackDiscovery and BuildEvent (#53443)
* Usage dependency injection

* Review edits
2020-04-02 10:57:37 -07:00
Ferhat c3ec1caac2
Replace isInstanceOf<T> uses with isA<T> (#53834)
* Replace isInstanceOf<T> uses with isA<T>

* Update isInstanceOf in flutter tools
2020-04-02 10:57:07 -07:00
Christopher Fujino 1a685e03a2
Improve downgrade-upgrade integration test (#53775) 2020-04-02 10:35:30 -07:00
Zachary Anderson 6fddb7ee8c
[flutter_tools] Handle full device when creating a temp directory (#53691) 2020-04-02 10:31:03 -07:00
Anna Gringauze 3a0d837741
Enable expression evaluation in debugger for web platform (#53595) 2020-04-02 10:26:03 -07:00
Shi-Hao Hong 19e7db585d
[gen_l10n] Escape special JSON characters in generateString utility function (#53605) 2020-04-01 11:16:01 -07:00
stuartmorgan 445b5a14f2
Precache platform filter change (#53701)
Makes the following changes to the behavior of precache:
- The --all-platforms flags now fetches all artifacts, rather than just
  turning off platform filtering of selected artifacts.
- Explicitly requested artifacts are no longer subject to platform
  filtering. E.g., 'precache --ios' will download iOS artifacts on
  Windows and Linux (but 'precache' without an 'ios' flag will still
  only download iOS artifacts on macOS).
- Desktop platform artifacts now respect the bypassing of platform
  filtering.

Fixes #53272
2020-04-01 10:54:59 -07:00
Emmanuel Garcia e61ab4a832
Copy APK into a known location, so it can be easily discovered (#53718) 2020-04-01 10:03:56 -07:00
Jonas Finnemann Jensen da036c5214
Application templates should default to publish_to: none (#52740) 2020-04-01 14:20:02 +02:00
Lau Ching Jun 587b622396
Fuchsia device is ephemeral. (#53717) 2020-04-01 00:51:02 -07:00
Jonah Williams bb5c340066
[flutter_tools] cache the base URL as index.html (#53666) 2020-04-01 00:36:02 -07:00
Greg Spencer 2a649b16e2
Add an adaptive visual density static function, and add it to… (#51921)
Adds a VisualDensity.adaptivePlatformDensity static function that returns different values for visual density based on the defaultTargetPlatform. Returns compact for desktop platforms, and a default visual density for other platforms.
2020-03-31 16:16:25 -07:00
Jenn Magder ad07c4041a
Delete unused NDK location checks (#53694) 2020-03-31 14:53:49 -07:00
Mubarak Imam df90bb5fd6
fix issue with multiple java runtimes on macOS (#52474) 2020-03-31 11:36:01 -07:00
Jonah Williams 7bf74c3460
[flutter_tools] handle unsafe build outputs (#53601) 2020-03-31 11:01:01 -07:00
stuartmorgan a2d62df3ee
Use feature flags for desktop cache (#53608) 2020-03-30 21:51:48 -07:00
Jonah Williams 8cb1d269f6
[versions] update EVERYTHING (#53467) 2020-03-30 14:09:38 -07:00
Jonah Williams 72343ee0e4
[flutter_tools] refactor build_system and targets to be context-free (#53268) 2020-03-30 12:51:04 -07:00
Jonah Williams 4605b51a7e
[flutter_tools] use package Uuid consistently (#53492) 2020-03-30 12:46:06 -07:00
Dan Field c8efcb632b
Only fetch tags when not on dev/beta/stable (#53450) 2020-03-27 22:31:01 -07:00
Jonah Williams dfc3318e87
[flutter_tools] dont create synthetic sdk when running consumer-only (#53466) 2020-03-27 22:25:09 -07:00
Jonah Williams 8403930d41
[flutter_tools] unpin SDK deps when upgrading packages (#53429) 2020-03-27 22:11:01 -07:00
stuartmorgan 94500073a0
Windows template update project (#53302)
Updates the Windows app template to use the new DartProject API, significantly simplifying the template.

Increments the template version, even though this isn't itself a breaking change, so that users will be prompted to update their projects rather than be broken later when the old API is removed.
2020-03-27 16:36:15 -07:00
Jenn Magder ce40fbaf51
Include metadata in GitHub crash template (#53118) 2020-03-27 16:21:45 -07:00
Jenn Magder 57b0ddbd60
Uninstall app flag (#53385) 2020-03-27 10:13:54 -07:00
Jonah Williams be3a4b37b3
[flutter_tools] don't trim log messages from the web (#53379) 2020-03-26 18:08:05 -07:00
Jonah Williams 2717eb6413
[flutter tools] rewrite launch non-prebuilt app tests (#53351) 2020-03-26 17:36:02 -07:00
Jonah Williams c5800fe107
[flutter_tools] update iOS deploy tests for best practices (#53343) 2020-03-26 17:31:01 -07:00
Dmitry Borodin 5a3e7e4366
Updated obsolete URL (#52158) 2020-03-26 14:34:00 -07:00
Zachary Anderson 9d97918c60
[flutter_tools] Prepare for OSError to implement Exception (#53258) 2020-03-26 09:51:01 -07:00
Jenn Magder 8a9023522c
Push iMobileDevice and iosDeploy instantiation into XCDevice constructor (#53307) 2020-03-25 18:12:13 -07:00
Jonah Williams e23c4796a3
Expose extra frontend options through build apk/ios/macOS (#53273)
This will allow experimenting with the remove to string transformer before we're ready to turn it on by default. This doesn't work for web yet since we use dart2js instead of the frontend_server for producing kernel
2020-03-25 16:56:41 -07:00
xster 1376746237
Reland #53153 to attach to existing modules and apps for Android (#53289) 2020-03-25 16:45:49 -07:00
Angjie Li 6083f15805
Allow user to specify which Chrome binary to use. (#53275)
* Allow user to specify which Chrome binary to use.
2020-03-25 15:55:32 -07:00
Jenn Magder ee3920c208
Remove SimControl from context (#53304) 2020-03-25 15:40:42 -07:00
Jenn Magder ba57ea09d1
Revert "Move processUtils into globals (#53209)" (#53301) 2020-03-25 14:59:03 -07:00
Jenn Magder 86389be66e
Convert CocoaPods tests to testWithoutContext (#53291) 2020-03-25 13:27:10 -07:00
Jenn Magder ec3653f41d
Remove XcodeValidator from context (#53213) 2020-03-25 11:57:05 -07:00
Dan Field 31175eb008
Revert "Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)" (#53269) 2020-03-25 11:26:02 -07:00
Jenn Magder 9ccac00599
Move processUtils into globals (#53209) 2020-03-25 11:23:08 -07:00
Michael Thomsen 29913c9011
Expose new pub outdated command (#53251) 2020-03-25 11:21:03 -07:00
Jenn Magder b860a3912b
Increase xcdevice timeout to 2 seconds (#53184) 2020-03-25 11:14:22 -07:00
Jenn Magder 207efd4cee
Convert idevicescreenshot and upgradePbxProjWithFlutterAssets tests to testWithoutContext (#53208) 2020-03-25 11:14:00 -07:00
Zachary Anderson 52e4011a3a
[flutter_tool] Timeout the Azure bot detector http request (#53217) 2020-03-25 11:11:03 -07:00
Jenn Magder b684041bb8
Revert "Let flutter attach find the service port by looking through old logs again (#53153)" (#53282)
This reverts commit 0c5ffdc9ef.
2020-03-25 10:53:45 -07:00
xster 0c5ffdc9ef
Let flutter attach find the service port by looking through old logs again (#53153) 2020-03-24 23:26:01 -07:00
Leaf Petersen 6563b0de34
Revert "Replace uses of deprecated CastError with TypeError (#53221)" (#53226)
This reverts commit 6c7c2e372a.
2020-03-24 23:02:41 -07:00
Leaf Petersen 6c7c2e372a
Replace uses of deprecated CastError with TypeError (#53221) 2020-03-24 22:11:46 -07:00
Jenn Magder c93847d187
Remove IOSDeploy from globals, hoist to XCDevice constructor (#53203) 2020-03-24 16:50:35 -07:00
Jenn Magder 778c2ce923
Convert some code_signing_tests to testWithoutContext (#53142) 2020-03-24 15:30:35 -07:00
Jenn Magder 151c8db7dc
Remove dead vmservice.RPCError catch (#53193) 2020-03-24 13:35:29 -07:00
Jonah Williams 8e492fa845
[flutter_tools] fix type error with AppDomain current directory (#53181) 2020-03-24 12:58:40 -07:00
Jonah Williams b5cd3ce854
[flutter_tools] test and catch more exception types in web runner (#53183) 2020-03-24 12:58:30 -07:00
Devon Carew d6614dbafd
save and restore the chrome session local storage information (#53030)
save and restore the chrome session local storage information
2020-03-24 12:20:13 -07:00
Jenn Magder c9323bdccd
Convert cocoapods_validator_test to testWithoutContext (#53177) 2020-03-24 11:34:57 -07:00
Jenn Magder 70c651b0a4
Move BuildSystem to globals (#53139) 2020-03-24 11:23:10 -07:00
Jenn Magder 0b321e6715
Remove IMobileDevice from globals, hoist to XCDevice constructor (#53144)
* Convert ios_device_logger_test.dart to testWithoutContext

* Remove IMobileDevice from globals, hoist to XCDevice constructor
2020-03-24 11:22:54 -07:00
Jenn Magder 404bb5a572
Convert analyze_test to testWithoutContext (#53141) 2020-03-24 11:22:34 -07:00
Lasse R.H. Nielsen af5194dbfd
Prepare Flutter for SDK changes to runZoned. (#52953)
The `runZoned` method deprecates the `onError` parameter.
Invocations using that parameter must use `runZonedGuarded` instead.

This prepares Flutter for the deprecation. The same places need to be migrated to using
`runZonedGuarded` when the SDK change has been ported to Flutter.
Then the deprecated member will be removed in a follow-up CL when the most important
packages have been migrated.
2020-03-24 08:34:17 -07:00
Jonah Williams 10571920c0
[flutter_tools] update to latest dwds API (#52936)
Should fix issues introduced in web-server device and allow loading org-dartlang-app URIs
2020-03-23 18:47:50 -07:00
stuartmorgan 685e9d1e47
Add pre-stable support for create on Windows (#51895)
Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.

Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.

Fixes #30704
2020-03-23 10:42:26 -07:00
Jonah Williams b1664a27d9
ensure default value for report timings (#52978) 2020-03-20 14:30:33 -07:00
Jonah Williams 441665e21a
[flutter_tools] split logger test and create log reader testing interface (#52934) 2020-03-20 13:46:39 -07:00
Jonah Williams 590f22ce82
[flutter_tools] restore report timings functionality to build aot (#52918) 2020-03-20 13:46:19 -07:00
Christopher Fujino 7d1fbcae1a
Refactor exits happy (#52916) 2020-03-20 13:05:19 -07:00
Jonah Williams a13c9cfc48
[flutter_tools] fix toFilePath called on null (#52931)
In certain circumstances, the .packages file or dart cache could be missing - since the tool runs from a snapshot this is otherwise fine.
2020-03-19 22:20:15 -07:00
Michael Thomsen 4106fbd99c
Allow recent Dart language features (#52879) 2020-03-19 16:54:34 -07:00
Jonah Williams 62c9c89d6b
[flutter_tools] split start app android tests into new file (#52906) 2020-03-19 16:53:19 -07:00
Jonah Williams 5b956fd8f6
[flutter_tools] split isSupportedForProject test into new file (#52911) 2020-03-19 16:42:05 -07:00
Kirill Pertsev bae2f2c108
Enables log reader on iOS Simulator to (rudimentary) process multiline messages (#52452) 2020-03-19 15:41:39 -07:00
Jason Simmons bbc9d4f3a6
Do not check the executable status of gen_snapshot if it has not yet been downloaded (#52574) 2020-03-19 15:01:02 -07:00
Jonah Williams d20242b703
[flutter_tools] refactor ios install/uninstall to new file (#52891) 2020-03-19 14:53:14 -07:00
Jonah Williams b21e780aee
[flutter_tools] refactor AotBuilder, removing globals and duplicated kernel compilation (#52896)
Reland of #52091
2020-03-19 14:52:42 -07:00
Jonah Williams 9391e480b2
Revert "[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)" (#52893)
This reverts commit f65421aaca.
2020-03-19 10:16:20 -07:00
Jenn Magder a61bff2fcf
Show Xcode workspace clean output with verbose flag (#52860) 2020-03-19 09:51:01 -07:00
Jonah Williams f65421aaca
[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)
Remove dependency injection from GenSnapshot and AotBuilder and update tests to use FakeProcessManager
2020-03-19 09:36:38 -07:00
Jonah Williams fe310148a1
[flutter_tool] Remove extra usage of .packages in vm service API (#52845) 2020-03-19 09:35:57 -07:00
Dan Field 53dc8db0e8
Do not throw when trying to discover a fuchsia device and the sshConfig is invalid (#52858)
* Do not throw when trying to discover a fuchsia device and the sshConfig is invalid
2020-03-19 09:28:54 -07:00
Jonah Williams 73b6702dee
[flutter_tools] refactor iOS tests for Device.startApp into new file (#52854) 2020-03-18 17:43:25 -07:00
Jenn Magder ee845255de
Move XcodeProjectInterpreter to globals (#52847) 2020-03-18 15:55:09 -07:00
Jenn Magder e0ab6fc00c
Move outputPreferences to globals (#52846) 2020-03-18 15:54:26 -07:00
Jonah Williams 0274f170fb
[flutter_tools] have the tool print the current canvaskit mode when toggling (#52841) 2020-03-18 15:51:23 -07:00
Yegor 7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Christopher Fujino 2d9902d9ac
Cleanup ios devices (#52568) 2020-03-18 12:51:01 -07:00
Zachary Anderson e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize (#52775) 2020-03-18 10:00:14 -07:00
Jonah Williams 542feb4736
[flutter_tools] remove unused Snapshot.dart artifact and associated code (#52821) 2020-03-18 09:18:41 -07:00
Jonah Williams da0788a180
Update fuchsia remote debug protocol to use package:test shim instead of package:test_api (#52706)
This is necessary to ensure the tests can run in google3. Fixes https://b.corp.google.com/issues/151657461
2020-03-18 09:12:46 -07:00
Jonah Williams b7101b45f5
[flutter_tools] disable added integration test due to Cirrus flakes (#52782) 2020-03-17 19:07:22 -07:00
Jonah Williams 46f0a5f7b5
[flutter_tools] Reland android device cleanup. (#52686) 2020-03-17 17:58:39 -07:00
Jonah Williams 90d6169678
[flutter_tools] refactor the IOSDevicePortForwarder and move tests out of devices_test.dart (#52772)
Updates the IOSDevicePortForwarder to no longer depend on context, or on an IOSDevice instance. Instead, it receives all necessary configuration through the constructor.

Moves the IOSDevicePortForwarder to a separate file.
2020-03-17 17:58:05 -07:00
Jonah Williams 6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
gaaclarke 6990b8b2d3
Added the "trace-whitelist" flag to run. (#52556) 2020-03-17 16:42:20 -07:00
Jonah Williams f149eec31b
[flutter_tools] always initialize the resident runner from dill (#52497) 2020-03-17 16:37:06 -07:00
Jenn Magder 757b39ba99
Ignore fuchsia device-finder no device error (#52761) 2020-03-17 16:02:45 -07:00
Christopher Fujino 071d4eb2c8
explicitly catch ArgumentError, and add tests (#52757) 2020-03-17 12:55:57 -07:00
Jonas Finnemann Jensen a4d30c1607
Add a comment for path dependencies in plugin example template (#50978) 2020-03-17 20:31:52 +01:00
Jonah Williams a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Jenn Magder 93a6057c42
Add SDK location unit tests (#52691) 2020-03-16 16:02:22 -07:00
Jenn Magder 2f216ceee5
Add timeout flag to devices command, pipe through discovery (#51678) 2020-03-16 14:15:00 -07:00
Jonah Williams 028b7dced1
[flutter_tools] remove context from WebWorkflow (#52613) 2020-03-16 11:33:00 -07:00
Michael Thomsen e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Jenn Magder 73ea37eca9
Revert "Fall back to environment SDKROOT passed from Xcode (#52570)" (#52583)
This reverts commit 8e6e15f915.
2020-03-13 18:29:09 -07:00
Jenn Magder 8e6e15f915
Fall back to environment SDKROOT passed from Xcode (#52570) 2020-03-13 17:16:56 -07:00
Dan Field 98cf01858c
Fetch tags for version command (#52212) 2020-03-13 17:16:03 -07:00
Jonah Williams bbc5b9d967
Revert "[flutter_tools]: reland android device cleanup (#52542)" (#52579)
This reverts commit 9186dfc34d.
2020-03-13 16:38:59 -07:00
Jonah Williams 3bc36095da
Revert "[flutter_tools]: reland move engine unpack to dart (#52543)" (#52549)
This reverts commit 3e25e60f57.
2020-03-13 09:50:07 -07:00
Jonah Williams 9186dfc34d
[flutter_tools]: reland android device cleanup (#52542) 2020-03-13 09:42:02 -07:00
Jonah Williams 3e25e60f57
[flutter_tools]: reland move engine unpack to dart (#52543)
Reland of #50707
2020-03-13 09:40:55 -07:00
Jonah Williams b3a37d0273
[flutter_tools] support toggling CanvasKit rendering on with 'k' (#52511) 2020-03-13 07:02:34 -07:00
Jonah Williams 1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f7.
2020-03-12 18:14:32 -07:00
Christopher Fujino 14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Jonah Williams 1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson 0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Shi-Hao Hong 183da8f837
[gen_l10n] Fix suppportedLocales list (#52448)
* Fix suppportedLocales list

* Refactor integration tests for gen_l10n tool to catch exceptions
2020-03-12 12:58:13 -07:00
Jonah Williams d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Dan Field 02769001d3
Android SDK test fixes (#52144) 2020-03-12 10:53:23 -07:00
Finn 9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino 38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy 1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson 04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Jonah Williams edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Jonah Williams 6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia 4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson 53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson 78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson 7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams 5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson 605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Ben Konyi 66b978a197
Update pub dependencies to roll forward package:test (#52273) 2020-03-10 13:26:02 -07:00
Zachary Anderson 733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams 2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams 377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams 60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams 3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams 88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Jonah Williams bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
George Wright 084a7077ce
Revert "Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)" (#52277)
This reverts commit ffcc776513.
2020-03-09 16:55:58 -07:00
George Wright ffcc776513
Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)
This worksaround an issue with the latest version of package_config which doesn't handle
multiple dart packages sharing the same source directory. In this case, the fuchsia dart_tool
targets were sharing a directory with their dependency, :flutter_tools
2020-03-09 15:08:57 -07:00
Angjie Li 665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Dan Field e13e17009d
Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field db1f33fd70
Revert "Local engine build mode (#52043)" (#52152)
This reverts commit 4d05ed5deb.
2020-03-06 16:57:18 -08:00
Jonah Williams c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Christopher Fujino 2e18cd347e
Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Dan Field a42d38a2f8
Fix flaky test (#52088) 2020-03-06 13:01:42 -08:00