Kate Lovett
84aa29ce63
Gold Pre-submit flow for contributors without permissions ( #47551 )
2020-01-09 08:08:03 -08:00
Kate Lovett
89d72a1208
Throwing when goldctl cannot authorize/initialize ( #45925 )
2019-12-16 12:18:03 -08:00
Lau Ching Jun
c2eb0681ce
Implement screenshot test for flutter web. ( #45530 )
2019-12-06 14:25:39 -08:00
Kate Lovett
9011cece25
Pre-Submit Tryjobs for Flutter Gold ( #44474 )
2019-12-04 15:43:36 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Kate Lovett
1374a41313
Provide debug output for Gold uploads on post-submit ( #45704 )
2019-11-27 11:29:53 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs ( #45200 )
...
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin
1f3ff5ca42
implicit-casts:false in flutter_goldens and flutter_goldens_client ( #45249 )
...
* implicit-casts:false in flutter_goldens and flutter_goldens_client
* fix type
2019-11-21 17:46:37 +01:00
Kate Lovett
26d09f1ab4
Gold Performance improvements ( #43748 )
2019-10-31 11:44:07 -07:00
Kate Lovett
7bc02037e3
Re-land Local & Pre-Submit Support for Skia Gold ( #43371 )
2019-10-25 15:05:21 -07:00
Kate Lovett
3a3939a7fa
Revert "Skia Gold Support for Local & PreSubmit Testing in package:flutter ( #40710 )" ( #43227 )
...
This reverts commit 8df0d6556d
2019-10-21 17:31:54 -07:00
Kate Lovett
8df0d6556d
Skia Gold Support for Local & PreSubmit Testing in package:flutter ( #40710 )
2019-10-21 16:45:56 -07:00
Kate Lovett
616794fca7
Re-land "Part 1: Skia Gold Testing" ( #36103 )
2019-07-28 12:26:06 -07:00
Kate Lovett
0379dd1c26
Updating cirrus fingerprint script to include goldens version ( #36690 )
2019-07-23 09:30:41 -07:00
Kate Lovett
8809f698cb
Revert "Part 1: Skia Gold Testing ( #33688 )" ( #36094 )
...
This reverts commit eb0b179028
2019-07-12 13:35:36 -07:00
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing ( #33688 )
...
* Fresh PR for Gold integration.
* Nits
* WIP
* Artifacts from merge
* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.
* Updating for CI implementation
* Write out service account
* Writing to skip out
* WIP
* ++
* Fixing depot tools deps
* Windows depot_tools
* Fixing setup scripts
* ++
* depot tools
* ++
* WIP
* Tracing depot_tools clone
* WIP
* ++
* analyzer
* WIP
* chrome typo
* copy artifact
* Working on tests
* Code cleanup
* ++
* Code cleanup, updated tests
* ++ review feedback
* Review
* Analyzer
* Review feedback
* Nits from review
* PRogress
* ++
* Fixing tests
* ++
* Testing repo route
* Just needing documention around new structures.
* cleanup
* Analyzer
* Documentation updates
* Documentation updates
* Cirrus updates
* cirrus nit
* Review feedback
* Review feedback
* Fixing skip comparator
* Fix base directory for Skia Gold case
* ++
* Feedback
* ++
* Fixed uri assertion
* Made GoldensClient abstract, altered SkiaGoldClient constructor
* Analyzer
2019-07-12 12:23:04 -07:00
Chris Bracken
4d9923201b
Correct typos ( #33322 )
...
Corects a bnuch of typeos throuhgout teh Fluter codebsae.
Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Kate Lovett
829bdeb426
Fixing accidental merge from WIP branch. ( #32520 )
...
Revert "Merge branch 'master' into master"
This reverts commit e3a03c04c46474982649
2019-05-10 15:53:41 -07:00
Kate Lovett
fdd554fb46
Anaalyzer fixes.
2019-04-25 15:59:48 -07:00
Kate Lovett
abb555fe94
Modified platform specific golden file test.
2019-04-25 15:50:53 -07:00
Kate Lovett
8861e9f3dc
Cleanup
2019-04-25 14:51:59 -07:00
Kate Lovett
e332ab859a
Changed implementation to incorpoarate new init feature for goldctl. Reduces redundant work as well.
2019-04-25 12:18:56 -07:00
Kate Lovett
a38311e6c8
Fixing duplicate test names.
2019-04-25 10:05:13 -07:00
Kate Lovett
ba011fd353
nits
2019-04-24 15:35:48 -07:00
Kate Lovett
1fcd1b02de
Changes for uploading baseline images.
2019-04-24 13:38:49 -07:00
Kate Lovett
7e542fc334
Committing progress.
2019-04-19 14:33:49 -07:00
Kate Lovett
9e3e44ee3d
Committing test progress.
2019-04-19 11:32:16 -07:00
Kate Lovett
4f29c31048
Updating inline documentation
2019-04-19 10:19:31 -07:00
Kate Lovett
b6a2efb7ab
Committing progress. Documentation and testing incomplete/in progress. Code cleanup needed as well.
2019-04-18 16:08:09 -07:00
Chris Bracken
52e4214dbb
Fix crash on flutter update-packages ( #28922 )
...
When running git update-packages, if the goldens repo is dirty, the
flutter tool currently crashes and logs the failure from git pull.
This adds a check for a dirty git client and emits a friendlier error
message in the case where it's not clean, and avoid the crash by
catching the NonZeroExitCode exception and rethrowing as toolExit
instead.
Fixes: https://github.com/flutter/flutter/issues/28915
2019-03-06 09:14:39 -08:00
Alexandre Ardhuin
d927c93310
Unnecessary new ( #20138 )
...
* enable lint unnecessary_new
* fix tests
* fix tests
* fix tests
2018-09-12 08:29:29 +02:00
Amir Hardon
592731f220
Clone goldens as part of flutter update-packages.
...
flutter_tools cannot depend on flutter_goldens (as flutter_goldens
depdends on the Flutter sdk), so this commit splits client.dart from
flutter_goldens to a pure-dart flutter_goldens_client package.
2018-08-20 14:29:26 -07:00
