Commit graph

16123 commits

Author SHA1 Message Date
Ian Hickson 8c6d60bcfd
Move commands into their own shard (#39140) 2019-10-02 12:46:51 -07:00
Jonah Williams 39f85f94ec
Reland: don't update last compile time when compilation is rejected. (#41580)
* dont update last compiled time when compilation is rejected

* lets try flushing, thats a neat trick

* windows man

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* Update devfs.dart

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* add test that verifies when compile is good that time is updated

* Update devfs_test.dart
2019-10-02 12:46:33 -07:00
Greg Spencer 4512a1c1b7
Add an ActivateAction to controls that use InkWell. (#41220)
Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered.

This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
2019-10-02 12:46:02 -07:00
Jonah Williams 0af2a84cbb
Handle empty entry in asset list and add more explicit validation (#41735) 2019-10-02 12:45:51 -07:00
Jonah Williams b1a6aa3ab8
Add support for downloading x86 Android JIT release artifact (#41751) 2019-10-02 12:45:35 -07:00
Jonah Williams a9f385bbff
Reduce log verbosity by removing individual used files (#41788) 2019-10-02 12:45:04 -07:00
engine-flutter-autoroll 5975e86f00
Roll engine 9e6314d348f9..4651df4d35af (2 commits) (#41743)
git@github.com:flutter/engine.git/compare/9e6314d348f9...4651df4d35af

git log 9e6314d348f9..4651df4d35af --no-merges --oneline
2019-10-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1e9112fbb472..9e514a183b99 (5 commits) (flutter/engine#12729)
2019-10-01 ychris@google.com Remove unused imports in the scenario app (flutter/engine#12728)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-02 15:44:24 -04:00
liyuqian cdb94cd675
Revert "Revert "Dsiable CPU/GPU measurement on BackdropFilter test (#41736)" (#41780)" (#41795)
This reverts commit 19c08e891d.

The attempted revert doesn't fix the problem, so we'll reland.
2019-10-02 12:35:42 -07:00
Christopher Fujino e70236e36c
Fix tools test verifyVersion() regex (#41744) 2019-10-02 09:32:30 -07:00
Greg Spencer 19c08e891d
Revert "Dsiable CPU/GPU measurement on BackdropFilter test (#41736)" (#41780)
This reverts c9d920f so that we can attempt to fix the build. The build dashboard clearly shows that things started failing at this change, although it's not totally clear that it is the cause: tests succeed locally.

If it doesn't fix things we can re-land this.
2019-10-02 07:22:25 -07:00
engine-flutter-autoroll 056f7244ef
Roll engine 5c428d924790..9e6314d348f9 (8 commits) (#41741)
git@github.com:flutter/engine.git/compare/5c428d924790...9e6314d348f9

git log 5c428d924790..9e6314d348f9 --no-merges --oneline
2019-10-01 bkonyi@google.com Roll src/third_party/dart 998f1efbe9..1103600280 (6 commits)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 3Axx8... to L_AEL... (flutter/engine#12726)
2019-10-01 ychris@google.com Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652)" (flutter/engine#12707)
2019-10-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7914a872657..1e9112fbb472 (4 commits) (flutter/engine#12724)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Resize channel buffers (flutter/engine#12402)
2019-10-01 bkonyi@google.com Roll src/third_party/dart fb1c5a6404..998f1efbe9 (3 commits)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Cleanup: Turned on NS_ASSUME_NONNULL_BEGIN for FlutterViewController. (flutter/engine#12708)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Jr7x0... to Q4sFH... (flutter/engine#12722)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-01 18:09:24 -04:00
Mouad Debbar e045ef2969
Keymap for Web (#41397) 2019-10-01 14:10:53 -07:00
Slade Capasso a9c28d5f6c
range_slider_test.dart diagnostics property tests (#40291)
* Updates to slider_test.dart

Fixed error that required onChanged.

* Updated slider.dart and slider_test.dart debugFillProperties

Updated slider.dart debugFillProperties to include all properties and slider_test debugFillProperties to test all properties

* Updated Slider onChanged property

* Updated debugFillProperties to ignore testing methods that are null in test

Per feedback from Hans/Anthony on Flutter Material

* Updated spacing in debugFillProperties

Per feedback from Hans

* Updated range_slider.dart and range_slider_test.dart to have DiagnosticProperties tests for all properties

* Updated range_slider.dart and range_slider_test.dart per feedback

Preventing null labels from creating an error.

Added made RangeLabels and RangeValues constants in instantiation of Range Slider.

Fixed spacing.

* Updates to start and end labels in diagnostic property tests

Updated per feedback from @clocksmith
2019-10-01 17:06:34 -04:00
Jonah Williams 6714baab41
Download Android x64 release artifacts (#41698) 2019-10-01 14:04:37 -07:00
Jonah Williams b2f38396f4
Reland: Switch to assemble API for dart2js (#41659)
* Stop using build_runner for dart2js

* fixes to yield when computing hashes and to imports

* add missing await

* Update filecache_test.dart

* Fix paths in filecache test

* use file uri for import

* add test cases and configurable override

* remove test dep

* fix filepaths for windows

* test no longer failing

* fix paths for test cases

* fix typo

* address comments

* make a constant

* make filehash async and use constant

* fix silly logic error
2019-10-01 14:03:42 -07:00
Jiahao 7fb085ee04
Manual roll of engine to 49815128157d..5c428d924790 (10 commits) (#41704)
16d7694e7 Roll src/third_party/dart 692230b484..67ae444f29 (8 commits)
2019-10-01 14:03:20 -07:00
Jonah Williams ce2c708a90
Add more information to cannot find Chrome message (#41695) 2019-10-01 14:03:12 -07:00
engine-flutter-autoroll 5e1f600fe7
16d7694e7 Roll src/third_party/dart 692230b484..67ae444f29 (8 commits) (#41660)
git@github.com:flutter/engine.git/compare/49815128157d...16d7694e760a

git log 49815128157d..16d7694e760a --no-merges --oneline
2019-10-01 bkonyi@google.com Roll src/third_party/dart 692230b484..67ae444f29 (8 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-01 16:59:29 -04:00
Yegor 8246785f3f
Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests. (#40630)
Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests.
2019-10-01 13:58:05 -07:00
liyuqian c9d920f301
Dsiable CPU/GPU measurement on BackdropFilter test (#41736)
This test is flaky if CPU/GPU measurement is enabled due to
https://github.com/flutter/flutter/issues/41577
2019-10-01 13:07:27 -07:00
engine-flutter-autoroll 2de1e4f4a1
Roll engine 94363be1eaec..49815128157d (6 commits) (#41656)
git@github.com:flutter/engine.git/compare/94363be1eaec...49815128157d

git log 94363be1eaec..49815128157d --no-merges --oneline
2019-09-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4a0d36d5bc57..2533afa3f8c6 (4 commits) (flutter/engine#12711)
2019-09-30 bkonyi@google.com Roll src/third_party/dart 14983a2941..692230b484 (5 commits)
2019-09-30 30870216+gaaclarke@users.noreply.github.com Cleanup: Made a macro to assert ARC is enabled. (flutter/engine#12701)
2019-09-30 iska.kaushik@gmail.com [flutter_runner] Verified Execution for read exec on Fuchsia (flutter/engine#12703)
2019-09-30 bkonyi@google.com Roll src/third_party/dart 623fd5c8cd..14983a2941 (2 commits)
2019-09-30 ychris@google.com Adding 'pub get' to the 'compile_xxxx.sh' in the Scenario app (flutter/engine#12699)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 22:05:53 -04:00
Jonah Williams 06a6fdbf23
Revert "Switch to assemble API for dart2js (#41447)" (#41658) 2019-09-30 18:35:01 -07:00
Jonah Williams ccc3dd968c
Switch to assemble API for dart2js (#41447) 2019-09-30 18:26:28 -07:00
engine-flutter-autoroll 3df57a71b7
Roll engine 463762b81756..94363be1eaec (2 commits) (#41642)
git@github.com:flutter/engine.git/compare/463762b81756...94363be1eaec

git log 463762b81756..94363be1eaec --no-merges --oneline
2019-09-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89e1f600ec78..4a0d36d5bc57 (12 commits) (flutter/engine#12704)
2019-09-30 50856934+nturgut@users.noreply.github.com [web_ui] Fixing invalid state bug for text editing (flutter/engine#12698)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 21:04:54 -04:00
Christopher Fujino 11d0235121
change printStatus calls to printTrace inside MDnsObservatoryDiscovery (#41621) 2019-09-30 14:15:17 -07:00
engine-flutter-autoroll 0e9ce63c98
463762b81 Roll src/third_party/dart 132bee48d0..623fd5c8cd (50 commits) (#41639)
git@github.com:flutter/engine.git/compare/9675ca2f6b00...463762b81756

git log 9675ca2f6b00..463762b81756 --no-merges --oneline
2019-09-30 bkonyi@google.com Roll src/third_party/dart 132bee48d0..623fd5c8cd (50 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 16:49:53 -04:00
Jenn Magder 1eb1e2226b
Skip pod initialization if version >= 1.8.0. (#41491) 2019-09-30 13:14:42 -07:00
engine-flutter-autoroll 4891e4a349
Roll engine 1f454c75330c..9675ca2f6b00 (3 commits) (#41628)
git@github.com:flutter/engine.git/compare/1f454c75330c...9675ca2f6b00

git log 1f454c75330c..9675ca2f6b00 --no-merges --oneline
2019-09-30 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (#12280)" (flutter/engine#12385)
2019-09-30 gspencergoog@users.noreply.github.com Add missing flag for embedder. (flutter/engine#12700)
2019-09-30 lu.zuccarini@gmail.com Add a method to flutter_window_controller to destroy the current window. (flutter/engine#12076)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 16:13:54 -04:00
Jonah Williams e8517a434d
Add analytics tracking for compile and refresh times for Flutter Web (#41545) 2019-09-30 12:45:03 -07:00
Jacob MacDonald 94993055f2
track unused inputs in build_runner (#41610) 2019-09-30 12:20:00 -07:00
Jonah Williams 06864e445c
Rename Server/web device to Headless Server/headless-server (#41618) 2019-09-30 12:19:45 -07:00
Jonah Williams 41b87255f5
Add support for depfile dependency in assemble (#41530) 2019-09-30 12:17:45 -07:00
engine-flutter-autoroll 60eeb60f8c
Roll engine f0c77405d5c2..1f454c75330c (3 commits) (#41624)
git@github.com:flutter/engine.git/compare/f0c77405d5c2...1f454c75330c

git log f0c77405d5c2..1f454c75330c --no-merges --oneline
2019-09-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from sWs8N... to _0Sq8... (flutter/engine#12697)
2019-09-30 jason-simmons@users.noreply.github.com Migrate from fuchsia.crash.Analyzer to fuchsia.feedback.CrashReporter (flutter/engine#12413)
2019-09-30 gspencergoog@users.noreply.github.com Add isFocusable to SemanticsFlag (flutter/engine#12618)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-09-30 15:10:54 -04:00
engine-flutter-autoroll bc60c94fc5
Roll engine 5b952f286fc0..f0c77405d5c2 (47 commits) (#41622)
git@github.com:flutter/engine.git/compare/5b952f286fc0...f0c77405d5c2

git log 5b952f286fc0..f0c77405d5c2 --no-merges --oneline
2019-09-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia e242d0ea937c..89e1f600ec78 (3 commits) (flutter/engine#12696)
2019-09-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ncc-K... to KH7Tv... (flutter/engine#12694)
2019-09-30 50856934+nturgut@users.noreply.github.com Refactoring text_editing.dart (flutter/engine#12479)
2019-09-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia abc851eb3dcc..e242d0ea937c (2 commits) (flutter/engine#12693)
2019-09-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0e7500021402..abc851eb3dcc (3 commits) (flutter/engine#12692)
2019-09-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7aeabcfa6a73..0e7500021402 (1 commits) (flutter/engine#12691)
2019-09-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from eUBos... to sWs8N... (flutter/engine#12690)
2019-09-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VACNQ... to ncc-K... (flutter/engine#12689)
2019-09-29 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from OEG20... to eUBos... (flutter/engine#12688)
2019-09-29 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6fMRC... to VACNQ... (flutter/engine#12687)
2019-09-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia be971636cf9b..7aeabcfa6a73 (3 commits) (flutter/engine#12686)
2019-09-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2e856451654d..be971636cf9b (1 commits) (flutter/engine#12685)
2019-09-29 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from lHiKM... to OEG20... (flutter/engine#12683)
2019-09-29 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from z3oH6... to 6fMRC... (flutter/engine#12682)
2019-09-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from nVAcH... to lHiKM... (flutter/engine#12680)
2019-09-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Kiq-H... to z3oH6... (flutter/engine#12679)
2019-09-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia bd84330ba277..2e856451654d (1 commits) (flutter/engine#12661)
2019-09-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8ab1530cd3cd..bd84330ba277 (1 commits) (flutter/engine#12639)
2019-09-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from qx53U... to nVAcH... (flutter/engine#12620)
2019-09-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from oob8T... to Kiq-H... (flutter/engine#12616)
2019-09-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 28ad6f869822..8ab1530cd3cd (5 commits) (flutter/engine#12614)
2019-09-27 liyuqian@google.com Revert "[fuchsia] Wire up OpacityLayer to Scenic (#11322)" (flutter/engine#12610)
2019-09-27 30870216+gaaclarke@users.noreply.github.com Started asserting the FlutterEngine is running before communicating over channels. (flutter/engine#12469)
2019-09-27 30870216+gaaclarke@users.noreply.github.com Split out the logic to handle status bar touches into its own function (flutter/engine#12587)
2019-09-27 bkonyi@google.com Roll src/third_party/dart c3c31b74fd..132bee48d0 (16 commits)
2019-09-27 iska.kaushik@gmail.com [flutter_runner] Refactor thread_application pair to ActiveApplication (flutter/engine#12573)
2019-09-27 gw280@google.com Reword confusing messaging surrounding unhandled exception in flutter_runner on Fuchsia (flutter/engine#12428)
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia b23d66e10a98..28ad6f869822 (10 commits) (flutter/engine#12580)
2019-09-27 iska.kaushik@gmail.com Revert "Update linux toolchain for fuchsia" (flutter/engine#12578)
2019-09-27 jonahwilliams@google.com Add support for JIT release mode (flutter/engine#12446)
2019-09-27 iska.kaushik@gmail.com Update linux toolchain for fuchsia (flutter/engine#12572)
2019-09-27 iska.kaushik@gmail.com Remove references to topaz (flutter/engine#12565)
2019-09-27 bkonyi@google.com Roll src/third_party/dart 7901c508c8..c3c31b74fd (4 commits)
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3787f51c65c3..b23d66e10a98 (1 commits) (flutter/engine#12559)
2019-09-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from HoRV8... to oob8T... (flutter/engine#12538)
2019-09-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from YDv3O... to qx53U... (flutter/engine#12520)
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia 296743a86281..3787f51c65c3 (4 commits) (flutter/engine#12512)
2019-09-27 bkonyi@google.com Roll src/third_party/dart 403c4af720..7901c508c8 (7 commits)
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia b83cc76a5e3a..296743a86281 (1 commits) (flutter/engine#12491)
2019-09-27 bkonyi@google.com Roll src/third_party/dart 327bc451f8..403c4af720 (9 commits)
2019-09-27 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from HfPKR... to zpVtV... (flutter/engine#12473)
2019-09-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia ec85f407bfee..b83cc76a5e3a (15 commits) (flutter/engine#12472)
2019-09-27 30870216+gaaclarke@users.noreply.github.com Added a default entrypoint variable to match android syntax. (flutter/engine#12370)
2019-09-26 tauu@h2overclock.de [web_ui] add missing dispose handler for MethodCalls to flutter/platform_view (flutter/engine#12226)
2019-09-26 tauu@h2overclock.de [web_ui] PersistedPlatformView attribute update handling to enable resizing (flutter/engine#12227)
...
2019-09-30 13:57:42 -04:00
Alexandre Ardhuin f0553ba58e
Missing trailing commas (#41473)
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
2019-09-30 18:48:23 +02:00
stuartmorgan d1761f1072
Pass Linux build mode on command line (#41551)
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.

Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.

Fixes #41528
2019-09-30 09:36:40 -07:00
Justin McCandless 67ea92cbca
Fix exception when selecting in TextField (#41326) 2019-09-30 09:24:30 -07:00
Erick Ghaumez d122f09959 Fix the ThemeData.copyWith toggleButtonsTheme argument type (#40994)
* set the copyWith toggleButtonsTheme argument type to ToggleButtonsThemeData

* add a ThemeData.copyWith test
2019-09-30 23:52:35 +08:00
Jonah Williams c8b3c9b727
use IOOverrides to allow inject file system, write test, find bug (#40066) 2019-09-30 08:41:12 -07:00
Zachary Anderson 45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal (#41493)
* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Danny Tuppeny 7e73cd74b1
Fix visibility of web server device when Chrome is not available (#40757)
* Fix visbility of web server device when Chrome is not available

* Add tests

* Update workflow test

* Fix tests to not rely on Chrome being on the underlying machine
2019-09-30 14:45:30 +01:00
Alexander Aprelev 839fdbd2ed
Retry devfs uploads in case they fail. (#41406)
* Retry devfs uploads in case they fail.

Fixes #34959.
2019-09-29 21:32:06 -07:00
Jonah Williams 69af9adeac
Update minimum build_runner version and enable incremental builder (#41499) 2019-09-29 13:01:33 -07:00
liyuqian 3606300bf5
Rename the file to fix the device lab (#41579)
TBR: @goderbauer
2019-09-29 11:51:04 -07:00
liyuqian 9cc29c61df
Reland "Measure iOS CPU/GPU percentage #41426" (#41578)
This reverts commit baea9bf7cc.

Additionally,   we let the test run on mac8 with iphonexs because the test won't run on Xcode 10.1 (mac3-7). Hence we force it to run on mac8 which currently has Xcode 10.2.
2019-09-29 11:33:43 -07:00
liyuqian baea9bf7cc
Revert "Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)" (#41575)
This reverts commit 67b5bdf99b.

Reason: it broke device lab.

TBR: @goderbauer
2019-09-29 10:58:13 -07:00
liyuqian 67b5bdf99b
Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)
This reverts commit f1e7fe8142.

This fix is in https://github.com/flutter/packages/pull/39
2019-09-28 14:24:46 -07:00
Greg Spencer 0223565fd5
Reland changes to Intent.doNothing to avoid analyzer issue (#41477)
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
2019-09-28 08:55:47 -07:00
MH Johnson f4ba8d1a93
[Material] Remove text ripple from TextFields (#41320)
* remove splash logic

* update tests
2019-09-28 11:47:17 -04:00
Greg Spencer 25f2399ba3
Add flutter drive to readme. (#41509)
This adds a description of the command needed to run the driver test
2019-09-28 00:22:37 -07:00