Commit graph

2863 commits

Author SHA1 Message Date
Yuqian Li 46d1aba2e2
Remove flutter_gallery_ios32__transition_perf test (#65415) 2020-09-08 15:55:12 -07:00
Jonah Williams 29898812d4
[framework] make hit slop based on device pointer kind for drag/pan/scale gestures (#64267)
Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.

One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.

This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.

This PR does not adjust:

kTouchSlop used in scroll_physics.dart's minFlingDistance
kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
2020-09-08 15:53:36 -07:00
Ian Hickson e10bdbbd9d
Fix RangeMaintainingScrollPhysics (#65135) 2020-09-07 11:40:03 -07:00
Jim Graham 9f4d4a5c59
re-enable the post_backdrop_filter test with CPU/GPU measurements (#65201) 2020-09-04 18:00:02 -07:00
Yuqian Li d7d1461f75
Increase simple animation delay and duration (#64002)
Previously, the CPU/GPU measurement using gauge happened after the
driver test is done. Now, the measurement happens within the driver
test. So we need to properly increase the delay and duration to get a
comparable reading as the old gauge measurements.
2020-09-03 13:25:19 -07:00
Yuqian Li 1135002b0f
Mark nonflaky tests as such (#65054)
Those 2 tests have been green for the last 10 runs
2020-09-03 12:46:24 -07:00
Shi-Hao Hong b80b432555
Move gen_l10n into flutter_tools (#65025) 2020-09-03 09:26:58 -07:00
Jenn Magder ace54425e0
Add observatory Bonjour service to built iOS Info.plist bundle (#65138) 2020-09-02 18:47:56 -07:00
Jenn Magder 259deec221
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (#65138)" (#65141)
This reverts commit 5e0aa8b9fc.
2020-09-02 18:31:45 -07:00
Jenn Magder 5e0aa8b9fc
Add observatory Bonjour service to built iOS Info.plist bundle (#65138) 2020-09-02 17:57:43 -07:00
gaaclarke 37de94d7d2
devicelab: started averaging startup time for ios test (#64978) 2020-09-02 16:35:03 -07:00
Jenn Magder 2e67bf2e32
Require xcode_backend.sh arguments (introduced in Flutter v0.0.7) (#65124) 2020-09-02 16:33:26 -07:00
Jenn Magder cb819504f3
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (#64988)" (#65109)
This reverts commit 4fde217dea.
2020-09-02 12:31:17 -07:00
Christopher Fujino 237c0ab424
Delete catalog generator android/ios tests (#64977) 2020-09-02 11:25:04 -07:00
Yuqian Li 484f3f2646
Add FrameTiming delay to watchPerformance (#64780) 2020-09-02 11:15:08 -07:00
Pedro Massango 7fdd9218b0
Proposal: deprecate autovalidate parameter of the Form, FormField and TextFormField widget (#61648) 2020-09-02 11:15:05 -07:00
Jenn Magder 4fde217dea
Add observatory Bonjour service to built iOS Info.plist bundle (#64988) 2020-09-02 11:11:07 -07:00
Dan Field a8281e31af
Mark large_image_changer tests as not flaky (#65033)
They appear to be passing now.
2020-09-01 10:57:59 -07:00
Dan Field e82571a98c
Update large_image_changer_test.dart (#64974)
Fix typo.
2020-09-01 09:09:31 -07:00
Ming Lyu (CareF) 28de49e358
Revert "Reland #61998 and update complex_layout ios files (#64885)" (#64990)
This reverts commit df83398687.
2020-08-31 18:47:08 -07:00
Ming Lyu (CareF) df83398687
Reland #61998 and update complex_layout ios files (#64885) 2020-08-31 17:23:06 -07:00
Dan Field b5ed913ecc
Memory/cpu/gpu benchmark for showing large images in succession (#64762) 2020-08-31 10:03:57 -07:00
Casey Hillers ef3440b8d8
[fuchsia] Test wait for device to be up after pave (#64819) 2020-08-31 09:48:05 -07:00
Shi-Hao Hong fd22fc3e35
[gen_l10n] Synthetic package generation by default (#62395)
* synthetic packages by default in gen_l10n tool

* Refactor default path for synthetic package

* Remove unused import

* Code cleanup

* Further improvements to help text

* Refactor synthetic package path

* Remove newlines

* Test cleanup

* clean up logic in inputs and outputs list function

* Update l10n.yaml usage

* only add option if value is non-null

* Update stocks app as proof of concept for synthetic package usage

* Address nits

* print pubspec contents

* add print statements

* Do not allow null value for useSyntheticPackage

* +

* +

* +

* +

* Cleanup

* Add test

* Fix text

* Dont parse pubspec directly

* Test using context

* WIP: generate synthetic packages on pub get -- needs tests

* Allow null value

* Update null handling

* Refactor to properly handle null case

* Fix yamlMap condition

* Fix yaml node for real

* WIP: struggling to write tests

* WIP - take absolute path as an option

* Add tests

* Use environment project directory for synthetic package generation pathway

* Fix typo

* Improve help text

* Update defaults

* Remove unauthorized path import

* Fix pathing issues at synthetic package generation

* Fix typo in test

* Use path.join so projectDir matches up based on OS

* Fix Windows pathing in test

* Remove unnecessary replaceApp code for projectDir.path

* Use globals.fs.currentDirectory.path in resident_runner_test.dart

* Fix merge conflict

* Add test to ensure that synthetic package is generated on pub get

* Fix resident_runner_test.dart tests

* Fix tests

* Use package:file instead of dart:io

* WIP - exploration

* Remove synthetic package use from stocks example

* Update integration test to not use synthetic packages

* Remove trailing whitespace

* flutter pub get runs synth package generation

* Remove more print statements

* Add license header

* WIP - minimally working pub.get

* Use own MockBuildSystem

* Modify test and implementation to be a little cleaner

* Fix flutter pub get invocation

* Use synthetic packages in stocks app

* Revert "Use synthetic packages in stocks app"

This reverts commit 45bf24903c.

* Add environment and buildSystem params to flutter test

* Address code review feedback

* +

* Isolate codegen into its own API

* Fix imports

* Slight refactor

* Add one more test for no l10n.yaml file

* Remove unneeded mock class and import in pub_get_test.dart

* More code review feedback

* Remove unnecessary imports

* Remove `return await`s that I missed

* use arrow functions instead
2020-08-31 13:19:41 +08:00
Shi-Hao Hong 34541c3073
Revert "A benchmark test case for measuring scroll smoothness (#61998)" (#64883)
This reverts commit 12b7355da1.
2020-08-30 18:42:10 +08:00
Ming Lyu (CareF) 12b7355da1
A benchmark test case for measuring scroll smoothness (#61998) 2020-08-29 04:28:03 -07:00
Tong Wu 8c2d1c49a2
[Devicelab] Temporarily remove testonly_devicelab_tests builder. (#64837) 2020-08-28 20:13:03 -07:00
Zachary Anderson dff7ea1c4f
Revert "Avoid thinning frameworks in iOS extensions (#64674)" (#64829)
This reverts commit ce9cde8c4e.
2020-08-28 15:23:22 -07:00
Zachary Anderson 6f02c0b231
Revert "Roll new gallery to help flaky Crane test (#64676)" (#64824)
This reverts commit e825281745.
2020-08-28 13:54:51 -07:00
Ming Lyu (CareF) 3579f1c33e
remove flaky flag (#64770) 2020-08-28 11:08:04 -07:00
Casey Hillers 4a33ce7d53
[fuchsia] Refactor fuchsia_ctl use to a function (#64736) 2020-08-28 10:53:04 -07:00
Yuqian Li e825281745
Roll new gallery to help flaky Crane test (#64676) 2020-08-28 10:48:03 -07:00
Jenn Magder ce9cde8c4e
Avoid thinning frameworks in iOS extensions (#64674) 2020-08-28 10:43:04 -07:00
Tong Wu 162d82db1b
Temporarily disable the mac/android test on LUCI. (#64729)
Because the test bed's CPU is too hot.

Bug: https://github.com/flutter/flutter/issues/64723
2020-08-27 10:18:36 -07:00
Casey Hillers f35a8b7470
Sync with engine run_tests script (#64670) 2020-08-26 21:33:03 -07:00
Dan Field dd9015c21e
Use Pixel4 for better wait times (#64609)
* Use Pixel4 for better wait times

According to the firebase team, these have lower wait times for tests.
2020-08-26 08:56:39 -07:00
Jonah Williams 3f6c862177
[null-safety] remove sound-null-safety by default, remove experiment flag (#64594)
To allow tests to begin migrating to null safety, sound null safety needs to be disabled. Also removes the experiment flag that is unnecessary since the framework is on the SDK allowlist.
2020-08-25 15:57:54 -07:00
Alexander Aprelev ed65f5e96c
Re-enable image_list test with updated certificate(good for 3650 days). (#64519)
Added instructions on how to regenerate certificate too.
2020-08-25 11:30:27 -07:00
Jenn Magder bd7e2eeee9
Bump Cirrus image Xcode version (#63252) 2020-08-25 10:34:33 -07:00
Ming Lyu (CareF) 13d1ff8c67
update manifest (#64079) 2020-08-25 13:17:20 -04:00
Mouad Debbar 707f995de3
[web] Fix and enable editable_text_test.dart (#64516) 2020-08-25 04:51:03 -07:00
Jenn Magder e960d773ee
Change iOS plugin simulator archs from allow list to deny list (#64504) 2020-08-24 17:48:05 -07:00
Yuqian Li facd6c7730
Mark new_gallery__crane_perf as flaky (#64341) 2020-08-24 13:36:04 -07:00
Jonah Williams 2f937703e4
[devicelab] disable image list duration tests (#64486) 2020-08-24 12:08:58 -07:00
Ming Lyu (CareF) d30e36ba8c
migrate flutter_gallery_sksl_warmup__transition_perf to e2e (#64275) 2020-08-21 19:36:03 -07:00
Tong Wu fe68f695ff
Fix LUCI builders config. (#64361) 2020-08-21 16:04:17 -07:00
Yuqian Li 6f0ea92709
Change typo profileDemos to restDemos (#64364) 2020-08-21 15:36:04 -07:00
godofredoc f37113dc7d
Add web_smoke_tests to luci. (#64331)
Bug:
  https://github.com/flutter/flutter/issues/64070
2020-08-21 11:30:25 -07:00
Ian Hickson 39be8a40b5
More restoration documentation (#63438) 2020-08-21 10:51:05 -07:00
Ian Hickson c7ebb2b75f
Trivial typo fixes to snippets documentation (#63436) 2020-08-21 10:46:05 -07:00
keyonghan c98a64f554
Add run_if property for existing LUCI try builders (#64180)
* add run_if property for existing try builders

* update

* update readme
2020-08-20 17:28:12 -07:00
godofredoc 1cd6694ab9
Remove windows_docs. (#64277) 2020-08-20 17:26:04 -07:00
Yuqian Li a1de2a22fb
Mark e2e version of ios32 transition test nonflaky (#64269) 2020-08-20 15:16:06 -07:00
Ming Lyu (CareF) 0f4d24819d
Revert "run the test longer time (#64185)" (#64255) 2020-08-20 15:06:08 -07:00
xster a2e5e074ab
Move Android doctor SDK check to 29 and Cirrus images to 30 (#63517) 2020-08-20 11:06:32 -07:00
Jim Graham 9e86e9fb1e
report list of detail files so devicelab can save them (#64009) 2020-08-20 10:58:25 -07:00
Ming Lyu (CareF) 1fc3a5e439
run the test longer time (#64185) 2020-08-19 21:23:59 -04:00
Christopher Fujino d6e308c578
Don't fail docs-linux on release branches (#64203) 2020-08-19 18:16:05 -07:00
Jonah Williams 04f7c9d52e
[flutter_tools] update dwds, roll to null-safe file and process (#64195)
Update to latest dwds, file-nullsafety, and process-nullsafety for #62886
2020-08-19 16:59:52 -07:00
Jonah Williams 829ef147d1
[null-safety] roll to null-safe platform (#64160) 2020-08-19 15:47:08 -07:00
Greg Spencer 041a3eaa84
Standardize the nullability of arguments to raw key data constructors. (#63523)
This standardizes the handling of nullability for the LogicalKeyboardKey.keyLabel and RawKeyEventData.keyLabel accessors so that they are non-nullable, but can be empty.

Before this change, the keyLabel could be either null or an empty string to indicate that there wasn't a label, which makes it harder to test for, since both need to be checked for. Since an empty string is sufficient, there is no need for it to be nullable.

Also, in raw_keyboard.dart, the web and Windows implementations wouldn't accept null values for parameters in the Map coming from the message, but tests were supplying null for some of them. This makes web and Windows creation of events match the other platforms, and makes the migration of tests to non-nullability easier.
2020-08-19 15:03:17 -07:00
Jonah Williams 69fd5c50a2
[flutter_tools] null assertions off by default for web (#64186)
Like Android/iOS, only enable --null-assertions if asked. Previously this was enabled by default for web, but in general this has proved to be too breaking to enable by default.

#61042
2020-08-19 14:52:47 -07:00
Yuqian Li 6eb45d35da
Rename needsMeasureCpuGpu to measureCpuGpu (#64000) 2020-08-19 13:26:07 -07:00
Jonah Williams 38e0c25823
[flutter_tools] reland: enable --null-assertions for flutter framework tests (#64120)
Reland of acdb909 with fixes to semantics.dart

#61042
2020-08-19 13:25:42 -07:00
Yuqian Li 266b9f99a9
Mark tests as nonflaky (#64077)
These tests look quite stable for the last 10 runs.
2020-08-19 10:37:12 -07:00
Tong Wu 430e3cf08c
[devicelab] Enable a LUCI try builder. (#64004) 2020-08-19 08:36:04 -07:00
Jonah Williams 1b69983c6d
[versions] update gallery, roll versions (#64067) 2020-08-19 08:07:15 -07:00
LongCatIsLooong db705b81e3
Restore the original name of the velocity tracker microbenchmark (#64060) 2020-08-19 00:41:06 -07:00
godofredoc 86d2fe9f20
Remove windows docs from list of try jobs. (#64125)
Bug:
  https://github.com/flutter/flutter/issues/64121
2020-08-18 21:48:04 -07:00
Michael Goderbauer 3e867f78db
Fix assert in dartdoc_checker and enable asserts (#64111) 2020-08-18 19:11:05 -07:00
Jenn Magder 1b47759528
Revert "[null-safety] enable null assertions for framework tests (#64071)" (#64118)
This reverts commit acdb909fcb.
2020-08-18 18:08:51 -07:00
Tong Wu d6c254be4e
Fix a data issue in prod_builder.json (#64116) 2020-08-18 17:51:29 -07:00
Michael Goderbauer e1a09622df
Bump dartdoc to 0.30.4 (#64112) 2020-08-18 17:31:04 -07:00
Jonah Williams acdb909fcb
[null-safety] enable null assertions for framework tests (#64071) 2020-08-18 17:21:04 -07:00
xster b92f80e22a
Incorrect path.join usage might be causing Windows test failures (#64056) 2020-08-18 17:16:04 -07:00
Ming Lyu (CareF) 48287750d0
remove duplicate e2e driver (#64015) 2020-08-18 17:06:05 -07:00
godofredoc d504437d88
Make cirrus tests presubmit only and add new luci tests. (#63995) 2020-08-18 17:01:09 -07:00
Jonah Williams 39c735f408
[flutter_tools] correctly forward error only stdout in non-verbose modes (#63815) 2020-08-18 16:56:05 -07:00
Ming Lyu (CareF) 3313df9b13
ensureVisible => scrollUntilVisible (#63983) 2020-08-17 14:11:02 -07:00
Yuqian Li c08ce78374
Mark nonflaky tests as such (#63801) 2020-08-17 12:23:01 -07:00
Ming Lyu (CareF) fe94267604
add ios tests (#63797) 2020-08-17 12:16:03 -07:00
Dan Field d1583fc39b
drop xcpretty for tests (#63804) 2020-08-14 20:09:41 -07:00
Remi Rousselet 2b25e29192
add benchmark for ChangeNotifier.notifyListeners (#62715) 2020-08-14 17:06:03 -07:00
Ming Lyu (CareF) 6f26e806ab
bug fix for flutter_gallery__transition_perf(_with_semantics) (#63799)
* report failure for semantics test

* bug fix
2020-08-14 19:37:08 -04:00
keyonghan 8d4aef0d51
Add enabled flag for try builders (#63783)
* add enabled flag

* remove flaky flag for try builders

* remove trailing space
2020-08-14 13:22:49 -07:00
godofredoc 58feba8edd
Update task_names to add the platform. (#63736) 2020-08-13 21:16:04 -07:00
MH Johnson bee9522f18
[Text Scaling][Material] Update BottomNavigationBar to show tooltips on long press. (#59127) 2020-08-13 22:53:27 -04:00
godofredoc 89f004e0d3
Add windows builders to presubmit. (#63726) 2020-08-13 19:00:20 -07:00
Ming Lyu (CareF) 360023e2bc
Clean up flutter_gallery__transition_perf (#63609) 2020-08-13 14:41:04 -07:00
godofredoc 0ec50a8e63
Add win (#63594) 2020-08-13 14:31:09 -07:00
Kate Lovett eb60849e93
Pin goldctl (#63593) 2020-08-13 11:16:04 -07:00
Greg Spencer 21f4096267
Revert: Update prepare_package.dart to use the process_runner package instead having duplicate code. #62710 (#63608)
This reverts #62710, since it has a noSuchMethodError in some circumstances.

This isn't just a straight git revert, because I had to resolve the conflicts in the reverted pubspec.yaml files and re-run flutter update-packages --force-upgrade to make the checksums match.
2020-08-13 08:43:20 -07:00
Konstantin Scheglov bd1a58a991
Add arguments for required parameters. (#63598) 2020-08-13 08:16:33 -07:00
Shi-Hao Hong 0a7c6243fa
[gen_l10n] Absolute project path parameter (#63368) 2020-08-13 05:11:05 -07:00
Ming Lyu (CareF) 0629030a05
WidgetTester.drag with time duration (#63410) 2020-08-12 21:01:03 -07:00
Emmanuel Garcia febcbcb885
Print dex when analyzing the APK (#63538) 2020-08-12 17:56:04 -07:00
Dan Field bc74ae5437
Remove unused files (#63532) 2020-08-12 15:41:05 -07:00
Jenn Magder 6b2ef0df7b
Fix App.framework path in Podfile (#63412) 2020-08-12 13:36:12 -07:00
Ming Lyu (CareF) 2384376f64
Migrate gallery/transitions_perf test to e2e (#62064) 2020-08-12 13:36:07 -07:00
LongCatIsLooong cea055ef00
Make Scrollable's free scroll initial velocity matches that of iOS (#60501) 2020-08-12 13:31:05 -07:00
Jonah Williams 9225d8d5b7
[flutter_tools] move to fake_async, skip failing tests (#63536) 2020-08-11 19:36:05 -07:00
Shi-Hao Hong c36b75e45b
Remove Special Handling of Norwegian Locales (#63034)
* Regenerate _no.arb and _nb.arb from scratch

* Revert no <--> nb synonym logic
2020-08-12 07:29:17 +08:00
godofredoc 8bef71b910
Update prod builders. (#63492)
* Update prod builders.

This is to make the builders show up in the flutter dashboard.

Bug:
  https://github.com/flutter/flutter/issues/63256

* Add mac and windows bots.

* Fix flaky flag.

* Rename taskName as task_name.
2020-08-11 15:52:20 -07:00
xster df8e537f96
move compile/target sdk versions to 29 (#62799) (#63008) 2020-08-11 14:51:02 -07:00
Greg Spencer a344fb1e2c
Update prepare_package.dart to use the process_runner package instead having duplicate code. (#62710)
Updates the prepare_package.dart script to use the process_runner package (which is where the ProcessRunner implementation was moved to).
2020-08-11 14:44:57 -07:00
Hans Muller d06c8fa54e
Updated old button references in dev/integration_tests/flutter_gallery ... full_screen_dialog_demo (#63491) 2020-08-11 11:39:20 -07:00
Hans Muller e13b929e61
Updated old button references in dev/integration_tests/flutter_gallery ... transformation_demo (#63432) 2020-08-11 10:05:19 -07:00
Hans Muller c13b354a02
Updated old button references in dev/integration_tests/flutter_gallery leave_behind_demo (#63430) 2020-08-11 10:03:34 -07:00
godofredoc 1731609c59
Enable builds in presubmit and remove old ones. (#63439)
Framework tests got replaced with a new version using shards. This pr is
enabling the new builders in presubmit and removing the old ones.

Bug:
  https://github.com/flutter/flutter/issues/63258
  https://github.com/flutter/flutter/issues/63242
  https://github.com/flutter/flutter/issues/63241
2020-08-11 08:22:21 -07:00
Hans Muller 6667c05243
Updated old button references in dev/integration_tests/flutter_gallery ... drawer_demo (#63404) 2020-08-11 07:46:37 -07:00
Hans Muller 5a5332a7c7
Updated old button references in dev/integration_tests/flutter_gallery ... banner_demo (#63402) 2020-08-11 07:46:23 -07:00
Hans Muller 0ea5e00276
Updated old button references in dev/integration_tests/flutter_gallery ... cards_demo (#63400) 2020-08-11 07:45:57 -07:00
Jenn Magder 0fe1adadd2
Pin iOS module test plugin versions (#63445) 2020-08-11 06:26:05 -07:00
Jenn Magder 31dfaa0c7e
Temporarily turn off module_test_ios during investigation (#63448) 2020-08-10 19:08:35 -07:00
Ming Lyu (CareF) 65d9faa1b4
Prepare macrobenchmarks' e2e tests for firebase test lab (#63197) 2020-08-10 11:01:02 -07:00
Michael Klimushyn cb69bbb4d5
Remove unused l and --isolate-filter tools (#63336) 2020-08-10 10:51:04 -07:00
Hans Muller f1bf6cf9f9
Updated old button references in dev/integration_tests/android_semantics_testing (#63232) 2020-08-08 18:21:09 -07:00
Hans Muller 61349ca6c5
Updated old button references in dev/integration_tests/hybrid_android_views (#63215) 2020-08-08 18:20:34 -07:00
Hans Muller 8798bc43af
Updated old button references in dev/integration_tests/android_views (#63214)
* Updated old button references in dev/integration_tests/android_views

* Empty commit to force all tests to rerun
2020-08-08 18:20:16 -07:00
Hans Muller 46e1f91c18
Updated old button references in dev/integration_tests/ui (#63213) 2020-08-08 18:19:59 -07:00
godofredoc 4aed976812
Add framework and hostonly tests to luci presubmit. (#63245)
Bugs:
    https://github.com/flutter/flutter/issues/63241
    https://github.com/flutter/flutter/issues/63242
2020-08-07 23:30:56 -07:00
Yuqian Li 2296bb154b
Measure CPU/GPU with the simple animation test (#63124) 2020-08-07 20:41:07 -07:00
Michael Goderbauer e49a57660d
Bump dartdoc to 0.32.3 and tighten doc quality checker (#63111) 2020-08-07 20:41:04 -07:00
Christopher Fujino b7a1a397b2
Rev json gem (#62987) 2020-08-07 20:36:06 -07:00
Ian Hickson ae432ca8a2
Add a comment with a reference to issue 62919 (LUCI should run the tests in a directory that contains a space character) to this skipped test. (#62920) 2020-08-06 18:46:03 -07:00
Ming Lyu (CareF) 99ea866247
update packages (#63017) 2020-08-06 16:21:05 -07:00
Michael Goderbauer 6ab558d86a
Revert "Add padding around flutter api docs search input (#44980)" (#63113)
This reverts commit c8cb245f24.
2020-08-06 16:15:09 -07:00
Ming Lyu (CareF) 4c3a14c9de
remove flaky flag (#63128) 2020-08-06 14:46:17 -07:00
keyonghan f08d7297e1
Add supported Luci builders for flutter repo (#62445) 2020-08-06 13:41:08 -07:00
Yuqian Li 6d487355a3
Remove cubic_bezier_perf.dart (#63028) 2020-08-05 20:21:02 -07:00
Ian Hickson 209e3e9fd6
Update docs.sh (#62814) 2020-08-05 19:21:08 -07:00
Tianguang 504963b4d1
Pin gallery version (#62986) 2020-08-05 15:11:18 -07:00
Hans Muller 6b7634b73a
Removed old button widget references from dev/manual_tests (#62816) 2020-08-05 14:51:27 -07:00
Yuqian Li 76a2f42e36
Mark nonflaky test as such (#63014) 2020-08-05 14:46:57 -07:00
Zachary Anderson bef6d1545a
Mark named_isolates_test flaky (#63021) 2020-08-05 14:42:29 -07:00
Tianguang ce1cfbe71d
Add remaining benchmarks (#62906) 2020-08-05 09:31:08 -07:00
Ming Lyu (CareF) 1d329d2cc9
migrate macrobenchmark/multi_widget_construction test to e2e (#62539) 2020-08-04 18:56:03 -07:00
Michael Goderbauer 3b887bec47
Reland "migrate part of painting to nullsafety (#62696)" (#62872) 2020-08-04 16:06:04 -07:00
Jonah Williams e8ad863a08
Revert "move compile/target sdk versions to 29 (#62799)" (#62884)
This reverts commit 5b3dc5251b.
2020-08-04 11:20:16 -07:00
xster 5b3dc5251b
move compile/target sdk versions to 29 (#62799) 2020-08-04 08:26:08 -07:00
gaaclarke fbd6dd64d3
Added a more generous timeout period for the keyboard animation. (#62628) 2020-08-04 08:14:17 -07:00
Jacob MacDonald 67e9b2945e
update to use more null safe packages (#62525)
Updates all the dependencies used in the most basic test and flutter_test isolates.
2020-08-03 12:29:30 -07:00
Michael Goderbauer e5ca020d66
Make dartdoc warnings fatal for flutter_test (#62614) 2020-08-03 10:46:04 -07:00
Jonah Williams c24772e8fb
[versions] update to the latest sdk versions (#62687) 2020-08-03 10:31:06 -07:00
Jenn Magder 1513b9719a
Add integration test for plugins without ios directories (#62630) 2020-08-03 10:24:04 -07:00
Jonah Williams c748f1a7aa
remove flutter attach devicelab test (#62704)
The flutter tool already has an attach integration test: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/flutter_attach_test.dart

The devicelab test frequently fails with difficult to debug issues and is not worth the maintenance cost.
2020-07-31 17:45:18 -07:00
Alexandre Ardhuin 7884420a0a
migrate services to nullsafety (#62513)
NNBD migration for services
2020-07-31 11:20:00 -07:00
Yuqian Li e6bc56f25a
Reland "Add Crane test to the new Gallery app (#62162)" (#62544) 2020-07-31 09:56:04 -07:00
Jason Simmons e5de16a247
Make the text field macrobenchmark work in debug mode (#62523) 2020-07-31 09:51:05 -07:00
keyonghan 4f09f2c2bd
remove flaky flag (#62348) 2020-07-31 09:48:18 -07:00
Tong Wu 8d58c99e37
[devicelab] Mark flutter_gallery_ios32__start_up as flaky. (#62646)
The test device is causing failure of this test, we will need a couple days to physically access the device and fix the issue. So mark it as flaky to unblock the tree.

Bug: https://github.com/flutter/flutter/issues/62633
2020-07-31 09:41:03 -07:00
Michael Goderbauer 6ca8fda978
After cleaning up 812 warnings: Make warnings fatal in dartdocs (#62553) 2020-07-30 14:11:23 -07:00
Jonah Williams e762e7e05f
[flutter_tools] deflake integration tests by running single isolate (#62534)
There are some occasional difficult to repro flakes on the tool integration tests. Try running only a single isolate to simplify the environment a bit.
2020-07-30 11:06:34 -07:00
冷石 Boy c8cb245f24
Add padding around flutter api docs search input (#44980) 2020-07-30 09:17:57 -07:00
Mehmet Fidanboylu db2ecf4486
Expose certain functions used when rolling Flutter (#62529) 2020-07-29 22:24:52 -07:00
Jim Graham 210f7680fc
ignore .idea directory in dart analyzer and analyzer benchmark output (#55235) 2020-07-29 17:16:26 -07:00
Todd Volkert 3099fb9e50
Remove devicelab timeouts (#62511) 2020-07-29 14:12:29 -07:00
Tong Mu c177db172d
Refactor gen_keycode: Split generators (#61916)
* Split gen_keycode to make maintenance easier.
2020-07-29 13:20:07 -07:00
Ben Konyi 3a5a3eaf68
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#62147)
This reverts commit adc9dde3ba.

- Fixed issue where `FallbackDiscovery` would hold on to a `VmService` when launching on iOS devices, causing DDS to fail to start
- Fixed `flutter drive` case where DDS is already running in another flutter_tools instance
2020-07-29 10:05:40 -07:00
Ming Lyu (CareF) 50828a1318
bug fix (#62349) 2020-07-28 18:31:04 -07:00
Michael Goderbauer f4e10b4fb5
Make dartdoc warnings fatal (& cleanup of warnings) (#62367) 2020-07-28 16:11:04 -07:00
Michael Goderbauer e17a721951
Ban unresolved dartdoc directives from HTML output (#62167) 2020-07-28 15:26:33 -07:00
Michael Goderbauer e4b6754155
Bump new gallery version (#62439) 2020-07-28 15:25:03 -07:00
Alexandre Ardhuin 00dcd5f49b
migrate gestures to nullsafety (#62157) 2020-07-28 15:11:05 -07:00
Michael Goderbauer 1d5a9ae215
Update the FlutterLogo colors and gradients (#62052) 2020-07-28 15:06:04 -07:00
Jonah Williams 27e13dd53e
Revert "Add Crane test to the new Gallery app (#62162)" (#62430)
This reverts commit 1ffdfa81d6.
2020-07-28 11:32:34 -07:00
Yuqian Li 1ffdfa81d6
Add Crane test to the new Gallery app (#62162) 2020-07-28 10:56:05 -07:00
Ming Lyu (CareF) 98264a4709
Simplify macrobencharks/picture_cache (#62219) 2020-07-28 10:51:11 -07:00
Jenn Magder 5281a9aaf1
Mark smoke_catalina_start_up_ios as not flaky (#62085) 2020-07-28 10:30:13 -07:00
Jenn Magder e8e5de44ec
Parse .flutter-plugins-dependencies for add-to-app iOS modules (#61269) 2020-07-28 10:16:09 -07:00
Todd Volkert 901ccbe65b
Add timeout to the devicelab runner logs (#62418) 2020-07-28 09:40:11 -07:00
Todd Volkert 8c5c720ce6
Temporarily disable docset generation (#62386)
https://github.com/flutter/flutter/issues/60646
2020-07-28 01:07:42 -07:00
Todd Volkert 39fa00201d
Use in-memory disk for docs shards (#62373)
https://github.com/flutter/flutter/issues/60646
2020-07-27 21:11:43 -07:00
Jonah Williams d834673033
roll dart/engine to f27729e97b5a00c3a8d8d49edc7b998fa755b97a (#62368) 2020-07-27 17:51:31 -07:00
Todd Volkert 271b8dd674
Fix doc generation scripts (#62340) 2020-07-27 08:46:57 -07:00
Todd Volkert 8e0eee9008
Sub-shard the docs shard (#62281)
Separate out offline docs, docset generation, and docs deployment
each into dedicated shards.

https://github.com/flutter/flutter/issues/60646
2020-07-26 23:38:01 -07:00
Todd Volkert 35e7005184
Rather than timing out dashing, run it in background (#62251)
https://github.com/flutter/flutter/issues/60646
2020-07-25 09:44:17 -07:00
Todd Volkert 5a290fc84d
Add --disable-dart-dev to docs.sh (#62249)
https://github.com/flutter/flutter/issues/62206
2020-07-24 23:51:41 -07:00
Todd Volkert 81bf39e4a9
Print date/time for each step taken in docs.sh (#62248)
This will allow us to see in the logs how long each step takes
2020-07-24 22:38:17 -07:00
Zachary Anderson ab3a4b0e69
Revert "bump nullsafety deps (#61978)" (#62234)
This reverts commit c46aa360b0.
2020-07-24 16:31:42 -07:00
Alexandre Ardhuin c46aa360b0
bump nullsafety deps (#61978) 2020-07-24 16:17:08 -07:00
Will Larche 7782845edd
[Material] Updated icons and fonts (#61778) 2020-07-24 15:41:13 -07:00
Jonah Williams 6c6c7ba8ec
[flutter_tools] ensure x64 is built if target-platforms is not specified (#62096)
In the add-2-app case, users may not specify the android target platforms field, but this only defaults to arm builds. Add x64 to the default list.

Fixes #62095
2020-07-24 15:33:13 -07:00
Zachary Anderson 5e0ba2290f
Pass --disable-dart-dev in more places (#62217) 2020-07-24 13:37:08 -07:00
Jason Simmons e64fe11542
Manual engine roll to 626244a72c5d53cc6d00c840987f9059faed511a (#62163)
Disabled web_benchmarks_canvaskit in the bot scripts because it was
failing in the Cirrus environment.
2020-07-23 18:11:17 -07:00
Jason Simmons fc72a5f105
Disable DartDev when running device lab tests (#62154)
This is a workaround for https://github.com/flutter/flutter/issues/62139
so that the engine roll pipeline can proceed.
2020-07-23 14:17:27 -07:00
Ming Lyu (CareF) 056e455e94
Add a E2E based performance test case (#61509) 2020-07-23 08:31:04 -07:00
Emmanuel Garcia ddb8e6e3bf
Test dynamic surface switch (#61918) 2020-07-22 20:00:07 -07:00
Chris Yang c5a69b9b8a
Reland "Branch out android platform view perf testing #60238" 2nd time (#61748) 2020-07-22 18:36:11 -07:00
Yazeed Al-Khalaf d41b1fbb50
✒ Spell Check All .md Files Related to Flutter 💙 (#61564)
* 🐛 Fix Spelling Issues in Main README.md

* 🐛 Fix spelling issues in dev README.md

* 🐛 Fix spelling issues in complex_layout README.md

* 🐛 Fix spelling issues in macrobenchmarks README.md

* 🐛 Fix spelling issues in platform_views_layout README.md

* 🐛 Fix spelling issues in test_Apps/stocks README.md

* 🐛 Fix spelling issues in bots README.md

* ✒ Spell Check dev/ci README.md

* ✒ Spell Check dev/ci/docker_linux README.md

* ✒ Spell Check dev/devicelab README.md

* ✒ Spell Check dev/docs README.md

* ✒ Spell Check dev/snippets README.md

* ✒ Spell Check dev/snippets/config/templates README.md

* ✒ Spell Check dev/tools/gen_keycodes README.md

* ✒ Spell Check dev/tools/vitool README.md

* ✒ Spell Check examples/catalog README.md

* ✒ Spell Check examples/flutter_view README.md

* ✒ Spell Check examples/image_list README.md

* ✒ Spell Check examples/layers README.md

* ✒ Spell Check examples/platform_channel README.md

* ✒ Spell Check examples/platform_channel_swift README.md

* ✒ Spell Check examples/platform_view README.md

* ✒ Spell Check packages/_flutter_web_build_script README.md

* ✒ Spell Check packages/flutter_localizations README.md

* ✒ Spell Check packages/flutter_tools README.md

* ✒ Spell Check CODE_OF_CONDUCT.md

* ✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md

* ✒ Spell Check dev/integration_test/android_views README.md

* ✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md

* ✒ Spell Check dev/integration_tests/flutter_gallery README.md

* ✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md

* ✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md

* ✒ Spell Check dev/integration_tests/ios_host_app README.md

* ✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md

* ✒ Spell Check dev/automated_tests/flutter_test README.md

* ✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md

* ✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md

* ✒ Spell Check packages/flutter_tools/doc/daemon.md

* ✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md

* ✒ Minimize line to 80 columns

* ✒ Minimize line to 80 columns

* ✒ Fix Typo

* ✒ Chnaged numbers to 1 for testing purposes

* ✒ Changed numbers to 1 for testing purposes

*  Remove 'a' which is a typo

* ✒ Change a sentence to be better

* ✒ Remove 'a' which is a typo

* ✒ Fix small issue

* ✒ Fix small typo

* ✒ Fix some typos

*  Remove trailing space

*  Remove trailing space

* 🐛 Fix small typo

* ✒ Fix Typo

* 🐛 Fix small bug
2020-07-22 18:23:47 -07:00
Jenn Magder fe781e7e78
Mark flutter_gallery_ios__transition_perf flaky during investigation (#62082) 2020-07-22 18:21:08 -07:00
Ben Konyi adc9dde3ba
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)" (#61993)
This reverts commit f7a1c87ffd.
2020-07-21 16:17:23 -07:00
Ben Konyi f7a1c87ffd
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)
This reverts commit 4867f5931f.
2020-07-21 15:44:38 -07:00
Ming Lyu (CareF) e103ef6e0b
remove frame policy test flaky (#61921) 2020-07-21 07:41:03 -07:00
Darren Austin 753b84894c
Ignore .idea/* files in the analysis bot. (#61215) 2020-07-20 18:51:04 -07:00
Ben Konyi 4867f5931f
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)" (#61909)
This reverts commit 895b7ef6fa.
2020-07-20 16:41:01 -07:00
Ben Konyi 895b7ef6fa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)
This reverts commit 38fe887342.
2020-07-20 16:01:58 -07:00
Christopher Fujino f8a82feb0b
add new docker_attach.sh script and update README (#61363) 2020-07-20 07:21:04 -07:00
Ming Lyu (CareF) 54c9441723
benchmarkLive: a new LiveTestWidgetsFlutterBindingFramePolicy for benchmark on device (#61388)
* add benchmarkLive flag and tests

* update handlePointerEventRecord doc

* using e2e 0.6.1
2020-07-17 18:56:12 -04:00
Ming Lyu (CareF) 7bef51acc9
cleanup macrobenchmark duplicate files (#61621)
* cleanup macrobenchmark duplicate files
2020-07-17 14:34:33 -04:00
godofredoc 87cb964a9d
Use device-finder instead of dev_finder is flutter code. (#61646) 2020-07-17 09:46:03 -07:00
Todd Volkert 1d47859774
Mark smoke_catalina_start_up_ios as flaky (#61737)
https://github.com/flutter/flutter/issues/61736
2020-07-17 09:40:10 -07:00
Todd Volkert b0c146c51b
Mark flutter_gallery_ios32__transition_perf as flaky (#61698)
https://github.com/flutter/flutter/issues/60559
2020-07-16 22:50:12 -07:00
Christopher Fujino df542b6831
update packages and update template (#61678) 2020-07-16 18:32:46 -07:00
Ming Lyu (CareF) 8badf93609
Revert "update packages (#61647)" (#61674)
This reverts commit b7b60a2d2c.
2020-07-16 20:13:18 -04:00
Emmanuel Garcia 1c55445b25
Update dependencies in test (#61675) 2020-07-16 16:50:36 -07:00
Emmanuel Garcia 293a2bf8e8
Android views using hybrid composition e2e driver test (#61507) 2020-07-16 16:19:49 -07:00
Ming Lyu (CareF) b7b60a2d2c
update packages (#61647) 2020-07-16 18:55:42 -04:00
Chris Yang 6a525b9aa5
Revert "Reland "Branch out android platform view perf testing (#60238)" (#61554)" (#61642) 2020-07-16 13:14:52 -07:00
Ben Konyi 38fe887342
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)" (#61641)
This reverts commit 594c3541aa.
2020-07-16 11:43:54 -07:00
Ben Konyi 594c3541aa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)
This reverts commit a1a5a8f635.
2020-07-16 11:38:17 -07:00
Chris Yang 63ceeb8f15
Reland "Branch out android platform view perf testing (#60238)" (#61554) 2020-07-16 11:23:52 -07:00
Danny Tuppeny 9c4a5ef1ed
Remove run_machine_concurrent_hot_reload device lab test (#61573)
This was testing that concurrent reloads were rejected. This is now allowed (as of #55376 (which has non-devicelab integration + unit tests).
2020-07-15 21:41:27 +01:00
Jonah Williams 626886e94a
Do not upload all pub packages into the zip bundle (#61488)
Remove git dependencies from pub-cache

#61487
2020-07-15 11:56:28 -07:00
Jonah Williams cb7770b3a5
[flutter_tools] add support for enable null safety asserts (#61114)
Enable null safety asserts for web debug mode. This induces runtime asserts at the boundaries between null safe and non-null safe libraries. Adds integration test that validates assertion error is thrown.

#61042
2020-07-15 09:54:39 -07:00
Sam Rawlins 54f99d642d
Remove unused optional parameters of private functions. (#60446) 2020-07-15 09:41:02 -07:00
Ben Konyi a1a5a8f635
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61395)" (#61498)
This reverts commit f98184e487.
2020-07-14 16:32:49 -07:00
Ben Konyi f98184e487
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61395)
This reverts commit 5b9c6e2b0e.
2020-07-14 15:57:36 -07:00
Emmanuel Garcia 93cfcc2166
Account for MotionEvent instance mutations (#61417) 2020-07-14 15:56:02 -07:00
Chris Yang 77efc00af0
Revert "Branch out android platform view perf testing (#60238)" (#61482)
This reverts commit 9f4499f431.
2020-07-14 15:10:21 -07:00
Chris Yang 9f4499f431
Branch out android platform view perf testing (#60238) 2020-07-14 13:07:41 -07:00
chunhtai 88a78d660e
reland "Adds semantics information for the popup menu item (#61258)" (#61385) 2020-07-13 16:16:02 -07:00
Emmanuel Garcia 158256b5a7
Migrate Android views e2e to the new embedding (#61205) 2020-07-13 14:06:03 -07:00
xster 8bd2e6585b
Remove v1 Android create templates (#61203) 2020-07-11 12:15:19 -07:00
Tong Wu aa0125387c
[devicelab] This no-op change marks 3 tests to run on LUCI builders. (#61257) 2020-07-10 21:49:40 -07:00
Yegor 744a169387
Add a benchmark that focuses on Paint object performance (#60939)
* Add a benchmark the focuses on Paint object performance
2020-07-10 17:50:24 -07:00
Dan Field 5b9c6e2b0e
Revert "Add support for Dart Development Service (DDS) in Flutter Tools (#59114)" (#61276)
This reverts commit fe7bbf7226.
2020-07-10 15:53:35 -07:00
Ben Konyi fe7bbf7226
Add support for Dart Development Service (DDS) in Flutter Tools (#59114) 2020-07-10 15:35:21 -07:00
Jenn Magder e110ca7209
Case insensitive check flavor names against Xcode schemes (#61140) 2020-07-09 16:56:02 -07:00
Robert Ancell 39f93d18b1
Add additional GTK keycodes for enter and tab (#61141) 2020-07-10 11:35:46 +12:00
Jenn Magder 1e510ff636
Turn on add-to-app iOS platform unit tests (#61007) 2020-07-09 15:52:49 -07:00
Alexandre Ardhuin f32a73711a
use nnbd deps (#61177) 2020-07-09 23:01:22 +02:00
Renzo Olivares d1c4bdb161
Add locales for fil(filipino) and gsw(swiss german) to locale list (#60632) 2020-07-09 13:56:01 -07:00
Shi-Hao Hong 61a04b1551
Fix and address Inconsistencies with Pashto support (#60600)
* Normalize Pashto incomplete translations

* Add comment to README.md about incomplete Pashto support
2020-07-09 15:52:19 +08:00
Kate Lovett f89814b02c
Adding CupertinoApp Sample templates (#60929) 2020-07-08 18:26:04 -07:00
Jonah Williams 80b5ee4e7c
Roll tester (#61128)
landing to unblock meta rollback
2020-07-08 14:39:55 -07:00
Dan Field f0e396710a
Update manifest.yaml (#61062) 2020-07-07 22:22:08 -07:00
Dan Field d45ad057b4
Handle git dependencies, roll packages to get transitive deps of flutter_gallery (#61064) 2020-07-07 22:21:19 -07:00
Dan Field 5969eb60ec
benchmark memory usage for grid view of memory intensive widgets (#61025) 2020-07-07 19:34:03 -07:00
Kaushik Iska ff6b7809bc
Re-land gesture detection for hybrid platform views (#61013) 2020-07-07 17:49:54 -07:00
Dan Field 33aa457604
Roll packages (#61034)
Roll packages, update XML deprecations.
2020-07-07 16:40:33 -07:00
Kaushik Iska 8ed8b06ac5
Revert "Add embedderId to PointerEvent (#60930)" (#61010)
This reverts commit 2ab5099436.
2020-07-07 12:12:20 -07:00
Kaushik Iska 2ab5099436
Add embedderId to PointerEvent (#60930)
This field is used to look-up the event in the platform
that resuted a given `PointerEvent`. This is currently only
used on Android, where the `embedderId` is set to be the
`motionEventId` for a given `MotionEvent`.

Roll engine to d0d6a4c2362d2ed478006bb3b01c34c0e96033b4
2020-07-07 10:59:12 -07:00
Jonah Williams de205ec13c
Roll tester version (#60668)
Includes a fix to a startup race condition and log truncation that should make sure strings aren't cut off
2020-07-06 10:36:05 -07:00
Ming Lyu (CareF) c3217dac7f
await timelinesummary to file (#60774) 2020-07-06 13:19:19 -04:00
Tong Mu 28d2f0106c
Web macrobenchmark: bench_mouse_region_grid_hover now tests hitTestDuration (#60554) 2020-07-05 11:48:03 -07:00
Maurice Parrish dcbc694b58
Have AndroidViewController extend PlatformViewController and add support for hybrid platform views (#60320) 2020-07-05 11:43:02 -07:00
Pierre-Louis 0bc4368233
Typo sweep (#60693) 2020-07-02 13:08:02 -07:00
Christopher Fujino e3ad0345ba
add a timeout to dashing (#60723) 2020-07-01 19:41:41 -07:00
Gary Qian d30c987ceb
Upgrade path_provider_linux (#60652) 2020-06-30 16:50:18 -07:00