Commit graph

13534 commits

Author SHA1 Message Date
Michael Goderbauer e48b7e99cd
More word substiturions (#59497) 2020-06-19 13:43:02 -07:00
Jason Simmons 4173881bbf
Fix the paste button label in the new version of the filtered text pasting test (#59865) 2020-06-19 12:41:29 -07:00
Andrew Chen 2933e895e5
Implement Comparable<TimeOfDay> (#59317) 2020-06-19 12:18:03 -07:00
Christopher Fujino 5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino 0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801.
2020-06-19 10:52:52 -07:00
Ian Hickson 8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Jonah Williams dec7423b44
Revert "Add the ability to ignore lines depending on comments (#58656)" (#59813)
This reverts commit df02518dc9.
2020-06-18 17:15:50 -07:00
Robert Ancell e6de0de8f7
Fix Linux shell window default size (#59630)
The previous call set the minimum size, not just the initial size.
2020-06-19 11:56:01 +12:00
Jenn Magder f41f795640
Clean up PollingDeviceDiscovery dispose (#59709) 2020-06-18 16:38:02 -07:00
Justin McCandless 339f0363a6
Reland modernize selection menu appearance (#59617) 2020-06-18 16:33:03 -07:00
Robert Ancell dd9fd2c851
Use a HeaderBar for Linux applications. (#59714) 2020-06-19 11:30:36 +12:00
Chris Bracken e0f60918d4
Roll the engine from 965fbbe to b5f5e63 (#59804)
This rolls the engine from:
965fbbed1776545ee681cb57f3fb1d0c2000bbcb to
b5f5e6332cb4987e9e38ffaa267733ec0a8705ba. A Dart SDK roll in this range
changed the format of the compileExpression RPC VMService endpoint,
necessitating a tool patch.
2020-06-18 16:12:54 -07:00
James D. Lin bdbe6774a3
[flutter tools] Change the desktop device names and IDs (#58812)
In google3, the Linux device is always available, and it has confused
people who run the Flutter doctor and see
"• Linux • Linux • linux-x64 • Linux" listed.

Rename the Linux device name to "Linux desktop" and the device ID to
be "linux". Make similar changes to the Windows and macOS
devices for consistency.  This is also  consistent with the web
devices.

The device ID change shouldn't be break -d usage since that does a
case-insensitive prefix match.
2020-06-18 15:30:00 -07:00
Jonah Williams e72d26a720
Revert "flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294)" (#59810)
This reverts commit 947b48e062.
2020-06-18 15:19:12 -07:00
Igor Akkerman 947b48e062
flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294) 2020-06-18 14:08:01 -07:00
stuartmorgan e85655c48e
Specify encoding for vswhere output (#59607)
On Windows, Process.run assumes the output uses the system codepage by default. This allows specifying it in our wrapper, and sets the encoding for vswhere to UTF-8 since we're passing a flag that forces it to use UTF-8 output.

Fixes #53515
2020-06-18 14:00:46 -07:00
Michael Goderbauer 32be39bf16
Fix doc for DecoratedBox (#59791) 2020-06-18 13:58:02 -07:00
Jonah Williams 01e09ea8af
[flutter_tools] add missing null-safety flags (#59773)
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety.

Fixes #59769

Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
2020-06-18 12:34:35 -07:00
Darren Austin 06de567811
Dismiss modal routes with a keyboard shortcut (#59310) 2020-06-18 11:53:02 -07:00
Jose Alba c6f6de6d1b
Chips text scaling (#57745) 2020-06-18 11:48:03 -07:00
Jonah Williams 5e77083b8d
[flutter_tools] make parent logger optional (#59786)
The addition of the non-optional parent logger broke the google3 roll. Make it optional so we can roll
2020-06-18 11:44:29 -07:00
Pasindu De Silva df02518dc9
Add the ability to ignore lines depending on comments (#58656)
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments.

// coverage:ignore-line to ignore one line.
// coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive.
// coverage:ignore-file to ignore the whole file.
2020-06-18 10:34:42 -07:00
Jonah Williams 447e3d3f38
[flutter_tools] remove globals from compilers (#59184)
Refactors KernelCompiler and ResidentCompiler to no longer use globals (except as a fallback for g3 migration). Improves the compilation error when running flutter test on a package without a flutter_test dependency.

Updates machine mode to output trace text to stderr
2020-06-18 10:33:17 -07:00
Jonah Williams e1f4cfb4f4
[flutter_tools] add toggle b and service extension to change platform brightness (#59571)
A frequent request from the last Flutter developer survey was for an easier method of testing light/dark mode changes. Currently, a user needs to manually change the theme settings or adjust phone settings to see the difference. Instead we should add a toggle from the CLI, and eventually devtools/Intellij/Vscode that allows developers to override the current setting.

Fixes #59495

Adds flutter.ext.brightnessOverride service protocol which either queries the current platform brightness, or overrides it to a new value. This accepts either Brightness.light or Brightness.dark as a value.

Adds a CLI toggle b which allows the setting to be toggled manually.

Requires an update to the MediaQuery, to conditionally use a debug override when not in release mode
2020-06-18 10:32:43 -07:00
Chris Bracken f39ab52221
Revert "Manual engine roll to update format of compileExpression RPC response (#59717)" (#59774)
Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c72c2.
2020-06-18 09:52:44 -07:00
Ben Konyi c7a37c72c2
Manual engine roll to update format of compileExpression RPC response (#59717) 2020-06-18 09:18:03 -07:00
chunhtai 747fe345f1
fix the widget span layout when text scale factor != 1 (#59711) 2020-06-18 08:28:03 -07:00
Jonah Williams 719ea5a8c0
[flutter_tools] make expando on vm service null safe to handle web stuff (#59624) 2020-06-18 08:18:04 -07:00
Per Classon dbc6dca5d0
Set upper limit on text scaling for AppBar.title (#58094) 2020-06-18 08:13:02 -07:00
Ming Lyu (CareF) 9c3f0faa6d
Add comments to flutter_driver for timeline class (#58823)
* Add comments to flutter_driver for timeline class

Mostly about explanation for the json items from
timeline.dart and timeline_summary.dart.
2020-06-17 18:47:54 -04:00
liyuqian 42e02d60d3
Reland non-breaking "Add clipBehavior to widgets with clipRect #55977" (#59364)
* Revert "Revert "Add clipBehavior to widgets with clipRect (#55977)" (#58344)"

This reverts commit 1d395c5e18.

* Add missed Overflow
2020-06-17 10:57:40 -07:00
Jonah Williams 802c4b0f12
[flutter_tools] handle NPE in list views method(#59626)
Fixes #59608

The VmService getter can be null, handle that in the listViews method. NNBD when
2020-06-17 10:53:54 -07:00
Jenn Magder b8c64d7014
Don't crash when pubspec isn't a map (#59632) 2020-06-17 10:33:02 -07:00
Alexandre Ardhuin 1fe677a3af
update _isolates_io.dart for better nnbd migration (#59666) 2020-06-17 18:58:21 +02:00
renyou a99d146ba9
Revert "Characters Package (#53381)" (#59677)
This reverts commit e0ed12c73a.
2020-06-17 08:39:34 -07:00
Ayush Bherwani 37cb7b7b48
[ExpansionPanelList] adds dividerColor property (#59641) 2020-06-17 01:58:01 -07:00
Alex Vincent fe15d1e793
[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686) 2020-06-16 23:58:01 -07:00
Justin McCandless e0ed12c73a
Characters Package (#53381) 2020-06-16 16:53:04 -07:00
Greg Spencer c5527dc8c4
Remove dependency on package:collection by moving mergeSort into foundation/collections.dart (#59521)
This removes a dependency from Flutter (package:collection) by copying the implementation of mergeSort into Flutter's foundation/collections.dart.

Also, removed a reference to UnmodifiableSetView from the shortcuts code by just returning a copy instead.
2020-06-16 14:41:05 -07:00
Per Classon 56a7dacd46
[flutter_tools] For l10n with deferred loading, use loadLibrary for non-web too (#59539)
After Dart VM change we are now required to use loadLibrary on an import whenever it is imported as deferred.

See: https://dart-review.googlesource.com/c/sdk/+/149613
2020-06-16 13:36:28 -07:00
stuartmorgan 61c198e766
Switch Linux to the GTK embedding (#59287)
Updates the tooling to use the GTK embedding, rather than the GLFW embedding:
- Adds new requirements to `doctor`
- Updates the app and plugin templates to make GTK-based runners and plugins
- Stops downloading and installing the GLFW artifacts

Final part of #54860, other than cleanup.
2020-06-16 13:31:24 -07:00
Kenzie Schmoll 5b147520bf
Cancel tooltip show timer when state is deactivated (#57244) 2020-06-16 13:14:43 -07:00
Jonah Williams 15154b115f
[flutter_tools] deprecate build aot (#59487)
This command was previously used by the re-entrant build scripts in xcode_backend.sh and build.gradle. These have since been refactored to use flutter assemble.

Deprecation the command in preparation for removal in a future release of flutter. The only current use is a test on HHH
2020-06-16 13:00:11 -07:00
MH Johnson 7042be8816
Re-land "[Widgets] Add DefaultTextHeightBehavior inherited widget." (#59350) 2020-06-16 12:50:02 -07:00
Diego Henrique Domingues 95ee633f66
[flutter_tools] fix the event attribute used to skip waiting (#59568) 2020-06-16 11:15:02 -07:00
renyou deec88bb97
Revert "Build routes even less. (#58202)" (#59503) 2020-06-16 10:40:04 -07:00
Ayush Bherwani dde1249937
[MergeableMaterial] adds dividerColor property (#59481) 2020-06-16 10:35:03 -07:00
Justin McCandless b429ec1e8f
InteractiveViewer mouse scale bug (#59478) 2020-06-16 10:30:06 -07:00
Jenn Magder 5a4bb5050d
Remove last references to ideviceinstaller (#59508) 2020-06-16 10:25:10 -07:00
Michael Joseph Rosenthal 42666df9b7
Add link to ListTile replacement guide (#59474) 2020-06-16 10:25:06 -07:00
Gary Qian 1b62b805ca
Handle backspace edgecase in trailing whitespace formatter. (#59379) 2020-06-16 10:20:04 -07:00
Christopher Fujino 807b60250a
[flutter_tools] Update roll_dev.dart (#59215) 2020-06-16 09:30:04 -07:00
Darren Austin e66a5cf55d
Removed an unused static local key from ScrollAction. (#59436) 2020-06-16 09:25:10 -07:00
Greg Spencer 2163731c99
Remove DiagnosticableMixin in favor of Diagnosticable (#58635) 2020-06-16 09:25:04 -07:00
Gary Qian 73560d4bff
Docs 'that that' fix (#50237) 2020-06-16 09:20:07 -07:00
Gary Qian a41855fa95
Docs 'that that' fix (#50236) 2020-06-16 09:20:03 -07:00
Jonah Williams 958f7c5b55
[flutter_tools] ensure generated entrypoint matches test and web entrypoint language version (#59291)
Ensure that the language version of the test/web generated entrypoint matches the language version of the test file to run, or the overall package language version if no annotation is provided.
2020-06-16 09:17:12 -07:00
Michael Goderbauer 584fd5f913
Word substitutions (#59484)
* Word substitutions

* ++
2020-06-16 09:15:43 -07:00
Michael Goderbauer 1bb40aee1b
Replace collection's SetEquals with flutter's own (#59514) 2020-06-16 09:15:14 -07:00
Zachary Anderson f8a4008e41
Revert "Modernize selection menu appearance (#59115)" (#59561)
This reverts commit b3c237ce54.
2020-06-16 08:41:22 -07:00
Jenn Magder e114ab99bb
Remove flutter_goldens_client package dependency from tool (#59365) 2020-06-15 09:55:02 -07:00
Justin McCandless 77859c682e
Characters package (#59267) 2020-06-15 09:50:02 -07:00
Justin McCandless b2a2cb7e03
Add instructions for updating a localized string (#59273)
* Add instructions for updating a localized string

* gem_missing_localizations does nothing when I test this out, seems to not be required

* Explain generation of new locale strings
2020-06-15 09:45:25 -07:00
Jason Simmons 959f5dca83
Revert "Prevent WhitelistingTextInputFormatter to return a empty string if the current value does not satisfy the formatter (#57264)" (#59221) 2020-06-15 09:45:04 -07:00
Ian Hickson f7f019aa94
More useful error messages when you use Stack without a textDirection. (#59360) 2020-06-15 09:40:10 -07:00
Justin McCandless b3c237ce54
Modernize selection menu appearance (#59115) 2020-06-15 09:40:04 -07:00
duzenko c79de78237
LG debugging/logcat fixed (#58670) 2020-06-15 09:35:07 -07:00
James D. Lin c21b3233e4
[flutter tools] Don't return success if we trigger runZoned's error callback (#58474) 2020-06-15 09:35:04 -07:00
Anis Alibegić d9bf8794c2
Add shadowColor to AppBar and AppBarTheme (#58708) 2020-06-15 09:30:08 -07:00
Ian Hickson 6202476691
Remove license statements in template files. (#57268) 2020-06-15 09:30:05 -07:00
stuartmorgan 401690a64f
CMake fix for projects without plugins (#59343)
This install step fails if the list is empty, which is the case for projects without plugins (or Dart-only plugins, so flutter/plugins presubmits are currently broken).
2020-06-12 19:45:48 -07:00
Chase Latta d64884dedf
Remove Fuchsia BUILD.gn files (#59285) 2020-06-12 12:50:03 -07:00
Darren Austin 913e21e4f0
First pass at keyboard navigation for the Material Date Picker (#59279) 2020-06-12 12:45:03 -07:00
Jenn Magder 0093c6a4c6
Add Podfile migration warning to support federated plugins (#59201) 2020-06-12 12:44:14 -07:00
Kate Lovett 97dc7eee57
Step 3 of 3: Remove opt-in for debugCheckHasMaterialLocalizations assertion on TextField (#58831) 2020-06-12 12:40:03 -07:00
Todd Volkert ff7538f7b5
Add support for horizontal and vertical double-arrow system cursors (#59342) 2020-06-12 12:35:08 -07:00
Juyeong Lee d350f4194e
fix typo in bottom navigation bar docs (#58780) 2020-06-12 12:35:03 -07:00
Ian Hickson 38c33d9c48
Build routes even less. (#58202) 2020-06-12 12:30:03 -07:00
Jenn Magder eee3912f04
Revert "[Widgets] Add DefaultTextHeightBehavior inherited widget. (#59196)" (#59347)
This reverts commit 3efc517ab5.
2020-06-12 10:33:24 -07:00
Danny Tuppeny 96711b00ce
Don't crash on requests for invalid package URLs (#59250) 2020-06-12 09:25:04 -07:00
MH Johnson 3efc517ab5
[Widgets] Add DefaultTextHeightBehavior inherited widget. (#59196) 2020-06-12 09:20:04 -07:00
Kate Lovett 64f42c0ea8
Support floating the header slivers of a NestedScrollView (#59187) 2020-06-12 09:15:02 -07:00
Jonah Williams bf94520644
[versions] Update all the versions (#59283) 2020-06-11 16:40:22 -07:00
Alexandre Ardhuin 65ef1f94bb
test flutter framework with null-safety (#59280) 2020-06-11 16:40:02 -07:00
Marcus Tomlinson 1fe0f22645
Remove use of BundleUtilities in Linux build (#59080)
* Explicitly install the Flutter library

* Publish ${FLUTTER_LIBRARY} to parent scope

* Bundle plugin libraries

* Bundle <plugin_name>_bundled_libraries too

* BUNDLED_LIBRARIES -> PLUGIN_BUNDLED_LIBRARIES

* Update Linux plugin test

* Address review comments
2020-06-11 22:00:28 +01:00
Jenn Magder 3744b82d8c
Support .flutter-plugins-dependencies (#59209) 2020-06-11 13:25:01 -07:00
Ayush Bherwani 802ba9ac90
adds interactive example (#59251) 2020-06-11 11:40:03 -07:00
Jenn Magder 222c2cb0cc
Deprecate make-host-app-editable (#59217) 2020-06-11 11:37:15 -07:00
zmtzawqlp 3fc364cfbb
add missing arguments for all constructors of ListView and GridView (#58746) 2020-06-11 11:35:02 -07:00
Gary Roumanis d25b9c80a4
Do not depend on embedded (#59210) 2020-06-11 09:31:05 -07:00
Wyte Krongapiradee 3be48f34f2
[Flutter Driver] Update the comments regarding the default timeout of WaitFor and WaitForAbsent commands (#58771) 2020-06-11 09:30:02 -07:00
Alexandre Ardhuin 4d7525f05c
Opt out nnbd in packages/flutter (#59186)
* add language version 2.8 in packages/flutter

* enable non-nullable analyzer flag
2020-06-11 14:11:30 +02:00
Darren Austin 012cee2731
Typo fixing sweep through packages/flutter. (#59219) 2020-06-11 05:10:01 -07:00
Gabriel Terwesten daddc914c7
Fix docs for Focus.onKey event propagation (#59096) 2020-06-10 16:35:01 -07:00
Hansol Lee e13b44d978
Add sample code to PositionedTransition (#59156) 2020-06-10 14:20:35 -07:00
Per Classon 8cf15ee2aa
Rebuild SliverAppBar when forceElevated changes (#59162) 2020-06-10 14:15:02 -07:00
Jenn Magder 319a61fd81
Move iOS Podfile logic into tool (#59044) 2020-06-10 14:12:48 -07:00
Jenn Magder 75fd73d818
Revert "[flutter_tools] inject output preferences at the top level (#58875)" (#59197)
This reverts commit dca6320fe4.
2020-06-10 13:49:35 -07:00
WJQ 618108bfca
Fix typo in scroll_aware_image_provider.dart (#59128) 2020-06-10 12:30:01 -07:00
Darren Austin cb8562e163
Make the InkResponse's focus highlight honor the radius parameter (#59117) 2020-06-10 12:25:04 -07:00