Commit graph

5920 commits

Author SHA1 Message Date
Adam Barth b2576dc000 Add coveralls token 2016-07-08 14:18:21 -07:00
Adam Barth 56aa920858 Improve how ImageIcon does opacity (#4847)
Putting the opacity in the color is much faster than using an opacity
widget because the opacity widget creates an offscreen buffer.

Fixes #4651
2016-07-08 13:39:54 -07:00
Adam Barth dda744eccc Fix attaching a dirty, detached SemanticsNode (#4855)
Previously we triggered an assert.

Fixes #4850
2016-07-08 13:28:42 -07:00
Adam Barth c9248cd4a6 Tooltip can disappear too quickly (#4851)
We were stacking up two dismiss timers. Now we don't start a new timer
if we've already got one. Also, fix an animation leak caught by the
test.

Fixes #4640
2016-07-08 09:52:09 -07:00
Adam Barth fc711a10cd Custom switch images are nutty (#4852)
Rather than requiring the developer to specify a full Decoration, we now
just take an ImageProvider for the thumb image. Also, fix
ImageFit.scaleDown to actually work.

Fixes #4571
Fixes #4673
2016-07-08 09:51:51 -07:00
Adam Barth d7a4a54b36 TwoLevelSublist should have an onOpenChanged callback (#4848)
Also, fix an animation leak found by the test.

Fixes #4619
2016-07-08 08:07:05 -07:00
Adam Barth 9e111d1872 Cleanup axis-aligned padding (#4845)
We now have an EdgeInsets.along function that projects the padding onto the
given Axis rather than repeating this function in several places.
2016-07-07 16:44:24 -07:00
Hans Muller 0f15263cea RefreshIndicator dismiss transition, remain visible during refresh, etc (#4844) 2016-07-07 16:30:10 -07:00
Adam Barth a33fc49659 Remove dangling reference to ViewController (#4841)
We want to use the FlutterViewController in this new project template.

Fixes #4840
2016-07-07 10:45:58 -07:00
Adam Barth e8a638ecf9 Minor RenderBox improvements (#4837)
* Make the size setter on RenderBox protected to avoid setting from
   outside the class.
 * Make normalize on BoxConstraints always return an object that
   isNormalized.
2016-07-07 07:49:35 -07:00
Adam Barth 04dca44f27 Be consistent about method versus function (#4828)
Fixes #4761
2016-07-06 18:45:42 -07:00
Phil Quitslund ea24d14c0c Merge pull request #4823 from pq/dart_1.18.0-dev.4.0
Bump Dart SDK to `1.18.0-dev.4.0`.
2016-07-06 14:54:52 -07:00
pq cb4f01ae3d Bump Dart SDK to 1.18.0-dev.4.0.
Last dev push for `1.18`.
2016-07-06 14:43:40 -07:00
Adam Barth 151750baa8 Update the ios projects for examples to HelloServices model (#4822)
We now use a different approach for ios projects where the developer controls
the Xcode project file. This patch removes the old ".generated" approach in
favor of the new approach.
2016-07-06 14:13:21 -07:00
Adam Barth 8d56fae557 Finish integrating HelloServices model on iOS (#4820)
This patch changes the default `flutter create` command to generate a
HelloServices-style app on iOS. As a consequence, the Atom integration now
fully works with HelloServices.
2016-07-06 13:13:28 -07:00
Eric Seidel 5dae820c1b Use https instead of http when downloading Dart. (#4821)
This came up in security review.

@abarth
2016-07-06 13:10:56 -07:00
Devon Carew ec752d813d send ext.flutter.debugDumpApp; ext.flutter.reassemble (#4810)
* send ext.flutter.debugDumpApp; ext.flutter.reassemble

* expose debugDumpRenderTree
2016-07-04 11:21:56 -07:00
Adam Barth 3cbb20d176 Just use SemanticAnnotator instead of Iterable<SemanticAnnotator> (#4813) 2016-07-03 21:16:21 -07:00
Adam Barth 839def55ba Teach the system to shutdown semantics (#4811)
We now stop updating semantics when there are no remaining clients.
2016-07-01 17:57:10 -07:00
Jason Simmons cbf7d98874 Allow a host message handler to return a null result (#4812)
Host apps will return null if there is no matching handler for a message name
2016-07-01 15:50:29 -07:00
Adam Barth 5ed8f1a1fd Add semantics for Sliders (#4808)
Also, make SemanticsOwner into a real class and use it instead of a static in
several places.
2016-07-01 13:38:24 -07:00
Devon Carew f0671edfdb workaround adb logcat -T (#4798) 2016-07-01 10:19:28 -07:00
Adam Barth 8c535ad7d7 Update use of @protected (#4805)
Now that protected can be accessed from inside the same library, we can
use protected in a number of new places and we can remove some
trampolines we were using to work around its previous semantics.
2016-07-01 10:06:40 -07:00
Adam Barth e0f37027ab Add some tests for these tweens (#4804) 2016-07-01 09:46:37 -07:00
Devon Carew 8cf2c1703e remove the flutter_dev env var (#4806) 2016-06-30 21:39:40 -07:00
Adam Barth 95a26ab0e8 Switch to SemanticAction (#4791)
This patch updates the framework to use the new SemanticAction in
semantics.mojom.
2016-06-30 17:38:05 -07:00
Adam Barth 639532bd51 Don't pick up Android SDK from local engine (#4801)
It can cause trouble if the user has a newer Android SDK installed normally.
Instead, just use the normal Android SDK.
2016-06-30 15:47:56 -07:00
Hans Muller 107cbd3185 Refresh Indicator fine tuning (#4800) 2016-06-30 15:36:06 -07:00
Matt Perry 6298a1aeb1 Fix a bug where ScrollableGrid/ScrollableList would flicker when (#4794)
navigating away.

Details are in the bug, but when we navigate away, the overscroll
indicator around the Scrollable would change the widget hierarchy. This
would trigger the Scrollable to rebuild, which would cause its
scrollOffset to be clamped to 0 for a frame.

BUG=https://github.com/flutter/flutter/issues/4597
2016-06-30 15:43:47 -04:00
Todd Volkert f410ca80b7 Include target in revision string, since it affects the xcode config (#4795) 2016-06-30 11:33:36 -07:00
Phil Quitslund 14c5321129 Merge pull request #4793 from pq/analyzer_0.27.4-alpha.15
Update to latest analyzer (w/ cleanup).
2016-06-30 11:05:31 -07:00
pq ec256c5ee4 Removed trampoline. 2016-06-30 10:50:38 -07:00
pq a417786d77 Update to latest analyzer (w/ cleanup).
Bye-bye `@protected `trampolines! :)
2016-06-30 10:39:45 -07:00
Phil Quitslund fa7f271448 Merge pull request #4790 from pq/1.18.0-dev.3.0
Update to latest Dart SDK (1.18.0-dev.3.0).
2016-06-30 10:08:09 -07:00
Hans Muller d9b9983e1a Refresh indicator (#4788) 2016-06-30 10:07:28 -07:00
pq a185d3749f Update to latest Dart SDK (1.18.0-dev.3.0). 2016-06-30 07:43:01 -07:00
Adam Barth 63eedb7677 Semantics debugger shouldn't crash when reparenting nodes (#4782)
Our previous approach to detecting when we needed to remove semantics nodes
didn't account for reparenting.
2016-06-28 14:44:02 -07:00
Phil Quitslund 05bcbb6cd0 Merge pull request #4785 from pq/empty_statement_cleanup
Cleanup empty statements.
2016-06-28 14:02:05 -07:00
pq 543f705adb Cleanup empty statements.
The new `empty_statements` lint (in the next DEV roll), flags these empty statements.  Harmless, except the one in `basic.dart` that fixes a real-life bug. :)
2016-06-28 13:42:22 -07:00
Todd Volkert fbab25be59 Remove errant xcuserdata file from project templates (#4784) 2016-06-28 13:39:07 -07:00
Chinmay Garde 1a5ca2f675 Fix failing tooltip_test.dart by avoiding floating point comparisons. (#4781) 2016-06-28 12:49:11 -07:00
Chinmay Garde b8bcd62e54 Remove counters used to tag variables and symbols in the solver for debugging purposes. (#4780) 2016-06-28 11:58:24 -07:00
Hans Muller 77cd8ee40e Reproduce the Shrine home page portrait grid layout (#4779) 2016-06-28 11:05:18 -07:00
Adam Barth 41d6303570 Improve test coverage for material.dart (#4776)
Previously these widget had zero test coverage. Also, improve the
coverage tooling Mac.
2016-06-28 08:48:48 -07:00
Adam Barth 14f42a6a48 Improve test coverage in rendering.dart (#4775) 2016-06-27 17:38:53 -07:00
Adam Barth bb0c41f2a6 Improve test coverage for gestures.dart (#4773)
This patch adds tests for some code paths we weren't hitting before and removes
some dead code that couldn't be tested because it was unreachable.
2016-06-27 14:42:41 -07:00
Adam Barth 2898768dde Add some missing docs (#4772)
These docs complete the dartdocs for their respective libraries.
2016-06-27 14:42:25 -07:00
Adam Barth 2af668f832 Change how navigator prevents redundant operations (#4769)
* Change how navigator prevents redundant operations

Instead of requiring transactions, we now cancel all active pointers that are
interacting with the navigator and absorb future pointers until we get a chance
to build. This approach isn't perfect (e.g., events that trigger off the
cancelled pointers could still interact with the navigator), but it should be
better than the current transaction-based approach.

Fixes #4716

* Remove openTransaction

* test

* fixup
2016-06-27 13:07:47 -07:00
Hans Muller 08bf1b6bce Scrollable dropdown, dropdown underline cosmetics (#4766) 2016-06-27 10:28:20 -07:00
Adam Barth 5fc04dab74 Document State (#4762)
This patch documents State in detail because it's a very common class
for developers to work with and it has a number of subtles.
2016-06-26 16:22:20 -07:00