Kate Lovett
ed8eaf1b84
Migrate the flutter/flutter wiki to docs/unsorted_wiki ( #148562 )
...
Part of https://github.com/flutter/flutter/issues/145009
This is part one of the wiki migration.
This moves all wiki pages wholesale into the new docs directory with no changes.
Follow up PRs will sort them, updating breadcrumbs and links.
2024-05-17 22:12:18 +00:00
Zachary Anderson
597462a3c4
Revert "if chains → switch expressions" ( #148556 )
...
Reverts flutter/flutter#147793
Introduced https://github.com/flutter/flutter/issues/148548 .
2024-05-17 10:27:02 -07:00
Valentin Vignal
1732994167
Add test for material_banner.0.dart and material_banner.1.dart ( #148452 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds test for
- `examples/api/lib/material/banner/material_banner.0.dart`
- `examples/api/lib/material/banner/material_banner.2.dart`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-16 17:44:37 -07:00
Nate
fa9992eff6
switch statement cleanup (#148382 )
...
This PR is step 12 in the journey to solve issue #136139 and make the
entire Flutter repo more readable.
Most of it involves implementing switch expressions, and there's also a
few other random things that I wanted to clean up a bit.
2024-05-16 17:16:06 -07:00
Michael Goderbauer
c4ad1dc1e9
const vs. non-const widget build benchmark ( #148261 )
...
This benchmark illustrates the impact that const'ness has on widget build times by building a widget tree with all const-widgets and then building the same widget tree without any const'ness. Local testing with this benchmark running on a Moto G4 shows that const'ness is 13-16% faster.
I'd like to check this benchmark in because the question of how important widget const'ness is comes up every so often. With this benchmark we have up-to-date data to point people to.
2024-05-16 23:23:14 +00:00
Valentin Vignal
ffae7c60c2
Add clipBehavior to DrawerThemeData ( #148061 )
...
Fixes https://github.com/flutter/flutter/issues/148060
2024-05-15 18:37:07 +00:00
derdilla
4ecc1b092b
test material text field example ( #147864 )
...
Adds simple tests to the last two [TextField](https://api.flutter.dev/flutter/material/TextField-class.html ) examples as part of fixing #130459 .
2024-05-14 20:46:46 +00:00
Daco Harkes
3391ddf55d
Try fix module test ( #147934 )
...
Issue
* https://github.com/flutter/flutter/issues/112033
Suggested in https://github.com/flutter/flutter/issues/112033#issuecomment-1652268832 , and makes the test pass for me locally on the M1 Macbook.
2024-05-13 21:30:01 +00:00
derdilla
708fe97f9e
test sliver fill remaining examples ( #148041 )
...
Par of #130459 . Adds tests all `SliverFillRemaining` examples.
2024-05-13 15:30:49 +00:00
Valentin Vignal
4af4cb89d5
Add test for scaffold.1.dart ( #147966 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds test for `examples/api/lib/material/scaffold/scaffold.1.dart`
2024-05-11 00:37:04 +00:00
flutter-pub-roller-bot
3c26c56ffa
Roll pub packages ( #148148 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-10 22:24:27 +00:00
Valentin Vignal
8e53ad917c
Add clipBehavior to DialogTheme ( #147635 )
...
Fixes https://github.com/flutter/flutter/issues/147634
2024-05-10 22:08:59 +00:00
Kostia Sokolovskyi
65e8c615b4
Add test for animated_size.0.dart API example. ( #147828 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Updates `examples/api/lib/widgets/animated_size/animated_size.0.dart` API example by using `SizedBox` to size the surrounding of the `FlutterLogo` while setting the constant `FlutterLogo` size. This was done because `FlutterLogo` already has size animation under the hood, and the main goal of this example is to show `AnimatedSize` usage
- Adds test for `examples/api/lib/widgets/animated_size/animated_size.0.dart`
2024-05-10 21:55:51 +00:00
Kostia Sokolovskyi
da9712f76f
Add test for draggable.0.dart API example. ( #147941 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds test for `examples/api/lib/widgets/drag_target/draggable.0.dart`
2024-05-10 21:54:16 +00:00
Kostia Sokolovskyi
456d176a70
Add tests for stream_builder.0.dart API example. ( #147832 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Updates `examples/api/lib/widgets/async/stream_builder.0.dart`
- Adds test for `examples/api/lib/widgets/async/stream_builder.0.dart`
2024-05-10 21:48:35 +00:00
Nate
4734d80f22
if chains → switch expressions (#147793 )
...
Previous "if-chains" pull requests:
- https://github.com/flutter/flutter/pull/144905
- https://github.com/flutter/flutter/pull/144977
- https://github.com/flutter/flutter/pull/145194
- https://github.com/flutter/flutter/pull/146293
- https://github.com/flutter/flutter/pull/147472
<br>
I think this one should be enough to wrap things up!
fixes https://github.com/flutter/flutter/issues/144903
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2024-05-10 00:55:48 -06:00
Christopher Fujino
730d6d44b7
Don't pin package:macros ( #148087 )
...
Full context https://github.com/flutter/flutter/issues/148004
TL;DR
1. Because `package:macros` depends on `package:_macros` via [a Dart SDK
dependency](https://github.com/dart-lang/sdk/blob/main/pkg/macros/pubspec.yaml#L13 );
and
2. `package:macros` exactly pins `package:_macros`; and
3. Each new version of `package:macros` will increment its exact pin of
`package:_macros`
([comment](https://github.com/flutter/flutter/issues/148004#issuecomment-2103099893 ));
and
4. The [flutter/flutter](https://github.com/flutter/flutter ) repository
exactly pins the Dart SDK (via its exact pin on the
[flutter/engine](https://github.com/flutter/engine ) repository
Therefore, the [flutter/flutter](https://github.com/flutter/flutter )
repository effectively pins both `package:macros` and `package:_macros`
already (as in, there exists only a single version of each that pub will
successfully be able to solve within the context of a particular Flutter
SDK).
Therefore, it is safe for
[flutter/flutter](https://github.com/flutter/flutter ) repository to
*not* pin `package:macros`, which will allow engine -> framework rolls
that contain a new Dart SDK that contains a new `package:_macros`
version to land automatically, provided all tests pass.
2024-05-09 16:28:49 -07:00
flutter-pub-roller-bot
076e701f46
Roll pub packages ( #148011 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-09 04:45:28 +00:00
flutter-pub-roller-bot
b7a9e60850
Roll pub packages ( #147995 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-08 20:28:00 +00:00
Sam Rawlins
39d8492fb8
Tweak to fix context.mounted in dialog_demo ( #147998 )
...
Prepares for a fix to the `use_build_context_synchronously` lint (https://dart-review.googlesource.com/c/sdk/+/365541 ) that will complain about these unsafe usages.
The lint rule cannot tell that the `mounted` field is shorthand for `context.mounted`.
2024-05-08 19:56:22 +00:00
Danny Tuppeny
cea1d6f055
Unpin DDS and roll pub packages ( #147925 )
...
DDS was temporarily pinned to 4.1.0 because 4.2.0 triggered some test
failures (see https://github.com/flutter/flutter/pull/147250 ). Those
failures should be fixed by vm_service 14.2.2, so this unpins DDS and
rolls both of these packages (along with devtools_shared, which is a DDS
dependency).
(If the bot updates vm_service before this is done, I can rebase over
that will reduce the size of this PR to just a few files)
2024-05-08 10:35:28 +01:00
Michael Goderbauer
8796562d0a
Properly guard context access in then clauses ( #147935 )
...
Prepares for a fix to the `use_build_context_synchronously` lint (https://dart-review.googlesource.com/c/sdk/+/365541 ) that will complain about these unsafe usages.
2024-05-07 20:50:46 +00:00
derdilla
a7bdf369e5
improve focus example ( #147464 )
...
Part of #130459 . Adds a test to the [second focus example](https://api.flutter.dev/flutter/widgets/Focus-class.html#widgets.Focus.2 ) and makes the function of the example more clear.
2024-05-07 20:07:49 +00:00
Gray Mackall
d04edd1d7f
Add kotlinOptions jvmTarget to templates ( #147326 )
...
Adds jvmTarget to gradle templates.
Fixes https://github.com/flutter/flutter/issues/147185 .
Interestingly, we already had this in many of our examples/tests, see search results here https://github.com/search?q=repo%3Aflutter%2Fflutter%20jvmTarget&type=code .
2024-05-07 17:32:10 +00:00
chunhtai
007faa980d
Reapply new PopScope API ( #147607 )
...
same as previous but with soft transition on modalroute
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-07 09:04:49 -07:00
Kostia Sokolovskyi
7920a52dd5
Add tests for callback_shortcuts.0.dart API example. ( #147536 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Corrects the name for `examples/api/test/widgets/shortcuts/callback_shortcuts.0_test.dart` test file
- Update tests for `examples/api/lib/widgets/shortcuts/callback_shortcuts.0.dart`
2024-05-07 15:21:46 +00:00
Kostia Sokolovskyi
28e65b7811
Add tests for shortcuts.dart API examples. ( #147433 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/widgets/shortcuts/shortcuts.0.dart`
- Adds tests for `examples/api/lib/widgets/shortcuts/shortcuts.1.dart`
2024-05-07 11:25:12 +00:00
osama
774ef8acf4
Added missing tests for ButtonStyle example ( #147457 )
...
Added missing tests for ButtonStyle example. Issue #130459
2024-05-07 09:00:27 +00:00
Greg Spencer
8a7c18c12a
Fix document generation, eliminate template support from snippets tool. ( #147893 )
...
## Description
This fixes the API doc generation that I broke when I moved the snippets tool into the framework.
It removes the last of the template support (properly this time), and makes sure all of the tests pass.
## Related Issues
- https://github.com/flutter/flutter/issues/144408
- https://github.com/flutter/flutter/issues/147609
- https://github.com/flutter/flutter/pull/147645
## Tests
- Fixed tests, including smoke test of doc generation.
2024-05-07 02:13:54 +00:00
derdilla
5ecd4ea83d
test focus example 0 ( #147564 )
...
Part of #130459 . Adds tests for [Focus example 0](https://api.flutter.dev/flutter/widgets/Focus-class.html#widgets.Focus.1 ).
2024-05-07 01:03:09 +00:00
flutter-pub-roller-bot
c0ed9f6ff4
Roll pub packages ( #147896 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-06 23:36:21 +00:00
flutter-pub-roller-bot
d4b2e5d705
Roll pub packages ( #147891 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-06 22:39:58 +00:00
Jonah Williams
5230ec5ba4
[new gallery] Reisze gallery images ( #147882 )
...
Some cause of jank on both Skia and Impeller are these massive images. We should just resize them so that the noise is reduced and we can see other performance issues.
Fixes https://github.com/flutter/flutter/issues/147797
Tested: this is a test!
2024-05-06 19:20:32 +00:00
Greg Spencer
183bc15816
Move snippets package back into flutter repo ( #147690 )
...
## Description
This moves the snippets package back into the Flutter repo so that API documentation generation can happen without the use of `dart pub global run` because `pub run` doesn't handle concurrency well.
The change modifies the dartdoc building process to include building an executable from the snippets tool and installing that in the cache directory for use during docs generation.
The snippets tool will reside in dev/snippets, where it originally resided before being moved to https://github.com/flutter/assets-for-api-docs .
The snippets code itself is unchanged from the code that is in https://github.com/flutter/assets-for-api-docs/packages/snippets .
## Related Issues
- https://github.com/flutter/flutter/issues/144408
- https://github.com/flutter/flutter/issues/147609
- https://github.com/flutter/flutter/pull/147645
## Tests
- Added snippets tests to the overall testing build.
2024-05-03 06:09:03 +00:00
Yegor
d5836ee60c
[web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes ( #147736 )
...
- Skip debug mode CanvasKit e2e tests due to flakiness.
- Unskip all other modes (`text_editing_integration` was over-skipped).
Fixes https://github.com/flutter/flutter/issues/146189
2024-05-02 22:23:30 +00:00
Yegor
1d0e798c21
[web] increase chromedriver logging level ( #147687 )
...
This can help debugging https://github.com/flutter/flutter/issues/146189
2024-05-02 10:16:37 -07:00
Greg Spencer
2e78ed0ff9
Allow explicit exclusion of packages from pinned packages in flutter update-packages --force-update ( #147679 )
...
## Description
This introduces a list of packages that we will explicitly not pin. It is to be used for things where the package isn't actually published, but is a transitive dependency of another package included in the SDK. This happens with the `macros` package, for instance, which depends on the private, unpublished, `_macros` package where the SDK does some tricky things to depend on it (it depends on "any", but ships it as part of the SDK).
Also ran `flutter update-packages --force-update` to update all of the pubspec files.
## Related Issues
- Fixes #147656
## Tests
- Added a test that makes sure that explicitly unpinned packages don't show up in the pinned list.
2024-05-02 01:16:54 +00:00
Yegor
f256f68831
[web] remove platform_messages_integration test ( #147654 )
...
This functionality is already fully covered by https://github.com/flutter/engine/blob/main/lib/web_ui/test/engine/platform_views/message_handler_test.dart
This might help with https://github.com/flutter/flutter/issues/146189 a little.
2024-05-01 21:12:01 +00:00
Yegor
ba6302e2d5
add lang attribute to the a11y_assessments app ( #147586 )
...
Since the app is used to assess Flutter's overall accessibility, the app
should follow at many guidelines as possible, including setting the
`lang` attribute.
Fixes b/338044851
2024-05-01 10:29:17 -07:00
Kostia Sokolovskyi
32ea4b3c46
Add test for animated_fractionally_sized_box.0.dart API example. ( #146721 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/animated_fractionally_sized_box.0_test.dart` test
2024-05-01 16:03:12 +00:00
Kostia Sokolovskyi
d33bb8fa5e
Add tests for single_activator.0.dart API example. ( #147426 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Fixes name of the `examples/api/lib/widgets/shortcuts/single_activator.single_activator.0.dart`
- Adds tests for `examples/api/lib/widgets/shortcuts/single_activator.0.dart`
2024-05-01 14:52:57 +00:00
Kishan Dhankecha
2867ac7885
Added missing code block language in docs ( #147481 )
...
- added language for all code blocks
- replaced `bash` or `shell` with `sh` for consistency.
- added `sh` and `console` in the GitHub template link generator.
- updated test for GitHub template.
2024-05-01 14:44:27 +00:00
chunhtai
3e399c1578
Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po… ( #147597 )
...
…pScope.onPopInvoke (#147016 )"
This reverts commit 8031a3e30chttps://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-30 13:25:24 -07:00
Elliott Brooks
c1c7898b96
Bump dependencies in Flutter ( #147546 )
2024-04-29 15:53:25 -07:00
Kostia Sokolovskyi
9230b0e820
Add tests for character_activator.0.dart API example. ( #147384 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/lib/widgets/shortcuts/character_activator.0.dart` test
- Fixes the description of the `examples/api/lib/widgets/shortcuts/character_activator.0.dart` example
2024-04-26 22:26:14 +00:00
Kishan Dhankecha
e4ad15900a
Added missing tests for Table api example table.0.dart. ( #147318 )
...
Added missing tests for Table example. Issue #130459
2024-04-26 21:30:17 +00:00
chunhtai
8031a3e30c
add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke ( #147016 )
...
same as https://github.com/flutter/flutter/pull/139164 , but make it a soft transition
2024-04-26 04:06:11 +00:00
Jonah Williams
4e16e67946
[devicelab] explicitly enable vulkan validation in test. ( #147382 )
...
Part of https://github.com/flutter/flutter/issues/142659
this test expects validation layers on, so we need to explicitly enable
them before we can turn them off by default.
2024-04-25 14:07:53 -07:00
Taha Tesser
fa85f69e47
Add missing overlayColor property in styleFrom methods ( #146685 )
...
fixes [Add missing `overlayColor` property in `styleFrom` methods](https://github.com/flutter/flutter/issues/146636 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
enum Sizes { extraSmall, small, medium, large, extraLarge }
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Text('styleFrom(overlayColor: Colors.red)', style: Theme.of(context).textTheme.titleLarge),
TextButton(
style: TextButton.styleFrom(overlayColor: Colors.red),
onPressed: () {},
child: const Text('TextButton'),
),
IconButton(
style: IconButton.styleFrom(
overlayColor: Colors.red,
),
onPressed: () {},
icon: const Icon(Icons.add),
),
MenuBar(
children: [
MenuItemButton(
style: MenuItemButton.styleFrom(overlayColor: Colors.red),
child: const Text('MenuItemButton'),
onPressed: () {},
),
SubmenuButton(
style: SubmenuButton.styleFrom(overlayColor: Colors.red),
menuChildren: [
MenuItemButton(
child: const Text('MenuItemButton'),
onPressed: () {},
),
],
child: const Text('SubmenuButton'),
),
],
),
SegmentedButton<Sizes>(
style:
SegmentedButton.styleFrom(overlayColor: Colors.red),
segments: const <ButtonSegment<Sizes>>[
ButtonSegment<Sizes>(
value: Sizes.extraSmall, label: Text('XS')),
ButtonSegment<Sizes>(value: Sizes.small, label: Text('S')),
ButtonSegment<Sizes>(value: Sizes.medium, label: Text('M')),
ButtonSegment<Sizes>(
value: Sizes.large,
label: Text('L'),
),
ButtonSegment<Sizes>(
value: Sizes.extraLarge, label: Text('XL')),
],
selected: const {Sizes.medium},
onSelectionChanged: (Set<Sizes> newSelection) {},
multiSelectionEnabled: true,
),
],
),
),
),
);
}
}
```
</details>
### Preview
2024-04-24 11:56:32 +00:00
Kostia Sokolovskyi
9ebf80a80a
Add test for sliver_animated_opacity.0.dart API example. ( #146722 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/sliver_animated_opacity.0_test.dart` test
2024-04-23 22:10:50 +00:00
