Elliott Brooks
2be334f96c
Refactor widget_inspector_test.dart ( #149850 )
...
Work towards https://github.com/flutter/devtools/issues/7894
The Flutter DevTools team is working on a new Widget Inspector. As part of this work, we need to make adjusts to the widget inspector service API.
This PR simply re-factors the `widget_inspector_test` in preparation for this work, to make it easier for us to modify the tests / add new tests.
Although this PR is large (`widget_inspector_test` is over 5000 lines!!), it does not change any of the current test logic.
Instead it:
- Moves test cases that were prefixed with "WidgetInspectorService" into the pre-existing group named "WidgetInspectorService"
- Moves tests cases in that group which were skipped with `!WidgetInspectorService.instance.isWidgetCreationTracked() // [intended] Test requires --track-widget-creation flag` into a group called "Requires flag --track-widget-creation"
- Adds two helper functions, `pumpWidgetTreeWithABC` and `findElementABC` and uses them in all test cases that were duplicating the same widget set-up.
2024-06-07 14:33:14 +00:00
Valentin Vignal
dcc5361126
Add test for dropdown_menu.1.dart ( #149547 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/dropdown_menu/dropdown_menu.1.dart`
2024-06-07 07:13:02 +00:00
Valentin Vignal
ad56b54b63
Add test for standard_fab_location.0.dart ( #149225 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/floating_action_button_location/standard_fab_location.0.dart`
2024-06-07 07:08:53 +00:00
Daco Harkes
2a543aa43b
[native_assets] Fix framework name deduplication ( #149761 )
...
Applies 02d5286e02https://github.com/flutter/flutter/issues/148955
2024-06-07 07:07:08 +00:00
engine-flutter-autoroll
ae47edab7a
Roll Flutter Engine from 47b15dfba1da to 087feab9922b (1 revision) ( #149871 )
...
47b15dfba1...087feab992skia-flutter-autoroll@skia.org Roll Skia from b3aedcf27979 to a7ee8897c66e (1 revision) (flutter/engine#53267 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-07 05:34:14 +00:00
engine-flutter-autoroll
73152214b8
Roll Flutter Engine from 5d5e0ee9102c to 47b15dfba1da (2 revisions) ( #149870 )
...
5d5e0ee910...47b15dfba1skia-flutter-autoroll@skia.org Roll Dart SDK from ed2b917b266d to 41acb19a67b5 (1 revision) (flutter/engine#53266 )
2024-06-07 skia-flutter-autoroll@skia.org Roll Skia from a42ff08f2b2e to b3aedcf27979 (1 revision) (flutter/engine#53265 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-07 04:32:32 +00:00
engine-flutter-autoroll
dccc26a28a
Roll Flutter Engine from fea8e51b0280 to 5d5e0ee9102c (2 revisions) ( #149867 )
...
fea8e51b02...5d5e0ee910skia-flutter-autoroll@skia.org Roll Skia from c1aae20f1c82 to a42ff08f2b2e (1 revision) (flutter/engine#53263 )
2024-06-06 41930132+hellohuanlin@users.noreply.github.com Reland "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering #53072 " (flutter/engine#53256 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-07 03:04:28 +00:00
engine-flutter-autoroll
2a127cbdf8
Roll Flutter Engine from 5a0a49939c64 to fea8e51b0280 (2 revisions) ( #149865 )
...
5a0a49939c...fea8e51b02skia-flutter-autoroll@skia.org Roll Dart SDK from 8e05acb354f5 to ed2b917b266d (1 revision) (flutter/engine#53262 )
2024-06-06 bdero@google.com [Impeller] Round out extreme angles between curve polyline segments. (flutter/engine#53210 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-07 02:06:26 +00:00
flutter-pub-roller-bot
9a654cb5da
Roll pub packages ( #149864 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-06-07 00:22:25 +00:00
engine-flutter-autoroll
7b83e3c15b
Roll Flutter Engine from bf1a4877da0b to 5a0a49939c64 (1 revision) ( #149861 )
...
bf1a4877da...5a0a49939cskia-flutter-autoroll@skia.org Roll Skia from 41896477ca14 to c1aae20f1c82 (3 revisions) (flutter/engine#53260 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 23:42:25 +00:00
Ian Hickson
961c5b7d93
Remove some vestigial /*!*/ comments ( #149361 )
2024-06-06 23:34:00 +00:00
Jackson Gardner
5fb34b719e
Attempt to fix some web test flakiness. ( #149828 )
...
If the service is disposed when we make calls on it, we need to bubble up an exception that is understood by the callers.
This is another speculative fix for https://github.com/flutter/flutter/issues/149238 .
2024-06-06 23:22:51 +00:00
Kate Lovett
01d1e74af5
Remove abi key permanently from golden file testing ( #149858 )
...
We have fiddled with this a bunch, and there is definitively no way to reliably include this, so I am removing it.
Since CI does not cover all possible values, we can't consistently look up images for local testing. We thought removing it from the look up would work fine, and it did for most tests, but there were still some that could not find an image without it.
A brief history on the abi key
- added in https://github.com/flutter/flutter/pull/143621
- disabled in https://github.com/flutter/flutter/pull/148023
- added back in https://github.com/flutter/flutter/pull/148072
- we thought there was only an issue with alphabetizing keys
- removed from local image look up in https://github.com/flutter/flutter/pull/149696
I updated the docs page to also discuss what makes a good key and what does not based on what we learned here.
2024-06-06 23:05:52 +00:00
Tong Mu
87f68a8876
[CupertinoActionSheet] Add sliding tap gesture ( #149471 )
...
This PR implements the `CupertinoActionSheet` part of https://github.com/flutter/flutter/issues/19786 .
This PR creates a new kind of gesture "sliding tap", which can be a simple tap but also allows the user to slide to other buttons during the tap, and select the button that the slide ends in.
The following video shows the behavior on a button list (left to right: Native iOS, after PR, before PR):
https://github.com/flutter/flutter/assets/1596656/1718630d-6890-4833-908b-762332a39568
Notice:
1. When the tap starts on a button or on the content section, the gesture can slide into a button to highlight it or activate it.
2. When the user performs a quick tap on a button, the button is immediately highlighted. (Before the PR, the highlight waits until the time out of a tap gesture, causing a quick tap to not highlight anything at all.)
The following video shows the behavior when the actions section scrolls (left to right: Native iOS, after PR)
https://github.com/flutter/flutter/assets/1596656/5eb70bc1-ec25-4376-9500-2aaa12f0034b
Notice:
1. Moving left or right doesn't cancel sliding tap, but moving vertically prioritizes the scrolling.
2. Moving before the drag starts is also recognized as a sliding tap.
Also, multiple pointers interact with the button list following an algorithm of "using earliest pointer". I can't record videos about it but I've added unit tests.
2024-06-06 22:41:05 +00:00
flutter-pub-roller-bot
27972ebb48
Roll pub packages ( #149852 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-06-06 22:35:15 +00:00
Hans Muller
7e3e30929a
SliverResizingHeader ( #143325 )
...
A sliver that is pinned to the start of its `CustomScrollView` and reacts to scrolling by resizing between the intrinsic sizes of its min and max extent prototypes.
The minimum and maximum sizes of this sliver are defined by `minExtentPrototype` and `maxExtentPrototype`, a pair of widgets that are laid out once. You can use `SizedBox` widgets to define the size limits.
This sliver is preferable to the general purpose `SliverPersistentHeader` for its relatively narrow use case because there's no need to create a `SliverPersistentHeaderDelegate` or to predict the header's minimum or maximum size.
The sample shows how this sliver's two extent prototype properties can be used to create a resizing header whose minimum and maximum sizes match small and large configurations of the same header widget.
https://github.com/flutter/flutter/assets/1377460/fa7ced98-9d92-4d13-b093-50392118c213
Related sliver utility PRs: https://github.com/flutter/flutter/pull/143538 , https://github.com/flutter/flutter/pull/143196 , https://github.com/flutter/flutter/pull/127340 .
2024-06-06 22:35:12 +00:00
Victoria Ashworth
ea93790479
Run tests on macOS 13 or 14 ( #149827 )
...
In preparation of upgrading our fleet to macOS 14, allow tests to run on either macOS 13 or 14.
Fixes https://github.com/flutter/flutter/issues/148871 .
2024-06-06 22:18:18 +00:00
Polina Cherkasova
440b1c64aa
Fix leaky test. ( #149823 )
...
Introduced by https://github.com/flutter/flutter/pull/148094
2024-06-06 21:41:22 +00:00
engine-flutter-autoroll
b73cd1bee0
Roll Flutter Engine from 31804a222f97 to bf1a4877da0b (3 revisions) ( #149848 )
...
31804a222f...bf1a4877dajonahwilliams@google.com [Impeller] Expand fast gradient to all shapes. (flutter/engine#53254 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Skia from 1211df22d135 to 41896477ca14 (1 revision) (flutter/engine#53258 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 62e8607e1410 to 8e05acb354f5 (1 revision) (flutter/engine#53257 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 21:30:26 +00:00
victorgalo
7d525ea318
Add support for setting the heading level for web semantics ( #97894 ) ( #125771 )
...
This change adds a new property in Semantics widget that would take an integer corresponding to the heading levels defined by the ARIA heading role. This is necessary in order to get proper accessibility and usability in a website for users who rely on screen readers and other assistive technologies.
Issue fixed by this PR:
fixes https://github.com/flutter/flutter/issues/97894
Engine part:
https://github.com/flutter/engine/pull/41435
2024-06-06 21:24:26 +00:00
auto-submit[bot]
6f2d0be6b5
Reverts "Introduce ChipAnimationStyle to override default chips animations durations ( #149245 )" ( #149847 )
...
Reverts: flutter/flutter#149245
Initiated by: QuncCccccc
Reason for reverting: the newly-added unit test might cause the red tree
Original PR Author: TahaTesser
Reviewed By: {bleroux, Piinks}
This change reverts the following previous change:
fixes [Custom backgroundColor on Chip makes it flicker between state transitions](https://github.com/flutter/flutter/issues/146730 )
### Example preview
https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
2024-06-06 20:35:18 +00:00
Kevin Chisholm
32da263b1d
3.22.2 release notes ( #149818 )
...
Update "Hotfixes to the stable channel" in preparation for the next hotfix release.
2024-06-06 20:02:57 +00:00
engine-flutter-autoroll
5502f9f962
Roll Flutter Engine from 25bcbb888939 to 31804a222f97 (3 revisions) ( #149837 )
...
25bcbb8889...31804a222f15619084+vashworth@users.noreply.github.com Run tests on macOS 13 or 14 (flutter/engine#53252 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Skia from d5acbe6bb22d to 1211df22d135 (2 revisions) (flutter/engine#53255 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2xWubo2mRP_2_wXKJ... to aVohW_hnfDaE0smBX... (flutter/engine#53253 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 2xWubo2mRP_2 to aVohW_hnfDaE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 19:47:03 +00:00
Taha Tesser
0a546705b4
Introduce ChipAnimationStyle to override default chips animations durations ( #149245 )
...
fixes [Custom backgroundColor on Chip makes it flicker between state transitions](https://github.com/flutter/flutter/issues/146730 )
### Example preview
https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
2024-06-06 19:39:49 +00:00
engine-flutter-autoroll
da0545b970
Roll Flutter Engine from f5a9690c6061 to 25bcbb888939 (1 revision) ( #149835 )
...
f5a9690c60...25bcbb8889skia-flutter-autoroll@skia.org Roll Skia from a3a32c107ddb to d5acbe6bb22d (3 revisions) (flutter/engine#53251 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 18:46:41 +00:00
Polina Cherkasova
d19d19c2d1
Fix leaky test. ( #149822 )
2024-06-06 11:33:27 -07:00
Jenn Magder
ef386d30c9
Unpin archive package from tool, update to version without security advisories ( #149430 )
...
Unpin `archive` version and run `flutter update-packages --force-upgrade` to show there are no additional dependencies pulled in (url_launcher was updated, but unrelated).
Fixes https://github.com/flutter/flutter/issues/149427
2024-06-06 18:19:19 +00:00
flutter-pub-roller-bot
50998a99f2
Roll pub packages ( #149630 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-06-06 18:08:49 +00:00
engine-flutter-autoroll
4a941db897
Roll Flutter Engine from d9684a37af06 to f5a9690c6061 (7 revisions) ( #149832 )
...
d9684a37af...f5a9690c60skia-flutter-autoroll@skia.org Roll Skia from ee42535eb2b4 to a3a32c107ddb (5 revisions) (flutter/engine#53250 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 7df5ccdf1c1b to 62e8607e1410 (2 revisions) (flutter/engine#53248 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Skia from c2899d177c94 to ee42535eb2b4 (1 revision) (flutter/engine#53247 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Dart SDK from e5459bcecb9c to 7df5ccdf1c1b (1 revision) (flutter/engine#53245 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Skia from 9f3289461e51 to c2899d177c94 (2 revisions) (flutter/engine#53244 )
2024-06-06 dkwingsmt@users.noreply.github.com Make pointer events ignore invalid views (flutter/engine#51925 )
2024-06-06 skia-flutter-autoroll@skia.org Roll Skia from 0062d519a9ad to 9f3289461e51 (1 revision) (flutter/engine#53242 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 17:53:08 +00:00
engine-flutter-autoroll
b31781a352
Roll Packages from 11e192a86db3 to 586faa631499 (13 revisions) ( #149820 )
...
11e192a86d...586faa6314ditman@gmail.com [google_sign_in_web] Update button_tester to use web_only library. (flutter/packages#6868 )
2024-06-05 engine-flutter-autoroll@skia.org Roll Flutter from c246ecdf8e27e06569a1flutter/packages#6875 )
2024-06-05 15619084+vashworth@users.noreply.github.com [path_provider] Skip verifying sample file on macOS (flutter/packages#6874 )
2024-06-05 joonas.kerttula@codemate.com [google_maps_flutter] Custom marker size improvements (flutter/packages#4055 )
2024-06-05 uberchilly@gmail.com [rfw] Material slider widget (flutter/packages#6610 )
2024-06-04 ditman@gmail.com [ci] Manual roll Flutter to c246ecdflutter/packages#6863 )
2024-06-04 molchanovia.dev@gmail.com Correcting the typo of Flutter in projects (flutter/packages#6850 )
2024-06-04 joonas.kerttula@codemate.com [google_maps_flutter] Custom marker size improvements - platform impls (flutter/packages#6826 )
2024-06-04 lrn@google.com Avoid cumbersome formatter workaround (flutter/packages#6573 )
2024-06-04 15619084+vashworth@users.noreply.github.com Clean Xcode project before analyzing and testing (flutter/packages#6842 )
2024-06-03 37848204+RobinCombrink@users.noreply.github.com [pigeon] Kotlin/Java method overloading for the `setUp` method (flutter/packages#6843 )
2024-06-03 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add support for setting show title on Chrome Custom Tabs (flutter/packages#6097 )
2024-06-03 ditman@gmail.com Revert "Roll Flutter from c85fa6abf47eebe2992a#6836 )" (flutter/packages#6860 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 17:01:57 +00:00
Mouad Debbar
7e414e88e0
Fix some links in the "Handling breaking change" section ( #149821 )
...
_Title says it all_
2024-06-06 17:00:51 +00:00
engine-flutter-autoroll
9243d8ea0f
Roll Flutter Engine from 92d0cd9370f7 to d9684a37af06 (1 revision) ( #149793 )
...
92d0cd9370...d9684a37afskia-flutter-autoroll@skia.org Roll Dart SDK from 86b8aacb2609 to e5459bcecb9c (1 revision) (flutter/engine#53241 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 16:56:59 +00:00
Bruno Leroux
4608a89137
Fix InputDecorator suffixIcon color when in error and hovered ( #149643 )
...
## Description
This PRs makes the `InputDecoration.suffixIcon` color compliant with the M3 spec when in error state and hovered.
From M3 spec, the color should be `onErrorContainer`, see https://m3.material.io/components/text-fields/specs#e4964192-72ad-414f-85b4-4b4357abb83c
## Related Issue
Fixes https://github.com/flutter/flutter/issues/149410 .
## Tests
Updates 2 tests.
2024-06-06 06:11:25 +00:00
engine-flutter-autoroll
c5025ad53d
Roll Flutter Engine from 32c3b9b7cbe1 to 92d0cd9370f7 (1 revision) ( #149789 )
...
32c3b9b7cb...92d0cd9370skia-flutter-autoroll@skia.org Roll Skia from 89570a0a171e to 0062d519a9ad (1 revision) (flutter/engine#53240 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 05:51:26 +00:00
engine-flutter-autoroll
c6acad75ed
Roll Flutter Engine from 0edca2e9d3d2 to 32c3b9b7cbe1 (2 revisions) ( #149786 )
...
0edca2e9d3...32c3b9b7cbyjbanov@google.com [web] clean up dynamic calls, remove always_specify_types (flutter/engine#53228 )
2024-06-06 jonahwilliams@google.com [Impeller] Reland Use Skia software renderer to draw stroked text. (flutter/engine#53238 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 04:48:24 +00:00
engine-flutter-autoroll
b891d2e0de
Roll Flutter Engine from f51e0ad3abbe to 0edca2e9d3d2 (8 revisions) ( #149785 )
...
f51e0ad3ab...0edca2e9d3#53198 )" (flutter/engine#53237 )
2024-06-05 jonahwilliams@google.com [Impeller] Use Skia software renderer to draw stroked text. (flutter/engine#53198 )
2024-06-05 chinmaygarde@google.com Remove the DBC interpreter flag. (flutter/engine#53204 )
2024-06-05 ditman@gmail.com [web] Adds allowPlatformDefault for wheel signals. (flutter/engine#51566 )
2024-06-05 jonahwilliams@google.com [Impeller] fix emojis with non-solid color sources. (flutter/engine#53229 )
2024-06-05 skia-flutter-autoroll@skia.org Roll Skia from 8448abc95867 to 89570a0a171e (1 revision) (flutter/engine#53236 )
2024-06-05 skia-flutter-autoroll@skia.org Roll Dart SDK from f838a9a8d45f to 86b8aacb2609 (1 revision) (flutter/engine#53234 )
2024-06-05 flar@google.com [DisplayList] remove legacy DisplayListMatrixClipTracker (flutter/engine#53232 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 03:27:14 +00:00
engine-flutter-autoroll
d3a273971c
Roll Flutter Engine from f37733035060 to f51e0ad3abbe (3 revisions) ( #149778 )
...
f377330350...f51e0ad3ab30870216+gaaclarke@users.noreply.github.com [Impeller] added test for bgra10xr png encoding (flutter/engine#53182 )
2024-06-05 jonahwilliams@google.com [Impeller] correctly map DL non-mipmap sample mode to non-mipmap sample mode. (flutter/engine#53161 )
2024-06-05 fujino@google.com Update testing/skia_gold_client/README.md (flutter/engine#53233 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-06 01:45:25 +00:00
Kate Lovett
236b3a716d
Remove abi key from local golden file testing ( #149696 )
...
Fixes https://github.com/flutter/flutter/issues/149435
CI does not comprehensively cover all of the possible abi keys, so some folks can't test locally if their machine's abi does not match CI. This just removes it from the local testing look up. The right image will be summoned, and in CI we can still keep track of it.
2024-06-05 23:51:11 +00:00
chunhtai
c1064da21b
Fixes Router transaction to respect operation order ( #149763 )
...
fixes https://github.com/flutter/flutter/issues/142393
The issue is that if routerdelegate mutate its currentConfiguration outside of Router's workflow, the change will be propagate back to routeinformationprovider at the end of the frame.
However if another things trigger router's dependencies change within the same frame. The dependencies will trigger a reparse of the current route which would end up override the currentConfiguration in routerDelegate.
This change introduce a transaction system that each operation will be add to the end of the transaction future so everything will be execute inorder
2024-06-05 23:17:53 +00:00
Yegor
ff0ab6ba45
Send q once ( #149767 )
...
The previous expression `success || line.contains('--- TEST FAILED ---')` made it such that as soon as success is reported, the test would send "q" on every line of stdout, which is wrong. This fixes the condition such that "q" is sent once, only when `--- TEST SUCCEEDED ---` or `--- TEST FAILED ---` is printed.
2024-06-05 22:44:01 +00:00
Flutter GitHub Bot
0708f3c8bc
Marks Mac_ios rrect_blur_perf_ios__timeline_summary to be unflaky ( #149729 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios rrect_blur_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20rrect_blur_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2024-06-05 22:40:01 +00:00
Qun Cheng
3ed3f31ba6
Add contrastLevel parameter to ColorScheme.fromSeed ( #149705 )
...
This PR is to add a parameter `contrastLevel` to `ColorScheme.fromSeed` so that we can construct high contrast `ColorScheme`.
https://github.com/flutter/flutter/assets/36861262/c609c996-5dfe-4c6c-800c-349a99de4256
Related to https://github.com/flutter/flutter/issues/149683
2024-06-05 22:16:08 +00:00
engine-flutter-autoroll
d46463056c
Roll Flutter Engine from 11a32d43e3f6 to f37733035060 (11 revisions) ( #149770 )
...
11a32d43e3...f377330350skia-flutter-autoroll@skia.org Roll Skia from 37755d48cca3 to 8448abc95867 (7 revisions) (flutter/engine#53230 )
2024-06-05 skia-flutter-autoroll@skia.org Roll Dart SDK from dac7c04c7342 to f838a9a8d45f (3 revisions) (flutter/engine#53225 )
2024-06-05 skia-flutter-autoroll@skia.org Roll Skia from 337c3c4d1f1b to 37755d48cca3 (45 revisions) (flutter/engine#53224 )
2024-06-05 yjbanov@google.com [web] enable always_specify_types for web_ui (flutter/engine#53226 )
2024-06-05 matanlurey@users.noreply.github.com Re-land #52859 : Revamp the engine style guide, remove `always_specify_types` (flutter/engine#53223 )
2024-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pagJoGS4kQ8Efa_if... to 2xWubo2mRP_2_wXKJ... (flutter/engine#53222 )
2024-06-05 fmil@google.com [icu] Manual roll of icu (flutter/engine#53199 )
2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (#53072 )" (flutter/engine#53220 )
2024-06-05 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (flutter/engine#53072 )
2024-06-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 343c20614708 to dac7c04c7342 (1 revision) (flutter/engine#53209 )
2024-06-04 jonahwilliams@google.com [Impeller] Intel iOS Simulators must block on GPU completion. (flutter/engine#53073 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pagJoGS4kQ8E to 2xWubo2mRP_2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-05 22:04:42 +00:00
Matan Lurey
d1e17c338b
Remove unused code from an older test artifact. ( #149746 )
...
This does nothing. Let's send it to the void!
2024-06-05 21:07:08 +00:00
Qun Cheng
6e5f39b5d9
Create CarouselView widget - Part 1 ( #148094 )
...
This PR is to create an ["uncontained" Carousel](https://m3.material.io/components/carousel/specs#477de3a1-c9df-4742-baf3-bcd5eeb3764c ).
https://github.com/flutter/flutter/assets/36861262/947e6b2c-219f-4c8b-aba1-4a1a010221a7
The rest of the layouts can be achieved by using `Carousel.weighted`: https://github.com/QuncCccccc/flutter/pull/2 . The branch of `Caorusel.weighted` PR is based on this PR for relatively easer review. Will request reviews for the part 2 PR once this one is successfully merged in master.
2024-06-05 21:03:21 +00:00
Andrew Kolos
1cf617812b
[flutter_tools] Remove additional listener on VM service that simply logged incoming messages ( #149756 )
...
In service of #146879 . In summary, a bunch of `printTrace` calls were added to try to troubleshoot this flake, but the flake has stopped happening.
This PR more-or-less reverts https://github.com/flutter/flutter/pull/148596 , since this was the only change that could have _theoretically_ (somehow maybe) stopped the flake. I'll consider reverting the rest of the `printTrace` calls if the flake does not reappear after this PR lands.
2024-06-05 20:54:53 +00:00
Michael Goderbauer
fbc0ff1f3b
Fix signature for TokenTemplate.updateFile ( #149673 )
...
This method isn't supposed to do any async work.
2024-06-05 20:51:06 +00:00
LongCatIsLooong
8ce3bfb6ca
Remove temporary LayoutBuilder migration flag, defer markNeedsLayout ( #149637 )
...
Looks like I did not need this flag since flutter_portal pinned flutter version to 3.10 in their presubmits.
I'll create a g3 fix for this since there're only a handful of scuba failures. Also a g3 test revealed a problem with calling `renderObject.markNeedsLayout` directly. It has to be deferred so the render tree is clean during the idle phase and the postFrameCallback phase.
2024-06-05 20:51:04 +00:00
Yegor
180cda380c
Revert "make output of flutter run web tests verbose ( #149694 )" ( #149766 )
...
This reverts commit cd8e84f465
2024-06-05 13:23:00 -07:00
auto-submit[bot]
27e06569a1
Reverts "TreeSliver & associated classes ( #147171 )" ( #149754 )
...
Reverts: flutter/flutter#147171
Initiated by: QuncCccccc
Reason for reverting: tree is red due to a test in this PR
Original PR Author: Piinks
Reviewed By: {QuncCccccc, TahaTesser, bleroux}
This change reverts the following previous change:
**FYI for Reviewers:** Much of the API surface matches that of the 2D TreeView in https://github.com/flutter/packages/pull/6592 . If it changes here, it should change there, and vice versa.
📜 [Design Document](https://docs.google.com/document/d/1-aFI7VjkF9yMkWpP94J8T_JREDS-M3bOak26PVehUYg/edit?usp=sharing )
This adds classes and associated callbacks and controllers for TreeSliver. Core components:
- TreeSliver
- RenderTreeSliver
- TreeSliverNode
- TreeSliverController
- TreeSliverStateMixin
- TreeSliverIndentationType
Fixes https://github.com/flutter/flutter/issues/114299
https://github.com/flutter/flutter/assets/16964204/3facd095-7262-4068-aa33-d713e2deca99
https://github.com/flutter/flutter/assets/16964204/f851ae30-8e71-45c7-82a4-9606986a5872
2024-06-05 17:17:19 +00:00
