Commit graph

20327 commits

Author SHA1 Message Date
Tong Mu fb0b982324
Change MouseTracker's interface for clarity. Simplify MouseRegion's implementation. (#64119)
* Redesigns the interface between MouseTracker and RendererBinding&RenderView.
* Simplifies the structure of RenderMouseRegion.
* Extracts the common utility code between mouse_tracker_test and mouse_tracker_cursor_test.
2020-08-19 18:51:56 -07:00
Ming Lyu (CareF) 1fc3a5e439
run the test longer time (#64185) 2020-08-19 21:23:59 -04:00
Christopher Fujino d6e308c578
Don't fail docs-linux on release branches (#64203) 2020-08-19 18:16:05 -07:00
Todd Volkert 21cfed34d4
(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)
* (insert|move|remove)ChildRenderObject Deprecation: Step 1

This deprecates the following methods:

* RenderObjectElement.insertChildRenderObject
* RenderObjectElement.moveChildRenderObject
* RenderObjectElement.removeChildRenderObject

...and replaces them with the following methods:

* RenderObjectElement.insertRenderObjectChild
* RenderObjectElement.moveRenderObjectChild
* RenderObjectElement.removeRenderObjectChild

The reason for the deprecation is to provide the `oldSlot` argument to
the `moveRenderObjectChild` method (such an argument was missing from
the now-deprecated `moveChildRenderObject` method) and the `slot`
argument to the `removeRenderObjectChild` method (such an argument was
missing from the now-deprecated `removeChildRenderObject` method). While
no argument was added to `insertRenderObjectChild`, the name change (and
corresponding deprecation) was made to maintain naming parity with the
other two methods.

This initial step does not update or remove any of the `slotToChild`
patterns that exist in the framework. This work is being separated
into two commits in case something needs to be reverted to minimize
the scope of each commit.

See https://github.com/flutter/flutter/issues/63269 for more info
2020-08-19 17:39:07 -07:00
Jonah Williams 04f7c9d52e
[flutter_tools] update dwds, roll to null-safe file and process (#64195)
Update to latest dwds, file-nullsafety, and process-nullsafety for #62886
2020-08-19 16:59:52 -07:00
chunhtai 31e881f3a8
remove ununsed deprecated field (#64076) 2020-08-19 16:26:05 -07:00
Jimmy Robert d69ae36398
Fix tooltip position. (#60479) 2020-08-19 16:11:06 -07:00
engine-flutter-autoroll 357ed4e6b9
Roll Engine from 81779371338a to 74d32ecdbd46 (2 revisions) (#64193) 2020-08-19 15:56:04 -07:00
Jonah Williams 829ef147d1
[null-safety] roll to null-safe platform (#64160) 2020-08-19 15:47:08 -07:00
Greg Spencer 041a3eaa84
Standardize the nullability of arguments to raw key data constructors. (#63523)
This standardizes the handling of nullability for the LogicalKeyboardKey.keyLabel and RawKeyEventData.keyLabel accessors so that they are non-nullable, but can be empty.

Before this change, the keyLabel could be either null or an empty string to indicate that there wasn't a label, which makes it harder to test for, since both need to be checked for. Since an empty string is sufficient, there is no need for it to be nullable.

Also, in raw_keyboard.dart, the web and Windows implementations wouldn't accept null values for parameters in the Map coming from the message, but tests were supplying null for some of them. This makes web and Windows creation of events match the other platforms, and makes the migration of tests to non-nullability easier.
2020-08-19 15:03:17 -07:00
Jonah Williams 69fd5c50a2
[flutter_tools] null assertions off by default for web (#64186)
Like Android/iOS, only enable --null-assertions if asked. Previously this was enabled by default for web, but in general this has proved to be too breaking to enable by default.

#61042
2020-08-19 14:52:47 -07:00
Tong Wu ae4b3ba2d1
Reorder issue templates. (#64174) 2020-08-19 14:51:07 -07:00
Jonah Williams 4954a46ff0
[flutter_tools] shrink API surface of Android SDK (#63867)
Attempt to simplify the Android SDK interface ahead of refactoring it. The locateAndroidSdk static method is called at startup to locate the android SDK, returning null if it cannot be found. These helper methods attempted to first look up the AndroidSDK if it was already null - which could only cover the case where someone installed the Android SDK while flutter was running (possibly through an IDE)
2020-08-19 14:44:56 -07:00
Zachary Anderson 6f78131474
WIP: [flutter_tool] Fix amberctl host address (#64020) 2020-08-19 14:41:05 -07:00
Justin McCandless ec24a819ea
ClipboardStatusNotifier should handle errors in Clipboard.getData (#64012) 2020-08-19 14:36:08 -07:00
engine-flutter-autoroll d981fafe8b
Roll Engine from dcbe3d3d3dff to 81779371338a (4 revisions) (#64171) 2020-08-19 13:41:08 -07:00
Darren Austin 2735a661f9
Changes to initialDate for CalendarDatePicker should update the state. (#64115) 2020-08-19 13:36:06 -07:00
Mouad Debbar 2b67846aab
Make SelectableText work better on web (#63786) 2020-08-19 13:31:06 -07:00
Rami 414f8b5950
Remove unused copyWith arguments in TimePickerThemeData (#64167) 2020-08-19 13:26:10 -07:00
Yuqian Li 6eb45d35da
Rename needsMeasureCpuGpu to measureCpuGpu (#64000) 2020-08-19 13:26:07 -07:00
Jonah Williams 38e0c25823
[flutter_tools] reland: enable --null-assertions for flutter framework tests (#64120)
Reland of acdb909 with fixes to semantics.dart

#61042
2020-08-19 13:25:42 -07:00
Yuqian Li 266b9f99a9
Mark tests as nonflaky (#64077)
These tests look quite stable for the last 10 runs.
2020-08-19 10:37:12 -07:00
engine-flutter-autoroll 380e8f3bb4
Roll Engine from 0b330467da24 to dcbe3d3d3dff (25 revisions) (#64161) 2020-08-19 10:16:05 -07:00
Masayuki Ono (mono) 606abc915f
Fix title color of license detail page (#63249) 2020-08-19 09:01:06 -07:00
Tong Wu 430e3cf08c
[devicelab] Enable a LUCI try builder. (#64004) 2020-08-19 08:36:04 -07:00
Jonah Williams 1b69983c6d
[versions] update gallery, roll versions (#64067) 2020-08-19 08:07:15 -07:00
Rami 021cf56fc9
[Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097) 2020-08-19 09:30:28 -04:00
LongCatIsLooong db705b81e3
Restore the original name of the velocity tracker microbenchmark (#64060) 2020-08-19 00:41:06 -07:00
Justin McCandless ce63f50733
Document how to size IV's child correctly, after seeing confusion in Github issues (#64100) 2020-08-18 23:51:04 -07:00
godofredoc 86d2fe9f20
Remove windows docs from list of try jobs. (#64125)
Bug:
  https://github.com/flutter/flutter/issues/64121
2020-08-18 21:48:04 -07:00
Michael Goderbauer 3e867f78db
Fix assert in dartdoc_checker and enable asserts (#64111) 2020-08-18 19:11:05 -07:00
Jenn Magder 1b47759528
Revert "[null-safety] enable null assertions for framework tests (#64071)" (#64118)
This reverts commit acdb909fcb.
2020-08-18 18:08:51 -07:00
Tong Wu d6c254be4e
Fix a data issue in prod_builder.json (#64116) 2020-08-18 17:51:29 -07:00
Michael Goderbauer e1a09622df
Bump dartdoc to 0.30.4 (#64112) 2020-08-18 17:31:04 -07:00
Jonah Williams acdb909fcb
[null-safety] enable null assertions for framework tests (#64071) 2020-08-18 17:21:04 -07:00
xster b92f80e22a
Incorrect path.join usage might be causing Windows test failures (#64056) 2020-08-18 17:16:04 -07:00
Michael Goderbauer 734a90eb3a
migrate semantics to nullsafety (#64055) 2020-08-18 17:11:06 -07:00
Jenn Magder 6ca9cd7b8f
Use real flutter root for finding pub in command integration test (#64021) 2020-08-18 17:09:02 -07:00
Ming Lyu (CareF) 48287750d0
remove duplicate e2e driver (#64015) 2020-08-18 17:06:05 -07:00
godofredoc d504437d88
Make cirrus tests presubmit only and add new luci tests. (#63995) 2020-08-18 17:01:09 -07:00
Jonah Williams a42c56791b
[flutter_tools] shrink fingerprinter API to currently used subset (#63840) 2020-08-18 17:01:06 -07:00
Jonah Williams 39c735f408
[flutter_tools] correctly forward error only stdout in non-verbose modes (#63815) 2020-08-18 16:56:05 -07:00
Ian Hickson 2122fe1fa1
Typo (#63692) 2020-08-18 16:51:06 -07:00
Greg Spencer d1eff0b413
Hook up soft keyboard "next" and "previous" buttons so that they move the focus by default (#63592)
Focus will be moved automatically if onEditingComplete is not specified, but must
by moved manually if onEditingComplete is specified.
2020-08-18 16:46:58 -07:00
Mehmet Fidanboylu 7f122c7429
Revert "Ensure time picker input mode lays out correctly in RTL (#63599)" (#64094)
This reverts commit 1de673bcda.
2020-08-18 14:15:50 -07:00
Mehmet Fidanboylu bd6252eb3a
Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" (#64091)
This reverts commit 64d76f2fb7.
2020-08-18 13:55:33 -07:00
Jonah Williams f0dd4ad530
[flutter_tools] add more info to coverage script (#64065)
Also output covered | total lines, and a summary percentage at the end + Kick tree
2020-08-18 12:18:54 -07:00
Alexander Aprelev 61362cff85
Move away from deprecated NoSuchMethodError to NoSuchMethodError.withInvocation (#63974) 2020-08-18 08:41:02 -07:00
Mehmet Fidanboylu 473744df2c
Revert "fix wrap intrinsic height calculation (#63420)" (#64046)
This reverts commit 72619b8642.
2020-08-18 08:07:14 -07:00
engine-flutter-autoroll a51dc3d913
Roll Engine from 02de4eb7cefa to 0b330467da24 (2 revisions) (#64024) 2020-08-17 23:51:02 -07:00