Commit graph

55 commits

Author SHA1 Message Date
Ian Hickson 5e216d44ca
Simplify devicelab logic and fix tests (#139122)
- fix https://github.com/flutter/flutter/issues/53707 by having the test not expect a timeout but instead actually look for the retry message
- simplify the `--task` option to only accept task names rather than also accepting paths
- remove some obsolete options that referred to the manifest which no longer seems to exist
2023-11-29 08:41:27 +00:00
Andrew Kolos 445e02dd63
fix --exit flag in dev/devicelab/bin/run.dart (#134162)
Fixes #134154 

This PR also changes the default value of the `--exit` flag from `true` to `false`. Effectively, this is not a change in behavior since `--exit` didn't previously work.
2023-09-07 19:36:55 +00:00
Jim Graham 88717b3c65
add missing forwards of local-engine-host in benchmark runners (#133517)
Some places where we are missing a forward of the `--local-engine-host` values in the benchmark code preventing local running of the benchmarks (does not affect CI usages which don't override local engine).
2023-08-29 00:31:14 +00:00
Matan Lurey a7997f606e
Update dev/devicelab/** to provide --local-engine-host. (#132342)
Partial work towards https://github.com/flutter/flutter/issues/132245.

I have to admit I don't totally understand what I've updated, or whether
there are more integration points needed.
2023-08-10 17:25:30 -07:00
Michael Goderbauer 5e1ba701ed
enable no_literal_bool_comparisons lint (#126647) 2023-05-16 16:14:23 +00:00
Harry Terkelsen daaba8a4aa
Add --local-web-sdk in devicelab runner to make --ab testing work for web (#123825)
This allows us to check for performance differences in local Web SDKs.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-03-31 14:25:00 -07:00
Ricardo Amador f989d551ce
Devicelab android emulator (#113472)
* Testing whether emulator is possible.

* Adding changes to see if emulator can be used from recipe.

* adding emulator support.

* Add the emulator flag for testing.

* Using string for boolean since it cannot be parsed in properties

* Checking to see if these changes are being used.

* Updated bool back to string

* Remove trailing whitespace from file.
2023-01-17 22:01:11 +00:00
Casey Hillers 3109073fd9
[devicelab] Remove legacy devicelab manifest logic (#101554) 2022-04-08 09:46:08 -07:00
Ian Hickson 57f097b532
Refactor devicelab bin/run.dart and other cleanup (#96320) 2022-01-10 13:40:17 -08:00
Ian Hickson 61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson 5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Darren Austin 8fcace1d6c
Migrate devicelab tests and test runners to null safety. (#85999)
* Migrate devicelab tests and test runners to null safety.
2021-07-23 13:37:57 -07:00
gaaclarke 66fd0b28b0
replaced unawaited with synchronous / await calls where needed (#82839) 2021-06-24 16:22:43 -07:00
Jenn Magder 94a41cde83
Mixed null safety in dev/devicelab (#84017) 2021-06-05 02:29:03 -07:00
gaaclarke 7cdd33fe99
added unawaited function for devicelab and turned on unawaited_futures linter (#82833) 2021-05-18 14:19:03 -07:00
Phil Quitslund 61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Jason Simmons a75730fe44
Restore support for the --local-engine flag in devicelab/bin/run.dart (#79583) 2021-04-01 13:54:02 -07:00
Casey Hillers c8c681f68e
[devicelab] Create test command to pass task args (#77110) 2021-03-04 11:59:02 -08:00
Casey Hillers 7ed797b053
Revert "[devicelab] Separate build and test from Flutter gallery tests (#76415)" (#77086)
This reverts commit 297c7b5cf2.
2021-03-02 12:17:18 -08:00
Casey Hillers 297c7b5cf2
[devicelab] Separate build and test from Flutter gallery tests (#76415) 2021-03-02 11:49:02 -08:00
Casey Hillers 849784e262
[devicelab] Add results path flag to test runner (#72765) 2020-12-22 16:45:38 -08:00
Casey Hillers 2565062df3
git branch flag (#71886) 2020-12-08 15:53:05 -08:00
Casey Hillers a228a17c57
[devicelab] LUCI builder flag (#70702) 2020-11-17 11:28:03 -08:00
Casey Hillers 0d7270ba0c
Revert "[devicelab] LUCI builder flag (#70464)" (#70496) 2020-11-13 16:38:03 -08:00
Casey Hillers 004d3f0f75
[devicelab] LUCI builder flag (#70464) 2020-11-13 10:38:03 -08:00
Casey Hillers 1c35091a13
[devicelab] Cocoon client (#68333) 2020-10-19 13:12:04 -07:00
Casey Hillers 9e206a0c93
Refactor devicelab logic to use TaskResult instead of JSON (#67550) 2020-10-07 16:37:09 -07:00
Michael R Fairhurst 7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Ming Lyu (CareF) 99f5eebc6b
Add --device-id option for devicelab/bin/run.dart (#59276)
* Implement device selection for devicelab/run.dart

* Add test to --device-id option for devicelab/run

* Update dev/devicelab/bin/run.dart by jonahwilliam

* Rename deviceOperatingSystem enum mock -> fake

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-06-26 09:29:46 -04:00
Ming Lyu (CareF) 78a4016c81
Line break for devicelab/bin/run.dart help info (#58986)
The original help info has lines too long for
appropriate terminal display.
2020-06-10 17:11:48 -04:00
Jim Graham 3519bec6c4
Save results of A/B test runs in a JSON file for future processing (#56416) 2020-05-08 00:34:02 -07:00
Yegor 20803507fd
print intermediate and raw A/B results when not silent (#54676)
* print intermediate A/B results when not silent
* print raw A/B results when in loud mode
* add tests; handle missing metrics more gracefully
* use less fancy section header on Windows
2020-04-16 14:36:42 -07:00
Yegor d119e5f1e4
Add A/B test mode to local devicelab runner (#54494)
* Add A/B test mode to local devicelab runner
2020-04-10 16:53:52 -07:00
Alexandre Ardhuin f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Alexandre Ardhuin 3800bb7b10 fix missing spaces in adjacent strings (#49159) 2020-01-21 16:43:03 -08:00
Alexandre Ardhuin 4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Alexandre Ardhuin ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Ian Hickson 449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
gaaclarke a66ea4f21b
Devicelab run.dart: Fixed check for path equality (#41403)
Fixed check for path equality.  It was too strict, disallowing leading "./".
2019-09-26 17:09:05 -07:00
Christopher Fujino 65f8f9c0b8
add --exit and --match-host-platform defaults to devicelab runner (#37832) 2019-08-20 14:37:42 -07:00
Ian Hickson 295530dcaf
Some minor cleanup in devicelab (#36571) 2019-07-22 14:13:33 -07:00
Dan Field bc3ca10e71
Make it easier to pass local engine flags when running devicelab tests (#34054) 2019-06-07 12:49:09 -07:00
Alexandre Ardhuin 8b0de38ef8
fix upcoming lint avoid_returning_null_for_void (#23190) 2018-10-17 11:01:37 +02:00
Alexandre Ardhuin d340e2f229
apply lint prefer_void_to_null in dev/ (#22661) 2018-10-04 18:44:23 +02:00
Alexandre Ardhuin d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Alexander Aprelev ded538a1bb
Update dependencies with forced upgrade. (#15344)
* Update dependencies with forced upgrade.

Now that https://github.com/flutter/flutter/issues/15261 is fixed, do the update with upgrade.

* Update test package use following upgrade

* Replace addOption(allowMultiple) with addMultiOption
2018-03-09 10:38:54 -08:00
Alexandre Ardhuin 3c379aaf43
whitespace cleanup (#14458) 2018-02-05 22:20:21 +01:00
Alexander Aprelev 3470c682f4 Make flag out of '--all' option (#12510) 2017-10-12 16:08:29 -07:00
Alexandre Ardhuin 189028a958 Separate the 'if' expression from its statement (#9177) 2017-04-04 21:45:50 +02:00