Commit graph

2060 commits

Author SHA1 Message Date
Dan Field fabeb2a16f
Revert string interp (#49602) 2020-01-28 07:56:51 -08:00
Darren Austin 9980d6e550
Script to generate missing localization resources (#49379)
Added a new script to generate missing localizations for use when adding new localizations to the Flutter framework.
2020-01-27 17:50:59 -08:00
Hans Muller 7539826d7b Update gen_l10n handling of plurals, numbers, and dates (#49357) 2020-01-27 16:18:02 -08:00
Dan Field 8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
chunhtai 4964fb62e1 reland add lifecycle enum and remove workaround (#49368) 2020-01-27 10:38:02 -08:00
Jonah Williams d204731daf
[flutter_tools] disable fast-start on routes test (#49473) 2020-01-25 00:53:23 -08:00
Jonah Williams 2f59919496 [flutter_tools] Reland fast start by default for Android (#49315) 2020-01-24 19:18:01 -08:00
Hans Muller bc5c46438a Migrate TextTheme to 2018 APIs (#48547) 2020-01-24 19:03:01 -08:00
Alexandre Ardhuin 92cbaa3efe remove unnecessary string interpolations (#49352) 2020-01-23 20:43:01 -08:00
Michael Goderbauer 7915e58f20 Change firebase Pixel3 version from Q-beta3 to 29 (#49396) 2020-01-23 16:53:48 -08:00
Angjie Li f0a175f41d Use flutter_tools to start WebDriver browser. (#49228) 2020-01-21 16:48:02 -08:00
Alexandre Ardhuin 3800bb7b10 fix missing spaces in adjacent strings (#49159) 2020-01-21 16:43:03 -08:00
Jenn Magder 2a7d57791d Generate bitcode for plugin frameworks for flutter build ios-framework (#49102) 2020-01-21 16:38:03 -08:00
Brett Morgan b530111c5a
Update documentation URLs (#49208) 2020-01-22 09:55:09 +11:00
Jonah Williams 2ebe9da454
Revert "[flutter_tools] Reland enable fast-start by default for Android (#48851)" (#49227) 2020-01-21 09:51:08 -08:00
Jonah Williams 1ac01b30ca
[flutter_tools] Reland enable fast-start by default for Android (#48851) 2020-01-21 08:59:26 -08:00
chunhtai ec1044a877
Revert "reland add lifecycle enum and remove workaround (#48460)" (#49098)
This reverts commit d372814f78.
2020-01-17 19:19:33 -08:00
Jenn Magder 9301a86a86 Precache iOS artifacts (#49010) 2020-01-17 15:28:01 -08:00
Anthony b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Francisco Magdaleno fcf341e4f3
Reland "[flutter_tools] Removes the need of a no-op plugin implementations #48614" (#49085) 2020-01-17 14:43:34 -08:00
Jenn Magder b225cb8d53
Revert "[flutter_tools] Removes the need of a no-op plugin implementations (#48614)" (#49005)
This reverts commit 5eb394e084.
2020-01-16 16:19:54 -08:00
Alexandre Ardhuin 003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Francisco Magdaleno 5eb394e084
[flutter_tools] Removes the need of a no-op plugin implementations (#48614) 2020-01-16 12:42:05 -08:00
sjindel-google ee1fa94b4d
Make build_aar_*_tests actually use release builds. (#48893) 2020-01-16 18:59:33 +01:00
Hans Muller 667c38d551
gen_l10n: generated Intl.message parameter should be an ordinary string (#48929) 2020-01-16 07:20:38 -08:00
chunhtai d372814f78 reland add lifecycle enum and remove workaround (#48460) 2020-01-15 16:33:01 -08:00
Jason Simmons 8092f6a2b6 Reland: Migrate some more integration tests to Android embedding v2 (#48840) 2020-01-14 18:23:01 -08:00
Dan Field 3e63411256 Avoid runtimeType.toString in toString overrides/debugLabels (#48607) 2020-01-14 16:43:01 -08:00
Jim Graham ea28a9c34d
Increase iteration counts to help improve noise in benchmark results. (#48845) 2020-01-14 16:39:36 -08:00
Emmanuel Garcia b9733522dd
Implement takeScreenshot and add driver test for Fuchsia (#48611) 2020-01-14 12:29:09 -08:00
Andrew Davies 52e0d980cb [tools] Rename dev_finder to device-finder. (#48610)
dev_finder name is deprecated. device-finder is preferred.
Functionality remains identical, this is an aesthetic change.

This change was generated via:
$ find . -not -path '*/\.*' -type f -exec sed -i 's/(^import.*)!dev_finder/device-finder/g' {} \;
2020-01-14 09:41:16 -08:00
Emmanuel Garcia fca5917519 Test hot reload targeting a Fuchsia device (#48472) 2020-01-10 14:38:01 -08:00
Shi-Hao Hong 47bba44920
L10n Currency Formatting, Fixes to Named vs Positional Parameters (#48445)
* Add currency formatting for l10n tool, fix positional vs named params
2020-01-10 14:19:40 -08:00
Gerrit a8c5f4e8c4 Add missing indentation to assets-images example (#45833) 2020-01-10 11:23:01 -08:00
Christopher Fujino 7a13d8a0ce install goldctl in docker build (#46640) 2020-01-10 09:38:03 -08:00
Jonah Williams 5d30c0970a
[flutter_tools][web] Add support for web app manifests and arbitrary resource files (from web/) (#48316) 2020-01-10 09:37:20 -08:00
Jonah Williams 5f4e4a3f8a
Revert "Migrate some more integration tests to Android embedding v2 (#48532)" (#48582)
This reverts commit 1613a62e85.
2020-01-10 09:11:42 -08:00
Jason Simmons 1613a62e85
Migrate some more integration tests to Android embedding v2 (#48532) 2020-01-09 14:33:27 -08:00
LongCatIsLooong d291de086c
Add a diagnostic message for malformed imports in analyze.dart (#38355) 2020-01-09 10:25:58 -08:00
Alexandre Ardhuin 82262d8896 format operator== according to flutter style guide (#48449) 2020-01-09 08:23:02 -08:00
Zachary Anderson 23ce192a8f Reland: Reword flutter run help screen. (#48423) 2020-01-09 08:18:03 -08:00
Christopher Fujino 0bbbd04107 Bump excon from 0.67.0 to 0.71.0 for ci on mac & linux (#48268) 2020-01-09 08:13:03 -08:00
Greg Spencer fabf4e3d0d Reverse the sense of the terms snippet and sample. (#48254) 2020-01-08 15:28:02 -08:00
Shi-Hao Hong c525988c8c
Reorganize tests in l10n tool (#47704) 2020-01-08 12:29:18 -08:00
David Iglesias f65f7f0118 Change video_demo slightly so it works on web. (#46719) 2020-01-08 12:28:01 -08:00
Kaushik Iska ccbce98e0b
[fuchsia] Create an entry-point script to run driver tests on Fuchsia (#48359)
* [fuchsia] Create an entry-point script to run driver tests on Fuchsia

This script currently only paves the device. This will soon run a
driver test on a NUC in LUCI.

* reference the engine script and fix comment
2020-01-08 12:25:38 -08:00
Greg Spencer 8b132015bb
Add CatmullRomCurve and CatmullRomSpline (#47547)
This adds CatmullRomCurve animation curve, and a CatmullRomSpline, which is what it uses to do interpolation.

This allows us to create animation curves which can smoothly interpolate the values given to the curve.

Since I've introduced a 2D spline curve, I also created a Curve2D base class for such parametric curves.
2020-01-08 07:59:54 -08:00
Shi-Hao Hong b038b40941 gen_l10n Number Format Handling (#47706) 2020-01-07 22:38:02 -08:00
Alexandre Ardhuin 1c79347ef6
use yield* (#48307) 2020-01-08 07:34:36 +01:00
Sam Rawlins 965ba387d4 Remove unused public static members of private classes/enums (#48218) 2020-01-07 12:18:02 -08:00
Alexandre Ardhuin 4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Jonah Williams fa337f5922
[flutter_tool] Enable globals technical debt benchmark (#48266) 2020-01-06 16:44:12 -08:00
Jonah Williams ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Angjie Li 9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
Jenn Magder dc99d61e5d Remove simulator arch in Profile and Release, App.xcframework (#48002) 2020-01-02 13:03:01 -08:00
Dan Field 24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno 04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Shi-Hao Hong 173322dc78
Support preferred locales for gen_l10n (#47845)
* Add preferred-supported-locales option to gen_l10n.dart executable
2019-12-30 11:22:01 -08:00
Jim Graham cf00b969a1
Fix semantics and transition-perf tests to parse new event format. (#47899) 2019-12-27 18:15:49 -08:00
Jenn Magder d874596e38
Remove package:flutter/foundation.dart import (#47701) 2019-12-23 16:16:43 -08:00
Francisco Magdaleno f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698)
This reverts commit cc1c9649c4.
2019-12-23 15:20:11 -08:00
Jenn Magder 85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568)
This reverts commit 648a5d8a1e.
2019-12-20 17:45:16 -08:00
Shi-Hao Hong 88cd1135bf
Handle plural gen_l10n regular placeholders and DateTime placeholders (#47483)
* Handle simple placeholders in plurals

* Handle Date plural placeholders

* Improve variable names

* Turn assert into exceptions, add tests
2019-12-20 16:22:44 -08:00
Angjie Li cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Jenn Magder 648a5d8a1e
Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Gary Qian b011ea5468
Pass _caretPrototype to prevent cache miss (#46720) 2019-12-20 06:46:49 +09:00
Janice Collins bd25f70c66
Upgrade dartdoc to 0.29.3. (#47246) 2019-12-19 09:45:02 -08:00
Alexandre Ardhuin 78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
Lau Ching Jun a4858782da
Revert "implicit-casts: false (#47199)" (#47428)
This reverts commit c235998acf.
2019-12-18 23:53:00 -08:00
Alexandre Ardhuin c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
Lau Ching Jun 2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45.
2019-12-18 17:02:31 -08:00
Jenn Magder 9184f4d6fb
Build iOS frameworks with relative output path (#47369) 2019-12-18 15:31:54 -08:00
Angjie Li 1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Emmanuel Garcia 9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
Jenn Magder 65ad8d805a
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928)" (#47264)
This reverts commit e54e301d50.
2019-12-17 17:20:57 -08:00
Jenn Magder e54e301d50 Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928) 2019-12-17 16:13:01 -08:00
Shi-Hao Hong c319f5f8d8
gen_l10n localizations date formatting (simple messages) (#47006)
* Implement date parsing for the gen_l10n tool
2019-12-17 14:03:43 -08:00
xster 74af8554ff Fix run_release_test flakiness (#45417) 2019-12-17 07:38:01 -08:00
Shi-Hao Hong 7874bca248
Move localization executables to bin folder (#46251) 2019-12-16 17:30:57 -08:00
Francisco Magdaleno ba73cfc149
Remove space from license (#47159) 2019-12-16 13:34:17 -08:00
Ian Hickson a516a24e79 Update internal dartdoc snippet documentation (#47017) 2019-12-16 12:33:01 -08:00
Dan Field 0f705b7e25
fix new test (#47010) 2019-12-13 14:21:38 -08:00
Jim Graham fa190a8685
New benchmark to measure performance of animations after removing a BackdropFilter. (#46924) 2019-12-13 13:27:53 -08:00
Shi-Hao Hong e7fec2bc33
Add helpful message about how to use localizationsDelegates list (#46250) 2019-12-13 12:00:35 -08:00
Shi-Hao Hong 2eed59c1d5
Add gen_l10n sorting tests (#46247)
* Add tests for sorting arbPathString, supportedLocales and supportedLanguageCodes alphabetically

* Plural arbPathStrings

* Factor out singleZhMessageArbFileString

* Make translations more accurate and generic
2019-12-13 10:03:56 -08:00
Jenn Magder dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder 7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00
Sean Freiburg 418b814555 Add buildNumber param to "flutter build aar" command (#46291) 2019-12-12 10:28:01 -08:00
Jonah Williams 78951b0c01
[benchmarks] Add time to development benchmark for Android (#46717) 2019-12-10 15:03:06 -08:00
Jonah Williams dfcd6568e8
re-enable build runner tooling tests (#46708) 2019-12-10 13:10:09 -08:00
Chris Yang 4a0049627f
Reland "Add a FlutterDriver screenshot test to device lab. #45411" (#46620) 2019-12-10 12:43:36 -08:00
Jonah Williams bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Jonah Williams 523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Ian Hickson 14145a4ec9 Try re-enabling all these tests. (#46615) 2019-12-09 18:58:02 -08:00
liyuqian 69728097bd Remove unused observer and raise the waiting time (#46626) 2019-12-09 15:18:02 -08:00
Ian Hickson 05862ff968 Fix platform-specif test logic. (#46623) 2019-12-09 12:58:03 -08:00
Todd Volkert 55f0bdc033
Fix docker tag during upload as well (#46252)
In https://github.com/flutter/flutter/pull/46035, we fixed the docker
tag to be a legal tag during build.  This PR makes the corresponding
change to the tag during upload.  Without this, we build the right tag,
but then we try to upload the wrong tag.
2019-12-09 12:56:47 -08:00
Emmanuel Garcia f264d6c277
Allow plugins that don't support the Android platform (#46282) 2019-12-08 20:04:19 -08:00
Jenn Magder e58dc16d7b
Revert "Add a FlutterDriver screenshot test to device lab. (#45411)" (#46281)
This reverts commit adec6977be.
2019-12-06 18:21:52 -08:00
Lau Ching Jun c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Chris Yang adec6977be
Add a FlutterDriver screenshot test to device lab. (#45411) 2019-12-06 14:17:02 -08:00
Shi-Hao Hong 37e66b2179
gen_l10n.dart tool testing (#44856)
* Add tests to gen_l10n.dart tool

* Separate out LocalizationsGenerator class to improve testability of code

* Add testing dependencies to dev/tools

* Integrate dev/tools testing to flutter CI

* Restructure dev/tools folder for testing

* Fix license headers
2019-12-06 11:35:08 -08:00
Jonah Williams 7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
liyuqian a2005eaf9a Memory test on scrolling large images quickly (#46184) 2019-12-05 19:28:00 -08:00
Greg Spencer bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00
Alexandre Ardhuin ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Jenn Magder fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Jenn Magder d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams 2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
godofredoc 1657075914
Move technical_debt_cost to use a cloud vm. (#45996) 2019-12-04 16:26:41 -08:00
Greg Spencer 09927b94c3
Add a VisualDensity manual test (#46083)
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
2019-12-04 10:48:06 -08:00
Janice Collins 50c8e6b2d6
Update dartdoc to 0.29.2. (#46014) 2019-12-04 09:59:16 -08:00
Todd Volkert 066a992a5c
Ensure that docker tag is legal (#46035) 2019-12-03 19:53:39 -08:00
Jonah Williams 0b2bf99491
Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
godofredoc 4c4cdbfc2b
Move dartdocs to devicelab vm. (#45952)
We added support linux VMs to devicelab and we will be moving some of
the machine independent benchmarks there.
2019-12-02 19:45:04 -08:00
Kate Lovett 2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Dan Field 088fa24463
Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Ian Hickson a78fb87dfe
Relicense Shrine demo to match rest of repository (#45718)
* Relicense Shrine demo to match rest of repository

The Shrine demo was Apache-licensed. The code was mostly
Google-written, with contributions from:

 - Michelle Dudley (@michdud)

 - Abhijeeth Padarthi <rkinabhi@gmail.com> (@rkinabhi)

 - @a14n

I contacted all three, and they confirmed their approval for this
change, as described below.

Abhijeeth Padarthi said by e-mail on Thu, Nov 21, 2019 at 5:48 PM:

> hi Ian,
>
> sure :)
>
> let me know if I need to do anything on my end..

Michelle Dudley wrote by e-mail on Sun, Nov 24, 2019 at 2:07 PM:

> Hi Ian,
>
> That would be ok with me.
>
> Thanks,
>
> Michelle

@a14n said on Discord's Flutter server in the #hackers channel at 10:44PM on Thursday, November 21, 2019:

> @Hixie no problem I agree with this relicensing

* Remove shrine loophole from license checker.
2019-11-27 16:25:56 -08:00
Ian Hickson 449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Kaushik Iska d1805aa22a
update-packages after dwds updates (#45633) 2019-11-26 18:34:06 -08:00
Greg Spencer 245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Emmanuel Garcia 943f98d3c3
Add integration test for transitive plugin dependencies (#45579) 2019-11-26 08:58:43 -08:00
Todd Volkert bae92c32e5
Disable tests that fail on non-master branches from running on those branches (#45455)
https://github.com/flutter/flutter/issues/45453
2019-11-24 22:29:28 -08:00
Emmanuel Garcia b6e92003c8
Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
Greg Spencer a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin fcb40a05bb
make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
liyuqian c61ef90f94
Upgrade gauge for debugging (#45212)
For https://github.com/flutter/flutter/issues/45194
and see also https://github.com/flutter/packages/pull/47.
2019-11-21 13:03:02 -08:00
Christopher Fujino 45953a12bb dev/ci/README.md update (#44010) 2019-11-21 12:09:02 -08:00
sjindel-google 43a8a1902e
Fix erroneous comments referring to blobs snapshots. (#41378) 2019-11-21 12:09:43 +01:00
Sangmin Lee 60c7cc25e9 Fix typo in README.md (#43173) 2019-11-20 16:14:10 -08:00
Michael Goderbauer f8cafd9dbc
Remove URLs in deprecation annotation (#45215) 2019-11-20 12:45:04 -08:00
Jonah Williams 0e36a91d18
Add macOS hot reload test (#45264) 2019-11-20 12:35:53 -08:00
Danny Tuppeny 927fbe5500
Re-enable asserts on Windows integration tests (#42637)
* Enable asserts

See https://github.com/flutter/flutter/issues/36476

* Remove comment
2019-11-20 17:50:37 +00:00
Jonah Williams f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
liyuqian a32fc986f3
Add a perf test for picture raster cache (#45050)
This will catch issues like
https://github.com/flutter/flutter/issues/44252, and this test is
inspired by the `list_demo` sample app in
https://github.com/flutter/flutter/issues/43083#issue-509586473

This is tested locally on a Moto G4 before and after the fix
https://github.com/flutter/engine/pull/13710

The `average_frame_rasterizer_time_millis` of this test drops from
~5.4ms to ~4.9ms after that fix.
2019-11-19 15:48:41 -08:00
chunhtai 99324105da
reland add lifecycle enum and fix the scheduleforcedframe (#45133)
* reland add lifecycle enum and fix the scheduleforcedframe
2019-11-19 15:45:37 -08:00
Greg Spencer a3186fbaa1
Analyze dartpad (#45124)
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors.

Also, added a --verbose option to the sample analyzer.
2019-11-19 15:16:12 -08:00
Greg Spencer 29ab6b549a
Update manual_tests to be able to run on macOS/web (#44830)
I updated the build files for manual_tests, as well as adding in a macos and web directory to allow the manual tests to be run on the web or on desktop.

The main change here are the parts that I added to the files in manual_tests/lib/... (the addition of kIsWeb to "if (!kIsWeb && Platform.isMacOS) {") The rest is just an update of the auto-generated code from flutter create.
2019-11-19 11:29:35 -08:00
Jonah Williams df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jenn Magder 6e5769d425
Remove FLUTTER_DEVICELAB_XCODE_PROVISIONING_CONFIG code paths (#45136) 2019-11-19 11:19:44 -08:00
Per Classon b5a85fcf48
Allow plural localized strings to not specify every case (#45168)
* Allow plural localized strings to not specify every case
2019-11-19 18:58:28 +01:00
chunhtai 7e1920b817
revert added lifecycle enum (#45119) 2019-11-18 13:38:47 -08:00
chunhtai 439d798712
fix ios_add2app_life_cycle license (#45115) 2019-11-18 11:33:42 -08:00
chunhtai af48f71497
reland add new enum change (#45012)
This reverts commit 75f310791f.
2019-11-18 10:04:09 -08:00
Ian Hickson 62e4ab87b3
Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
Kate Lovett 7aa5b07537
Adding flutter_goldens package tests (#44479) 2019-11-15 10:29:19 -08:00
Greg Spencer dcc4b82540
Fix snippets to include element ID in the output sample. (#44787)
This fixes the snippet code output so that it includes the name of the element that it is a snippet for in the first line.
2019-11-15 10:23:04 -08:00
Kaushik Iska 75f310791f Revert "reland add new enum change (#44281) (#44487)" (#44947)
This reverts commit f0794917fc.
2019-11-14 16:49:43 -08:00
chunhtai f0794917fc
reland add new enum change (#44281) (#44487)
* reland add new enum change (#44281)

This reverts commit ed82bb821c.
2019-11-14 13:27:38 -08:00