Amir Hardon
7d27550f6f
Respond to AndroidView focus events. ( #33901 )
...
When an AndroidView gains focus we invoke the(newly introduced)
'TextInput.setPlatformViewClient' text_input system channel method
which sets the platform view as the text input target.
When the AndroidView loses focus we send a clearFocus message to
platform views system channel(so the engine can clear the focus from
the platform view).
This PR is going to land before the engine implementation is rolled to
the framework, we swallow MissingPluginException for the newly
introduced method channel methods so this is a no-op before the engine
is ready(after the engine is rolled with the corresponding change I'll
remove the logic to swallow the exceptions).
The engine counterpart is in: flutter/engine#9203
2019-06-06 14:49:31 -07:00
stuartmorgan
fb8df82c06
Add 'doctor' support for Windows ( #33872 )
...
Moves the logic for finding vcvars64.bat to a new VisualStudio class
that encapsulates finding, and providing information about, VisualStudio
installations. Adds a validator for it, and runs it for Windows
workflows in doctor.
2019-06-06 14:02:27 -07:00
stuartmorgan
9751f3e537
Add use_frameworks to macOS Podfile template ( #33987 )
...
This wasn't included originally since it didn't seem to be necessary for
macOS in testing, but not having it breaks Swift plugins. This matches
the iOS Swift Podfile template.
2019-06-06 12:43:37 -07:00
Anthony
e1d0ded926
[Material] Create a themable Range Slider (continuous and discrete) ( #31681 )
...
Creates a Material Design range slider.
The range slider is based off the updated slider, with the main difference being that it has 2 thumbs.
By default, the thumbs cannot pass each other and both the thumb and the value indicator create a stroke when they are overlapping for better visibility.
2019-06-06 15:31:02 -04:00
Kate Lovett
005fa1c689
Updating names to correct versioning convention ( #33865 )
2019-06-06 12:15:44 -07:00
Alexander Aprelev
30dbc4c767
Whitelist adb.exe heap corruption exit code. ( #33951 )
...
* Whitelist adb.exe heap corruption exit code.
In android platform tools 29.0.0 adb.exe shell seems to be exiting with heap corruption exit code, otherwise producing results as expected. This PR whitelists this exit code on Windows.
Fixes https://github.com/flutter/flutter/issues/33938 .
* Fix condition
* Fix 'shell am start' command
* Fix stop command
* Refactor into runAdbMostlyChecked(Sync/Async)
* runAdbMostlyChecked -> runAdbChecked
2019-06-06 12:01:03 -07:00
Zachary Anderson
5555725fe3
[flutter_tool] Fix 'q' for Fuchsia profile/debug mode ( #33846 )
2019-06-06 11:16:19 -07:00
Michael Goderbauer
9114f4456c
Add localFocalPoint to ScaleDetector ( #33955 )
2019-06-06 11:09:39 -07:00
LongCatIsLooong
d759197d1f
Add scrollbars to Gallery ( #33634 )
2019-06-06 10:54:28 -07:00
Rubens de Melo
23174c34b1
Include advice about dispose in TextEditingController api ( #33653 )
...
* include advice about dispose
The same note in https://flutter.dev/docs/cookbook/forms/text-field-changes
* Include remember to dispose texteditingcontroller
Almost the same note here https://flutter.dev/docs/cookbook/forms/text-field-changes#2-use-a-texteditingcontroller .
* include remember to dispose TextEditingController and link to see also
* remove extras spaces and duplicated comment
* include details about using Positioned.fill
* Revert "include details about using Positioned.fill"
This reverts commit c06196f888https://flutter.dev/docs/cookbook/forms/text-field-changes#2-use-a-texteditingcontroller )
* include of, remove extra white space and improve description link to cookbook.
include of, remove extra white space and improve description link to cookbook.
* include of, remove extra white space and improve link description to cookbook
include of, remove extra white space and improve link description to cookbook
* include of, remove extra white space and improve link description to cookbook
include of, remove extra white space and improve link description to cookbook
* remove extra white spaces
* remove extra white space
2019-06-06 10:41:48 -07:00
sjindel-google
f83df74b6b
Don't print warning message when running benchmarks test. ( #33842 )
...
# Description
Currently the benchmarks test prints a scary warning message, even when it passes, that a benchmark is being run with asserts enabled.
Normally we don't want developers to do this, because the performance of code with asserts is not characteristic of what end-users will experience. However, we need to unit-test benchmarkWidgets, so I've added a contraindicated option to suppress the warning for the test.
# Related Issues
25049 (comment)
2019-06-06 19:39:32 +02:00
Zachary Anderson
366dcb1588
Revert engine back to afb9d510c3bb0f1b97980434b41200a2d3491697 ( #33982 )
...
Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886 )"
This reverts commit 61b83d320e
2019-06-06 09:50:45 -07:00
Gary Qian
14414f350a
Reland "Text inline widgets, TextSpan rework" ( #33946 )
2019-06-05 18:14:17 -07:00
engine-flutter-autoroll
881cdfdeb0
3371da1e0 Add platform_fuchsia.cc for default font on fuchsia (flutter/engine#9204) ( #33953 )
...
7826548462...3371da1e09flutter/engine#9204 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-05 21:11:55 -04:00
Michael Goderbauer
61b83d320e
Add currentSystemFrameTimeStamp to SchedulerBinding ( #33886 )
2019-06-05 18:02:01 -07:00
engine-flutter-autoroll
c84767cae8
Roll engine afb9d510c3bb..782654846230 (3 commits) ( #33950 )
...
afb9d510c3...7826548462flutter/engine#9199 )
5ea125eaf Switch PlatformViewsController from Activity ref to Application ref. (flutter/engine#9193 )
fd4368c85 Skip golden tests on non-Linux OSes (flutter/engine#9198 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-05 20:24:55 -04:00
Greg Spencer
947bd7524a
Fix a bug in Shortcuts with synonyms, and add tests. ( #33949 )
...
This fixes a rather embarrassing bug in ShortcutManager that happened because I forgot to add the tests I meant to add.
This fixes the bug, and adds the tests.
2019-06-05 17:13:25 -07:00
Jason Simmons
95818d2b7a
Reland "Framework support for font features in text styles" ( #33876 )
...
See https://github.com/flutter/flutter/issues/31691
2019-06-05 16:36:05 -07:00
Greg Spencer
f0978c225a
Game controller button support ( #33868 )
...
This adds support for game controller buttons. It adds some supplemental USB HID codes that aren't available from the Chromium source code, and maps those on Android to the game pad buttons that Android supports. Other platforms are not supported yet.
2019-06-05 16:23:17 -07:00
engine-flutter-autoroll
4e4d3a5de4
afb9d510c Roll src/third_party/skia 7e2c3cdbb238..e0d90c84e42f (19 commits) (flutter/engine#9202) ( #33945 )
...
669ac3848d...afb9d510c3flutter/engine#9202 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-05 19:22:59 -04:00
Zachary Anderson
5180201fe1
[flutter_tool] Track APK sha calculation time ( #33923 )
2019-06-05 15:28:19 -07:00
Jonah Williams
b3382b9907
Reland support flutter test on platform chrome ( #33859 )
2019-06-05 15:27:49 -07:00
Jonah Williams
7548614350
Prevent windows web doctor from launching chrome ( #33874 )
2019-06-05 15:16:50 -07:00
engine-flutter-autoroll
b7a9a75bb9
Roll engine bf15bd080314..669ac3848d0f (6 commits) ( #33940 )
...
bf15bd0803...669ac3848dflutter/engine#9201 )
a6451caff Roll src/third_party/skia 89fc1db4e809..7e2c3cdbb238 (2 commits) (flutter/engine#9195 )
178e7e320 Revert "Roll src/third_party/dart b080e7c97a..9dcb026b26 (30 commits)" (flutter/engine#9200 )
369ba9ee5 Roll src/third_party/dart b080e7c97a..9dcb026b26 (30 commits)
44b1cedff Allow the task queues to be swapped in MessageLoops (flutter/engine#9189 )
89c0c1b8f Roll src/third_party/skia 346f82c1c3e0..89fc1db4e809 (2 commits) (flutter/engine#9191 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-05 17:44:56 -04:00
K. P. Sroka
ab707aca8f
Prevent exception being thrown on hasScrolledBody ( #31485 )
...
Convert scheduling to use `scheduleMicrotask` instead of `Timer.run`
2019-06-05 13:30:59 -07:00
MH Johnson
1b87f558d5
[Material] Add support for hovered, pressed, and focused text color on Buttons. ( #33090 )
...
* Support for stateful text colors in buttons
* Add color and a11y tests for buttons
2019-06-05 15:46:53 -04:00
Jonah Williams
50ea6f32d3
add benchmarks to track web size ( #33892 )
2019-06-05 12:40:21 -07:00
engine-flutter-autoroll
a6e77377ff
Roll engine 86aa01442b5d..bf15bd080314 (5 commits) ( #33895 )
...
86aa01442b...bf15bd0803flutter/engine#9186 )
d4c7c30fd Roll src/third_party/skia a4bb02063672..346f82c1c3e0 (6 commits) (flutter/engine#9188 )
7746e2e7f Compile the physical_shape_layer_unittests.cc TU. (flutter/engine#9187 )
12f48f760 Allow for whitelisted flags to be passed to the Dart VM (flutter/engine#9148 )
b304dabc3 [scene_host] Cleanup scene_host closures (flutter/engine#9061 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-05 15:37:56 -04:00
Gary Qian
2db7918eb5
Revert "Text inline widgets, TextSpan rework ( #33794 )" ( #33928 )
...
This reverts commit 86862c1e62
2019-06-05 11:35:46 -07:00
Kate Lovett
5a6a664094
The the doc fix ( #33917 )
2019-06-05 09:07:53 -07:00
Hans Muller
5948b3daca
Updated localizations ( #33883 )
2019-06-04 17:49:15 -07:00
Gary Qian
86862c1e62
Text inline widgets, TextSpan rework ( #33794 )
...
* Merge in changes for inline widgets
* Make analyzer happy, fix tests
* Fix analyzer
* Add missing doc
* Docs on RichText
* Fix analyzer some more
* Remove whitespace at end of line
* Update goldens
* Text fixes
* Analyzer
2019-06-04 16:27:53 -07:00
engine-flutter-autoroll
b3b6d03737
Roll engine 661c24e4f359..86aa01442b5d (2 commits) ( #33869 )
...
661c24e4f3...86aa01442bflutter/engine#9185 )
bd358e797 Roll src/third_party/skia 806267973f8d..a4bb02063672 (10 commits) (flutter/engine#9184 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-04 19:25:55 -04:00
Jenn Magder
035e3d37d7
Revert "Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #33852 )" ( #33882 )
...
This reverts commit d053fe5cb3
2019-06-04 15:35:35 -07:00
Kaushik Iska
92bfc99132
Added a benchmark for ImageCache ( #33814 )
...
* Add an image cache benchmark for a monochrome image
2019-06-04 12:32:52 -07:00
Gary Qian
e0cb468865
Unmark flutter_gallery__back_button_memory as flaky ( #33861 )
2019-06-04 12:27:08 -07:00
Jenn Magder
d053fe5cb3
Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #33852 )
...
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-04 12:17:57 -07:00
Greg Spencer
387e2b0602
Add actions and keyboard shortcut map support ( #33298 )
...
This implements the keyboard shortcut handling and action invocation in order to provide a place in the infrastructure for keyboard events to trigger actions. This will allow binding of key events to actions like "move the focus to the next widget" and "activate button".
2019-06-04 11:30:24 -07:00
Justin McCandless
a35d6615ee
Double double tap toggles instead of error ( #33802 )
...
Fix exception that was happening when double-double-tapping a TextField (or double long tapping).
2019-06-04 10:39:08 -07:00
Tong Mu
c482edac4f
Revert "Move declaration of semantic handlers from detectors to recognizers ( #33475 )" ( #33851 )
...
This reverts commit 572f349f5c
2019-06-04 10:13:15 -07:00
engine-flutter-autoroll
71b8465bca
661c24e4f Roll src/third_party/skia 525aa0ca60c8..806267973f8d (11 commits) (flutter/engine#9182) ( #33847 )
...
a63ef4cb4f...661c24e4f3flutter/engine#9182 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-04 13:07:55 -04:00
Justin McCandless
fce54ae685
Handles hidden by keyboard ( #32838 )
...
Extra space when scrolling to selected input so that the selection caret is visible.
2019-06-04 08:37:29 -07:00
Kate Lovett
04015b987b
Fixing duplicate test names. ( #33805 )
2019-06-04 07:01:52 -07:00
engine-flutter-autoroll
090ece49e6
Roll engine da78549e9476..a63ef4cb4fde (2 commits) ( #33839 )
...
da78549e94...a63ef4cb4fflutter/engine#9181 )
05365c4c3 Revert change by mistake: extract resources (flutter/engine#9180 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-06-04 09:33:00 -04:00
Jonah Williams
7442eeafe5
Reland https://github.com/flutter/flutter/pull/33663 ( #33828 )
2019-06-04 00:41:21 -07:00
engine-flutter-autoroll
f319f33756
da78549e9 Roll src/third_party/dart 5b72293f49..b080e7c97a (1 commits) ( #33826 )
...
606a8ede2c...da78549e94https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-06-04 03:00:56 -04:00
Jonah Williams
83986acbdb
Add a real-er web restart, doctor, workflow ( #33786 )
2019-06-03 23:19:42 -07:00
Todd Volkert
6d554827b6
Revert "Use conditional imports for flutter foundation libraries ( #33663 )" ( #33825 )
...
This reverts commit 90500a5dc4
2019-06-03 22:00:45 -07:00
engine-flutter-autoroll
d4a83af448
606a8ede2 Roll src/third_party/dart 1045ef1ceb..5b72293f49 (3 commits) ( #33822 )
...
f4d92c1f0c...606a8ede2chttps://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-06-04 00:05:56 -04:00
engine-flutter-autoroll
0e66d4fa1d
Roll engine 2ab34e4da16a..f4d92c1f0cd8 (2 commits) ( #33819 )
...
2ab34e4da1...f4d92c1f0cflutter/engine#9172 )
6e43c200b Roll src/third_party/dart 8cbb11cc55..1045ef1ceb (10 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-06-03 22:55:55 -04:00
