Commit graph

6069 commits

Author SHA1 Message Date
Ian Hickson 940473e5d6 Don't crash if Slider is given an empty range. (#10133)
Instead just disable the slider.

Fixes https://github.com/flutter/flutter/issues/10055
2017-05-16 19:35:01 -07:00
Ian Hickson 8b5ece7ca9 Report semantics geometry in physical units. (#10094)
Previously we used logical pixels. This made the accessibility metrics
tiny on modern devices, since the OS works in physical units.

Also add a bit more debugging info and some docs.
2017-05-16 16:43:22 -07:00
Adam Barth 20cc29cd62 Propagate notifications when onNotification returns null (#10081)
Previously we threw an exception to require a non-null value. Now we
just treat null as the common case of not stopping propagation.
2017-05-16 15:11:11 -07:00
Ian Hickson 63cfe1e30d Add strokeWidth to the paints matcher (#10121) 2017-05-16 14:17:41 -07:00
Hans Muller 765e5d5b5b Added SliverPrototypeExtentList et al (#10097) 2017-05-16 11:56:55 -07:00
Ian Hickson 73dcca65f7 Nits for protocol discovery (#10112)
Rather than complain about these in a code review I figured I'd just fix them. :-)
2017-05-16 11:38:07 -07:00
Ian Hickson 7eef73dd00 Answer the question of why icon buttons are 48x48. (#10117) 2017-05-16 11:36:12 -07:00
Collin Jackson 7154ac48db Merge remote-tracking branch 'origin/alpha' 2017-05-16 09:32:27 -07:00
Collin Jackson 00214fa7bd Fix call to unimplemented application:openURL:options: in iOS template (#10107)
Fixes #10106
2017-05-16 09:31:35 -07:00
Todd Volkert 10decc7c19 Fix race condition in protocol_discovery.dart (#10092)
For some reaosn, when we discovered our URI, we were re-instantiating
the `Completer` instance variable whose future we listen to in `nextUri()`.
This led to a race between a caller calling `nextUri()` and us discovering
the URI. If we happened to discover our URI before a caller called
`nextUri()`, then they would be left waiting on a future from the newly
allocated `Completer` (which would never complete).

Fixes #10064
2017-05-16 08:25:51 -07:00
Ian Hickson ce2c834f70 Adjust the tests to handle a higher-DPI test harness. (#10056)
Requires https://github.com/flutter/engine/pull/3688
2017-05-15 16:47:14 -07:00
Ian Hickson abeb164fe2 Add intrinsic dimensions to RenderEditable (#10093)
Also:

* Make TextPainter.preferredLineHeight honour root fontSize

* Remove bogus docs.

* More aggressively track dirty state for RenderEditable.

* Some tests.
2017-05-15 14:06:58 -07:00
xster b232a84b0d Auto provision iOS deploy 1/3 - find and use the first valid code signing certs (#9946)
* blind wrote everything except the user prompt

* works

* Add some logical refinements

* Make certificates unique and add more instructinos

* print more info

* Add test

* use string is empty

* review notes

* some formatting around commands

* add a newline
2017-05-15 12:54:32 -07:00
Mikkel Nygaard Ravn 5bdd80d085 Update docs/sample code for async widgets (#10029) 2017-05-15 15:19:45 +02:00
Adam Barth 49b183c502 Estimate the brightness of the primary color (#10071)
If the caller doesn't explicitly give the brightness of the primary
color, we now estimate it using an algorithm from the Web Content
Accessibility Guidelines.

Also, this patch contains a function that converts RGB colors to
HSVColors. I was originally going to use that, but the WCAG algorithm
ended up seeming like a better choice. The patch still includes this
function because it's generally useful.

Fixes #5718
2017-05-14 10:09:52 -07:00
Adam Barth 4b7a1912ee Add NavigatorState.pushAndRemoveUntil (#10026)
Fixes #9989
2017-05-12 17:45:17 -07:00
Ian Hickson db84df230d Some tools to dump other trees. (#9999) 2017-05-12 15:51:58 -07:00
Ian Hickson 292abf7223 "flutter packages pub ..." to passthrough to dart pub (#10044) 2017-05-12 15:40:35 -07:00
Jason Simmons 91b1a07656 Framework support for checkerboardOffscreenLayers (#10054)
See https://github.com/flutter/flutter/issues/9473
2017-05-12 14:41:07 -07:00
Ian Hickson 7c9c5a296c Rearrange tests to more closely match code structure (#10043) 2017-05-12 10:44:52 -07:00
P.Y. Laligand af4905ffbb Fixed analysis error. (#10035) 2017-05-12 10:03:18 -07:00
Alexandre Ardhuin 5bce52d6be try use_string_buffers lint (#10034) 2017-05-12 19:00:55 +02:00
Ian Hickson 18eac03d76 VerboseLogger should just wrap the parent Logger (#10020)
This way, you can test things even with a VerboseLogger.
2017-05-12 10:00:11 -07:00
Hans Muller 09e8c2ffb0 Update ExpansionTile, added a sample app (#10019) 2017-05-12 09:11:00 -07:00
Adam Barth bd56c79767 Handle back during pushReplacement (#10016)
Previously, we would strand the old route in the overlay even though it had
been removed from the history.
2017-05-11 19:33:37 -07:00
Adam Barth b9f4e5dac7 Make AnimatedCrossFade's alignment configurable (#9973)
The default is topCenter, which is sensible, but someone might want to use a
bottomCenter alignment, for example.
2017-05-11 17:47:19 -07:00
Chris Bracken bbe67c3f48 Rev SDK, package versions to dev versions (#10017)
VERSION: 0.0.7-dev
flutter: 0.0.27-dev
flutter_driver: 0.0.5-dev
flutter_test: 0.0.5-dev
2017-05-11 17:02:08 -07:00
Chris Bracken dc4ca8db83 Rev alpha branch version to 0.0.6, flutter 0.0.26 (#10010)
VERSION: 0.0.6
flutter: 0.0.26
flutter_driver: 0.0.4
flutter_test: 0.0.4
2017-05-11 15:33:29 -07:00
Devon Carew 2f737cf94e change a printStatus() to a printTrace() (#9992) 2017-05-11 08:49:26 -07:00
Ian Hickson 2f590eccbc Post alpha (#9980)
* Rev versions for alpha branch

* Rev versions after alpha
2017-05-10 22:08:27 -07:00
xster 81ec553fb6 More Cupertino dialog UI tweaks (#9960)
* is default

* hit target

* correct test name

* review note
2017-05-10 18:59:50 -07:00
Ian Hickson cc44cc779b Rev versions for alpha branch (#9979) 2017-05-10 17:36:30 -07:00
Ian Hickson e5e5f61c66 Improve error messages from slivers. (#9971)
Also, fix some logic in SliverPadding.
2017-05-10 17:34:17 -07:00
Ian Hickson dddf572780 Minor tweaks to flutter doctor (#9963) 2017-05-10 16:28:12 -07:00
Ian Hickson 7a52116d05 Make PhysicalModel more convenient, and add debug info (#9975) 2017-05-10 16:27:02 -07:00
Todd Volkert ff7d9432b8 Allow for different adb server version messages in device detection (#9974) 2017-05-10 15:51:08 -07:00
P.Y. Laligand d562e1aa63 Fixed some analysis errors. (#9967) 2017-05-10 15:30:28 -07:00
Yegor f7d62aaa9e fix driver connection flakiness (#9968) 2017-05-10 15:16:45 -07:00
Ian Hickson abaf290119 Further improve the docs for box_painter. (#9936) 2017-05-10 15:09:15 -07:00
Jason Simmons d1fa21166b Use runCommand to start sdkmanager and adjust the executable name for Windows (#9962)
Fixes https://github.com/flutter/flutter/issues/9954
2017-05-10 12:42:42 -07:00
Hans Muller 3f0aa820e3 Added enableAssertInitializer: true to analysis_options_user.yaml (#9943) 2017-05-10 07:14:51 -07:00
Mikkel Nygaard Ravn bc390ef4d0 Add sample code to FutureBuilder (#9952) 2017-05-10 13:42:26 +02:00
Alexandre Ardhuin e4546584d1 enable always_require_non_null_named_parameters lint (#9948)
* enable always_require_non_null_named_parameters lint

* Update home.dart
2017-05-10 08:45:36 +02:00
Alexandre Ardhuin 1f0b2d8a68 bump to linter-0.1.31 (#9947) 2017-05-10 08:20:13 +02:00
Chris Bracken 60f5ae8e77 Add const non-null asserts where required (#9945)
Also includes minor doc fixes.
2017-05-09 21:15:42 -07:00
Chris Bracken 0b2fb13269 Add const non-null asserts where required (#9939)
Also fixes a small typo.
2017-05-09 17:56:49 -07:00
Ian Hickson 1af253e313 Update versions post-alpha roll. (#9941) 2017-05-09 17:53:41 -07:00
Ian Hickson 9f1d5ba50e Rev versions for alpha cut (#9940)
And add a script to rev the versions.
2017-05-09 17:06:52 -07:00
Hans Muller 1157812bb9 Added ExpansionTile and deprecated TwoLevelList et al (#9938) 2017-05-09 16:32:01 -07:00
Chris Bracken 5b18fca053 Add const non-null asserts where required (#9937) 2017-05-09 15:41:06 -07:00