Commit graph

8098 commits

Author SHA1 Message Date
Chris Bracken 9495df4bc3
Revert "It's time to #deleteDart1 (#18293)" (#18313)
Several benchmarks started failing during kernel compile:
1. Timeouts:
   * commands_test
   * hot_mode_dev_cycle__benchmark
   * run_machine_concurrent_hot_reload
   * service_extensions_test

2. Kernel compiler crash:
   * hot_mode_dev_cycle_linux__benchmark
   * routing_test

3. Unexpected termination:
   * hot_mode_dev_cycle_win__benchmark

This reverts commit ed63e7082a.
2018-06-08 12:43:11 -07:00
Chris Bracken ed63e7082a
It's time to #deleteDart1 (#18293)
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.
2018-06-08 11:04:57 -07:00
Jonah Williams e186a164c8
Add 'header' SemanticsFlag to AppBar, NavBar (#18289) 2018-06-08 10:28:12 -07:00
Yegor 3983815de5
fix setTextEntryEmulation docs (#18298) 2018-06-07 22:01:59 -07:00
Chris Bracken 0e4770e809
Count kernel bytes in bytes synced by DevFS.update (#18288)
DevFS.update() returns the number of bytes synced from the host to the
target device. When running in Dart 2 mode, ensure that the size of the
kernel file is included in the count of bytes synced.
2018-06-07 18:27:08 -07:00
Chris Bracken 0628a1fb24
Eliminiate concurrent map key set modification (#18284)
Iterates over a copy of the dirty entries list rather than the original,
in order to avoid the potential for a concurrent modification exception
when fileUris are removed/added later in the loop.

This occurs when non-asset URIs (Dart sources) are listed in the dirty
set when --preview-dart-2 is enabled (the default).
2018-06-07 16:45:09 -07:00
Chris Bracken 3c25817bc7
Make kernel compiler stdoutHandler private (#18283)
Thie field is never used outside of the class and has a private type,
making it impossible to subclass/mock.
2018-06-07 16:44:25 -07:00
Jonah Williams d803f02d4f
Add activeIcon property to BottomNavigationBarItem (#18125) 2018-06-07 15:42:54 -07:00
Jonah Williams 0891a1136b
update a11y for material slider (#18005) 2018-06-07 15:41:35 -07:00
matthew-carroll 3bc906d372
Extracted an ImplicitlyAnimatedWidgetState from AnimatedWidgetBaseState (#18181)
Extracted a superclass from AnimatedWidgetBaseState that is called ImplicitlyAnimatedWidgetState. ImplicitlyAnimatedWidgetState implicitly animates, but it does not call setState() automatically. Subclasses must respond to animation changes themselves. This is a useful optimization for Widgets whose render objects listen to animations directly. (#18173)
2018-06-07 14:04:30 -07:00
Michael Goderbauer 3b9b5acefc
showOnScreen Improvements (#18252) 2018-06-07 10:07:52 -07:00
Michael Goderbauer 06140f2b14
Closing search with system back button works (#18174)
Fixes #18145.
2018-06-06 16:35:05 -07:00
amirh 0a26ac0970
_markNeedsClip() when clipper type has changed. (#18248)
A bug in _RenderCustomClip was compaeing the type of oldClipper to
itself instead to the type of newClipper.

This was the root cause for the crash #14937 worked around.
This also reverts the workaround introduced in #14937.
2018-06-06 15:28:20 -07:00
Stanislav Baranov 4a2ed22b0e
Propagate flutter tool verbose flag through gradle to flutter build bundle. (#18246) 2018-06-06 13:43:32 -07:00
Edman P. Anjos 4bbd4ce981 Surface border parameter in CupertinoSliverNavigationBar (#18194)
* Surface border parameter in CupertinoSliverNavigationBar (#18152)

* Add tests for CupertinoSliverNavigationBar border

* Remove unused keys, find by descendant
2018-06-06 11:44:06 -07:00
Danny Tuppeny 199d945b9e
Add emulators to docs (#18231) 2018-06-06 19:06:17 +01:00
Alan Knight b135fb3795 Remove tests that rely on 'ar' locale information which will change (#18217) 2018-06-05 15:53:15 -07:00
xster ac0c44fc1a
Small fidelity adjustments for Cupertino (#18104) 2018-06-05 15:38:05 -07:00
Alexander Aprelev f11c8d967c
Add compile-expression service. (#16161)
This registers compile-expression service that is used by dart vm to evaluate expressions when debugging flutter applications.
2018-06-05 13:22:13 -07:00
Keerti Parthasarathy da7670c2ee
Fixes for test failures in Dart 2 mode (#18122) 2018-06-05 12:38:30 -07:00
Michael Goderbauer 12eeb94c89
Compare SemanticsHandler# at end of test to value at beginning of test (#18183) 2018-06-05 12:24:56 -07:00
Hans Muller 04e0fcb00e
Fixed a typo in the render paragraph locale setter (#18189) 2018-06-05 10:55:11 -07:00
Hans Muller e8bceabbb8
Correct OutlineBorder gapStart when InputDecoration icon is specified (#18182) 2018-06-05 10:40:49 -07:00
Ian Hickson 25c4bc32b8
Try to make the test framework a little more resilient to timeouts (#18180) 2018-06-05 09:51:19 -07:00
Danny Tuppeny b9392ed220
Update flutter daemon docs (#18199)
* Document flutter run --machine at the bottom of the doc
* Be consistent with prefixes
2018-06-05 16:21:50 +01:00
Alexandre Ardhuin 09276bea25
enable lint prefer_equal_for_default_values (#18156) 2018-06-05 08:50:40 +02:00
Ian Hickson 6be81ebf9b
Be more resilient to bad data from VM (#18132)
Fixes https://github.com/flutter/flutter/issues/14517
Or at least, fixes the crash part of that.
2018-06-04 19:12:55 -07:00
matthew-carroll e396cc79ea
Documented embedded navigators in the Navigator class file (#15040). (#18051)
* Documented nested navigators in the Navigator class file (#15040).
2018-06-04 17:20:04 -07:00
Ian Hickson 944f0a4cc1
Revert "Clean up output of "flutter run --release" (#18049)" (#18184)
This reverts commit 4f1b66044c.
2018-06-04 16:17:08 -07:00
Ian Hickson 4f1b66044c
Clean up output of "flutter run --release" (#18049) 2018-06-04 15:22:51 -07:00
Ian Hickson e3427550e9
Be less verbose in the logs. (#17401)
Now that we have thousands of tests, it doesn't make sense to display a separate line for each test. The result is just megabytes of logs that you have to scrub through to find error messages.
2018-06-04 15:22:19 -07:00
Danny Tuppeny 43da9d5ef9
Use isDirectory instead of existsSync to avoid crash (#18167)
Fixes #15198.
2018-06-04 17:59:07 +01:00
Tran Huy Phuc 34933f801f TextFormField/TextField - remove spaces in character counter (#18096)
* TextFormField/TextField - remove spaces in character counter(follow material design guidelines)
2018-06-04 09:41:31 -07:00
Martin Kustermann ec6c4aba89
Rename --prefer-shared-library to --build-shared library consistently (#18164)
The change in 8b8d368d2 has only renamed the flag in a subset of the
places.
2018-06-04 17:44:37 +02:00
Danny Tuppeny f833c43e6e
Skip version checks when running flutter upgrade (#18031)
We were already skipping the check in `flutter upgrade` but this also spawns `flutter precache` and `flutter doctor` which would still check and potentially output the message.
2018-06-04 12:04:45 +01:00
matthew-carroll 4cd5870ece
Added docs to CupertinoAlertDialog to explain title, content, and button styling (#18128) (#18129) 2018-06-01 15:57:01 -07:00
Michael Goderbauer 62e87c8e6f
Start refresh while bouncing back to 0.0 from overscroll on iOS (#18012) 2018-06-01 15:22:57 -07:00
Michael Goderbauer 026c89835f
Clarify Offstage docs (#18089) 2018-06-01 15:22:33 -07:00
Michael Goderbauer 4c5303a204
Unfocus textfield if it is disabled (#18097) 2018-06-01 09:40:52 -07:00
Mikkel Nygaard Ravn e49a9661ad
Await writing local props to complete (#18110) 2018-06-01 12:15:30 +02:00
Danny Tuppeny 3d7d96806a
Use correct branch for version checks on beta/dev (#18016) 2018-06-01 10:59:20 +01:00
Mikkel Nygaard Ravn 8c39c35eb0
Upgradle Gradle dependencies to match Android Studio 3.1.2 (#18080) 2018-06-01 09:57:40 +02:00
Ian Hickson b83749cab0
Golden file tests for clip (#18056)
Also, fixes "flutter run" for golden tests, and some docs.
2018-06-01 00:23:26 -07:00
Ian Hickson 72c459bcfc
Fix crash when painting empty tables (#17952) 2018-05-31 22:47:25 -07:00
Ian Hickson 1891173999
Spacer should only flex in the main axis direction. (#18052) 2018-05-31 20:38:37 -07:00
Alexander Markov ed20de0ae9
Restore omitted optional 'new' to fix Flutter gallery in Dart 1 mode (#18087) 2018-05-31 17:48:09 -07:00
Hans Muller f1e4defbbc
Pass locale along to RenderParagraph (#17879) 2018-05-31 11:01:24 -07:00
Mikkel Nygaard Ravn 87a6e2b497
Revert "Update Gradle dependencies (#18071)" (#18074)
This reverts commit 59bb2dba73.
2018-05-31 19:25:40 +02:00
Sam Rawlins fba81d0f1d Use anyNamed when mocking named arguments (#17996) 2018-05-31 08:24:26 -07:00
Mikkel Nygaard Ravn 59bb2dba73
Update Gradle dependencies (#18071) 2018-05-31 17:16:47 +02:00